X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2FRevisionStorageTest.php;h=e9f16dbd5c988ef6ef6d3d4a07c1a0f8a5f86b0f;hp=3ba82a6f59d9c09c1937a96f40531a643e3a722c;hb=1d7a1bf8bddf0908e4f572c82268733f63126a13;hpb=fb4821adfc3ab95d9c5c0be1162139f99bfebf6c

diff --git a/tests/phpunit/includes/RevisionStorageTest.php b/tests/phpunit/includes/RevisionStorageTest.php
index 3ba82a6f59..e9f16dbd5c 100644
--- a/tests/phpunit/includes/RevisionStorageTest.php
+++ b/tests/phpunit/includes/RevisionStorageTest.php
@@ -22,6 +22,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
 		$this->tablesUsed = array_merge( $this->tablesUsed,
 			[ 'page',
 				'revision',
+				'ip_changes',
 				'text',
 
 				'recentchanges',
@@ -146,7 +147,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
 		$orig = $this->makeRevision();
 
 		$dbr = wfGetDB( DB_REPLICA );
-		$res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
+		$res = $dbr->select( 'revision', Revision::selectFields(), [ 'rev_id' => $orig->getId() ] );
 		$this->assertTrue( is_object( $res ), 'query failed' );
 
 		$row = $res->fetchObject();
@@ -164,7 +165,7 @@ class RevisionStorageTest extends MediaWikiTestCase {
 		$orig = $this->makeRevision();
 
 		$dbr = wfGetDB( DB_REPLICA );
-		$res = $dbr->select( 'revision', '*', [ 'rev_id' => $orig->getId() ] );
+		$res = $dbr->select( 'revision', Revision::selectFields(), [ 'rev_id' => $orig->getId() ] );
 		$this->assertTrue( is_object( $res ), 'query failed' );
 
 		$row = $res->fetchObject();
@@ -188,7 +189,9 @@ class RevisionStorageTest extends MediaWikiTestCase {
 		$page->doDeleteArticle( 'test Revision::newFromArchiveRow' );
 
 		$dbr = wfGetDB( DB_REPLICA );
-		$res = $dbr->select( 'archive', '*', [ 'ar_rev_id' => $orig->getId() ] );
+		$res = $dbr->select(
+			'archive', Revision::selectArchiveFields(), [ 'ar_rev_id' => $orig->getId() ]
+		);
 		$this->assertTrue( is_object( $res ), 'query failed' );
 
 		$row = $res->fetchObject();
@@ -438,6 +441,25 @@ class RevisionStorageTest extends MediaWikiTestCase {
 		$this->assertEquals( 'some testing text', $rev->getContent()->getNativeData() );
 	}
 
+	/**
+	 * @covers Revision::insertOn
+	 */
+	public function testInsertOn() {
+		$ip = '2600:387:ed7:947e:8c16:a1ad:dd34:1dd7';
+
+		$orig = $this->makeRevision( [
+			'user_text' => $ip
+		] );
+
+		// Make sure the revision was copied to ip_changes
+		$dbr = wfGetDB( DB_REPLICA );
+		$res = $dbr->select( 'ip_changes', '*', [ 'ipc_rev_id' => $orig->getId() ] );
+		$row = $res->fetchObject();
+
+		$this->assertEquals( IP::toHex( $ip ), $row->ipc_hex );
+		$this->assertEquals( $orig->getTimestamp(), $row->ipc_rev_timestamp );
+	}
+
 	public static function provideUserWasLastToEdit() {
 		return [
 			[ # 0