X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=tests%2Fintegration%2Fincludes%2Fhttp%2FMWHttpRequestTestCase.php;h=603f4c26f2908a93e0efd89e63564daeb0fef26d;hp=cc769d7ee8c4600fed1d17c3c3137ebb35dd3472;hb=2f5d88819799f077f4d3a3288dad104141692f20;hpb=ee56f00ddf0609082f8ae9a4dc3e6e1b6f54ddfd diff --git a/tests/integration/includes/http/MWHttpRequestTestCase.php b/tests/integration/includes/http/MWHttpRequestTestCase.php index cc769d7ee8..603f4c26f2 100644 --- a/tests/integration/includes/http/MWHttpRequestTestCase.php +++ b/tests/integration/includes/http/MWHttpRequestTestCase.php @@ -2,7 +2,7 @@ use Wikimedia\TestingAccessWrapper; -abstract class MWHttpRequestTestCase extends PHPUnit_Framework_TestCase { +abstract class MWHttpRequestTestCase extends PHPUnit\Framework\TestCase { protected static $httpEngine; protected $oldHttpEngine; @@ -105,17 +105,16 @@ abstract class MWHttpRequestTestCase extends PHPUnit_Framework_TestCase { $this->assertHasCookie( 'foo', 'bar', $request->getCookieJar() ); $this->markTestIncomplete( 'CookieJar does not handle deletion' ); - return; - $request = MWHttpRequest::factory( 'http://httpbin.org/cookies/delete?foo' ); - $cookieJar = new CookieJar(); - $cookieJar->setCookie( 'foo', 'bar', [ 'domain' => 'httpbin.org' ] ); - $cookieJar->setCookie( 'foo2', 'bar2', [ 'domain' => 'httpbin.org' ] ); - $request->setCookieJar( $cookieJar ); - $status = $request->execute(); - $this->assertTrue( $status->isGood() ); - $this->assertNotHasCookie( 'foo', $request->getCookieJar() ); - $this->assertHasCookie( 'foo2', 'bar2', $request->getCookieJar() ); + // $request = MWHttpRequest::factory( 'http://httpbin.org/cookies/delete?foo' ); + // $cookieJar = new CookieJar(); + // $cookieJar->setCookie( 'foo', 'bar', [ 'domain' => 'httpbin.org' ] ); + // $cookieJar->setCookie( 'foo2', 'bar2', [ 'domain' => 'httpbin.org' ] ); + // $request->setCookieJar( $cookieJar ); + // $status = $request->execute(); + // $this->assertTrue( $status->isGood() ); + // $this->assertNotHasCookie( 'foo', $request->getCookieJar() ); + // $this->assertHasCookie( 'foo2', 'bar2', $request->getCookieJar() ); } public function testGetResponseHeaders() {