X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=includes%2Fspecials%2FSpecialSearch.php;h=9f83832e133b883e83af4354db47c19b7a08e2ff;hp=6daf19f5c3e7607ca792c6187057a9d81851cc04;hb=6bb1170e2f3539218965d1ceaa2cfc5e6197f465;hpb=eb2f439768d34254964e798d9523211ba8ea2f5f

diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php
index 6daf19f5c3..9f83832e13 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -234,11 +234,6 @@ class SpecialSearch extends SpecialPage {
 
 			return;
 		}
-		# No match, generate an edit URL
-		$title = Title::newFromText( $term );
-		if ( !is_null( $title ) ) {
-			Hooks::run( 'SpecialSearchNogomatch', [ &$title ] );
-		}
 		$this->showResults( $term );
 	}
 
@@ -300,12 +295,12 @@ class SpecialSearch extends SpecialPage {
 		$textStatus = null;
 		if ( $textMatches instanceof Status ) {
 			$textStatus = $textMatches;
-			$textMatches = null;
+			$textMatches = $textStatus->getValue();
 		}
 
 		// did you mean... suggestions
 		$didYouMeanHtml = '';
-		if ( $showSuggestion && $textMatches && !$textStatus ) {
+		if ( $showSuggestion && $textMatches ) {
 			if ( $textMatches->hasRewrittenQuery() ) {
 				$didYouMeanHtml = $this->getDidYouMeanRewrittenHtml( $term, $textMatches );
 			} elseif ( $textMatches->hasSuggestion() ) {
@@ -365,6 +360,25 @@ class SpecialSearch extends SpecialPage {
 
 		$out->addHTML( "<div class='searchresults'>" );
 
+		$hasErrors = $textStatus && $textStatus->getErrors();
+		if ( $hasErrors ) {
+			list( $error, $warning ) = $textStatus->splitByErrorType();
+			if ( $error->getErrors() ) {
+				$out->addHTML( Html::rawElement(
+					'div',
+					[ 'class' => 'errorbox' ],
+					$error->getHTML( 'search-error' )
+				) );
+			}
+			if ( $warning->getErrors() ) {
+				$out->addHTML( Html::rawElement(
+					'div',
+					[ 'class' => 'warningbox' ],
+					$warning->getHTML( 'search-warning' )
+				) );
+			}
+		}
+
 		// prev/next links
 		$prevnext = null;
 		if ( $num || $this->offset ) {
@@ -393,7 +407,8 @@ class SpecialSearch extends SpecialPage {
 			}
 			$titleMatches->free();
 		}
-		if ( $textMatches && !$textStatus ) {
+
+		if ( $textMatches ) {
 			// output appropriate heading
 			if ( $numTextMatches > 0 && $numTitleMatches > 0 ) {
 				$out->addHTML( '<div class="mw-search-visualclear"></div>' );
@@ -417,17 +432,18 @@ class SpecialSearch extends SpecialPage {
 		$hasOtherResults = $textMatches &&
 			$textMatches->hasInterwikiResults( SearchResultSet::INLINE_RESULTS );
 
-		if ( $num === 0 ) {
-			if ( $textStatus ) {
-				$out->addHTML( '<div class="error">' .
-					$textStatus->getMessage( 'search-error' ) . '</div>' );
-			} else {
+		// If we have no results and we have not already displayed an error message
+		if ( $num === 0 && !$hasErrors ) {
+			if ( !$this->offset ) {
+				// If we have an offset the create link was rendered earlier in this function.
+				// This class needs a good de-spaghettification, but for now this will
+				// do the job.
 				$this->showCreateLink( $title, $num, $titleMatches, $textMatches );
-				$out->wrapWikiMsg( "<p class=\"mw-search-nonefound\">\n$1</p>",
-					[ $hasOtherResults ? 'search-nonefound-thiswiki' : 'search-nonefound',
-							wfEscapeWikiText( $term )
-					] );
 			}
+			$out->wrapWikiMsg( "<p class=\"mw-search-nonefound\">\n$1</p>", [
+				$hasOtherResults ? 'search-nonefound-thiswiki' : 'search-nonefound',
+				wfEscapeWikiText( $term )
+			] );
 		}
 
 		if ( $hasOtherResults ) {
@@ -455,7 +471,6 @@ class SpecialSearch extends SpecialPage {
 		$out->addHTML( "</div>" );
 
 		Hooks::run( 'SpecialSearchResultsAppend', [ $this, $out, $term ] );
-
 	}
 
 	/**
@@ -470,25 +485,6 @@ class SpecialSearch extends SpecialPage {
 		return "<p class=\"mw-search-interwiki-header mw-search-visualclear\">\n$wikiMsg</p>";
 	}
 
-	/**
-	 * Decide if the suggested query should be run, and it's results returned
-	 * instead of the provided $textMatches
-	 *
-	 * @param SearchResultSet $textMatches The results of a users query
-	 * @return bool
-	 */
-	protected function shouldRunSuggestedQuery( SearchResultSet $textMatches ) {
-		if ( !$this->runSuggestion ||
-			!$textMatches->hasSuggestion() ||
-			$textMatches->numRows() > 0 ||
-			$textMatches->searchContainedSyntax()
-		) {
-			return false;
-		}
-
-		return $this->getConfig()->get( 'SearchRunSuggestedQuery' );
-	}
-
 	/**
 	 * Generates HTML shown to the user when we have a suggestion about a query
 	 * that might give more results than their current query.
@@ -752,7 +748,6 @@ class SpecialSearch extends SpecialPage {
 	 * @return string
 	 */
 	protected function showHit( SearchResult $result, $terms, $position ) {
-
 		if ( $result->isBrokenTitle() ) {
 			return '';
 		}
@@ -972,7 +967,6 @@ class SpecialSearch extends SpecialPage {
 	 * @return string
 	 */
 	protected function showInterwikiHit( $result, $lastInterwiki, $query ) {
-
 		if ( $result->isBrokenTitle() ) {
 			return '';
 		}
@@ -1335,24 +1329,6 @@ class SpecialSearch extends SpecialPage {
 		return false;
 	}
 
-	/**
-	 * Check if query starts with all: prefix
-	 *
-	 * @param string $term The string to check
-	 * @return bool
-	 */
-	protected function startsWithAll( $term ) {
-
-		$allkeyword = $this->msg( 'searchall' )->inContentLanguage()->text();
-
-		$parts = explode( ':', $term );
-		if ( count( $parts ) > 1 ) {
-			return $parts[0] == $allkeyword;
-		}
-
-		return false;
-	}
-
 	/**
 	 * @since 1.18
 	 *