X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=includes%2Fresourceloader%2FResourceLoader.php;h=1a93f6ef133d5be00ff164dd782842551badeaa1;hp=09535b731e0fccb14e0129a2010dfda363fe429f;hb=28adc4d7eef2d7d8e5696a4f9849538a769daa00;hpb=461108c21af243cded462c8fc7cd73ee1efd50da diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php index 09535b731e..1a93f6ef13 100644 --- a/includes/resourceloader/ResourceLoader.php +++ b/includes/resourceloader/ResourceLoader.php @@ -601,10 +601,8 @@ class ResourceLoader implements LoggerAwareInterface { * @return string Hash */ public static function makeHash( $value ) { - // Use base64 to output more entropy in a more compact string (default hex is only base16). - // The first 8 chars of a base64 encoded digest represent the same binary as - // the first 12 chars of a hex encoded digest. - return substr( base64_encode( sha1( $value, true ) ), 0, 8 ); + $hash = hash( 'fnv132', $value ); + return Wikimedia\base_convert( $hash, 16, 36, 7 ); } /** @@ -1390,13 +1388,14 @@ MESSAGE; * the given value. * * @param array $configuration List of configuration values keyed by variable name + * @param bool $pretty Pretty-print with extra whitespace * @return string */ - public static function makeConfigSetScript( array $configuration ) { + public static function makeConfigSetScript( array $configuration, $pretty = null ) { return Xml::encodeJsCall( 'mw.config.set', [ $configuration ], - ResourceLoader::inDebugMode() + ( $pretty === null ) ? ResourceLoader::inDebugMode() : $pretty ); } @@ -1470,34 +1469,6 @@ MESSAGE; return wfAppendQuery( $script, $query ); } - /** - * Build a load.php URL - * @deprecated since 1.24 Use createLoaderURL() instead - * @param array $modules Array of module names (strings) - * @param string $lang Language code - * @param string $skin Skin name - * @param string|null $user User name. If null, the &user= parameter is omitted - * @param string|null $version Versioning timestamp - * @param bool $debug Whether the request should be in debug mode - * @param string|null $only &only= parameter - * @param bool $printable Printable mode - * @param bool $handheld Handheld mode - * @param array $extraQuery Extra query parameters to add - * @return string URL to load.php. May be protocol-relative if $wgLoadScript is, too. - */ - public static function makeLoaderURL( $modules, $lang, $skin, $user = null, - $version = null, $debug = false, $only = null, $printable = false, - $handheld = false, $extraQuery = [] - ) { - global $wgLoadScript; - - $query = self::makeLoaderQuery( $modules, $lang, $skin, $user, $version, $debug, - $only, $printable, $handheld, $extraQuery - ); - - return wfAppendQuery( $wgLoadScript, $query ); - } - /** * Helper for createLoaderURL() * @@ -1507,7 +1478,7 @@ MESSAGE; * @param array $extraQuery * @return array */ - public static function createLoaderQuery( ResourceLoaderContext $context, $extraQuery = [] ) { + protected static function createLoaderQuery( ResourceLoaderContext $context, $extraQuery = [] ) { return self::makeLoaderQuery( $context->getModules(), $context->getLanguage(), @@ -1524,7 +1495,7 @@ MESSAGE; /** * Build a query array (array representation of query string) for load.php. Helper - * function for makeLoaderURL(). + * function for createLoaderURL(). * * @param array $modules * @param string $lang