X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=includes%2Fapi%2FApiQueryAllDeletedRevisions.php;h=172ee99989d251b3f37ae7ce44dc29036c914235;hp=4e95f5b8ca52ae66dc5990334192c851b074eea2;hb=59ebff658ce912c1b0e7ef8d8f9bfec5a4e17b39;hpb=44aec8a00a9f0f92a746ca575b58147fea1135e5

diff --git a/includes/api/ApiQueryAllDeletedRevisions.php b/includes/api/ApiQueryAllDeletedRevisions.php
index 4e95f5b8ca..172ee99989 100644
--- a/includes/api/ApiQueryAllDeletedRevisions.php
+++ b/includes/api/ApiQueryAllDeletedRevisions.php
@@ -55,7 +55,6 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 
 		$result = $this->getResult();
 		$pageSet = $this->getPageSet();
-		$titles = $pageSet->getTitles();
 
 		// This module operates in two modes:
 		// 'user': List deleted revs by a certain user
@@ -83,6 +82,21 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 			}
 		}
 
+		// If we're generating titles only, we can use DISTINCT for a better
+		// query. But we can't do that in 'user' mode (wrong index), and we can
+		// only do it when sorting ASC (because MySQL apparently can't use an
+		// index backwards for grouping even though it can for ORDER BY, WTF?)
+		$dir = $params['dir'];
+		$optimizeGenerateTitles = false;
+		if ( $mode === 'all' && $params['generatetitles'] && $resultPageSet !== null ) {
+			if ( $dir === 'newer' ) {
+				$optimizeGenerateTitles = true;
+			} else {
+				$p = $this->getModulePrefix();
+				$this->setWarning( "For better performance when generating titles, set {$p}dir=newer" );
+			}
+		}
+
 		$this->addTables( 'archive' );
 		if ( $resultPageSet === null ) {
 			$this->parseParameters( $params );
@@ -90,7 +104,12 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 			$this->addFields( array( 'ar_title', 'ar_namespace' ) );
 		} else {
 			$this->limit = $this->getParameter( 'limit' ) ?: 10;
-			$this->addFields( array( 'ar_title', 'ar_namespace', 'ar_timestamp', 'ar_rev_id', 'ar_id' ) );
+			$this->addFields( array( 'ar_title', 'ar_namespace' ) );
+			if ( $optimizeGenerateTitles ) {
+				$this->addOption( 'DISTINCT' );
+			} else {
+				$this->addFields( array( 'ar_timestamp', 'ar_rev_id', 'ar_id' ) );
+			}
 		}
 
 		if ( $this->fld_tags ) {
@@ -130,7 +149,6 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 			}
 		}
 
-		$dir = $params['dir'];
 		$miser_ns = null;
 
 		if ( $mode == 'all' ) {
@@ -229,7 +247,14 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 		if ( !is_null( $params['continue'] ) ) {
 			$cont = explode( '|', $params['continue'] );
 			$op = ( $dir == 'newer' ? '>' : '<' );
-			if ( $mode == 'all' ) {
+			if ( $optimizeGenerateTitles ) {
+				$this->dieContinueUsageIf( count( $cont ) != 2 );
+				$ns = intval( $cont[0] );
+				$this->dieContinueUsageIf( strval( $ns ) !== $cont[0] );
+				$title = $db->addQuotes( $cont[1] );
+				$this->addWhere( "ar_namespace $op $ns OR " .
+					"(ar_namespace = $ns AND ar_title $op= $title)" );
+			} elseif ( $mode == 'all' ) {
 				$this->dieContinueUsageIf( count( $cont ) != 4 );
 				$ns = intval( $cont[0] );
 				$this->dieContinueUsageIf( strval( $ns ) !== $cont[0] );
@@ -259,7 +284,13 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 
 		$sort = ( $dir == 'newer' ? '' : ' DESC' );
 		$orderby = array();
-		if ( $mode == 'all' ) {
+		if ( $optimizeGenerateTitles ) {
+			// Targeting index name_title_timestamp
+			if ( $params['namespace'] === null || count( array_unique( $params['namespace'] ) ) > 1 ) {
+				$orderby[] = "ar_namespace $sort";
+			}
+			$orderby[] = "ar_title $sort";
+		} elseif ( $mode == 'all' ) {
 			// Targeting index name_title_timestamp
 			if ( $params['namespace'] === null || count( array_unique( $params['namespace'] ) ) > 1 ) {
 				$orderby[] = "ar_namespace $sort";
@@ -283,7 +314,9 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 		foreach ( $res as $row ) {
 			if ( ++$count > $this->limit ) {
 				// We've had enough
-				if ( $mode == 'all' ) {
+				if ( $optimizeGenerateTitles ) {
+					$this->setContinueEnumParameter( 'continue', "$row->ar_namespace|$row->ar_title" );
+				} elseif ( $mode == 'all' ) {
 					$this->setContinueEnumParameter( 'continue',
 						"$row->ar_namespace|$row->ar_title|$row->ar_timestamp|$row->ar_id"
 					);
@@ -319,7 +352,7 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 						'pageid' => $title->getArticleID(),
 						'revisions' => array( $rev ),
 					);
-					$result->setIndexedTagName( $a['revisions'], 'rev' );
+					ApiResult::setIndexedTagName( $a['revisions'], 'rev' );
 					ApiQueryBase::addTitleInfo( $a, $title );
 					$fit = $result->addValue( array( 'query', $this->getModuleName() ), $index, $a );
 				} else {
@@ -348,7 +381,7 @@ class ApiQueryAllDeletedRevisions extends ApiQueryRevisionsBase {
 				$resultPageSet->populateFromRevisionIDs( $generated );
 			}
 		} else {
-			$result->setIndexedTagName_internal( array( 'query', $this->getModuleName() ), 'page' );
+			$result->addIndexedTagName( array( 'query', $this->getModuleName() ), 'page' );
 		}
 	}