X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=includes%2FWebRequest.php;h=c6ddf81697234fc29f50466737efeecb859fdc21;hp=7bfb5a43e481dba11d0844ccb1f48b59ea183651;hb=90232b6f36ee5a1473f2e865cc7a72d0014db4c7;hpb=16c80e429be5904fb42a93f260f8de3d18f0c692 diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 7bfb5a43e4..c6ddf81697 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -88,8 +88,7 @@ class WebRequest { * @codeCoverageIgnore */ public function __construct() { - $this->requestTime = isset( $_SERVER['REQUEST_TIME_FLOAT'] ) - ? $_SERVER['REQUEST_TIME_FLOAT'] : microtime( true ); + $this->requestTime = $_SERVER['REQUEST_TIME_FLOAT']; // POST overrides GET data // We don't use $_REQUEST here to avoid interference from cookies... @@ -123,9 +122,9 @@ class WebRequest { if ( !preg_match( '!^https?://!', $url ) ) { $url = 'http://unused' . $url; } - MediaWiki\suppressWarnings(); + Wikimedia\suppressWarnings(); $a = parse_url( $url ); - MediaWiki\restoreWarnings(); + Wikimedia\restoreWarnings(); if ( $a ) { $path = isset( $a['path'] ) ? $a['path'] : ''; @@ -142,7 +141,7 @@ class WebRequest { $router->add( "$wgScript/$1" ); if ( isset( $_SERVER['SCRIPT_NAME'] ) - && preg_match( '/\.php5?/', $_SERVER['SCRIPT_NAME'] ) + && preg_match( '/\.php/', $_SERVER['SCRIPT_NAME'] ) ) { # Check for SCRIPT_NAME, we handle index.php explicitly # But we do have some other .php files such as img_auth.php @@ -270,6 +269,8 @@ class WebRequest { * @since 1.27 */ public static function getRequestId() { + // This method is called from various error handlers and should be kept simple. + if ( !self::$reqId ) { self::$reqId = isset( $_SERVER['UNIQUE_ID'] ) ? $_SERVER['UNIQUE_ID'] : wfRandomString( 24 ); @@ -431,7 +432,7 @@ class WebRequest { * selected by a drop-down menu). For freeform input, see getText(). * * @param string $name - * @param string $default Optional default (or null) + * @param string|null $default Optional default (or null) * @return string|null */ public function getVal( $name, $default = null ) { @@ -781,6 +782,8 @@ class WebRequest { * @return string */ public static function getGlobalRequestURL() { + // This method is called on fatal errors; it should not depend on anything complex. + if ( isset( $_SERVER['REQUEST_URI'] ) && strlen( $_SERVER['REQUEST_URI'] ) ) { $base = $_SERVER['REQUEST_URI']; } elseif ( isset( $_SERVER['HTTP_X_ORIGINAL_URL'] )