X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=includes%2FHooks.php;h=f4f86be68bb0a0077351de0a82794d7f6257b65d;hp=511781dbbd300c0107b712a39bb3cd41eb2f5fd3;hb=22806b0a4509e97b56fb52b387e17e3c80fb7eb2;hpb=056f1f532d5e60df920bf4c2d69f80c4fc593b65

diff --git a/includes/Hooks.php b/includes/Hooks.php
index 511781dbbd..f4f86be68b 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -176,22 +176,13 @@ class Hooks {
 				throw new MWException( 'Invalid callback ' . $func . ' in hooks for ' . $event . "\n" );
 			}
 
-			/*
-			 * Call the hook. The documentation of call_user_func_array says
-			 * false is returned on failure. However, if the function signature
-			 * does not match the call signature, PHP will issue an warning and
-			 * return null instead. The following code catches that warning and
-			 * provides better error message.
-			 */
-			$retval = null;
-			$badhookmsg = null;
-			$hook_args = array_merge( $hook, $args );
-
 			// mark hook as deprecated, if deprecation version is specified
 			if ( $deprecatedVersion !== null ) {
 				wfDeprecated( "$event hook (used in $func)", $deprecatedVersion );
 			}
 
+			// Call the hook.
+			$hook_args = array_merge( $hook, $args );
 			$retval = call_user_func_array( $callback, $hook_args );
 
 			// Process the return value.