RCFilters: Move parameter operations to ViewModel

[lhc/web/wiklou.git] / tests / qunit / suites / resources / mediawiki.rcfilters / UriProcessor.test.js

diff --git a/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js b/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js
index 38ade4d..291d5c7 100644 (file)
--- a/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js
+++ b/tests/qunit/suites/resources/mediawiki.rcfilters/UriProcessor.test.js
@@ -6,24 +6,24 @@
                        title: 'Group 1',
                        type: 'send_unselected_if_any',
                        filters: [
-                               { name: 'filter1', default: true },
-                               { name: 'filter2' }
+                               { name: 'filter1', cssClass: 'filter1class', default: true },
+                               { name: 'filter2', cssClass: 'filter2class' }
                        ]
                }, {
                        name: 'group2',
                        title: 'Group 2',
                        type: 'send_unselected_if_any',
                        filters: [
-                               { name: 'filter3' },
-                               { name: 'filter4', default: true }
+                               { name: 'filter3', cssClass: 'filter3class' },
+                               { name: 'filter4', cssClass: 'filter4class', default: true }
                        ]
                }, {
                        name: 'group3',
                        title: 'Group 3',
                        type: 'string_options',
                        filters: [
-                               { name: 'filter5' },
-                               { name: 'filter6' }
+                               { name: 'filter5', cssClass: 'filter5class' },
+                               { name: 'filter6' } // Not supporting highlights
                        ]
                } ],
                minimalDefaultParams = {
@@ -49,55 +49,79 @@
                );
        } );
 
-       QUnit.test( 'updateModelBasedOnQuery & getUriParametersFromModel', function ( assert ) {
+       QUnit.test( 'getUpdatedUri', function ( assert ) {
                var uriProcessor,
-                       filtersModel = new mw.rcfilters.dm.FiltersViewModel(),
-                       baseParams = {
-                               filter1: '0',
-                               filter2: '0',
-                               filter3: '0',
-                               filter4: '0',
-                               group3: '',
-                               highlight: '0',
-                               group1__filter1_color: null,
-                               group1__filter2_color: null,
-                               group2__filter3_color: null,
-                               group2__filter4_color: null,
-                               group3__filter5_color: null,
-                               group3__filter6_color: null
-                       };
+                       filtersModel = new mw.rcfilters.dm.FiltersViewModel();
+
+               filtersModel.initializeFilters( mockFilterStructure );
+               uriProcessor = new mw.rcfilters.UriProcessor( filtersModel );
+
+               assert.deepEqual(
+                       ( uriProcessor.getUpdatedUri( {} ) ).query,
+                       { urlversion: '2' },
+                       'Empty model state with empty uri state, assumes the given uri is already normalized, and adds urlversion=2'
+               );
+
+               assert.deepEqual(
+                       ( uriProcessor.getUpdatedUri( { foo: 'bar' } ) ).query,
+                       { urlversion: '2', foo: 'bar' },
+                       'Empty model state with unrecognized params retains unrecognized params'
+               );
+
+               // Update the model
+               filtersModel.toggleFiltersSelected( {
+                       group1__filter1: true, // Param: filter2: '1'
+                       group3__filter5: true // Param: group3: 'filter5'
+               } );
+
+               assert.deepEqual(
+                       ( uriProcessor.getUpdatedUri( {} ) ).query,
+                       { urlversion: '2', filter2: '1', group3: 'filter5' },
+                       'Model state is reflected in the updated URI'
+               );
+
+               assert.deepEqual(
+                       ( uriProcessor.getUpdatedUri( { foo: 'bar' } ) ).query,
+                       { urlversion: '2', filter2: '1', group3: 'filter5', foo: 'bar' },
+                       'Model state is reflected in the updated URI with existing uri params'
+               );
+       } );
+
+       QUnit.test( 'updateModelBasedOnQuery', function ( assert ) {
+               var uriProcessor,
+                       filtersModel = new mw.rcfilters.dm.FiltersViewModel();
 
                filtersModel.initializeFilters( mockFilterStructure );
                uriProcessor = new mw.rcfilters.UriProcessor( filtersModel );
 
                uriProcessor.updateModelBasedOnQuery( {} );
                assert.deepEqual(
-                       uriProcessor.getUriParametersFromModel(),
-                       $.extend( true, {}, baseParams, minimalDefaultParams ),
+                       filtersModel.getCurrentParameterState(),
+                       minimalDefaultParams,
                        'Version 1: Empty url query sets model to defaults'
                );
 
                uriProcessor.updateModelBasedOnQuery( { urlversion: '2' } );
                assert.deepEqual(
-                       uriProcessor.getUriParametersFromModel(),
-                       baseParams,
+                       filtersModel.getCurrentParameterState(),
+                       {},
                        'Version 2: Empty url query sets model to all-false'
                );
 
                uriProcessor.updateModelBasedOnQuery( { filter1: '1', urlversion: '2' } );
                assert.deepEqual(
-                       uriProcessor.getUriParametersFromModel(),
-                       $.extend( true, {}, baseParams, { filter1: '1' } ),
+                       filtersModel.getCurrentParameterState(),
+                       $.extend( true, {}, { filter1: '1' } ),
                        'Parameters in Uri query set parameter value in the model'
                );
 
                uriProcessor.updateModelBasedOnQuery( { highlight: '1', group1__filter1_color: 'c1', urlversion: '2' } );
                assert.deepEqual(
-                       uriProcessor.getUriParametersFromModel(),
-                       $.extend( true, {}, baseParams, {
+                       filtersModel.getCurrentParameterState(),
+                       {
                                highlight: '1',
                                group1__filter1_color: 'c1'
-                       } ),
+                       },
                        'Highlight parameters in Uri query set highlight state in the model'
                );
        } );