Merge "Improve Doxygen template used by mwdocgen.php"
[lhc/web/wiklou.git] / tests / phpunit / includes / upload / UploadFromUrlTest.php
index 428fd27..6d17a68 100644 (file)
@@ -11,11 +11,10 @@ class UploadFromUrlTest extends ApiTestCase {
        protected function setUp() {
                parent::setUp();
 
-               $this->setMwGlobals( array(
+               $this->setMwGlobals( [
                        'wgEnableUploads' => true,
                        'wgAllowCopyUploads' => true,
-                       'wgAllowAsyncCopyUploads' => true,
-               ) );
+               ] );
 
                if ( wfLocalFile( 'UploadFromUrlTest.png' )->exists() ) {
                        $this->deleteFile( 'UploadFromUrlTest.png' );
@@ -31,10 +30,10 @@ class UploadFromUrlTest extends ApiTestCase {
                $module = new ApiMain( $req, true );
                $module->execute();
 
-               return array(
-                       $module->getResult()->getResultData( null, array( 'Strip' => 'all' ) ),
+               return [
+                       $module->getResult()->getResultData( null, [ 'Strip' => 'all' ] ),
                        $req
-               );
+               ];
        }
 
        /**
@@ -56,9 +55,9 @@ class UploadFromUrlTest extends ApiTestCase {
                $exception = false;
 
                try {
-                       $this->doApiRequest( array(
+                       $this->doApiRequest( [
                                'action' => 'upload',
-                       ) );
+                       ] );
                } catch ( UsageException $e ) {
                        $exception = true;
                        $this->assertEquals( "The token parameter must be set", $e->getMessage() );
@@ -67,24 +66,24 @@ class UploadFromUrlTest extends ApiTestCase {
 
                $exception = false;
                try {
-                       $this->doApiRequest( array(
+                       $this->doApiRequest( [
                                'action' => 'upload',
                                'token' => $token,
-                       ), $data );
+                       ], $data );
                } catch ( UsageException $e ) {
                        $exception = true;
-                       $this->assertEquals( "One of the parameters sessionkey, file, url, statuskey is required",
+                       $this->assertEquals( "One of the parameters sessionkey, file, url is required",
                                $e->getMessage() );
                }
                $this->assertTrue( $exception, "Got exception" );
 
                $exception = false;
                try {
-                       $this->doApiRequest( array(
+                       $this->doApiRequest( [
                                'action' => 'upload',
                                'url' => 'http://www.example.com/test.png',
                                'token' => $token,
-                       ), $data );
+                       ], $data );
                } catch ( UsageException $e ) {
                        $exception = true;
                        $this->assertEquals( "The filename parameter must be set", $e->getMessage() );
@@ -94,78 +93,17 @@ class UploadFromUrlTest extends ApiTestCase {
                $this->user->removeGroup( 'sysop' );
                $exception = false;
                try {
-                       $this->doApiRequest( array(
+                       $this->doApiRequest( [
                                'action' => 'upload',
                                'url' => 'http://www.example.com/test.png',
                                'filename' => 'UploadFromUrlTest.png',
                                'token' => $token,
-                       ), $data );
+                       ], $data );
                } catch ( UsageException $e ) {
                        $exception = true;
                        $this->assertEquals( "Permission denied", $e->getMessage() );
                }
                $this->assertTrue( $exception, "Got exception" );
-
-               $this->user->addGroup( 'sysop' );
-               $data = $this->doApiRequest( array(
-                       'action' => 'upload',
-                       'url' => 'http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png',
-                       'asyncdownload' => 1,
-                       'filename' => 'UploadFromUrlTest.png',
-                       'token' => $token,
-               ), $data );
-
-               $this->assertEquals( $data[0]['upload']['result'], 'Queued', 'Queued upload' );
-
-               $job = JobQueueGroup::singleton()->pop();
-               $this->assertThat( $job, $this->isInstanceOf( 'UploadFromUrlJob' ), 'Queued upload inserted' );
-       }
-
-       /**
-        * @depends testClearQueue
-        */
-       public function testAsyncUpload( $data ) {
-               $token = $this->user->getEditToken();
-
-               $this->user->addGroup( 'users' );
-
-               $data = $this->doAsyncUpload( $token, true );
-               $this->assertEquals( $data[0]['upload']['result'], 'Success' );
-               $this->assertEquals( $data[0]['upload']['filename'], 'UploadFromUrlTest.png' );
-               $this->assertTrue( wfLocalFile( $data[0]['upload']['filename'] )->exists() );
-
-               $this->deleteFile( 'UploadFromUrlTest.png' );
-
-               return $data;
-       }
-
-       /**
-        * @depends testClearQueue
-        */
-       public function testAsyncUploadWarning( $data ) {
-               $token = $this->user->getEditToken();
-
-               $this->user->addGroup( 'users' );
-
-               $data = $this->doAsyncUpload( $token );
-
-               $this->assertEquals( $data[0]['upload']['result'], 'Warning' );
-               $this->assertTrue( isset( $data[0]['upload']['sessionkey'] ) );
-
-               $data = $this->doApiRequest( array(
-                       'action' => 'upload',
-                       'sessionkey' => $data[0]['upload']['sessionkey'],
-                       'filename' => 'UploadFromUrlTest.png',
-                       'ignorewarnings' => 1,
-                       'token' => $token,
-               ) );
-               $this->assertEquals( $data[0]['upload']['result'], 'Success' );
-               $this->assertEquals( $data[0]['upload']['filename'], 'UploadFromUrlTest.png' );
-               $this->assertTrue( wfLocalFile( $data[0]['upload']['filename'] )->exists() );
-
-               $this->deleteFile( 'UploadFromUrlTest.png' );
-
-               return $data;
        }
 
        /**
@@ -178,13 +116,13 @@ class UploadFromUrlTest extends ApiTestCase {
                $this->assertFalse( $job, 'Starting with an empty jobqueue' );
 
                $this->user->addGroup( 'users' );
-               $data = $this->doApiRequest( array(
+               $data = $this->doApiRequest( [
                        'action' => 'upload',
                        'filename' => 'UploadFromUrlTest.png',
                        'url' => 'http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png',
                        'ignorewarnings' => true,
                        'token' => $token,
-               ), $data );
+               ], $data );
 
                $job = JobQueueGroup::singleton()->pop();
                $this->assertFalse( $job );
@@ -195,126 +133,12 @@ class UploadFromUrlTest extends ApiTestCase {
                return $data;
        }
 
-       public function testLeaveMessage() {
-               $token = $this->user->user->getEditToken();
-
-               $talk = $this->user->user->getTalkPage();
-               if ( $talk->exists() ) {
-                       $page = WikiPage::factory( $talk );
-                       $page->doDeleteArticle( '' );
-               }
-
-               $this->assertFalse(
-                       (bool)$talk->getArticleID( Title::GAID_FOR_UPDATE ),
-                       'User talk does not exist'
-               );
-
-               $this->doApiRequest( array(
-                       'action' => 'upload',
-                       'filename' => 'UploadFromUrlTest.png',
-                       'url' => 'http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png',
-                       'asyncdownload' => 1,
-                       'token' => $token,
-                       'leavemessage' => 1,
-                       'ignorewarnings' => 1,
-               ) );
-
-               $job = JobQueueGroup::singleton()->pop();
-               $this->assertEquals( 'UploadFromUrlJob', get_class( $job ) );
-               $job->run();
-
-               $this->assertTrue( wfLocalFile( 'UploadFromUrlTest.png' )->exists() );
-               $this->assertTrue( (bool)$talk->getArticleID( Title::GAID_FOR_UPDATE ), 'User talk exists' );
-
-               $this->deleteFile( 'UploadFromUrlTest.png' );
-
-               $exception = false;
-               try {
-                       $this->doApiRequest( array(
-                               'action' => 'upload',
-                               'filename' => 'UploadFromUrlTest.png',
-                               'url' => 'http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png',
-                               'asyncdownload' => 1,
-                               'token' => $token,
-                               'leavemessage' => 1,
-                       ) );
-               } catch ( UsageException $e ) {
-                       $exception = true;
-                       $this->assertEquals(
-                               'Using leavemessage without ignorewarnings is not supported',
-                               $e->getMessage()
-                       );
-               }
-               $this->assertTrue( $exception );
-
-               $job = JobQueueGroup::singleton()->pop();
-               $this->assertFalse( $job );
-
-               return;
-               /*
-               // Broken until using leavemessage with ignorewarnings is supported
-               $talkRev = Revision::newFromTitle( $talk );
-               $talkSize = $talkRev->getSize();
-
-               $job->run();
-
-               $this->assertFalse( wfLocalFile( 'UploadFromUrlTest.png' )->exists() );
-
-               $talkRev = Revision::newFromTitle( $talk );
-               $this->assertTrue( $talkRev->getSize() > $talkSize, 'New message left' );
-               */
-       }
-
-       /**
-        * Helper function to perform an async upload, execute the job and fetch
-        * the status
-        *
-        * @param string $token
-        * @param bool $ignoreWarnings
-        * @param bool $leaveMessage
-        * @return array The result of action=upload&statuskey=key
-        */
-       private function doAsyncUpload( $token, $ignoreWarnings = false, $leaveMessage = false ) {
-               $params = array(
-                       'action' => 'upload',
-                       'filename' => 'UploadFromUrlTest.png',
-                       'url' => 'http://upload.wikimedia.org/wikipedia/mediawiki/b/bc/Wiki.png',
-                       'asyncdownload' => 1,
-                       'token' => $token,
-               );
-               if ( $ignoreWarnings ) {
-                       $params['ignorewarnings'] = 1;
-               }
-               if ( $leaveMessage ) {
-                       $params['leavemessage'] = 1;
-               }
-
-               $data = $this->doApiRequest( $params );
-               $this->assertEquals( $data[0]['upload']['result'], 'Queued' );
-               $this->assertTrue( isset( $data[0]['upload']['statuskey'] ) );
-               $statusKey = $data[0]['upload']['statuskey'];
-
-               $job = JobQueueGroup::singleton()->pop();
-               $this->assertEquals( 'UploadFromUrlJob', get_class( $job ) );
-
-               $status = $job->run();
-               $this->assertTrue( $status );
-
-               $data = $this->doApiRequest( array(
-                       'action' => 'upload',
-                       'statuskey' => $statusKey,
-                       'token' => $token,
-               ) );
-
-               return $data;
-       }
-
        protected function deleteFile( $name ) {
                $t = Title::newFromText( $name, NS_FILE );
                $this->assertTrue( $t->exists(), "File '$name' exists" );
 
                if ( $t->exists() ) {
-                       $file = wfFindFile( $name, array( 'ignoreRedirect' => true ) );
+                       $file = wfFindFile( $name, [ 'ignoreRedirect' => true ] );
                        $empty = "";
                        FileDeleteForm::doDelete( $t, $file, $empty, "none", true );
                        $page = WikiPage::factory( $t );