<?php
+
+use Wikimedia\TestingAccessWrapper;
+
/**
* Test class for ChangesListSpecialPage class
*
[
'namespace' => NS_MAIN,
],
- "rc conditions with no options (aka default setting)"
+ "rc conditions with one namespace"
);
}
);
}
- /**
- * T4429
- * @dataProvider provideNamespacesAssociations
- */
- public function testRcNsFilterAssociation( $ns1, $ns2 ) {
+ public function testRcNsFilterMultiple() {
+ $this->assertConditions(
+ [ # expected
+ "rc_namespace IN ('1','2','3')",
+ ],
+ [
+ 'namespace' => '1,2,3',
+ ],
+ "rc conditions with multiple namespaces"
+ );
+ }
+
+ public function testRcNsFilterMultipleAssociated() {
$this->assertConditions(
[ # expected
- "(rc_namespace = '$ns1' OR rc_namespace = '$ns2')",
+ "rc_namespace IN ('0','1','4','5','6','7')",
],
[
- 'namespace' => $ns1,
+ 'namespace' => '1,4,7',
'associated' => 1,
],
- "rc conditions with namespace inverted"
+ "rc conditions with multiple namespaces and associated"
);
}
- /**
- * T4429
- * @dataProvider provideNamespacesAssociations
- */
- public function testRcNsFilterAssociationWithInversion( $ns1, $ns2 ) {
+ public function testRcNsFilterMultipleAssociatedInvert() {
$this->assertConditions(
[ # expected
- "(rc_namespace != '$ns1' AND rc_namespace != '$ns2')",
+ "rc_namespace NOT IN ('2','3','8','9')",
],
[
- 'namespace' => $ns1,
+ 'namespace' => '2,3,9',
'associated' => 1,
- 'invert' => 1,
+ 'invert' => 1
],
- "rc conditions with namespace inverted"
+ "rc conditions with multiple namespaces, associated and inverted"
);
}
- /**
- * Provides associated namespaces to test recent changes
- * namespaces association filtering.
- */
- public static function provideNamespacesAssociations() {
- return [ # (NS => Associated_NS)
- [ NS_MAIN, NS_TALK ],
- [ NS_TALK, NS_MAIN ],
- ];
+ public function testRcNsFilterMultipleInvert() {
+ $this->assertConditions(
+ [ # expected
+ "rc_namespace NOT IN ('1','2','3')",
+ ],
+ [
+ 'namespace' => '1,2,3',
+ 'invert' => 1,
+ ],
+ "rc conditions with multiple namespaces inverted"
+ );
}
public function testRcHidemyselfFilter() {
}
public function testFilterUserExpLevel() {
+ $now = time();
$this->setMwGlobals( [
'wgLearnerEdits' => 10,
'wgLearnerMemberSince' => 4,
'Learner3' => [ 'edits' => 460, 'days' => 33 ],
'Learner4' => [ 'edits' => 525, 'days' => 28 ],
'Experienced1' => [ 'edits' => 538, 'days' => 33 ],
- ] );
+ ], $now );
// newcomers only
$this->assertArrayEquals(
[ 'Newcomer1', 'Newcomer2', 'Newcomer3' ],
- $this->fetchUsers( [ 'newcomer' ] )
+ $this->fetchUsers( [ 'newcomer' ], $now )
);
// newcomers and learner
'Newcomer1', 'Newcomer2', 'Newcomer3',
'Learner1', 'Learner2', 'Learner3', 'Learner4',
],
- $this->fetchUsers( [ 'newcomer', 'learner' ] )
+ $this->fetchUsers( [ 'newcomer', 'learner' ], $now )
);
// newcomers and more learner
'Newcomer1', 'Newcomer2', 'Newcomer3',
'Experienced1',
],
- $this->fetchUsers( [ 'newcomer', 'experienced' ] )
+ $this->fetchUsers( [ 'newcomer', 'experienced' ], $now )
);
// learner only
$this->assertArrayEquals(
[ 'Learner1', 'Learner2', 'Learner3', 'Learner4' ],
- $this->fetchUsers( [ 'learner' ] )
+ $this->fetchUsers( [ 'learner' ], $now )
);
// more experienced only
$this->assertArrayEquals(
[ 'Experienced1' ],
- $this->fetchUsers( [ 'experienced' ] )
+ $this->fetchUsers( [ 'experienced' ], $now )
);
// learner and more experienced
'Learner1', 'Learner2', 'Learner3', 'Learner4',
'Experienced1',
],
- $this->fetchUsers( [ 'learner', 'experienced' ] ),
+ $this->fetchUsers( [ 'learner', 'experienced' ], $now ),
'Learner and more experienced'
);
/* 'Learner1', 'Learner2', 'Learner3', 'Learner4', */
/* 'Experienced1', */
/* ], */
- /* $this->fetchUsers( [ 'newcomer', 'learner', 'experienced' ] ) */
+ /* $this->fetchUsers( [ 'newcomer', 'learner', 'experienced' ], $now ) */
/* ); */
}
- private function createUsers( $specs ) {
+ private function createUsers( $specs, $now ) {
$dbw = wfGetDB( DB_MASTER );
foreach ( $specs as $name => $spec ) {
User::createNew(
$name,
[
'editcount' => $spec['edits'],
- 'registration' => $dbw->timestamp( $this->daysAgo( $spec['days'] ) ),
+ 'registration' => $dbw->timestamp( $this->daysAgo( $spec['days'], $now ) ),
'email' => 'ut',
]
);
}
}
- private function fetchUsers( $filters ) {
+ private function fetchUsers( $filters, $now ) {
$tables = [];
$conds = [];
$fields = [];
&$conds,
&$query_options,
&$join_conds,
- $filters
+ $filters,
+ $now
]
);
$result = wfGetDB( DB_MASTER )->select(
- 'user',
+ $tables,
'user_name',
array_filter( $conds ) + [ 'user_email' => 'ut' ]
);
return $usernames;
}
- private function daysAgo( $days ) {
+ private function daysAgo( $days, $now ) {
$secondsPerDay = 86400;
- return time() - $days * $secondsPerDay;
+ return $now - $days * $secondsPerDay;
}
public function testGetFilterGroupDefinitionFromLegacyCustomFilters() {
],
];
}
+
+ public function provideGetFilterConflicts() {
+ return [
+ [
+ "parameters" => [],
+ "expectedConflicts" => false,
+ ],
+ [
+ "parameters" => [
+ "hideliu" => true,
+ "userExpLevel" => "newcomer",
+ ],
+ "expectedConflicts" => true,
+ ],
+ [
+ "parameters" => [
+ "hideanons" => true,
+ "userExpLevel" => "learner",
+ ],
+ "expectedConflicts" => false,
+ ],
+ [
+ "parameters" => [
+ "hidemajor" => true,
+ "hidenewpages" => true,
+ "hidepageedits" => true,
+ "hidecategorization" => false,
+ "hidelog" => true,
+ "hideWikidata" => true,
+ ],
+ "expectedConflicts" => true,
+ ],
+ [
+ "parameters" => [
+ "hidemajor" => true,
+ "hidenewpages" => false,
+ "hidepageedits" => true,
+ "hidecategorization" => false,
+ "hidelog" => false,
+ "hideWikidata" => true,
+ ],
+ "expectedConflicts" => true,
+ ],
+ [
+ "parameters" => [
+ "hidemajor" => true,
+ "hidenewpages" => false,
+ "hidepageedits" => false,
+ "hidecategorization" => true,
+ "hidelog" => true,
+ "hideWikidata" => true,
+ ],
+ "expectedConflicts" => false,
+ ],
+ [
+ "parameters" => [
+ "hideminor" => true,
+ "hidenewpages" => true,
+ "hidepageedits" => true,
+ "hidecategorization" => false,
+ "hidelog" => true,
+ "hideWikidata" => true,
+ ],
+ "expectedConflicts" => false,
+ ],
+ ];
+ }
+
+ /**
+ * @dataProvider provideGetFilterConflicts
+ */
+ public function testGetFilterConflicts( $parameters, $expectedConflicts ) {
+ $context = new RequestContext;
+ $context->setRequest( new FauxRequest( $parameters ) );
+ $this->changesListSpecialPage->setContext( $context );
+
+ $this->assertEquals(
+ $expectedConflicts,
+ $this->changesListSpecialPage->areFiltersInConflict()
+ );
+ }
}
dépôts / lhc / web / wiklou.git / blobdiff