Complete VersionChecker test coverage

[lhc/web/wiklou.git] / tests / phpunit / includes / registration / VersionCheckerTest.php

diff --git a/tests/phpunit/includes/registration/VersionCheckerTest.php b/tests/phpunit/includes/registration/VersionCheckerTest.php
index 2bb1fe4..4a2810b 100644 (file)
--- a/tests/phpunit/includes/registration/VersionCheckerTest.php
+++ b/tests/phpunit/includes/registration/VersionCheckerTest.php
@@ -1,15 +1,17 @@
 <?php
 
 /**
- * @covers CoreVersionChecker
+ * @covers VersionChecker
  */
-class CoreVersionCheckerTest extends PHPUnit_Framework_TestCase {
+class VersionCheckerTest extends PHPUnit_Framework_TestCase {
+
+       use MediaWikiCoversValidator;
+
        /**
         * @dataProvider provideCheck
         */
        public function testCheck( $coreVersion, $constraint, $expected ) {
-               $checker = new VersionChecker();
-               $checker->setCoreVersion( $coreVersion );
+               $checker = new VersionChecker( $coreVersion );
                $this->assertEquals( $expected, !(bool)$checker->checkArray( [
                        'FakeExtension' => [
                                'MediaWiki' => $constraint,
@@ -46,13 +48,13 @@ class CoreVersionCheckerTest extends PHPUnit_Framework_TestCase {
         * @dataProvider provideType
         */
        public function testType( $given, $expected ) {
-               $checker = new VersionChecker();
+               $checker = new VersionChecker( '1.0.0' );
                $checker
-                       ->setCoreVersion( '1.0.0' )
                        ->setLoadedExtensionsAndSkins( [
                                'FakeDependency' => [
                                        'version' => '1.0.0',
                                ],
+                               'NoVersionGiven' => [],
                        ] );
                $this->assertEquals( $expected, $checker->checkArray( [
                        'FakeExtension' => $given,
@@ -77,6 +79,39 @@ class CoreVersionCheckerTest extends PHPUnit_Framework_TestCase {
                                ],
                                []
                        ],
+                       [
+                               [
+                                       'extensions' => [
+                                               'NoVersionGiven' => '*'
+                                       ]
+                               ],
+                               [],
+                       ],
+                       [
+                               [
+                                       'extensions' => [
+                                               'NoVersionGiven' => '1.0',
+                                       ]
+                               ],
+                               [ 'NoVersionGiven does not expose its version, but FakeExtension requires: 1.0.' ],
+                       ],
+                       [
+                               [
+                                       'extensions' => [
+                                               'Missing' => '*',
+                                       ]
+                               ],
+                               [ 'FakeExtension requires Missing to be installed.' ],
+                       ],
+                       [
+                               [
+                                       'extensions' => [
+                                               'FakeDependency' => '2.0.0',
+                                       ]
+                               ],
+                               // phpcs:ignore Generic.Files.LineLength.TooLong
+                               [ 'FakeExtension is not compatible with the current installed version of FakeDependency (1.0.0), it requires: 2.0.0.' ],
+                       ]
                ];
        }
 
@@ -85,15 +120,14 @@ class CoreVersionCheckerTest extends PHPUnit_Framework_TestCase {
         * returns any error message.
         */
        public function testInvalidConstraint() {
-               $checker = new VersionChecker();
+               $checker = new VersionChecker( '1.0.0' );
                $checker
-                       ->setCoreVersion( '1.0.0' )
                        ->setLoadedExtensionsAndSkins( [
                                'FakeDependency' => [
                                        'version' => 'not really valid',
                                ],
                        ] );
-               $this->assertEquals( [ "Dependency FakeDependency provides an invalid version string." ],
+               $this->assertEquals( [ "FakeDependency does not have a valid version string." ],
                        $checker->checkArray( [
                                'FakeExtension' => [
                                        'extensions' => [
@@ -103,16 +137,15 @@ class CoreVersionCheckerTest extends PHPUnit_Framework_TestCase {
                        ] )
                );
 
-               $checker = new VersionChecker();
+               $checker = new VersionChecker( '1.0.0' );
                $checker
-                       ->setCoreVersion( '1.0.0' )
                        ->setLoadedExtensionsAndSkins( [
                                'FakeDependency' => [
                                        'version' => '1.24.3',
                                ],
                        ] );
 
-               $this->setExpectedException( 'UnexpectedValueException' );
+               $this->setExpectedException( UnexpectedValueException::class );
                $checker->checkArray( [
                        'FakeExtension' => [
                                'FakeDependency' => 'not really valid',