Merge "Revert "Add type hint against LinkTarget""

[lhc/web/wiklou.git] / tests / phpunit / includes / poolcounter / PoolCounterTest.php

diff --git a/tests/phpunit/includes/poolcounter/PoolCounterTest.php b/tests/phpunit/includes/poolcounter/PoolCounterTest.php
index d9cd57e..15b47b4 100644 (file)
--- a/tests/phpunit/includes/poolcounter/PoolCounterTest.php
+++ b/tests/phpunit/includes/poolcounter/PoolCounterTest.php
@@ -1,7 +1,8 @@
 <?php
 
-// We will use this class with getMockForAbstractClass to create a concrete mock class. That call will die if the
-// contructor is not public, unless we use disableOriginalConstructor(), in which case we could not test the constructor.
+// We will use this class with getMockForAbstractClass to create a concrete mock class.
+// That call will die if the contructor is not public, unless we use disableOriginalConstructor(),
+// in which case we could not test the constructor.
 abstract class PoolCounterAbstractMock extends PoolCounter {
        public function __construct() {
                call_user_func_array( 'parent::__construct', func_get_args() );
@@ -10,50 +11,50 @@ abstract class PoolCounterAbstractMock extends PoolCounter {
 
 class PoolCounterTest extends MediaWikiTestCase {
        public function testConstruct() {
-               $poolCounterConfig = array(
+               $poolCounterConfig = [
                        'class' => 'PoolCounterMock',
                        'timeout' => 10,
                        'workers' => 10,
                        'maxqueue' => 100,
-               );
+               ];
 
                $poolCounter = $this->getMockBuilder( 'PoolCounterAbstractMock' )
-                       ->setConstructorArgs( array( $poolCounterConfig, 'testCounter', 'someKey' ) )
-                       // don't mock anything - the proper syntax would be setMethods(null), but due to a PHPUnit bug that
-                       // does not work with getMockForAbstractClass()
-                       ->setMethods( array( 'idontexist' ) )
+                       ->setConstructorArgs( [ $poolCounterConfig, 'testCounter', 'someKey' ] )
+                       // don't mock anything - the proper syntax would be setMethods(null), but due
+                       // to a PHPUnit bug that does not work with getMockForAbstractClass()
+                       ->setMethods( [ 'idontexist' ] )
                        ->getMockForAbstractClass();
                $this->assertInstanceOf( 'PoolCounter', $poolCounter );
        }
 
        public function testConstructWithSlots() {
-               $poolCounterConfig = array(
+               $poolCounterConfig = [
                        'class' => 'PoolCounterMock',
                        'timeout' => 10,
                        'workers' => 10,
                        'slots' => 2,
                        'maxqueue' => 100,
-               );
+               ];
 
                $poolCounter = $this->getMockBuilder( 'PoolCounterAbstractMock' )
-                       ->setConstructorArgs( array( $poolCounterConfig, 'testCounter', 'key' ) )
-                       ->setMethods( array( 'idontexist' ) ) // don't mock anything
+                       ->setConstructorArgs( [ $poolCounterConfig, 'testCounter', 'key' ] )
+                       ->setMethods( [ 'idontexist' ] ) // don't mock anything
                        ->getMockForAbstractClass();
                $this->assertInstanceOf( 'PoolCounter', $poolCounter );
        }
 
        public function testHashKeyIntoSlots() {
                $poolCounter = $this->getMockBuilder( 'PoolCounterAbstractMock' )
-                       // don't mock anything - the proper syntax would be setMethods(null), but due to a PHPUnit bug that
-                       // does not work with getMockForAbstractClass()
-                       ->setMethods( array( 'idontexist' ) )
+                       // don't mock anything - the proper syntax would be setMethods(null), but due
+                       // to a PHPUnit bug that does not work with getMockForAbstractClass()
+                       ->setMethods( [ 'idontexist' ] )
                        ->disableOriginalConstructor()
                        ->getMockForAbstractClass();
 
                $hashKeyIntoSlots = new ReflectionMethod( $poolCounter, 'hashKeyIntoSlots' );
                $hashKeyIntoSlots->setAccessible( true );
 
-               $keysWithTwoSlots = $keysWithFiveSlots = array();
+               $keysWithTwoSlots = $keysWithFiveSlots = [];
                foreach ( range( 1, 100 ) as $i ) {
                        $keysWithTwoSlots[] = $hashKeyIntoSlots->invoke( $poolCounter, 'key ' . $i, 2 );
                        $keysWithFiveSlots[] = $hashKeyIntoSlots->invoke( $poolCounter, 'key ' . $i, 5 );