return [
'No overrides' => [ true, [] ],
'In-key options are ok' => [ true, [
- 'editsection' => false,
'thumbsize' => 1e100,
'wrapclass' => false,
] ],
];
}
- /**
- * @dataProvider provideOptionsHashPre30
- * @param array $usedOptions Used options
- * @param string $expect Expected value
- * @param array $options Options to set
- * @param array $globals Globals to set
- */
- public function testOptionsHashPre30( $usedOptions, $expect, $options, $globals = [] ) {
- global $wgHooks;
-
- $globals += [
- 'wgRenderHashAppend' => '',
- 'wgHooks' => [],
- ];
- $globals['wgHooks'] += [
- 'PageRenderingHash' => [],
- ] + $wgHooks;
- $this->setMwGlobals( $globals );
-
- $popt = new ParserOptions();
- foreach ( $options as $setter => $value ) {
- $popt->$setter( $value );
- }
- $this->assertSame( $expect, $popt->optionsHashPre30( $usedOptions ) );
- }
-
- public static function provideOptionsHashPre30() {
- $used = [ 'wrapclass', 'editsection', 'printable' ];
-
- return [
- 'Canonical options, nothing used' => [ [], '*!*!*!*!*!*', [] ],
- 'Canonical options, used some options' => [ $used, '*!*!*!*!*', [] ],
- 'Used some options, non-default values' => [
- $used,
- '*!*!*!*!*!printable=1!wrapclass=foobar',
- [
- 'setWrapOutputClass' => 'foobar',
- 'setIsPrintable' => true,
- ]
- ],
- 'Canonical options, nothing used, but with hooks and $wgRenderHashAppend' => [
- [],
- '*!*!*!*!*!wgRenderHashAppend!*!onPageRenderingHash',
- [],
- [
- 'wgRenderHashAppend' => '!wgRenderHashAppend',
- 'wgHooks' => [ 'PageRenderingHash' => [ [ __CLASS__ . '::onPageRenderingHash' ] ] ],
- ]
- ],
- ];
- }
-
/**
* @dataProvider provideOptionsHash
* @param array $usedOptions Used options
}
public static function provideOptionsHash() {
- $used = [ 'wrapclass', 'editsection', 'printable' ];
+ $used = [ 'wrapclass', 'printable' ];
$classWrapper = TestingAccessWrapper::newFromClass( ParserOptions::class );
$classWrapper->getDefaults();
$confstr .= '!onPageRenderingHash';
}
+ // Test weird historical behavior is still weird
+ public function testOptionsHashEditSection() {
+ global $wgHooks;
+
+ $this->setMwGlobals( [
+ 'wgRenderHashAppend' => '',
+ 'wgHooks' => [ 'PageRenderingHash' => [] ] + $wgHooks,
+ ] );
+
+ $popt = ParserOptions::newCanonical();
+ $popt->registerWatcher( function ( $name ) {
+ $this->assertNotEquals( 'editsection', $name );
+ } );
+
+ $this->assertTrue( $popt->getEditSection() );
+ $this->assertSame( 'canonical', $popt->optionsHash( [] ) );
+ $this->assertSame( 'canonical', $popt->optionsHash( [ 'editsection' ] ) );
+
+ $popt->setEditSection( false );
+ $this->assertFalse( $popt->getEditSection() );
+ $this->assertSame( 'canonical', $popt->optionsHash( [] ) );
+ $this->assertSame( 'editsection=0', $popt->optionsHash( [ 'editsection' ] ) );
+ }
+
/**
* @expectedException InvalidArgumentException
* @expectedExceptionMessage Unknown parser option bogus