Merge "Revert "Log the reason why revision->getContent() returns null""

[lhc/web/wiklou.git] / tests / phpunit / includes / api / query / ApiQueryContinueTestBase.php

diff --git a/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php b/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php
index 3960e88..d2bdb49 100644 (file)
--- a/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php
+++ b/tests/phpunit/includes/api/query/ApiQueryContinueTestBase.php
@@ -1,7 +1,5 @@
 <?php
 /**
- * Created on Jan 1, 2013
- *
  * Copyright © 2013 Yuri Astrakhan "<Firstname><Lastname>@gmail.com"
  *
  * This program is free software; you can redistribute it and/or modify
@@ -57,13 +55,9 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase {
                } else {
                        $params['action'] = 'query';
                }
-               // Silence warning
-               if ( !isset( $params['continue'] ) ) {
-                       $params['continue'] = '';
-               }
                $count = 0;
-               $result = array();
-               $continue = array();
+               $result = [];
+               $continue = [];
                do {
                        $request = array_merge( $params, $continue );
                        uksort( $request, function ( $a, $b ) {
@@ -94,7 +88,7 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase {
                                $continue = $data['continue'];
                                unset( $data['continue'] );
                        } else {
-                               $continue = array();
+                               $continue = [];
                        }
                        if ( $this->mVerbose ) {
                                $this->printResult( $data );
@@ -116,7 +110,7 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase {
         */
        private function printResult( $data ) {
                $q = $data['query'];
-               $print = array();
+               $print = [];
                if ( isset( $q['pages'] ) ) {
                        foreach ( $q['pages'] as $p ) {
                                $m = $p['title'];
@@ -163,7 +157,7 @@ abstract class ApiQueryContinueTestBase extends ApiQueryTestBase {
 
        /**
         * Recursively merge the new result returned from the query to the previous results.
-        * @param mixed $results
+        * @param mixed &$results
         * @param mixed $newResult
         * @param bool $numericIds If true, treat keys as ids to be merged instead of appending
         */