Do not insert page titles into querycache.qc_value

[lhc/web/wiklou.git] / tests / phpunit / includes / LinkerTest.php

diff --git a/tests/phpunit/includes/LinkerTest.php b/tests/phpunit/includes/LinkerTest.php
index d3523c3..dcac471 100644 (file)
--- a/tests/phpunit/includes/LinkerTest.php
+++ b/tests/phpunit/includes/LinkerTest.php
@@ -4,7 +4,6 @@
  * @group Database
  */
 class LinkerTest extends MediaWikiLangTestCase {
-
        /**
         * @dataProvider provideCasesForUserLink
         * @covers Linker::userLink
@@ -15,11 +14,11 @@ class LinkerTest extends MediaWikiLangTestCase {
                ] );
 
                // We'd also test the warning, but injecting a mock logger into a static method is tricky.
-               if ( $userName === '' ) {
+               if ( !$userName ) {
                        Wikimedia\suppressWarnings();
                }
                $actual = Linker::userLink( $userId, $userName, $altUserName );
-               if ( $userName === '' ) {
+               if ( !$userName ) {
                        Wikimedia\restoreWarnings();
                }
 
@@ -38,6 +37,9 @@ class LinkerTest extends MediaWikiLangTestCase {
                        'Empty username, userid 0' => [ '(no username available)', 0, '' ],
                        'Empty username, userid > 0' => [ '(no username available)', 73, '' ],
 
+                       'false instead of username' => [ '(no username available)', 73, false ],
+                       'null instead of username' => [ '(no username available)', 0, null ],
+
                        # ## ANONYMOUS USER ########################################
                        [
                                '<a href="/wiki/Special:Contributions/JohnDoe" '
@@ -279,7 +281,7 @@ class LinkerTest extends MediaWikiLangTestCase {
                                "/* [[linkie?]] */",
                        ],
                        [
-                               '<span dir="auto"><span class="autocomment"><a href="/wiki/Special:BlankPage" title="Special:BlankPage">→‎</a>: </span> // Edit via via</span>',
+                               '<span dir="auto"><span class="autocomment">: </span> // Edit via via</span>',
                                // Regression test for T222857
                                "/*  */ // Edit via via",
                        ],
@@ -321,6 +323,36 @@ class LinkerTest extends MediaWikiLangTestCase {
                                "/* autocomment */",
                                null
                        ],
+                       [
+                               '',
+                               "/* */",
+                               false, true
+                       ],
+                       [
+                               '',
+                               "/* */",
+                               null
+                       ],
+                       [
+                               '<span dir="auto"><span class="autocomment">[[</span></span>',
+                               "/* [[ */",
+                               false, true
+                       ],
+                       [
+                               '<span dir="auto"><span class="autocomment">[[</span></span>',
+                               "/* [[ */",
+                               null
+                       ],
+                       [
+                               "foo <span dir=\"auto\"><span class=\"autocomment\"><a href=\"#.23\">→‎&#91;[#_\t_]]</a></span></span>",
+                               "foo /* [[#_\t_]] */",
+                               false, true
+                       ],
+                       [
+                               "foo <span dir=\"auto\"><span class=\"autocomment\"><a href=\"#_.09\">#_\t_</a></span></span>",
+                               "foo /* [[#_\t_]] */",
+                               null
+                       ],
                        [
                                '<span dir="auto"><span class="autocomment"><a href="/wiki/Special:BlankPage#autocomment" title="Special:BlankPage">→‎autocomment</a></span></span>',
                                "/* autocomment */",
@@ -414,14 +446,15 @@ class LinkerTest extends MediaWikiLangTestCase {
         * @covers Linker::generateRollback
         * @dataProvider provideCasesForRollbackGeneration
         */
-       public function testGenerateRollback( $rollbackEnabled, $expectedModules ) {
+       public function testGenerateRollback( $rollbackEnabled, $expectedModules, $title ) {
                $this->markTestSkippedIfDbType( 'postgres' );
 
                $context = RequestContext::getMain();
                $user = $context->getUser();
                $user->setOption( 'showrollbackconfirmation', $rollbackEnabled );
 
-               $pageData = $this->insertPage( 'Rollback_Test_Page' );
+               $this->assertSame( 0, Title::newFromText( $title )->getArticleID() );
+               $pageData = $this->insertPage( $title );
                $page = WikiPage::factory( $pageData['title'] );
 
                $updater = $page->newPageUpdater( $user );
@@ -433,8 +466,24 @@ class LinkerTest extends MediaWikiLangTestCase {
 
                $rollbackOutput = Linker::generateRollback( $page->getRevision(), $context );
                $modules = $context->getOutput()->getModules();
+               $currentRev = $page->getRevision();
+               $oldestRev = $page->getOldestRevision();
 
                $this->assertEquals( $expectedModules, $modules );
+               $this->assertEquals( $user->getName(), $currentRev->getUserText() );
+               $this->assertEquals(
+                       static::getTestSysop()->getUser(),
+                       $oldestRev->getUserText()
+               );
+
+               $ids = [];
+               $r = $oldestRev;
+               while ( $r ) {
+                       $ids[] = $r->getId();
+                       $r = $r->getNext();
+               }
+               $this->assertEquals( [ $oldestRev->getId(), $currentRev->getId() ], $ids );
+
                $this->assertContains( 'rollback 1 edit', $rollbackOutput );
        }
 
@@ -442,12 +491,13 @@ class LinkerTest extends MediaWikiLangTestCase {
                return [
                        [
                                true,
-                               [ 'mediawiki.page.rollback.confirmation' ]
-
+                               [ 'mediawiki.page.rollback.confirmation' ],
+                               'Rollback_Test_Page'
                        ],
                        [
                                false,
-                               []
+                               [],
+                               'Rollback_Test_Page2'
                        ]
                ];
        }