Do not insert page titles into querycache.qc_value

[lhc/web/wiklou.git] / tests / phpunit / includes / LinkerTest.php

diff --git a/tests/phpunit/includes/LinkerTest.php b/tests/phpunit/includes/LinkerTest.php
index c700d5f..dcac471 100644 (file)
--- a/tests/phpunit/includes/LinkerTest.php
+++ b/tests/phpunit/includes/LinkerTest.php
@@ -14,11 +14,11 @@ class LinkerTest extends MediaWikiLangTestCase {
                ] );
 
                // We'd also test the warning, but injecting a mock logger into a static method is tricky.
-               if ( $userName === '' ) {
+               if ( !$userName ) {
                        Wikimedia\suppressWarnings();
                }
                $actual = Linker::userLink( $userId, $userName, $altUserName );
-               if ( $userName === '' ) {
+               if ( !$userName ) {
                        Wikimedia\restoreWarnings();
                }
 
@@ -37,6 +37,9 @@ class LinkerTest extends MediaWikiLangTestCase {
                        'Empty username, userid 0' => [ '(no username available)', 0, '' ],
                        'Empty username, userid > 0' => [ '(no username available)', 73, '' ],
 
+                       'false instead of username' => [ '(no username available)', 73, false ],
+                       'null instead of username' => [ '(no username available)', 0, null ],
+
                        # ## ANONYMOUS USER ########################################
                        [
                                '<a href="/wiki/Special:Contributions/JohnDoe" '
@@ -450,7 +453,7 @@ class LinkerTest extends MediaWikiLangTestCase {
                $user = $context->getUser();
                $user->setOption( 'showrollbackconfirmation', $rollbackEnabled );
 
-               $this->assertEquals( 0, Title::newFromText( $title )->getArticleID() );
+               $this->assertSame( 0, Title::newFromText( $title )->getArticleID() );
                $pageData = $this->insertPage( $title );
                $page = WikiPage::factory( $pageData['title'] );