groupModel.areAllSelectedInConflictWith( filterItem ) &&
// Every selected member of the item's own group is also
// in conflict with the other group
- filterItemGroup.getSelectedItems().every( function ( otherGroupItem ) {
+ filterItemGroup.findSelectedItems().every( function ( otherGroupItem ) {
return groupModel.areAllSelectedInConflictWith( otherGroupItem );
} )
);
mw.rcfilters.dm.FiltersViewModel.prototype.getFirstConflictedItem = function () {
var conflictedItem;
- $.each( this.getItems(), function ( index, filterItem ) {
+ this.getItems().forEach( function ( filterItem ) {
if ( filterItem.isSelected() && filterItem.isConflicted() ) {
conflictedItem = filterItem;
return false;
*/
mw.rcfilters.dm.FiltersViewModel.prototype.areNamespacesEffectivelyInverted = function () {
return this.getInvertModel().isSelected() &&
- this.getSelectedItems().some( function ( itemModel ) {
+ this.findSelectedItems().some( function ( itemModel ) {
return itemModel.getGroupModel().getName() === 'namespace';
} );
};
*
* @return {mw.rcfilters.dm.FilterItem[]} Selected items
*/
- mw.rcfilters.dm.FiltersViewModel.prototype.getSelectedItems = function () {
+ mw.rcfilters.dm.FiltersViewModel.prototype.findSelectedItems = function () {
var allSelected = [];
$.each( this.getFilterGroups(), function ( groupName, groupModel ) {
- allSelected = allSelected.concat( groupModel.getSelectedItems() );
+ allSelected = allSelected.concat( groupModel.findSelectedItems() );
} );
return allSelected;