}
}
$fields['top'] = $dbr->addQuotes( 'no' );
- } else {
- if ( $this->mShowAll ) {
- $fields['top'] = $dbr->addQuotes( 'yes' );
- }
+ } elseif ( $this->mShowAll ) {
+ $fields['top'] = $dbr->addQuotes( 'yes' );
}
$fields['thumb'] = $prefix . '_name';
$resultArray[] = $topRes2;
$topRes2 = $res2->next();
}
+ } elseif ( !$ascending ) {
+ $resultArray[] = $topRes2;
+ $topRes2 = $res2->next();
} else {
- if ( !$ascending ) {
- $resultArray[] = $topRes2;
- $topRes2 = $res2->next();
- } else {
- $resultArray[] = $topRes1;
- $topRes1 = $res1->next();
- }
+ $resultArray[] = $topRes1;
+ $topRes1 = $res1->next();
}
}
// Add delete links if allowed
// From https://github.com/Wikia/app/pull/3859
- if ( $filePage->userCan( 'delete', $this->getUser() ) ) {
+ $permissionManager = MediaWikiServices::getInstance()->getPermissionManager();
+
+ if ( $permissionManager->userCan( 'delete', $this->getUser(), $filePage ) ) {
$deleteMsg = $this->msg( 'listfiles-delete' )->text();
$delete = $linkRenderer->makeKnownLink(
return $this->getLanguage()->formatNum( intval( $value ) + 1 );
case 'top':
// Messages: listfiles-latestversion-yes, listfiles-latestversion-no
- return $this->msg( 'listfiles-latestversion-' . $value );
+ return $this->msg( 'listfiles-latestversion-' . $value )->escaped();
default:
throw new MWException( "Unknown field '$field'" );
}