Merge "Add tablesUsed to RevisionStoreDbTest"

[lhc/web/wiklou.git] / includes / skins / QuickTemplate.php

diff --git a/includes/skins/QuickTemplate.php b/includes/skins/QuickTemplate.php
index e0ceab5..19b41ba 100644 (file)
--- a/includes/skins/QuickTemplate.php
+++ b/includes/skins/QuickTemplate.php
@@ -62,11 +62,11 @@ abstract class QuickTemplate {
        }
 
        /**
-       * extends the value of data with name $name with the value $value
-       * @since 1.25
-       * @param string $name
-       * @param mixed $value
-       */
+        * extends the value of data with name $name with the value $value
+        * @since 1.25
+        * @param string $name
+        * @param mixed $value
+        */
        public function extend( $name, $value ) {
                if ( $this->haveData( $name ) ) {
                        $this->data[$name] = $this->data[$name] . $value;
@@ -91,15 +91,19 @@ abstract class QuickTemplate {
        }
 
        /**
+        * @deprecated since 1.31 This function is a now-redundant optimisation intended
+        *  for very old versions of PHP. The use of references here makes the code
+        *  more fragile and is incompatible with plans like T140664. Use set() instead.
         * @param string $name
-        * @param mixed $value
+        * @param mixed &$value
         */
        public function setRef( $name, &$value ) {
+               wfDeprecated( __METHOD__, '1.31' );
                $this->data[$name] =& $value;
        }
 
        /**
-        * @param MediaWikiI18N $t
+        * @param MediaWikiI18N &$t
         */
        public function setTranslator( &$t ) {
                $this->translator = &$t;