rdbms: make Database query error handling more strict
[lhc/web/wiklou.git] / includes / libs / rdbms / database / DatabaseMysqlBase.php
index bc4beba..6beea17 100644 (file)
@@ -73,6 +73,9 @@ abstract class DatabaseMysqlBase extends Database {
        // Cache getServerId() for 24 hours
        const SERVER_ID_CACHE_TTL = 86400;
 
+       /** @var float Warn if lag estimates are made for transactions older than this many seconds */
+       const LAG_STALE_WARN_THRESHOLD = 0.100;
+
        /**
         * Additional $params include:
         *   - lagDetectionMethod : set to one of (Seconds_Behind_Master,pt-heartbeat).
@@ -763,7 +766,10 @@ abstract class DatabaseMysqlBase extends Database {
        protected function getLagFromPtHeartbeat() {
                $options = $this->lagDetectionOptions;
 
-               if ( $this->trxLevel ) {
+               $staleness = $this->trxLevel
+                       ? microtime( true ) - $this->trxTimestamp()
+                       : 0;
+               if ( $staleness > self::LAG_STALE_WARN_THRESHOLD ) {
                        // Avoid returning higher and higher lag value due to snapshot age
                        // given that the isolation level will typically be REPEATABLE-READ
                        $this->queryLogger->warning(
@@ -914,27 +920,29 @@ abstract class DatabaseMysqlBase extends Database {
                        $rpos = $this->getReplicaPos();
                        $gtidsWait = $rpos ? MySQLMasterPos::getCommonDomainGTIDs( $pos, $rpos ) : [];
                        if ( !$gtidsWait ) {
+                               $this->queryLogger->error(
+                                       "No GTIDs with the same domain between master ($pos) and replica ($rpos)",
+                                       $this->getLogContext( [
+                                               'method' => __METHOD__,
+                                       ] )
+                               );
+
                                return -1; // $pos is from the wrong cluster?
                        }
                        // Wait on the GTID set (MariaDB only)
                        $gtidArg = $this->addQuotes( implode( ',', $gtidsWait ) );
-                       if ( strpos( $gtidArg, ':' ) !== false ) {
-                               // MySQL GTIDs, e.g "source_id:transaction_id"
-                               $res = $this->doQuery( "SELECT WAIT_FOR_EXECUTED_GTID_SET($gtidArg, $timeout)" );
-                       } else {
-                               // MariaDB GTIDs, e.g."domain:server:sequence"
-                               $res = $this->doQuery( "SELECT MASTER_GTID_WAIT($gtidArg, $timeout)" );
-                       }
+                       $res = $this->doQuery( "SELECT MASTER_GTID_WAIT($gtidArg, $timeout)" );
                } else {
                        // Wait on the binlog coordinates
                        $encFile = $this->addQuotes( $pos->getLogFile() );
-                       $encPos = intval( $pos->getLogPosition()[$pos::CORD_EVENT] );
+                       $encPos = intval( $pos->pos[1] );
                        $res = $this->doQuery( "SELECT MASTER_POS_WAIT($encFile, $encPos, $timeout)" );
                }
 
                $row = $res ? $this->fetchRow( $res ) : false;
                if ( !$row ) {
-                       throw new DBExpectedError( $this, "Replication wait failed: {$this->lastError()}" );
+                       throw new DBExpectedError( $this,
+                               "MASTER_POS_WAIT() or MASTER_GTID_WAIT() failed: {$this->lastError()}" );
                }
 
                // Result can be NULL (error), -1 (timeout), or 0+ per the MySQL manual
@@ -966,23 +974,21 @@ abstract class DatabaseMysqlBase extends Database {
         * @return MySQLMasterPos|bool
         */
        public function getReplicaPos() {
-               $now = microtime( true ); // as-of-time *before* fetching GTID variables
-
-               if ( $this->useGTIDs() ) {
-                       // Try to use GTIDs, fallbacking to binlog positions if not possible
-                       $data = $this->getServerGTIDs( __METHOD__ );
-                       // Use gtid_current_pos for MariaDB and gtid_executed for MySQL
-                       foreach ( [ 'gtid_current_pos', 'gtid_executed' ] as $name ) {
-                               if ( isset( $data[$name] ) && strlen( $data[$name] ) ) {
-                                       return new MySQLMasterPos( $data[$name], $now );
-                               }
+               $now = microtime( true );
+
+               if ( $this->useGTIDs ) {
+                       $res = $this->query( "SELECT @@global.gtid_slave_pos AS Value", __METHOD__ );
+                       $gtidRow = $this->fetchObject( $res );
+                       if ( $gtidRow && strlen( $gtidRow->Value ) ) {
+                               return new MySQLMasterPos( $gtidRow->Value, $now );
                        }
                }
 
-               $data = $this->getServerRoleStatus( 'SLAVE', __METHOD__ );
-               if ( $data && strlen( $data['Relay_Master_Log_File'] ) ) {
+               $res = $this->query( 'SHOW SLAVE STATUS', __METHOD__ );
+               $row = $this->fetchObject( $res );
+               if ( $row && strlen( $row->Relay_Master_Log_File ) ) {
                        return new MySQLMasterPos(
-                               "{$data['Relay_Master_Log_File']}/{$data['Exec_Master_Log_Pos']}",
+                               "{$row->Relay_Master_Log_File}/{$row->Exec_Master_Log_Pos}",
                                $now
                        );
                }
@@ -996,97 +1002,23 @@ abstract class DatabaseMysqlBase extends Database {
         * @return MySQLMasterPos|bool
         */
        public function getMasterPos() {
-               $now = microtime( true ); // as-of-time *before* fetching GTID variables
-
-               $pos = false;
-               if ( $this->useGTIDs() ) {
-                       // Try to use GTIDs, fallbacking to binlog positions if not possible
-                       $data = $this->getServerGTIDs( __METHOD__ );
-                       // Use gtid_current_pos for MariaDB and gtid_executed for MySQL
-                       foreach ( [ 'gtid_current_pos', 'gtid_executed' ] as $name ) {
-                               if ( isset( $data[$name] ) && strlen( $data[$name] ) ) {
-                                       $pos = new MySQLMasterPos( $data[$name], $now );
-                                       break;
-                               }
-                       }
-                       // Filter domains that are inactive or not relevant to the session
-                       if ( $pos ) {
-                               $pos->setActiveOriginServerId( $this->getServerId() );
-                               $pos->setActiveOriginServerUUID( $this->getServerUUID() );
-                               if ( isset( $data['gtid_domain_id'] ) ) {
-                                       $pos->setActiveDomain( $data['gtid_domain_id'] );
-                               }
-                       }
-               }
+               $now = microtime( true );
 
-               if ( !$pos ) {
-                       $data = $this->getServerRoleStatus( 'MASTER', __METHOD__ );
-                       if ( $data && strlen( $data['File'] ) ) {
-                               $pos = new MySQLMasterPos( "{$data['File']}/{$data['Position']}", $now );
+               if ( $this->useGTIDs ) {
+                       $res = $this->query( "SELECT @@global.gtid_binlog_pos AS Value", __METHOD__ );
+                       $gtidRow = $this->fetchObject( $res );
+                       if ( $gtidRow && strlen( $gtidRow->Value ) ) {
+                               return new MySQLMasterPos( $gtidRow->Value, $now );
                        }
                }
 
-               return $pos;
-       }
-
-       /**
-        * @return int
-        * @throws DBQueryError If the variable doesn't exist for some reason
-        */
-       protected function getServerId() {
-               return $this->srvCache->getWithSetCallback(
-                       $this->srvCache->makeGlobalKey( 'mysql-server-id', $this->getServer() ),
-                       self::SERVER_ID_CACHE_TTL,
-                       function () {
-                               $res = $this->query( "SELECT @@server_id AS id", __METHOD__ );
-                               return intval( $this->fetchObject( $res )->id );
-                       }
-               );
-       }
-
-       /**
-        * @return string|null
-        */
-       protected function getServerUUID() {
-               return $this->srvCache->getWithSetCallback(
-                       $this->srvCache->makeGlobalKey( 'mysql-server-uuid', $this->getServer() ),
-                       self::SERVER_ID_CACHE_TTL,
-                       function () {
-                               $res = $this->query( "SHOW GLOBAL VARIABLES LIKE 'server_uuid'" );
-                               $row = $this->fetchObject( $res );
-
-                               return $row ? $row->Value : null;
-                       }
-               );
-       }
-
-       /**
-        * @param string $fname
-        * @return string[]
-        */
-       protected function getServerGTIDs( $fname = __METHOD__ ) {
-               $map = [];
-               // Get global-only variables like gtid_executed
-               $res = $this->query( "SHOW GLOBAL VARIABLES LIKE 'gtid_%'", $fname );
-               foreach ( $res as $row ) {
-                       $map[$row->Variable_name] = $row->Value;
-               }
-               // Get session-specific (e.g. gtid_domain_id since that is were writes will log)
-               $res = $this->query( "SHOW SESSION VARIABLES LIKE 'gtid_%'", $fname );
-               foreach ( $res as $row ) {
-                       $map[$row->Variable_name] = $row->Value;
+               $res = $this->query( 'SHOW MASTER STATUS', __METHOD__ );
+               $row = $this->fetchObject( $res );
+               if ( $row && strlen( $row->File ) ) {
+                       return new MySQLMasterPos( "{$row->File}/{$row->Position}", $now );
                }
 
-               return $map;
-       }
-
-       /**
-        * @param string $role One of "MASTER"/"SLAVE"
-        * @param string $fname
-        * @return string[] Latest available server status row
-        */
-       protected function getServerRoleStatus( $role, $fname = __METHOD__ ) {
-               return $this->query( "SHOW $role STATUS", $fname )->fetchRow() ?: [];
+               return false;
        }
 
        public function serverIsReadOnly() {
@@ -1399,6 +1331,26 @@ abstract class DatabaseMysqlBase extends Database {
                return $errno == 2013 || $errno == 2006;
        }
 
+       protected function wasKnownStatementRollbackError() {
+               $errno = $this->lastErrno();
+
+               if ( $errno === 1205 ) { // lock wait timeout
+                       // Note that this is uncached to avoid stale values of SET is used
+                       $row = $this->selectRow(
+                               false,
+                               [ 'innodb_rollback_on_timeout' => '@@innodb_rollback_on_timeout' ],
+                               [],
+                               __METHOD__
+                       );
+                       // https://dev.mysql.com/doc/refman/5.7/en/innodb-error-handling.html
+                       // https://dev.mysql.com/doc/refman/5.5/en/innodb-parameters.html
+                       return $row->innodb_rollback_on_timeout ? false : true;
+               }
+
+               // See https://dev.mysql.com/doc/refman/5.5/en/error-messages-server.html
+               return in_array( $errno, [ 1022, 1216, 1217, 1137 ], true );
+       }
+
        /**
         * @param string $oldName
         * @param string $newName
@@ -1531,12 +1483,6 @@ abstract class DatabaseMysqlBase extends Database {
                return 'CAST( ' . $field . ' AS SIGNED )';
        }
 
-       /*
-        * @return bool Whether GTID support is used (mockable for testing)
-        */
-       protected function useGTIDs() {
-               return $this->useGTIDs;
-       }
 }
 
 class_alias( DatabaseMysqlBase::class, 'DatabaseMysqlBase' );