Use real variargs for variadic methods

[lhc/web/wiklou.git] / includes / libs / StatusValue.php

diff --git a/includes/libs/StatusValue.php b/includes/libs/StatusValue.php
index 4b381f8..4fcfffd 100644 (file)
--- a/includes/libs/StatusValue.php
+++ b/includes/libs/StatusValue.php
@@ -63,12 +63,12 @@ class StatusValue {
         * Factory function for fatal errors
         *
         * @param string|MessageSpecifier $message Message key or object
+        * @param mixed ...$parameters
         * @return static
         */
-       public static function newFatal( $message /*, parameters...*/ ) {
-               $params = func_get_args();
+       public static function newFatal( $message, ...$parameters ) {
                $result = new static();
-               $result->fatal( ...$params );
+               $result->fatal( $message, ...$parameters );
                return $result;
        }
 
@@ -173,12 +173,13 @@ class StatusValue {
         * Add a new warning
         *
         * @param string|MessageSpecifier $message Message key or object
+        * @param mixed ...$parameters
         */
-       public function warning( $message /*, parameters... */ ) {
+       public function warning( $message, ...$parameters ) {
                $this->errors[] = [
                        'type' => 'warning',
                        'message' => $message,
-                       'params' => array_slice( func_get_args(), 1 )
+                       'params' => $parameters
                ];
        }
 
@@ -187,12 +188,13 @@ class StatusValue {
         * This can be used for non-fatal errors
         *
         * @param string|MessageSpecifier $message Message key or object
+        * @param mixed ...$parameters
         */
-       public function error( $message /*, parameters... */ ) {
+       public function error( $message, ...$parameters ) {
                $this->errors[] = [
                        'type' => 'error',
                        'message' => $message,
-                       'params' => array_slice( func_get_args(), 1 )
+                       'params' => $parameters
                ];
        }
 
@@ -201,12 +203,13 @@ class StatusValue {
         * as a whole was fatal
         *
         * @param string|MessageSpecifier $message Message key or object
+        * @param mixed ...$parameters
         */
-       public function fatal( $message /*, parameters... */ ) {
+       public function fatal( $message, ...$parameters ) {
                $this->errors[] = [
                        'type' => 'error',
                        'message' => $message,
-                       'params' => array_slice( func_get_args(), 1 )
+                       'params' => $parameters
                ];
                $this->ok = false;
        }