Merge "Added a separate error message for mkdir failures"

[lhc/web/wiklou.git] / includes / changetags / ChangeTagsRevisionList.php

diff --git a/includes/changetags/ChangeTagsRevisionList.php b/includes/changetags/ChangeTagsRevisionList.php
index f0dfc0f..91193b0 100644 (file)
--- a/includes/changetags/ChangeTagsRevisionList.php
+++ b/includes/changetags/ChangeTagsRevisionList.php
@@ -19,6 +19,8 @@
  * @ingroup Change tagging
  */
 
+use Wikimedia\Rdbms\IDatabase;
+
 /**
  * Stores a list of taggable revisions.
  * @since 1.25
@@ -34,19 +36,19 @@ class ChangeTagsRevisionList extends ChangeTagsList {
         */
        public function doQuery( $db ) {
                $ids = array_map( 'intval', $this->ids );
-               $queryInfo = array(
-                       'tables' => array( 'revision', 'user' ),
+               $queryInfo = [
+                       'tables' => [ 'revision', 'user' ],
                        'fields' => array_merge( Revision::selectFields(), Revision::selectUserFields() ),
-                       'conds' => array(
+                       'conds' => [
                                'rev_page' => $this->title->getArticleID(),
                                'rev_id' => $ids,
-                       ),
-                       'options' => array( 'ORDER BY' => 'rev_id DESC' ),
-                       'join_conds' => array(
+                       ],
+                       'options' => [ 'ORDER BY' => 'rev_id DESC' ],
+                       'join_conds' => [
                                'page' => Revision::pageJoinCond(),
                                'user' => Revision::userJoinCond(),
-                       ),
-               );
+                       ],
+               ];
                ChangeTags::modifyDisplayQuery(
                        $queryInfo['tables'],
                        $queryInfo['fields'],
@@ -79,9 +81,7 @@ class ChangeTagsRevisionList extends ChangeTagsList {
         * @param User $user
         * @return Status
         */
-       public function updateChangeTagsOnAll( $tagsToAdd, $tagsToRemove, $params,
-               $reason, $user ) {
-
+       public function updateChangeTagsOnAll( $tagsToAdd, $tagsToRemove, $params, $reason, $user ) {
                // @codingStandardsIgnoreStart Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed
                for ( $this->reset(); $this->current(); $this->next() ) {
                        // @codingStandardsIgnoreEnd