resources: Collapse all jQuery UI modules into one deprecated mega-module

[lhc/web/wiklou.git] / includes / XmlSelect.php

diff --git a/includes/XmlSelect.php b/includes/XmlSelect.php
index 9d37b95..45002e8 100644 (file)
--- a/includes/XmlSelect.php
+++ b/includes/XmlSelect.php
@@ -24,10 +24,10 @@
  * Class for generating HTML <select> or <datalist> elements.
  */
 class XmlSelect {
-       protected $options = array();
+       protected $options = [];
        protected $default = false;
        protected $tagName = 'select';
-       protected $attributes = array();
+       protected $attributes = [];
 
        public function __construct( $name = false, $id = false, $default = false ) {
                if ( $name ) {
@@ -70,20 +70,16 @@ class XmlSelect {
         * @return string|null
         */
        public function getAttribute( $name ) {
-               if ( isset( $this->attributes[$name] ) ) {
-                       return $this->attributes[$name];
-               } else {
-                       return null;
-               }
+               return $this->attributes[$name] ?? null;
        }
 
        /**
         * @param string $label
-        * @param string $value If not given, assumed equal to $label
+        * @param string|false $value If not given, assumed equal to $label
         */
        public function addOption( $label, $value = false ) {
                $value = $value !== false ? $value : $label;
-               $this->options[] = array( $label => $value );
+               $this->options[] = [ $label => $value ];
        }
 
        /**
@@ -103,7 +99,7 @@ class XmlSelect {
         * label => ( label => value, label => value )
         *
         * @param array $options
-        * @param string|array $default
+        * @param string|array|false $default
         * @return string
         */
        static function formatOptions( $options, $default = false ) {
@@ -112,7 +108,7 @@ class XmlSelect {
                foreach ( $options as $label => $value ) {
                        if ( is_array( $value ) ) {
                                $contents = self::formatOptions( $value, $default );
-                               $data .= Html::rawElement( 'optgroup', array( 'label' => $label ), $contents ) . "\n";
+                               $data .= Html::rawElement( 'optgroup', [ 'label' => $label ], $contents ) . "\n";
                        } else {
                                // If $default is an array, then the <select> probably has the multiple attribute,
                                // so we should check if each $value is in $default, rather than checking if