Fix warning from r72349, $script is no longer used.
[lhc/web/wiklou.git] / includes / ChangesList.php
index 9889c6f..2e603bf 100644 (file)
@@ -1,12 +1,19 @@
 <?php
+/**
+ * Classes to show various lists of changes:
+ * - what links here
+ * - related changes
+ * - recent changes
+ *
+ * @file
+ */
 
 /**
  * @todo document
  */
-class RCCacheEntry extends RecentChange
-{
+class RCCacheEntry extends RecentChange {
        var $secureName, $link;
-       var $curlink , $difflink, $lastlink , $usertalklink , $versionlink ;
+       var $curlink , $difflink, $lastlink, $usertalklink, $versionlink;
        var $userlink, $timestamp, $watched;
 
        static function newFromParent( $rc ) {
@@ -15,24 +22,21 @@ class RCCacheEntry extends RecentChange
                $rc2->mExtra = $rc->mExtra;
                return $rc2;
        }
-} ;
+}
 
 /**
- * Class to show various lists of changes:
- * - what links here
- * - related changes
- * - recent changes
+ * Base class for all changes lists
  */
 class ChangesList {
-       # Called by history lists and recent changes
-       #
+       public $skin;
+       protected $watchlist = false;
 
        /**
        * Changeslist contructor
-       * @param Skin $skin
+       * @param $skin Skin
        */
-       function __construct( &$skin ) {
-               $this->skin =& $skin;
+       public function __construct( $skin ) {
+               $this->skin = $skin;
                $this->preCacheMessages();
        }
 
@@ -44,25 +48,35 @@ class ChangesList {
         * @return ChangesList derivative
         */
        public static function newFromUser( &$user ) {
+               global $wgRequest;
+
                $sk = $user->getSkin();
-               $list = NULL;
+               $list = null;
                if( wfRunHooks( 'FetchChangesList', array( &$user, &$sk, &$list ) ) ) {
-                       return $user->getOption( 'usenewrc' ) ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
+                       $new = $wgRequest->getBool( 'enhanced', $user->getOption( 'usenewrc' ) );
+                       return $new ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
                } else {
                        return $list;
                }
        }
+       
+       /**
+        * Sets the list to use a <li class="watchlist-(namespace)-(page)"> tag
+        * @param $value Boolean
+        */
+       public function setWatchlistDivs( $value = true ) {
+               $this->watchlist = $value;
+       }
 
        /**
         * As we use the same small set of messages in various methods and that
         * they are called often, we call them once and save them in $this->message
         */
        private function preCacheMessages() {
-               // Precache various messages
                if( !isset( $this->message ) ) {
-                       foreach( explode(' ', 'cur diff hist minoreditletter newpageletter last '.
-                               'blocklink history boteditletter semicolon-separator' ) as $msg ) {
-                               $this->message[$msg] = wfMsgExt( $msg, array( 'escape') );
+                       foreach ( explode( ' ', 'cur diff hist last blocklink history ' .
+                       'semicolon-separator pipe-separator' ) as $msg ) {
+                               $this->message[$msg] = wfMsgExt( $msg, array( 'escapenoentities' ) );
                        }
                }
        }
@@ -70,26 +84,95 @@ class ChangesList {
 
        /**
         * Returns the appropriate flags for new page, minor change and patrolling
-        * @param bool $new
-        * @param bool $minor
-        * @param bool $patrolled
-        * @param string $nothing, string to use for empty space
-        * @param bool $bot
-        * @return string
+        * @param $new Boolean
+        * @param $minor Boolean
+        * @param $patrolled Boolean
+        * @param $nothing String to use for empty space
+        * @param $bot Boolean
+        * @return String
         */
-       protected function recentChangesFlags( $new, $minor, $patrolled, $nothing = '&nbsp;', $bot = false ) {
-               $f = $new ? '<span class="newpage">' . $this->message['newpageletter'] . '</span>'
-                               : $nothing;
-               $f .= $minor ? '<span class="minor">' . $this->message['minoreditletter'] . '</span>'
-                               : $nothing;
-               $f .= $bot ? '<span class="bot">' . $this->message['boteditletter'] . '</span>' : $nothing;
-               $f .= $patrolled ? '<span class="unpatrolled">!</span>' : $nothing;
+       protected function recentChangesFlags( $new, $minor, $patrolled, $nothing = '&#160;', $bot = false ) {
+               $f = $new ? self::flag( 'newpage' ) : $nothing;
+               $f .= $minor ? self::flag( 'minor' ) : $nothing;
+               $f .= $bot ? self::flag( 'bot' ) : $nothing;
+               $f .= $patrolled ? self::flag( 'unpatrolled' ) : $nothing;
                return $f;
        }
 
+       /**
+        * Provide the <abbr> element appropriate to a given abbreviated flag,
+        * namely the flag indicating a new page, a minor edit, a bot edit, or an
+        * unpatrolled edit.  By default in English it will contain "N", "m", "b",
+        * "!" respectively, plus it will have an appropriate title and class.
+        *
+        * @param $key String: 'newpage', 'unpatrolled', 'minor', or 'bot'
+        * @return String: Raw HTML
+        */
+       public static function flag( $key ) {
+               static $messages = null;
+               if ( is_null( $messages ) ) {
+                       foreach ( explode( ' ', 'minoreditletter boteditletter newpageletter ' .
+                       'unpatrolledletter recentchanges-label-minor recentchanges-label-bot ' .
+                       'recentchanges-label-newpage recentchanges-label-unpatrolled' ) as $msg ) {
+                               $messages[$msg] = wfMsgExt( $msg, 'escapenoentities' );
+                       }
+               }
+               # Inconsistent naming, bleh
+               if ( $key == 'newpage' || $key == 'unpatrolled' ) {
+                       $key2 = $key;
+               } else {
+                       $key2 = $key . 'edit';
+               }
+               return "<abbr class=\"$key\" title=\""
+                       . $messages["recentchanges-label-$key"] . "\">"
+                       . $messages["${key2}letter"]
+                       . '</abbr>';
+       }
+
+       /**
+        * Some explanatory wrapper text for the given flag, to be used in a legend
+        * explaining what the flags mean.  For instance, "N - new page".  See
+        * also flag().
+        *
+        * @param $key String: 'newpage', 'unpatrolled', 'minor', or 'bot'
+        * @return String: Raw HTML
+        */
+       private static function flagLine( $key ) {
+               return wfMsgExt( "recentchanges-legend-$key", array( 'escapenoentities',
+                       'replaceafter' ), self::flag( $key ) );
+       }
+
+       /**
+        * A handy legend to tell users what the little "m", "b", and so on mean.
+        *
+        * @return String: Raw HTML
+        */
+       public static function flagLegend() {
+               global $wgGroupPermissions, $wgLang;
+
+               $flags = array( self::flagLine( 'newpage' ),
+                       self::flagLine( 'minor' ) );
+
+               # Don't show info on bot edits unless there's a bot group of some kind
+               foreach ( $wgGroupPermissions as $rights ) {
+                       if ( isset( $rights['bot'] ) && $rights['bot'] ) {
+                               $flags[] = self::flagLine( 'bot' );
+                               break;
+                       }
+               }
+
+               if ( self::usePatrol() ) {
+                       $flags[] = self::flagLine( 'unpatrolled' );
+               }
+
+               return '<div class="mw-rc-label-legend">' .
+                       wfMsgExt( 'recentchanges-label-legend', 'parseinline',
+                       $wgLang->commaList( $flags ) ) . '</div>';
+       }
+
        /**
         * Returns text for the start of the tabular part of RC
-        * @return string
+        * @return String
         */
        public function beginRecentChangesList() {
                $this->rc_cache = array();
@@ -99,10 +182,46 @@ class ChangesList {
                $this->rclistOpen = false;
                return '';
        }
+       
+       /**
+        * Show formatted char difference
+        * @param $old Integer: bytes
+        * @param $new Integer: bytes
+        * @returns String
+        */
+       public static function showCharacterDifference( $old, $new ) {
+               global $wgRCChangedSizeThreshold, $wgLang, $wgMiserMode;
+               $szdiff = $new - $old;
+
+               $code = $wgLang->getCode();
+               static $fastCharDiff = array();
+               if ( !isset($fastCharDiff[$code]) ) {
+                       $fastCharDiff[$code] = $wgMiserMode || wfMsgNoTrans( 'rc-change-size' ) === '$1';
+               }
+                       
+               $formatedSize = $wgLang->formatNum($szdiff);
+
+               if ( !$fastCharDiff[$code] ) {
+                       $formatedSize = wfMsgExt( 'rc-change-size', array( 'parsemag', 'escape' ), $formatedSize );
+               }
+                       
+               if( abs( $szdiff ) > abs( $wgRCChangedSizeThreshold ) ) {
+                       $tag = 'strong';
+               } else {
+                   $tag = 'span';
+               }
+               if( $szdiff === 0 ) {
+                       return "<$tag class='mw-plusminus-null'>($formatedSize)</$tag>";
+               } elseif( $szdiff > 0 ) {
+                       return "<$tag class='mw-plusminus-pos'>(+$formatedSize)</$tag>";
+           } else {
+                       return "<$tag class='mw-plusminus-neg'>($formatedSize)</$tag>";
+               }
+       }
 
        /**
         * Returns text for the end of RC
-        * @return string
+        * @return String
         */
        public function endRecentChangesList() {
                if( $this->rclistOpen ) {
@@ -112,102 +231,154 @@ class ChangesList {
                }
        }
 
-       protected function insertMove( &$s, $rc ) {
+       public function insertMove( &$s, $rc ) {
                # Diff
                $s .= '(' . $this->message['diff'] . ') (';
                # Hist
-               $s .= $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), $this->message['hist'], 'action=history' ) .
-                       ') . . ';
-
+               $s .= $this->skin->link(
+                       $rc->getMovedToTitle(),
+                       $this->message['hist'],
+                       array(),
+                       array( 'action' => 'history' ),
+                       array( 'known', 'noclasses' )
+               ) . ') . . ';
                # "[[x]] moved to [[y]]"
                $msg = ( $rc->mAttribs['rc_type'] == RC_MOVE ) ? '1movedto2' : '1movedto2_redir';
-               $s .= wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),
-                       $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );
+               $s .= wfMsg(
+                       $msg,
+                       $this->skin->link(
+                               $rc->getTitle(),
+                               null,
+                               array(),
+                               array( 'redirect' => 'no' ),
+                               array( 'known', 'noclasses' )
+                       ),
+                       $this->skin->link(
+                               $rc->getMovedToTitle(),
+                               null,
+                               array(),
+                               array(),
+                               array( 'known', 'noclasses' )
+                       )
+               );
        }
 
-       protected function insertDateHeader(&$s, $rc_timestamp) {
+       public function insertDateHeader( &$s, $rc_timestamp ) {
                global $wgLang;
-
                # Make date header if necessary
                $date = $wgLang->date( $rc_timestamp, true, true );
-               $s = '';
                if( $date != $this->lastdate ) {
-                       if( '' != $this->lastdate ) {
+                       if( $this->lastdate != '' ) {
                                $s .= "</ul>\n";
                        }
-                       $s .= '<h4>'.$date."</h4>\n<ul class=\"special\">";
+                       $s .= Xml::element( 'h4', null, $date ) . "\n<ul class=\"special\">";
                        $this->lastdate = $date;
                        $this->rclistOpen = true;
                }
        }
 
-       protected function insertLog(&$s, $title, $logtype) {
+       public function insertLog( &$s, $title, $logtype ) {
                $logname = LogPage::logName( $logtype );
-               $s .= '(' . $this->skin->makeKnownLinkObj($title, $logname ) . ')';
+               $s .= '(' . $this->skin->link(
+                       $title,
+                       $logname,
+                       array(),
+                       array(),
+                       array( 'known', 'noclasses' )
+               ) . ')';
        }
 
-       protected function insertDiffHist(&$s, &$rc, $unpatrolled) {
+       public function insertDiffHist( &$s, &$rc, $unpatrolled ) {
                # Diff link
-               if( !$this->userCan($rc,Revision::DELETED_TEXT) ) {
+               if( $rc->mAttribs['rc_type'] == RC_NEW || $rc->mAttribs['rc_type'] == RC_LOG ) {
                        $diffLink = $this->message['diff'];
-               } else if( $rc->mAttribs['rc_type'] == RC_NEW || $rc->mAttribs['rc_type'] == RC_LOG ) {
+               } else if( !self::userCan($rc,Revision::DELETED_TEXT) ) {
                        $diffLink = $this->message['diff'];
                } else {
-                       $rcidparam = $unpatrolled
-                               ? array( 'rcid' => $rc->mAttribs['rc_id'] )
-                               : array();
-                       $diffLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['diff'],
-                               wfArrayToCGI( array(
-                                       'curid' => $rc->mAttribs['rc_cur_id'],
-                                       'diff'  => $rc->mAttribs['rc_this_oldid'],
-                                       'oldid' => $rc->mAttribs['rc_last_oldid'] ),
-                                       $rcidparam ),
-                               '', '', ' tabindex="'.$rc->counter.'"');
-               }
-               $s .= '('.$diffLink.') (';
-
+                       $query = array(
+                               'curid' => $rc->mAttribs['rc_cur_id'],
+                               'diff'  => $rc->mAttribs['rc_this_oldid'],
+                               'oldid' => $rc->mAttribs['rc_last_oldid']
+                       );
+
+                       if( $unpatrolled ) {
+                               $query['rcid'] = $rc->mAttribs['rc_id'];
+                       };
+
+                       $diffLink = $this->skin->link(
+                               $rc->getTitle(),
+                               $this->message['diff'],
+                               array( 'tabindex' => $rc->counter ),
+                               $query,
+                               array( 'known', 'noclasses' )
+                       );
+               }
+               $s .= '(' . $diffLink . $this->message['pipe-separator'];
                # History link
-               $s .= $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['hist'],
-                       wfArrayToCGI( array(
+               $s .= $this->skin->link(
+                       $rc->getTitle(),
+                       $this->message['hist'],
+                       array(),
+                       array(
                                'curid' => $rc->mAttribs['rc_cur_id'],
-                               'action' => 'history' ) ) );
+                               'action' => 'history'
+                       ),
+                       array( 'known', 'noclasses' )
+               );
                $s .= ') . . ';
        }
 
-       protected function insertArticleLink(&$s, &$rc, $unpatrolled, $watched) {
-               # Article link
+       public function insertArticleLink( &$s, &$rc, $unpatrolled, $watched ) {
+               global $wgContLang;
                # If it's a new article, there is no diff link, but if it hasn't been
                # patrolled yet, we need to give users a way to do so
-               $params = ( $unpatrolled && $rc->mAttribs['rc_type'] == RC_NEW )
-                       ? 'rcid='.$rc->mAttribs['rc_id']
-                       : '';
+               $params = array();
+
+               if ( $unpatrolled && $rc->mAttribs['rc_type'] == RC_NEW ) {
+                       $params['rcid'] = $rc->mAttribs['rc_id'];
+               }
+
                if( $this->isDeleted($rc,Revision::DELETED_TEXT) ) {
-                       $articlelink = $this->skin->makeKnownLinkObj( $rc->getTitle(), '', $params );
-                       $articlelink = '<span class="history-deleted">'.$articlelink.'</span>';
+                       $articlelink = $this->skin->link(
+                               $rc->getTitle(),
+                               null,
+                               array(),
+                               $params,
+                               array( 'known', 'noclasses' )
+                       );
+                       $articlelink = '<span class="history-deleted">' . $articlelink . '</span>';
                } else {
-                   $articlelink = ' '. $this->skin->makeKnownLinkObj( $rc->getTitle(), '', $params );
+                       $articlelink = ' '. $this->skin->link(
+                               $rc->getTitle(),
+                               null,
+                               array(),
+                               $params,
+                               array( 'known', 'noclasses' )
+                       );
                }
-               if( $watched )
+               # Bolden pages watched by this user
+               if( $watched ) {
                        $articlelink = "<strong class=\"mw-watched\">{$articlelink}</strong>";
-               global $wgContLang;
+               }
+               # RTL/LTR marker
                $articlelink .= $wgContLang->getDirMark();
 
-               wfRunHooks('ChangesListInsertArticleLink',
-                       array(&$this, &$articlelink, &$s, &$rc, $unpatrolled, $watched));
+               wfRunHooks( 'ChangesListInsertArticleLink',
+                       array(&$this, &$articlelink, &$s, &$rc, $unpatrolled, $watched) );
 
-               $s .= ' '.$articlelink;
+               $s .= " $articlelink";
        }
 
-       protected function insertTimestamp(&$s, $rc) {
+       public function insertTimestamp( &$s, $rc ) {
                global $wgLang;
-               # Timestamp
-               $s .= $this->message['semicolon-separator'] . ' ' . $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
+               $s .= $this->message['semicolon-separator'] . 
+                       $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
        }
 
        /** Insert links to user page, user talk page and eventually a blocking link */
-       protected function insertUserRelatedLinks(&$s, &$rc) {
-               if ( $this->isDeleted($rc,Revision::DELETED_USER) ) {
-                  $s .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-user') . '</span>';
+       public function insertUserRelatedLinks( &$s, &$rc ) {
+               if( $this->isDeleted( $rc, Revision::DELETED_USER ) ) {
+                  $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
                } else {
                  $s .= $this->skin->userLink( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
                  $s .= $this->skin->userToolLinks( $rc->mAttribs['rc_user'], $rc->mAttribs['rc_user_text'] );
@@ -215,26 +386,22 @@ class ChangesList {
        }
 
        /** insert a formatted action */
-       protected function insertAction(&$s, &$rc) {
-               # Add action
+       public function insertAction( &$s, &$rc ) {
                if( $rc->mAttribs['rc_type'] == RC_LOG ) {
-                       // log action
-                       if ( $this->isDeleted($rc,LogPage::DELETED_ACTION) ) {
-                               $s .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-event') . '</span>';
+                       if( $this->isDeleted( $rc, LogPage::DELETED_ACTION ) ) {
+                               $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-event' ) . '</span>';
                        } else {
-                               $s .= ' ' . LogPage::actionText( $rc->mAttribs['rc_log_type'], $rc->mAttribs['rc_log_action'],
-                                       $rc->getTitle(), $this->skin, LogPage::extractParams($rc->mAttribs['rc_params']), true, true );
+                               $s .= ' '.LogPage::actionText( $rc->mAttribs['rc_log_type'], $rc->mAttribs['rc_log_action'],
+                                       $rc->getTitle(), $this->skin, LogPage::extractParams( $rc->mAttribs['rc_params'] ), true, true );
                        }
                }
        }
 
        /** insert a formatted comment */
-       protected function insertComment(&$s, &$rc) {
-               # Add comment
+       public function insertComment( &$s, &$rc ) {
                if( $rc->mAttribs['rc_type'] != RC_MOVE && $rc->mAttribs['rc_type'] != RC_MOVE_OVER_REDIRECT ) {
-                       // log comment
-                       if ( $this->isDeleted($rc,Revision::DELETED_COMMENT) ) {
-                               $s .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-comment') . '</span>';
+                       if( $this->isDeleted( $rc, Revision::DELETED_COMMENT ) ) {
+                               $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span>';
                        } else {
                                $s .= $this->skin->commentBlock( $rc->mAttribs['rc_comment'], $rc->getTitle() );
                        }
@@ -243,7 +410,7 @@ class ChangesList {
 
        /**
         * Check whether to enable recent changes patrol features
-        * @return bool
+        * @return Boolean
         */
        public static function usePatrol() {
                global $wgUser;
@@ -256,10 +423,10 @@ class ChangesList {
        protected function numberofWatchingusers( $count ) {
                global $wgLang;
                static $cache = array();
-               if ( $count > 0 ) {
-                       if ( !isset( $cache[$count] ) ) {
-                               $cache[$count] = wfMsgExt('number_of_watching_users_RCview',
-                                       array('parsemag', 'escape'), $wgLang->formatNum($count));
+               if( $count > 0 ) {
+                       if( !isset( $cache[$count] ) ) {
+                               $cache[$count] = wfMsgExt( 'number_of_watching_users_RCview',
+                                       array('parsemag', 'escape' ), $wgLang->formatNum( $count ) );
                        }
                        return $cache[$count];
                } else {
@@ -269,33 +436,70 @@ class ChangesList {
 
        /**
         * Determine if said field of a revision is hidden
-        * @param RCCacheEntry $rc
-        * @param int $field one of DELETED_* bitfield constants
-        * @return bool
+        * @param $rc RCCacheEntry
+        * @param $field Integer: one of DELETED_* bitfield constants
+        * @return Boolean
         */
        public static function isDeleted( $rc, $field ) {
-               return ($rc->mAttribs['rc_deleted'] & $field) == $field;
+               return ( $rc->mAttribs['rc_deleted'] & $field ) == $field;
        }
 
        /**
         * Determine if the current user is allowed to view a particular
         * field of this revision, if it's marked as deleted.
-        * @param RCCacheEntry $rc
-        * @param int $field
-        * @return bool
+        * @param $rc RCCacheEntry
+        * @param $field Integer
+        * @return Boolean
         */
        public static function userCan( $rc, $field ) {
-               if( ( $rc->mAttribs['rc_deleted'] & $field ) == $field ) {
-                       global $wgUser;
-                       $permission = ( $rc->mAttribs['rc_deleted'] & Revision::DELETED_RESTRICTED ) == Revision::DELETED_RESTRICTED
-                               ? 'hiderevision'
-                               : 'deleterevision';
-                       wfDebug( "Checking for $permission due to $field match on $rc->mAttribs['rc_deleted']\n" );
-                       return $wgUser->isAllowed( $permission );
+               if( $rc->mAttribs['rc_type'] == RC_LOG ) {
+                       return LogEventsList::userCanBitfield( $rc->mAttribs['rc_deleted'], $field );
+               } else {
+                       return Revision::userCanBitfield( $rc->mAttribs['rc_deleted'], $field );
+               }
+       }
+
+       protected function maybeWatchedLink( $link, $watched = false ) {
+               if( $watched ) {
+                       return '<strong class="mw-watched">' . $link . '</strong>';
                } else {
-                       return true;
+                       return '<span class="mw-rc-unwatched">' . $link . '</span>';
                }
        }
+       
+       /** Inserts a rollback link */
+       public function insertRollback( &$s, &$rc ) {
+               global $wgUser;
+               if( !$rc->mAttribs['rc_new'] && $rc->mAttribs['rc_this_oldid'] && $rc->mAttribs['rc_cur_id'] ) {
+                       $page = $rc->getTitle();
+                       /** Check for rollback and edit permissions, disallow special pages, and only
+                         * show a link on the top-most revision */
+                       if ($wgUser->isAllowed('rollback') && $rc->mAttribs['page_latest'] == $rc->mAttribs['rc_this_oldid'] )
+                       {
+                               $rev = new Revision( array(
+                                       'id'        => $rc->mAttribs['rc_this_oldid'],
+                                       'user'      => $rc->mAttribs['rc_user'],
+                                       'user_text' => $rc->mAttribs['rc_user_text'],
+                                       'deleted'   => $rc->mAttribs['rc_deleted']
+                               ) );
+                               $rev->setTitle( $page );
+                               $s .= ' '.$this->skin->generateRollback( $rev );
+                       }
+               }
+       }
+
+       public function insertTags( &$s, &$rc, &$classes ) {
+               if ( empty($rc->mAttribs['ts_tags']) )
+                       return;
+                       
+               list($tagSummary, $newClasses) = ChangeTags::formatSummaryRow( $rc->mAttribs['ts_tags'], 'changeslist' );
+               $classes = array_merge( $classes, $newClasses );
+               $s .= ' ' . $tagSummary;
+       }
+
+       public function insertExtra( &$s, &$rc, &$classes ) {
+               ## Empty, used for subclassers to add anything special.
+       }
 }
 
 
@@ -306,108 +510,131 @@ class OldChangesList extends ChangesList {
        /**
         * Format a line using the old system (aka without any javascript).
         */
-       public function recentChangesLine( &$rc, $watched = false ) {
-               global $wgContLang, $wgRCShowChangedSize, $wgUser;
-
-               $fname = 'ChangesList::recentChangesLineOld';
-               wfProfileIn( $fname );
-
-               # Extract DB fields into local scope
-               // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
-               extract( $rc->mAttribs );
-
+       public function recentChangesLine( &$rc, $watched = false, $linenumber = null ) {
+               global $wgLang, $wgRCShowChangedSize, $wgUser;
+               wfProfileIn( __METHOD__ );
                # Should patrol-related stuff be shown?
-               $unpatrolled = $wgUser->useRCPatrol() && $rc_patrolled == 0;
+               $unpatrolled = $wgUser->useRCPatrol() && !$rc->mAttribs['rc_patrolled'];
 
-               $this->insertDateHeader($s,$rc_timestamp);
+               $dateheader = ''; // $s now contains only <li>...</li>, for hooks' convenience.
+               $this->insertDateHeader( $dateheader, $rc->mAttribs['rc_timestamp'] );
 
-               $s .= '<li>';
+               $s = '';
+               $classes = array();
+               // use mw-line-even/mw-line-odd class only if linenumber is given (feature from bug 14468)
+               if( $linenumber ) {
+                       if( $linenumber & 1 ) {
+                               $classes[] = 'mw-line-odd';
+                       }
+                       else {
+                               $classes[] = 'mw-line-even';
+                       }
+               }
 
                // Moved pages
-               if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
+               if( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
                        $this->insertMove( $s, $rc );
                // Log entries
-               } elseif( $rc_log_type ) {
-                       $logtitle = Title::newFromText( "Log/$rc_log_type", NS_SPECIAL );
-                       $this->insertLog( $s, $logtitle, $rc_log_type );
+               } elseif( $rc->mAttribs['rc_log_type'] ) {
+                       $logtitle = Title::newFromText( 'Log/'.$rc->mAttribs['rc_log_type'], NS_SPECIAL );
+                       $this->insertLog( $s, $logtitle, $rc->mAttribs['rc_log_type'] );
                // Log entries (old format) or log targets, and special pages
-               } elseif( $rc_namespace == NS_SPECIAL ) {
-                       list( $specialName, $specialSubpage ) = SpecialPage::resolveAliasWithSubpage( $rc_title );
-                       if ( $specialName == 'Log' ) {
-                               $this->insertLog( $s, $rc->getTitle(), $specialSubpage );
-                       } else {
-                               wfDebug( "Unexpected special page in recentchanges\n" );
+               } elseif( $rc->mAttribs['rc_namespace'] == NS_SPECIAL ) {
+                       list( $name, $subpage ) = SpecialPage::resolveAliasWithSubpage( $rc->mAttribs['rc_title'] );
+                       if( $name == 'Log' ) {
+                               $this->insertLog( $s, $rc->getTitle(), $subpage );
                        }
                // Regular entries
                } else {
-                       wfProfileIn($fname.'-page');
-
-                       $this->insertDiffHist($s, $rc, $unpatrolled);
-
+                       $this->insertDiffHist( $s, $rc, $unpatrolled );
                        # M, N, b and ! (minor, new, bot and unpatrolled)
-                       $s .= $this->recentChangesFlags( $rc_type == RC_NEW, $rc_minor, $unpatrolled, '', $rc_bot );
-                       $this->insertArticleLink($s, $rc, $unpatrolled, $watched);
-
-                       wfProfileOut($fname.'-page');
+                       $s .= $this->recentChangesFlags( $rc->mAttribs['rc_new'], $rc->mAttribs['rc_minor'],
+                               $unpatrolled, '', $rc->mAttribs['rc_bot'] );
+                       $this->insertArticleLink( $s, $rc, $unpatrolled, $watched );
                }
-
-               wfProfileIn( $fname.'-rest' );
-
-               $this->insertTimestamp($s,$rc);
-
+               # Edit/log timestamp
+               $this->insertTimestamp( $s, $rc );
+               # Bytes added or removed
                if( $wgRCShowChangedSize ) {
-                       $s .= ( $rc->getCharacterDifference() == '' ? '' : $rc->getCharacterDifference() . ' . . ' );
+                       $cd = $rc->getCharacterDifference();
+                       if( $cd != '' ) {
+                               $s .= "$cd  . . ";
+                       }
                }
                # User tool links
-               $this->insertUserRelatedLinks($s,$rc);
+               $this->insertUserRelatedLinks( $s, $rc );
                # Log action text (if any)
-               $this->insertAction($s, $rc);
+               $this->insertAction( $s, $rc );
                # Edit or log comment
-               $this->insertComment($s, $rc);
-
-               # Mark revision as deleted if so
-               if ( !$rc_log_type && $this->isDeleted($rc,Revision::DELETED_TEXT) )
-                  $s .= ' <tt>' . wfMsgHtml( 'deletedrev' ) . '</tt>';
-               if($rc->numberofWatchingusers > 0) {
-                       $s .= ' ' . wfMsg('number_of_watching_users_RCview',  $wgContLang->formatNum($rc->numberofWatchingusers));
+               $this->insertComment( $s, $rc );
+               # Tags
+               $this->insertTags( $s, $rc, $classes );
+               # Rollback
+               $this->insertRollback( $s, $rc );
+               # For subclasses
+               $this->insertExtra( $s, $rc, $classes );
+               
+               # How many users watch this page
+               if( $rc->numberofWatchingusers > 0 ) {
+                       $s .= ' ' . wfMsgExt( 'number_of_watching_users_RCview', 
+                               array( 'parsemag', 'escape' ), $wgLang->formatNum( $rc->numberofWatchingusers ) );
                }
+               
+               if( $this->watchlist ) {
+                       $classes[] = Sanitizer::escapeClass( 'watchlist-'.$rc->mAttribs['rc_namespace'].'-'.$rc->mAttribs['rc_title'] );
+               }
+               
+               wfRunHooks( 'OldChangesListRecentChangesLine', array(&$this, &$s, $rc) );
 
-               $s .= "</li>\n";
-
-               wfProfileOut( $fname.'-rest' );
-
-               wfProfileOut( $fname );
-               return $s;
+               wfProfileOut( __METHOD__ );
+               return "$dateheader<li class=\"".implode( ' ', $classes )."\">".$s."</li>\n";
        }
 }
 
 
 /**
- * Generate a list of changes using an Enhanced system (use javascript).
+ * Generate a list of changes using an Enhanced system (uses javascript).
  */
 class EnhancedChangesList extends ChangesList {
+       /**
+        * Add the JavaScript file for enhanced changeslist
+        * @return String
+        */
+       public function beginRecentChangesList() {
+               global $wgOut;
+               $this->rc_cache = array();
+               $this->rcMoveIndex = 0;
+               $this->rcCacheIndex = 0;
+               $this->lastdate = '';
+               $this->rclistOpen = false;
+               $wgOut->addModules( 'mediawiki.legacy.enhancedchanges' );
+               return '';
+       }
        /**
         * Format a line for enhanced recentchange (aka with javascript and block of lines).
         */
        public function recentChangesLine( &$baseRC, $watched = false ) {
-               global $wgLang, $wgContLang, $wgUser;
+               global $wgLang, $wgUser;
+               
+               wfProfileIn( __METHOD__ );
 
                # Create a specialised object
                $rc = RCCacheEntry::newFromParent( $baseRC );
 
                # Extract fields from DB into the function scope (rc_xxxx variables)
-               // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
+               // FIXME: Would be good to replace this extract() call with something
+               // that explicitly initializes variables.
                extract( $rc->mAttribs );
-               $curIdEq = 'curid=' . $rc_cur_id;
+               $curIdEq = array( 'curid' => $rc_cur_id );
 
                # If it's a new day, add the headline and flush the cache
-               $date = $wgLang->date( $rc_timestamp, true);
+               $date = $wgLang->date( $rc_timestamp, true );
                $ret = '';
                if( $date != $this->lastdate ) {
                        # Process current cache
                        $ret = $this->recentChangesBlock();
                        $this->rc_cache = array();
-                       $ret .= "<h4>{$date}</h4>\n";
+                       $ret .= Xml::element( 'h4', null, $date );
                        $this->lastdate = $date;
                }
 
@@ -423,34 +650,37 @@ class EnhancedChangesList extends ChangesList {
                // Page moves
                if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
                        $msg = ( $rc_type == RC_MOVE ) ? "1movedto2" : "1movedto2_redir";
-                       $clink = wfMsg( $msg, $this->skin->makeKnownLinkObj( $rc->getTitle(), '', 'redirect=no' ),
-                         $this->skin->makeKnownLinkObj( $rc->getMovedToTitle(), '' ) );
+                       $clink = wfMsg( $msg, $this->skin->linkKnown( $rc->getTitle(), null,
+                               array(), array( 'redirect' => 'no' ) ),
+                               $this->skin->linkKnown( $rc->getMovedToTitle() ) );
+               // New unpatrolled pages
+               } else if( $rc->unpatrolled && $rc_type == RC_NEW ) {
+                       $clink = $this->skin->linkKnown( $rc->getTitle(), null, array(),
+                               array( 'rcid' => $rc_id ) );
+               // Log entries
+               } else if( $rc_type == RC_LOG ) {
+                       if( $rc_log_type ) {
+                               $logtitle = SpecialPage::getTitleFor( 'Log', $rc_log_type );
+                               $clink = '(' . $this->skin->linkKnown( $logtitle, 
+                                       LogPage::logName($rc_log_type) ) . ')';
+                       } else {
+                               $clink = $this->skin->link( $rc->getTitle() );
+                       }
+                       $watched = false;
                // Log entries (old format) and special pages
                } elseif( $rc_namespace == NS_SPECIAL ) {
                        list( $specialName, $logtype ) = SpecialPage::resolveAliasWithSubpage( $rc_title );
                        if ( $specialName == 'Log' ) {
                                # Log updates, etc
                                $logname = LogPage::logName( $logtype );
-                               $clink = '(' . $this->skin->makeKnownLinkObj( $rc->getTitle(), $logname ) . ')';
+                               $clink = '(' . $this->skin->linkKnown( $rc->getTitle(), $logname ) . ')';
                        } else {
                                wfDebug( "Unexpected special page in recentchanges\n" );
                                $clink = '';
                        }
-               // New unpatrolled pages
-               } else if( $rc->unpatrolled && $rc_type == RC_NEW ) {
-                       $clink = $this->skin->makeKnownLinkObj( $rc->getTitle(), '', "rcid={$rc_id}" );
-               // Log entries
-               } else if( $rc_type == RC_LOG ) {
-                       if( $rc_log_type ) {
-                               $logtitle = SpecialPage::getTitleFor( 'Log', $rc_log_type );
-                               $clink = '(' . $this->skin->makeKnownLinkObj( $logtitle, LogPage::logName($rc_log_type) ) . ')';
-                       } else {
-                               $clink = $this->skin->makeLinkObj( $rc->getTitle(), '' );
-                       }
-                       $watched = false;
                // Edits
                } else {
-                       $clink = $this->skin->makeKnownLinkObj( $rc->getTitle(), '' );
+                       $clink = $this->skin->linkKnown( $rc->getTitle() );
                }
 
                # Don't show unusable diff links
@@ -458,49 +688,54 @@ class EnhancedChangesList extends ChangesList {
                        $showdifflinks = false;
                }
 
-               $time = $wgContLang->time( $rc_timestamp, true, true );
+               $time = $wgLang->time( $rc_timestamp, true, true );
                $rc->watched = $watched;
                $rc->link = $clink;
                $rc->timestamp = $time;
                $rc->numberofWatchingusers = $baseRC->numberofWatchingusers;
 
-               # Make "cur" and "diff" links
+               # Make "cur" and "diff" links.  Do not use link(), it is too slow if
+               # called too many times (50% of CPU time on RecentChanges!).
                if( $rc->unpatrolled ) {
-                       $rcIdQuery = "&rcid={$rc_id}";
+                       $rcIdQuery = array( 'rcid' => $rc_id );
                } else {
-                       $rcIdQuery = '';
+                       $rcIdQuery = array();
                }
-               $querycur = $curIdEq."&diff=0&oldid=$rc_this_oldid";
-               $querydiff = $curIdEq."&diff=$rc_this_oldid&oldid=$rc_last_oldid$rcIdQuery";
-               $aprops = ' tabindex="'.$baseRC->counter.'"';
-               $curLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['cur'], $querycur, '' ,'', $aprops );
+               $querycur = $curIdEq + array( 'diff' => '0', 'oldid' => $rc_this_oldid );
+               $querydiff = $curIdEq + array( 'diff' => $rc_this_oldid, 'oldid' =>
+                       $rc_last_oldid ) + $rcIdQuery;
 
-               # Make "diff" an "cur" links
                if( !$showdifflinks ) {
-                  $curLink = $this->message['cur'];
-                  $diffLink = $this->message['diff'];
-               } else if( $rc_type == RC_NEW || $rc_type == RC_LOG || $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
-                       if( $rc_type != RC_NEW ) {
+                       $curLink = $this->message['cur'];
+                       $diffLink = $this->message['diff'];
+               } else if( in_array( $rc_type, array(RC_NEW,RC_LOG,RC_MOVE,RC_MOVE_OVER_REDIRECT) ) ) {
+                       if ( $rc_type != RC_NEW ) {
                                $curLink = $this->message['cur'];
+                       } else {
+                               $curUrl = htmlspecialchars( $rc->getTitle()->getLinkUrl( $querycur ) );
+                               $curLink = "<a href=\"$curUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['cur']}</a>";
                        }
                        $diffLink = $this->message['diff'];
                } else {
-                       $diffLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['diff'], $querydiff, '' ,'', $aprops );
+                       $diffUrl = htmlspecialchars( $rc->getTitle()->getLinkUrl( $querydiff ) );
+                       $curUrl = htmlspecialchars( $rc->getTitle()->getLinkUrl( $querycur ) );
+                       $diffLink = "<a href=\"$diffUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['diff']}</a>";
+                       $curLink = "<a href=\"$curUrl\" tabindex=\"{$baseRC->counter}\">{$this->message['cur']}</a>";
                }
 
                # Make "last" link
-               if( !$showdifflinks ) {
-                   $lastLink = $this->message['last'];
-               } else if( $rc_last_oldid == 0 || $rc_type == RC_LOG || $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
+               if( !$showdifflinks || !$rc_last_oldid ) {
+                       $lastLink = $this->message['last'];
+               } else if( $rc_type == RC_LOG || $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
                        $lastLink = $this->message['last'];
                } else {
-                       $lastLink = $this->skin->makeKnownLinkObj( $rc->getTitle(), $this->message['last'],
-                       $curIdEq.'&diff='.$rc_this_oldid.'&oldid='.$rc_last_oldid . $rcIdQuery );
+                       $lastLink = $this->skin->linkKnown( $rc->getTitle(), $this->message['last'],
+                               array(), $curIdEq + array('diff' => $rc_this_oldid, 'oldid' => $rc_last_oldid) + $rcIdQuery );
                }
 
                # Make user links
                if( $this->isDeleted($rc,Revision::DELETED_USER) ) {
-                       $rc->userlink = ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-user') . '</span>';
+                       $rc->userlink = ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
                } else {
                        $rc->userlink = $this->skin->userLink( $rc_user, $rc_user_text );
                        $rc->usertalklink = $this->skin->userToolLinks( $rc_user, $rc_user_text );
@@ -525,8 +760,12 @@ class EnhancedChangesList extends ChangesList {
                        if( !isset( $this->rc_cache[$secureName] ) ) {
                                $this->rc_cache[$secureName] = array();
                        }
+
                        array_push( $this->rc_cache[$secureName], $rc );
                }
+
+               wfProfileOut( __METHOD__ );
+
                return $ret;
        }
 
@@ -535,7 +774,10 @@ class EnhancedChangesList extends ChangesList {
         */
        protected function recentChangesBlockGroup( $block ) {
                global $wgLang, $wgContLang, $wgRCShowChangedSize;
-               $r = '<table cellpadding="0" cellspacing="0" border="0" style="background: none"><tr>';
+
+               wfProfileIn( __METHOD__ );
+
+               $r = '<table class="mw-enhanced-rc"><tr>';
 
                # Collate list of users
                $userlinks = array();
@@ -545,7 +787,7 @@ class EnhancedChangesList extends ChangesList {
                $curId = $currentRevision = 0;
                # Some catalyst variables...
                $namehidden = true;
-               $alllogs = true;
+               $allLogs = true;
                foreach( $block as $rcObj ) {
                        $oldid = $rcObj->mAttribs['rc_last_oldid'];
                        if( $rcObj->mAttribs['rc_new'] ) {
@@ -564,7 +806,7 @@ class EnhancedChangesList extends ChangesList {
                                $unpatrolled = true;
                        }
                        if( $rcObj->mAttribs['rc_type'] != RC_LOG ) {
-                               $alllogs = false;
+                               $allLogs = false;
                        }
                        # Get the latest entry with a page_id and oldid
                        # since logs may not have these.
@@ -587,38 +829,44 @@ class EnhancedChangesList extends ChangesList {
                        $text = $userlink;
                        $text .= $wgContLang->getDirMark();
                        if( $count > 1 ) {
-                               $text .= ' ('.$count.'&times;)';
+                               $text .= ' (' . $wgLang->formatNum( $count ) . '×)';
                        }
                        array_push( $users, $text );
                }
 
-               $users = ' <span class="changedby">[' . implode( $this->message['semicolon-separator'] . ' ', $users ) . ']</span>';
+               $users = ' <span class="changedby">[' . 
+                       implode( $this->message['semicolon-separator'], $users ) . ']</span>';
 
-               # Arrow
-               $rci = 'RCI'.$this->rcCacheIndex;
-               $rcl = 'RCL'.$this->rcCacheIndex;
-               $rcm = 'RCM'.$this->rcCacheIndex;
-               $toggleLink = "javascript:toggleVisibility('$rci','$rcm','$rcl')";
-               $tl  = '<span id="'.$rcm.'"><a href="'.$toggleLink.'">' . $this->sideArrow() . '</a></span>';
-               $tl .= '<span id="'.$rcl.'" style="display:none"><a href="'.$toggleLink.'">' . $this->downArrow() . '</a></span>';
-               $r .= '<td valign="top" style="white-space: nowrap"><tt>'.$tl.'&nbsp;';
+               # ID for JS visibility toggle
+               $jsid = $this->rcCacheIndex;
+               # onclick handler to toggle hidden/expanded
+               $toggleLink = "onclick='toggleVisibility($jsid); return false'";
+               # Title for <a> tags
+               $expandTitle = htmlspecialchars( wfMsg( 'rc-enhanced-expand' ) );
+               $closeTitle = htmlspecialchars( wfMsg( 'rc-enhanced-hide' ) );
+
+               $tl = "<span id='mw-rc-openarrow-$jsid' class='mw-changeslist-expanded' style='visibility:hidden'><a href='#' $toggleLink title='$expandTitle'>" . $this->sideArrow() . "</a></span>";
+               $tl .= "<span id='mw-rc-closearrow-$jsid' class='mw-changeslist-hidden' style='display:none'><a href='#' $toggleLink title='$closeTitle'>" . $this->downArrow() . "</a></span>";
+               $r .= '<td class="mw-enhanced-rc">'.$tl.'&#160;';
 
                # Main line
-               $r .= $this->recentChangesFlags( $isnew, false, $unpatrolled, '&nbsp;', $bot );
+               $r .= $this->recentChangesFlags( $isnew, false, $unpatrolled, '&#160;', $bot );
 
                # Timestamp
-               $r .= '&nbsp;'.$block[0]->timestamp.'&nbsp;</tt></td><td>';
+               $r .= '&#160;'.$block[0]->timestamp.'&#160;</td><td style="padding:0px;">';
 
                # Article link
                if( $namehidden ) {
-                       $r .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-event') . '</span>';
-               } else {
+                       $r .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-event' ) . '</span>';
+               } else if( $allLogs ) {
                        $r .= $this->maybeWatchedLink( $block[0]->link, $block[0]->watched );
+               } else {
+                       $this->insertArticleLink( $r, $block[0], $block[0]->unpatrolled, $block[0]->watched );
                }
 
                $r .= $wgContLang->getDirMark();
 
-               $curIdEq = 'curid=' . $curId;
+               $queryParams['curid'] = $curId;
                # Changes message
                $n = count($block);
                static $nchanges = array();
@@ -627,28 +875,56 @@ class EnhancedChangesList extends ChangesList {
                }
                # Total change link
                $r .= ' ';
-               if( !$alllogs ) {
+               if( !$allLogs ) {
                        $r .= '(';
-                       if( !ChangesList::userCan($rcObj,Revision::DELETED_TEXT) ) {
+                       if( !ChangesList::userCan( $rcObj, Revision::DELETED_TEXT ) ) {
                                $r .= $nchanges[$n];
                        } else if( $isnew ) {
                                $r .= $nchanges[$n];
                        } else {
-                               $r .= $this->skin->makeKnownLinkObj( $block[0]->getTitle(),
-                                       $nchanges[$n], $curIdEq."&diff=$currentRevision&oldid=$oldid" );
+                               $params = $queryParams;
+                               $params['diff'] = $currentRevision;
+                               $params['oldid'] = $oldid;
+                               
+                               $r .= $this->skin->link(
+                                       $block[0]->getTitle(),
+                                       $nchanges[$n],
+                                       array(),
+                                       $params,
+                                       array( 'known', 'noclasses' )
+                               );
                        }
-                       $r .= ') . . ';
                }
 
+               # History
+               if( $allLogs ) {
+                       // don't show history link for logs
+               } else if( $namehidden || !$block[0]->getTitle()->exists() ) {
+                       $r .= $this->message['pipe-separator'] . $this->message['hist'] . ')';
+               } else {
+                       $params = $queryParams;
+                       $params['action'] = 'history';
+
+                       $r .= $this->message['pipe-separator'] .
+                               $this->skin->link(
+                                       $block[0]->getTitle(),
+                                       $this->message['hist'],
+                                       array(),
+                                       $params,
+                                       array( 'known', 'noclasses' )
+                               ) . ')';
+               }
+               $r .= ' . . ';
+
                # Character difference (does not apply if only log items)
-               if( $wgRCShowChangedSize && !$alllogs ) {
+               if( $wgRCShowChangedSize && !$allLogs ) {
                        $last = 0;
                        $first = count($block) - 1;
                        # Some events (like logs) have an "empty" size, so we need to skip those...
-                       while( $last < $first && $block[$last]->mAttribs['rc_new_len'] === NULL ) {
+                       while( $last < $first && $block[$last]->mAttribs['rc_new_len'] === null ) {
                                $last++;
                        }
-                       while( $first > $last && $block[$first]->mAttribs['rc_old_len'] === NULL ) {
+                       while( $first > $last && $block[$first]->mAttribs['rc_old_len'] === null ) {
                                $first--;
                        }
                        # Get net change
@@ -662,52 +938,61 @@ class EnhancedChangesList extends ChangesList {
                        }
                }
 
-               # History
-               if( $namehidden || !$block[0]->getTitle()->exists() ) {
-                       $r .= '(' . $this->message['history'] . ')';
-               } else {
-                       $r .= '(' . $this->skin->makeKnownLinkObj( $block[0]->getTitle(),
-                               $this->message['history'], $curIdEq.'&action=history' ) . ')';
-               }
-
                $r .= $users;
                $r .= $this->numberofWatchingusers($block[0]->numberofWatchingusers);
 
                $r .= "</td></tr></table>\n";
 
                # Sub-entries
-               $r .= '<div id="'.$rci.'" style="display:none;"><table cellpadding="0" cellspacing="0"  border="0" style="background: none">';
+               $r .= '<div id="mw-rc-subentries-'.$jsid.'" class="mw-changeslist-hidden">';
+               $r .= '<table class="mw-enhanced-rc">';
                foreach( $block as $rcObj ) {
-                       # Get rc_xxxx variables
-                       // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
+                       # Extract fields from DB into the function scope (rc_xxxx variables)
+                       // FIXME: Would be good to replace this extract() call with something
+                       // that explicitly initializes variables.
+                       # Classes to apply -- TODO implement
+                       $classes = array();
                        extract( $rcObj->mAttribs );
 
                        #$r .= '<tr><td valign="top">'.$this->spacerArrow();
-                       $r .= '<tr><td valign="top">';
-                       $r .= '<tt>'.$this->spacerIndent() . $this->spacerIndent();
-                       $r .= $this->recentChangesFlags( $rc_new, $rc_minor, $rcObj->unpatrolled, '&nbsp;', $rc_bot );
-                       $r .= '&nbsp;</tt></td><td valign="top">';
+                       $r .= '<tr><td style="vertical-align:top;font-family:monospace; padding:0px;">';
+                       $r .= $this->spacerIndent() . $this->spacerIndent();
+                       $r .= $this->recentChangesFlags( $rc_new, $rc_minor, $rcObj->unpatrolled, '&#160;', $rc_bot );
+                       $r .= '&#160;</td><td style="vertical-align:top; padding:0px;"><span style="font-family:monospace">';
+
+                       $params = $queryParams;
 
-                       $o = '';
                        if( $rc_this_oldid != 0 ) {
-                               $o = 'oldid='.$rc_this_oldid;
+                               $params['oldid'] = $rc_this_oldid;
                        }
-                       # Revision link
+
+                       # Log timestamp
                        if( $rc_type == RC_LOG ) {
-                               $link = '<tt>'.$rcObj->timestamp.'</tt> ';
+                               $link = $rcObj->timestamp;
+                       # Revision link
                        } else if( !ChangesList::userCan($rcObj,Revision::DELETED_TEXT) ) {
-                               $link = '<span class="history-deleted"><tt>'.$rcObj->timestamp.'</tt></span> ';
+                               $link = '<span class="history-deleted">'.$rcObj->timestamp.'</span> ';
                        } else {
-                               $link = '<tt>'.$this->skin->makeKnownLinkObj( $rcObj->getTitle(), $rcObj->timestamp, $curIdEq.'&'.$o ).'</tt>';
+                               if ( $rcObj->unpatrolled && $rc_type == RC_NEW) {
+                                       $params['rcid'] = $rcObj->mAttribs['rc_id'];
+                               }
+
+                               $link = $this->skin->link(
+                                               $rcObj->getTitle(),
+                                               $rcObj->timestamp,
+                                               array(),
+                                               $params,
+                                               array( 'known', 'noclasses' )
+                                       );
                                if( $this->isDeleted($rcObj,Revision::DELETED_TEXT) )
                                        $link = '<span class="history-deleted">'.$link.'</span> ';
                        }
-                       $r .= $link;
+                       $r .= $link . '</span>';
 
                        if ( !$rc_type == RC_LOG || $rc_type == RC_NEW ) {
                                $r .= ' (';
                                $r .= $rcObj->curlink;
-                               $r .= $this->message['semicolon-separator'] . ' ';
+                               $r .= $this->message['pipe-separator'];
                                $r .= $rcObj->lastlink;
                                $r .= ')';
                        }
@@ -721,153 +1006,154 @@ class EnhancedChangesList extends ChangesList {
                        $r .= $rcObj->userlink;
                        $r .= $rcObj->usertalklink;
                        // log action
-                       parent::insertAction( $r, $rcObj );
+                       $this->insertAction( $r, $rcObj );
                        // log comment
-                       parent::insertComment( $r, $rcObj );
-                       # Mark revision as deleted
-                       if( !$rc_log_type && $this->isDeleted($rcObj,Revision::DELETED_TEXT) ) {
-                               $r .= ' <tt>' . wfMsgHtml( 'deletedrev' ) . '</tt>';
-                       }
+                       $this->insertComment( $r, $rcObj );
+                       # Rollback
+                       $this->insertRollback( $r, $rcObj );
+                       # Tags
+                       $this->insertTags( $r, $rcObj, $classes );
 
                        $r .= "</td></tr>\n";
                }
                $r .= "</table></div>\n";
 
                $this->rcCacheIndex++;
-               return $r;
-       }
 
-       protected function maybeWatchedLink( $link, $watched=false ) {
-               if( $watched ) {
-                       // FIXME: css style might be more appropriate
-                       return '<strong class="mw-watched">' . $link . '</strong>';
-               } else {
-                       return $link;
-               }
+               wfProfileOut( __METHOD__ );
+
+               return $r;
        }
 
        /**
         * Generate HTML for an arrow or placeholder graphic
-        * @param string $dir one of '', 'd', 'l', 'r'
-        * @param string $alt text
-        * @return string HTML <img> tag
+        * @param $dir String: one of '', 'd', 'l', 'r'
+        * @param $alt String: text
+        * @param $title String: text
+        * @return String: HTML <img> tag
         */
-       protected function arrow( $dir, $alt='' ) {
+       protected function arrow( $dir, $alt='', $title='' ) {
                global $wgStylePath;
                $encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
                $encAlt = htmlspecialchars( $alt );
-               return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" />";
+               $encTitle = htmlspecialchars( $title );
+               return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" title=\"$encTitle\" />";
        }
 
        /**
         * Generate HTML for a right- or left-facing arrow,
         * depending on language direction.
-        * @return string HTML <img> tag
+        * @return String: HTML <img> tag
         */
        protected function sideArrow() {
                global $wgContLang;
                $dir = $wgContLang->isRTL() ? 'l' : 'r';
-               return $this->arrow( $dir, '+' );
+               return $this->arrow( $dir, '+', wfMsg( 'rc-enhanced-expand' ) );
        }
 
        /**
         * Generate HTML for a down-facing arrow
         * depending on language direction.
-        * @return string HTML <img> tag
+        * @return String: HTML <img> tag
         */
        protected function downArrow() {
-               return $this->arrow( 'd', '-' );
+               return $this->arrow( 'd', '-', wfMsg( 'rc-enhanced-hide' ) );
        }
 
        /**
         * Generate HTML for a spacer image
-        * @return string HTML <img> tag
+        * @return String: HTML <img> tag
         */
        protected function spacerArrow() {
-               return $this->arrow( '', ' ' );
+               return $this->arrow( '', codepointToUtf8( 0xa0 ) ); // non-breaking space
        }
 
        /**
         * Add a set of spaces
-        * @return string HTML <td> tag
+        * @return String: HTML <td> tag
         */
        protected function spacerIndent() {
-               return '&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
+               return '&#160;&#160;&#160;&#160;&#160;';
        }
 
        /**
         * Enhanced RC ungrouped line.
-        * @return string a HTML formated line (generated using $r)
+        * @return String: a HTML formated line (generated using $r)
         */
        protected function recentChangesBlockLine( $rcObj ) {
-               global $wgContLang, $wgRCShowChangedSize;
-
-               # Get rc_xxxx variables
-               // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables.
-               extract( $rcObj->mAttribs );
-               $curIdEq = 'curid='.$rc_cur_id;
+               global $wgRCShowChangedSize;
 
-               $r = '<table cellspacing="0" cellpadding="0" border="0" style="background: none"><tr>';
+               wfProfileIn( __METHOD__ );
 
-               $r .= '<td valign="top" style="white-space: nowrap"><tt>' . $this->spacerArrow() . '&nbsp;';
+               # Extract fields from DB into the function scope (rc_xxxx variables)
+               // FIXME: Would be good to replace this extract() call with something
+               // that explicitly initializes variables.
+               $classes = array(); // TODO implement
+               extract( $rcObj->mAttribs );
+               $query['curid'] = $rc_cur_id;
 
+               $r = '<table class="mw-enhanced-rc"><tr>';
+               $r .= '<td class="mw-enhanced-rc">' . $this->spacerArrow() . '&#160;';
                # Flag and Timestamp
                if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
-                       $r .= '&nbsp;&nbsp;&nbsp;&nbsp;'; // 4 flags -> 4 spaces
+                       $r .= '&#160;&#160;&#160;&#160;'; // 4 flags -> 4 spaces
                } else {
-                       $r .= $this->recentChangesFlags( $rc_type == RC_NEW, $rc_minor, $rcObj->unpatrolled, '&nbsp;', $rc_bot );
+                       $r .= $this->recentChangesFlags( $rc_type == RC_NEW, $rc_minor, $rcObj->unpatrolled, '&#160;', $rc_bot );
                }
-               $r .= '&nbsp;'.$rcObj->timestamp.'&nbsp;</tt></td><td>';
-
+               $r .= '&#160;'.$rcObj->timestamp.'&#160;</td><td style="padding:0px;">';
                # Article or log link
                if( $rc_log_type ) {
                        $logtitle = Title::newFromText( "Log/$rc_log_type", NS_SPECIAL );
                        $logname = LogPage::logName( $rc_log_type );
-                       $r .= '(' . $this->skin->makeKnownLinkObj($logtitle, $logname ) . ')';
-               } else if( !$this->userCan($rcObj,Revision::DELETED_TEXT) ) {
-                       $r .= '<span class="history-deleted">' . $rcObj->link . '</span>';
+                       $r .= '(' . $this->skin->link(
+                               $logtitle,
+                               $logname,
+                               array(),
+                               array(),
+                               array( 'known', 'noclasses' )
+                       ) . ')';
                } else {
-                       $r .= $this->maybeWatchedLink( $rcObj->link, $rcObj->watched );
+                       $this->insertArticleLink( $r, $rcObj, $rcObj->unpatrolled, $rcObj->watched );
                }
-
                # Diff and hist links
                if ( $rc_type != RC_LOG ) {
-                  $r .= ' ('. $rcObj->difflink . $this->message['semicolon-separator'] . ' ';
-                  $r .= $this->skin->makeKnownLinkObj( $rcObj->getTitle(), wfMsg( 'hist' ), $curIdEq.'&action=history' ) . ')';
+                       $r .= ' ('. $rcObj->difflink . $this->message['pipe-separator'];
+                       $query['action'] = 'history';
+                       $r .= $this->skin->link(
+                               $rcObj->getTitle(),
+                               $this->message['hist'],
+                               array(),
+                               $query,
+                               array( 'known', 'noclasses' )
+                       ) . ')';
                }
                $r .= ' . . ';
-
                # Character diff
-               if( $wgRCShowChangedSize ) {
-                       $r .= ( $rcObj->getCharacterDifference() == '' ? '' : '&nbsp;' . $rcObj->getCharacterDifference() . ' . . ' ) ;
+               if( $wgRCShowChangedSize && ($cd = $rcObj->getCharacterDifference()) ) {
+                       $r .= "$cd . . ";
                }
-
                # User/talk
                $r .= ' '.$rcObj->userlink . $rcObj->usertalklink;
-
                # Log action (if any)
                if( $rc_log_type ) {
                        if( $this->isDeleted($rcObj,LogPage::DELETED_ACTION) ) {
                                $r .= ' <span class="history-deleted">' . wfMsgHtml('rev-deleted-event') . '</span>';
                        } else {
-                               $r .= ' ' . LogPage::actionText( $rc_log_type, $rc_log_action, $rcObj->getTitle(), $this->skin, LogPage::extractParams($rc_params), true, true );
+                               $r .= ' ' . LogPage::actionText( $rc_log_type, $rc_log_action, $rcObj->getTitle(), 
+                                       $this->skin, LogPage::extractParams($rc_params), true, true );
                        }
                }
-
-               # Edit or log comment
-               if( $rc_type != RC_MOVE && $rc_type != RC_MOVE_OVER_REDIRECT ) {
-                       // log comment
-                       if ( $this->isDeleted($rcObj,LogPage::DELETED_COMMENT) ) {
-                          $r .= ' <span class="history-deleted">' . wfMsg('rev-deleted-comment') . '</span>';
-                       } else {
-                         $r .= $this->skin->commentBlock( $rc_comment, $rcObj->getTitle() );
-                       }
-               }
-
+               $this->insertComment( $r, $rcObj );
+               $this->insertRollback( $r, $rcObj );
+               # Tags
+               $this->insertTags( $r, $rcObj, $classes );
                # Show how many people are watching this if enabled
                $r .= $this->numberofWatchingusers($rcObj->numberofWatchingusers);
 
                $r .= "</td></tr></table>\n";
+
+               wfProfileOut( __METHOD__ );
+
                return $r;
        }
 
@@ -879,6 +1165,9 @@ class EnhancedChangesList extends ChangesList {
                if( count ( $this->rc_cache ) == 0 ) {
                        return '';
                }
+
+               wfProfileIn( __METHOD__ );
+
                $blockOut = '';
                foreach( $this->rc_cache as $block ) {
                        if( count( $block ) < 2 ) {
@@ -888,6 +1177,8 @@ class EnhancedChangesList extends ChangesList {
                        }
                }
 
+               wfProfileOut( __METHOD__ );
+
                return '<div>'.$blockOut.'</div>';
        }