Don't look for pipes in the root node.
[lhc/web/wiklou.git] / includes / CategoryPage.php
index f7af3d6..bbd3c43 100644 (file)
@@ -1,50 +1,66 @@
 <?php
 /**
- * Special handling for category description pages
- * Modelled after ImagePage.php
+ * Special handling for category description pages.
+ * Modelled after ImagePage.php.
  *
+ * @file
  */
 
-if( !defined( 'MEDIAWIKI' ) )
+if ( !defined( 'MEDIAWIKI' ) )
        die( 1 );
 
 /**
+ * Special handling for category description pages, showing pages,
+ * subcategories and file that belong to the category
  */
 class CategoryPage extends Article {
+       # Subclasses can change this to override the viewer class.
+       protected $mCategoryViewerClass = 'CategoryViewer';
+
        function view() {
                global $wgRequest, $wgUser;
 
                $diff = $wgRequest->getVal( 'diff' );
                $diffOnly = $wgRequest->getBool( 'diffonly', $wgUser->getOption( 'diffonly' ) );
 
-               if ( isset( $diff ) && $diffOnly )
-                       return Article::view();
+               if ( isset( $diff ) && $diffOnly ) {
+                       return parent::view();
+               }
 
-               if( !wfRunHooks( 'CategoryPageView', array( &$this ) ) )
+               if ( !wfRunHooks( 'CategoryPageView', array( &$this ) ) ) {
                        return;
+               }
 
                if ( NS_CATEGORY == $this->mTitle->getNamespace() ) {
                        $this->openShowCategory();
                }
 
-               Article::view();
+               parent::view();
 
                if ( NS_CATEGORY == $this->mTitle->getNamespace() ) {
                        $this->closeShowCategory();
                }
        }
-       
+
        /**
         * Don't return a 404 for categories in use.
+        * In use defined as: either the actual page exists
+        * or the category currently has members.
         */
        function hasViewableContent() {
-               if( parent::hasViewableContent() ) {
+               if ( parent::hasViewableContent() ) {
                        return true;
                } else {
                        $cat = Category::newFromTitle( $this->mTitle );
-                       return $cat->getId() != 0;
+                       // If any of these are not 0, then has members
+                       if ( $cat->getPageCount()
+                               || $cat->getSubcatCount()
+                               || $cat->getFileCount()
+                       ) {
+                               return true;
+                       }
                }
-                       
+               return false;
        }
 
        function openShowCategory() {
@@ -53,10 +69,14 @@ class CategoryPage extends Article {
 
        function closeShowCategory() {
                global $wgOut, $wgRequest;
-               $from = $wgRequest->getVal( 'from' );
-               $until = $wgRequest->getVal( 'until' );
 
-               $viewer = new CategoryViewer( $this->mTitle, $from, $until );
+               $from = $until = array();
+               foreach ( array( 'page', 'subcat', 'file' ) as $type ) {
+                       $from[$type] = $wgRequest->getVal( "{$type}from" );
+                       $until[$type] = $wgRequest->getVal( "{$type}until" );
+               }
+
+               $viewer = new $this->mCategoryViewerClass( $this->mTitle, $from, $until, $wgRequest->getValues() );
                $wgOut->addHTML( $viewer->getHTML() );
        }
 }
@@ -66,27 +86,32 @@ class CategoryViewer {
                $articles, $articles_start_char,
                $children, $children_start_char,
                $showGallery, $gallery,
-               $skin;
-       /** Category object for this page */
+               $imgsNoGalley, $imgsNoGallery_start_char,
+               $skin, $collation;
+       # Category object for this page
        private $cat;
+       # The original query array, to be used in generating paging links.
+       private $query;
 
-       function __construct( $title, $from = '', $until = '' ) {
+       function __construct( $title, $from = '', $until = '', $query = array() ) {
                global $wgCategoryPagingLimit;
                $this->title = $title;
                $this->from = $from;
                $this->until = $until;
                $this->limit = $wgCategoryPagingLimit;
                $this->cat = Category::newFromTitle( $title );
+               $this->query = $query;
+               $this->collation = Collation::singleton();
+               unset( $this->query['title'] );
        }
 
        /**
         * Format the category data list.
         *
         * @return string HTML output
-        * @private
         */
-       function getHTML() {
-               global $wgOut, $wgCategoryMagicGallery, $wgCategoryPagingLimit;
+       public function getHTML() {
+               global $wgOut, $wgCategoryMagicGallery, $wgContLang;
                wfProfileIn( __METHOD__ );
 
                $this->showGallery = $wgCategoryMagicGallery && !$wgOut->mNoGallery;
@@ -95,11 +120,22 @@ class CategoryViewer {
                $this->doCategoryQuery();
                $this->finaliseCategoryState();
 
-               $r = $this->getCategoryTop() .
-                       $this->getSubcategorySection() .
+               $r = $this->getSubcategorySection() .
                        $this->getPagesSection() .
-                       $this->getImageSection() .
-                       $this->getCategoryBottom();
+                       $this->getImageSection();
+
+               if ( $r == '' ) {
+                       // If there is no category content to display, only
+                       // show the top part of the navigation links.
+                       // FIXME: cannot be completely suppressed because it
+                       //        is unknown if 'until' or 'from' makes this
+                       //        give 0 results.
+                       $r = $r . $this->getCategoryTop();
+               } else {
+                       $r = $this->getCategoryTop() .
+                               $r .
+                               $this->getCategoryBottom();
+               }
 
                // Give a proper message if category is empty
                if ( $r == '' ) {
@@ -107,7 +143,7 @@ class CategoryViewer {
                }
 
                wfProfileOut( __METHOD__ );
-               return $r;
+               return $wgContLang->convert( $r );
        }
 
        function clearCategoryState() {
@@ -115,9 +151,12 @@ class CategoryViewer {
                $this->articles_start_char = array();
                $this->children = array();
                $this->children_start_char = array();
-               if( $this->showGallery ) {
+               if ( $this->showGallery ) {
                        $this->gallery = new ImageGallery();
                        $this->gallery->setHideBadImages();
+               } else {
+                       $this->imgsNoGallery = array();
+                       $this->imgsNoGallery_start_char = array();
                }
        }
 
@@ -132,27 +171,29 @@ class CategoryViewer {
        /**
         * Add a subcategory to the internal lists, using a Category object
         */
-       function addSubcategoryObject( $cat, $sortkey, $pageLength ) {
+       function addSubcategoryObject( Category $cat, $sortkey, $pageLength ) {
+               // Subcategory; strip the 'Category' namespace from the link text.
                $title = $cat->getTitle();
-               $this->addSubcategory( $title, $sortkey, $pageLength );
+
+               $link = $this->getSkin()->link( $title, $title->getText() );
+               if ( $title->isRedirect() ) {
+                       // This didn't used to add redirect-in-category, but might
+                       // as well be consistent with the rest of the sections
+                       // on a category page.
+                       $link = '<span class="redirect-in-category">' . $link . '</span>';
+               }
+               $this->children[] = $link;
+
+               $this->children_start_char[] = 
+                       $this->getSubcategorySortChar( $cat->getTitle(), $sortkey );
        }
 
        /**
-        * Add a subcategory to the internal lists, using a title object 
+        * Add a subcategory to the internal lists, using a title object
         * @deprecated kept for compatibility, please use addSubcategoryObject instead
         */
-       function addSubcategory( $title, $sortkey, $pageLength ) {
-               global $wgContLang;
-               // Subcategory; strip the 'Category' namespace from the link text.
-               $this->children[] = $this->getSkin()->link(
-                       $title,
-                       $wgContLang->convertHtml( $title->getText() ).
-                       array(),
-                       array(),
-                       array( 'known', 'noclasses' )
-               );
-
-               $this->children_start_char[] = $this->getSubcategorySortChar( $title, $sortkey );
+       function addSubcategory( Title $title, $sortkey, $pageLength ) {
+               $this->addSubcategoryObject( Category::newFromTitle( $title ), $sortkey, $pageLength );
        }
 
        /**
@@ -165,12 +206,14 @@ class CategoryViewer {
        function getSubcategorySortChar( $title, $sortkey ) {
                global $wgContLang;
 
-               if( $title->getPrefixedText() == $sortkey ) {
-                       $firstChar = $wgContLang->firstChar( $title->getDBkey() );
+               if ( $title->getPrefixedText() == $sortkey ) {
+                       $word = $title->getDBkey();
                } else {
-                       $firstChar = $wgContLang->firstChar( $sortkey );
+                       $word = $sortkey;
                }
 
+               $firstChar = $this->collation->getFirstLetter( $word );
+
                return $wgContLang->convert( $firstChar );
        }
 
@@ -178,14 +221,25 @@ class CategoryViewer {
         * Add a page in the image namespace
         */
        function addImage( Title $title, $sortkey, $pageLength, $isRedirect = false ) {
+               global $wgContLang;
                if ( $this->showGallery ) {
-                       if( $this->flip ) {
+                       $flip = $this->flip['file'];
+                       if ( $flip ) {
                                $this->gallery->insert( $title );
                        } else {
                                $this->gallery->add( $title );
                        }
                } else {
-                       $this->addPage( $title, $sortkey, $pageLength, $isRedirect );
+                       $link = $this->getSkin()->link( $title );
+                       if ( $isRedirect ) {
+                               // This seems kind of pointless given 'mw-redirect' class,
+                               // but keeping for back-compatibility with user css.
+                               $link = '<span class="redirect-in-category">' . $link . '</span>';
+                       }
+                       $this->imgsNoGallery[] = $link;
+
+                       $this->imgsNoGallery_start_char[] = $wgContLang->convert( 
+                               $this->collation->getFirstLetter( $sortkey ) );
                }
        }
 
@@ -194,86 +248,103 @@ class CategoryViewer {
         */
        function addPage( $title, $sortkey, $pageLength, $isRedirect = false ) {
                global $wgContLang;
-               $titletext = $wgContLang->convertHtml( $title->getPrefixedText() );
-               $this->articles[] = $isRedirect
-                       ? '<span class="redirect-in-category">' .
-                               $this->getSkin()->link(
-                                       $title,
-                                       $titletext,
-                                       array(),
-                                       array(),
-                                       array( 'known', 'noclasses' )
-                               ) . '</span>'
-                       : $this->getSkin()->makeSizeLinkObj( $pageLength, $title, $titletext );
-               $this->articles_start_char[] = $wgContLang->convert( $wgContLang->firstChar( $sortkey ) );
+
+               $link = $this->getSkin()->link( $title );
+               if ( $isRedirect ) {
+                       // This seems kind of pointless given 'mw-redirect' class,
+                       // but keeping for back-compatiability with user css.
+                       $link = '<span class="redirect-in-category">' . $link . '</span>';
+               }
+               $this->articles[] = $link;
+
+               $this->articles_start_char[] = $wgContLang->convert( 
+                       $this->collation->getFirstLetter( $sortkey ) );
        }
 
        function finaliseCategoryState() {
-               if( $this->flip ) {
+               if ( $this->flip['subcat'] ) {
                        $this->children            = array_reverse( $this->children );
                        $this->children_start_char = array_reverse( $this->children_start_char );
+               }
+               if ( $this->flip['page'] ) {
                        $this->articles            = array_reverse( $this->articles );
                        $this->articles_start_char = array_reverse( $this->articles_start_char );
                }
+               if ( !$this->showGallery && $this->flip['file'] ) {
+                       $this->imgsNoGallery            = array_reverse( $this->imgsNoGallery );
+                       $this->imgsNoGallery_start_char = array_reverse( $this->imgsNoGallery_start_char );
+               }
        }
 
        function doCategoryQuery() {
                $dbr = wfGetDB( DB_SLAVE, 'category' );
-               if( $this->from != '' ) {
-                       $pageCondition = 'cl_sortkey >= ' . $dbr->addQuotes( $this->from );
-                       $this->flip = false;
-               } elseif( $this->until != '' ) {
-                       $pageCondition = 'cl_sortkey < ' . $dbr->addQuotes( $this->until );
-                       $this->flip = true;
-               } else {
-                       $pageCondition = '1 = 1';
-                       $this->flip = false;
-               }
-               $res = $dbr->select(
-                       array( 'page', 'categorylinks', 'category' ),
-                       array( 'page_title', 'page_namespace', 'page_len', 'page_is_redirect', 'cl_sortkey',
-                               'cat_id', 'cat_title', 'cat_subcats', 'cat_pages', 'cat_files' ),
-                       array( $pageCondition, 'cl_to' => $this->title->getDBkey() ),
-                       __METHOD__,
-                       array( 'ORDER BY' => $this->flip ? 'cl_sortkey DESC' : 'cl_sortkey',
-                               'USE INDEX' => array( 'categorylinks' => 'cl_sortkey' ),
-                               'LIMIT'    => $this->limit + 1 ),
-                       array( 'categorylinks'  => array( 'INNER JOIN', 'cl_from = page_id' ),
-                               'category' => array( 'LEFT JOIN', 'cat_title = page_title AND page_namespace = ' . NS_CATEGORY ) )
-               );
 
-               $count = 0;
-               $this->nextPage = null;
-               while( $x = $dbr->fetchObject ( $res ) ) {
-                       if( ++$count > $this->limit ) {
-                               // We've reached the one extra which shows that there are
-                               // additional pages to be had. Stop here...
-                               $this->nextPage = $x->cl_sortkey;
-                               break;
+               $this->nextPage = array(
+                       'page' => null,
+                       'subcat' => null,
+                       'file' => null,
+               );
+               $this->flip = array( 'page' => false, 'subcat' => false, 'file' => false );
+
+               foreach ( array( 'page', 'subcat', 'file' ) as $type ) {
+                       # Get the sortkeys for start/end, if applicable.  Note that if
+                       # the collation in the database differs from the one
+                       # set in $wgCategoryCollation, pagination might go totally haywire.
+                       $extraConds = array( 'cl_type' => $type );
+                       if ( $this->from[$type] !== null ) {
+                               $extraConds[] = 'cl_sortkey >= '
+                                       . $dbr->addQuotes( $this->collation->getSortKey( $this->from[$type] ) );
+                       } elseif ( $this->until[$type] !== null ) {
+                               $extraConds[] = 'cl_sortkey < '
+                                       . $dbr->addQuotes( $this->collation->getSortKey( $this->until[$type] ) );
+                               $this->flip[$type] = true;
                        }
 
-                       $title = Title::makeTitle( $x->page_namespace, $x->page_title );
+                       $res = $dbr->select(
+                               array( 'page', 'categorylinks', 'category' ),
+                               array( 'page_id', 'page_title', 'page_namespace', 'page_len',
+                                       'page_is_redirect', 'cl_sortkey', 'cat_id', 'cat_title',
+                                       'cat_subcats', 'cat_pages', 'cat_files', 'cl_sortkey_prefix' ),
+                               array( 'cl_to' => $this->title->getDBkey() ) + $extraConds,
+                               __METHOD__,
+                               array(
+                                       'USE INDEX' => array( 'categorylinks' => 'cl_sortkey' ),
+                                       'LIMIT' => $this->limit + 1,
+                                       'ORDER BY' => $this->flip[$type] ? 'cl_sortkey DESC' : 'cl_sortkey',
+                               ),
+                               array(
+                                       'categorylinks'  => array( 'INNER JOIN', 'cl_from = page_id' ),
+                                       'category' => array( 'LEFT JOIN', 'cat_title = page_title AND page_namespace = ' . NS_CATEGORY )
+                               )
+                       );
+
+                       $count = 0;
+                       foreach ( $res as $row ) {
+                               $title = Title::newFromRow( $row );
+                               $rawSortkey = $title->getCategorySortkey( $row->cl_sortkey_prefix );
 
-                       if( $title->getNamespace() == NS_CATEGORY ) {
-                               $cat = Category::newFromRow( $x, $title );
-                               $this->addSubcategoryObject( $cat, $x->cl_sortkey, $x->page_len );
-                       } elseif( $this->showGallery && $title->getNamespace() == NS_FILE ) {
-                               $this->addImage( $title, $x->cl_sortkey, $x->page_len, $x->page_is_redirect );
-                       } else {
-                               $this->addPage( $title, $x->cl_sortkey, $x->page_len, $x->page_is_redirect );
+                               if ( ++$count > $this->limit ) {
+                                       # We've reached the one extra which shows that there
+                                       # are additional pages to be had. Stop here...
+                                       $this->nextPage[$type] = $rawSortkey;
+                                       break;
+                               }
+
+                               if ( $title->getNamespace() == NS_CATEGORY ) {
+                                       $cat = Category::newFromRow( $row, $title );
+                                       $this->addSubcategoryObject( $cat, $rawSortkey, $row->page_len );
+                               } elseif ( $title->getNamespace() == NS_FILE ) {
+                                       $this->addImage( $title, $rawSortkey, $row->page_len, $row->page_is_redirect );
+                               } else {
+                                       $this->addPage( $title, $rawSortkey, $row->page_len, $row->page_is_redirect );
+                               }
                        }
                }
-               $dbr->freeResult( $res );
        }
 
        function getCategoryTop() {
-               $r = '';
-               if( $this->until != '' ) {
-                       $r .= $this->pagingLinks( $this->title, $this->nextPage, $this->until, $this->limit );
-               } elseif( $this->nextPage != '' || $this->from != '' ) {
-                       $r .= $this->pagingLinks( $this->title, $this->from, $this->nextPage, $this->limit );
-               }
-               return $r == ''
+               $r = $this->getCategoryBottom();
+               return $r === ''
                        ? $r
                        : "<br style=\"clear:both;\"/>\n" . $r;
        }
@@ -284,12 +355,15 @@ class CategoryViewer {
                $rescnt = count( $this->children );
                $dbcnt = $this->cat->getSubcatCount();
                $countmsg = $this->getCountMessage( $rescnt, $dbcnt, 'subcat' );
-               if( $rescnt > 0 ) {
+
+               if ( $rescnt > 0 ) {
                        # Showing subcategories
                        $r .= "<div id=\"mw-subcategories\">\n";
                        $r .= '<h2>' . wfMsg( 'subcategories' ) . "</h2>\n";
                        $r .= $countmsg;
+                       $r .= $this->getSectionPagingLinks( 'subcat' );
                        $r .= $this->formatList( $this->children, $this->children_start_char );
+                       $r .= $this->getSectionPagingLinks( 'subcat' );
                        $r .= "\n</div>";
                }
                return $r;
@@ -309,40 +383,61 @@ class CategoryViewer {
                $rescnt = count( $this->articles );
                $countmsg = $this->getCountMessage( $rescnt, $dbcnt, 'article' );
 
-               if( $rescnt > 0 ) {
+               if ( $rescnt > 0 ) {
                        $r = "<div id=\"mw-pages\">\n";
                        $r .= '<h2>' . wfMsg( 'category_header', $ti ) . "</h2>\n";
                        $r .= $countmsg;
+                       $r .= $this->getSectionPagingLinks( 'page' );
                        $r .= $this->formatList( $this->articles, $this->articles_start_char );
+                       $r .= $this->getSectionPagingLinks( 'page' );
                        $r .= "\n</div>";
                }
                return $r;
        }
 
        function getImageSection() {
-               if( $this->showGallery && ! $this->gallery->isEmpty() ) {
+               $r = '';
+               $rescnt = $this->showGallery ? $this->gallery->count() : count( $this->imgsNoGallery );
+               if ( $rescnt > 0 ) {
                        $dbcnt = $this->cat->getFileCount();
-                       $rescnt = $this->gallery->count();
                        $countmsg = $this->getCountMessage( $rescnt, $dbcnt, 'file' );
 
-                       return "<div id=\"mw-category-media\">\n" .
-                       '<h2>' . wfMsg( 'category-media-header', htmlspecialchars( $this->title->getText() ) ) . "</h2>\n" .
-                       $countmsg . $this->gallery->toHTML() . "\n</div>";
-               } else {
-                       return '';
+                       $r .= "<div id=\"mw-category-media\">\n";
+                       $r .= '<h2>' . wfMsg( 'category-media-header', htmlspecialchars( $this->title->getText() ) ) . "</h2>\n";
+                       $r .= $countmsg;
+                       $r .= $this->getSectionPagingLinks( 'file' );
+                       if ( $this->showGallery ) {
+                               $r .= $this->gallery->toHTML();
+                       } else {
+                               $r .= $this->formatList( $this->imgsNoGallery, $this->imgsNoGallery_start_char );
+                       }
+                       $r .= $this->getSectionPagingLinks( 'file' );
+                       $r .= "\n</div>";
                }
+               return $r;
        }
 
-       function getCategoryBottom() {
-               if( $this->until != '' ) {
-                       return $this->pagingLinks( $this->title, $this->nextPage, $this->until, $this->limit );
-               } elseif( $this->nextPage != '' || $this->from != '' ) {
-                       return $this->pagingLinks( $this->title, $this->from, $this->nextPage, $this->limit );
+       /**
+        * Get the paging links for a section (subcats/pages/files), to go at the top and bottom
+        * of the output.
+        *
+        * @param $type String: 'page', 'subcat', or 'file'
+        * @return String: HTML output, possibly empty if there are no other pages
+        */
+       private function getSectionPagingLinks( $type ) {
+               if ( $this->until[$type] !== null ) {
+                       return $this->pagingLinks( $this->nextPage[$type], $this->until[$type], $type );
+               } elseif ( $this->nextPage[$type] !== null || $this->from[$type] !== null ) {
+                       return $this->pagingLinks( $this->from[$type], $this->nextPage[$type], $type );
                } else {
                        return '';
                }
        }
 
+       function getCategoryBottom() {
+               return '';
+       }
+
        /**
         * Format a list of articles chunked by letter, either as a
         * bullet list or a columnar format, depending on the length.
@@ -355,10 +450,10 @@ class CategoryViewer {
         */
        function formatList( $articles, $articles_start_char, $cutoff = 6 ) {
                if ( count ( $articles ) > $cutoff ) {
-                       return $this->columnList( $articles, $articles_start_char );
-               } elseif ( count($articles) > 0) {
+                       return self::columnList( $articles, $articles_start_char );
+               } elseif ( count( $articles ) > 0 ) {
                        // for short lists of articles in categories.
-                       return $this->shortList( $articles, $articles_start_char );
+                       return self::shortList( $articles, $articles_start_char );
                }
                return '';
        }
@@ -367,62 +462,60 @@ class CategoryViewer {
         * Format a list of articles chunked by letter in a three-column
         * list, ordered vertically.
         *
+        * TODO: Take the headers into account when creating columns, so they're
+        * more visually equal.
+        *
+        * More distant TODO: Scrap this and use CSS columns, whenever IE finally
+        * supports those.
+        *
         * @param $articles Array
         * @param $articles_start_char Array
         * @return String
         * @private
         */
-       function columnList( $articles, $articles_start_char ) {
-               // divide list into three equal chunks
-               $chunk = (int) ( count( $articles ) / 3 );
-               $remaining = count( $articles ) % 3;
-
-               // get and display header
-               $r = '<table width="100%"><tr valign="top">';
-
-               $prev_start_char = 'none';
-
-               // loop through the chunks
-               for( $startChunk = 0, $endChunk = $chunk, $chunkIndex = 0;
-                       $chunkIndex < 3;
-                       $chunkIndex++, $startChunk = $endChunk, $endChunk += $remaining == 0 ? $chunk : $chunk + 1 )
-               {
-                       $r .= "<td>\n";
-                       $atColumnTop = true;
+       static function columnList( $articles, $articles_start_char ) {
+               $columns = array_combine( $articles, $articles_start_char );
+               # Split into three columns
+               $columns = array_chunk( $columns, ceil( count( $columns ) / 3 ), true /* preserve keys */ );
+
+               $ret = '<table width="100%"><tr valign="top"><td>';
+               $prevchar = null;
+
+               foreach ( $columns as $column ) {
+                       $colContents = array();
+
+                       # Kind of like array_flip() here, but we keep duplicates in an
+                       # array instead of dropping them.
+                       foreach ( $column as $article => $char ) {
+                               if ( !isset( $colContents[$char] ) ) {
+                                       $colContents[$char] = array();
+                               }
+                               $colContents[$char][] = $article;
+                       }
 
-                       // output all articles in category
-                       for ($index = $startChunk ;
-                               $index < $endChunk && $index < count($articles);
-                               $index++ )
-                       {
-                               // check for change of starting letter or begining of chunk
-                               if ( ($index == $startChunk) ||
-                                        ($articles_start_char[$index] != $articles_start_char[$index - 1]) )
-
-                               {
-                                       if( $atColumnTop ) {
-                                               $atColumnTop = false;
-                                       } else {
-                                               $r .= "</ul>\n";
-                                       }
-                                       $cont_msg = "";
-                                       if ( $articles_start_char[$index] == $prev_start_char )
-                                               $cont_msg = ' ' . wfMsgHtml( 'listingcontinuesabbrev' );
-                                       $r .= "<h3>" . htmlspecialchars( $articles_start_char[$index] ) . "$cont_msg</h3>\n<ul>";
-                                       $prev_start_char = $articles_start_char[$index];
+                       $first = true;
+                       foreach ( $colContents as $char => $articles ) {
+                               $ret .= '<h3>' . htmlspecialchars( $char );
+                               if ( $first && $char === $prevchar ) {
+                                       # We're continuing a previous chunk at the top of a new
+                                       # column, so add " cont." after the letter.
+                                       $ret .= ' ' . wfMsgHtml( 'listingcontinuesabbrev' );
                                }
+                               $ret .= "</h3>\n";
 
-                               $r .= "<li>{$articles[$index]}</li>";
-                       }
-                       if( !$atColumnTop ) {
-                               $r .= "</ul>\n";
-                       }
-                       $r .= "</td>\n";
+                               $ret .= '<ul><li>';
+                               $ret .= implode( "</li>\n<li>", $articles );
+                               $ret .= '</li></ul>';
 
+                               $first = false;
+                               $prevchar = $char;
+                       }
 
+                       $ret .= "</td>\n<td>";
                }
-               $r .= '</tr></table>';
-               return $r;
+
+               $ret .= '</td></tr></table>';
+               return $ret;
        }
 
        /**
@@ -432,12 +525,12 @@ class CategoryViewer {
         * @return String
         * @private
         */
-       function shortList( $articles, $articles_start_char ) {
+       static function shortList( $articles, $articles_start_char ) {
                $r = '<h3>' . htmlspecialchars( $articles_start_char[0] ) . "</h3>\n";
-               $r .= '<ul><li>'.$articles[0].'</li>';
-               for ($index = 1; $index < count($articles); $index++ )
+               $r .= '<ul><li>' . $articles[0] . '</li>';
+               for ( $index = 1; $index < count( $articles ); $index++ )
                {
-                       if ($articles_start_char[$index] != $articles_start_char[$index - 1])
+                       if ( $articles_start_char[$index] != $articles_start_char[$index - 1] )
                        {
                                $r .= "</ul><h3>" . htmlspecialchars( $articles_start_char[$index] ) . "</h3>\n<ul>";
                        }
@@ -449,37 +542,44 @@ class CategoryViewer {
        }
 
        /**
-        * @param $title Title object
-        * @param $first String
-        * @param $last String
-        * @param $limit Int
-        * @param $query Array: additional query options to pass
-        * @return String
-        * @private
+        * Create paging links, as a helper method to getSectionPagingLinks().
+        *
+        * @param $first String The 'until' parameter for the generated URL
+        * @param $last String The 'from' parameter for the genererated URL
+        * @param $type String A prefix for parameters, 'page' or 'subcat' or
+        *     'file'
+        * @return String HTML
         */
-       function pagingLinks( $title, $first, $last, $limit, $query = array() ) {
+       private function pagingLinks( $first, $last, $type = '' ) {
                global $wgLang;
                $sk = $this->getSkin();
-               $limitText = $wgLang->formatNum( $limit );
+               $limitText = $wgLang->formatNum( $this->limit );
 
                $prevLink = wfMsgExt( 'prevn', array( 'escape', 'parsemag' ), $limitText );
-               if( $first != '' ) {
-                       $query['until'] = $first;
-                       $prevLink = $sk->link(
-                               $title,
+
+               if ( $first != '' ) {
+                       $prevQuery = $this->query;
+                       $prevQuery["{$type}until"] = $first;
+                       unset( $prevQuery["{$type}from"] );
+                       $prevLink = $sk->linkKnown(
+                               $this->title,
                                $prevLink,
                                array(),
-                               $query
+                               $prevQuery
                        );
                }
+
                $nextLink = wfMsgExt( 'nextn', array( 'escape', 'parsemag' ), $limitText );
-               if( $last != '' ) {
-                       $query['from'] = $last;
-                       $nextLink = $sk->link(
-                               $title,
+
+               if ( $last != '' ) {
+                       $lastQuery = $this->query;
+                       $lastQuery["{$type}from"] = $last;
+                       unset( $lastQuery["{$type}until"] );
+                       $nextLink = $sk->linkKnown(
+                               $this->title,
                                $nextLink,
                                array(),
-                               $query
+                               $lastQuery
                        );
                }
 
@@ -488,8 +588,8 @@ class CategoryViewer {
 
        /**
         * What to do if the category table conflicts with the number of results
-        * returned?  This function says what.  It works the same whether the
-        * things being counted are articles, subcategories, or files.
+        * returned?  This function says what. Each type is considered independently
+        * of the other types.
         *
         * Note for grepping: uses the messages category-article-count,
         * category-article-count-limited, category-subcat-count,
@@ -512,13 +612,28 @@ class CategoryViewer {
                #      than $this->limit and there's no offset.  In this case we still
                #      know the right figure.
                #   3) We have no idea.
-               $totalrescnt = count( $this->articles ) + count( $this->children ) +
-                       ($this->showGallery ? $this->gallery->count() : 0);
-               if($dbcnt == $rescnt || (($totalrescnt == $this->limit || $this->from
-               || $this->until) && $dbcnt > $rescnt)){
+
+               # Check if there's a "from" or "until" for anything
+
+               // This is a little ugly, but we seem to use different names
+               // for the paging types then for the messages.
+               if ( $type === 'article' ) {
+                       $pagingType = 'page';
+               } else {
+                       $pagingType = $type;
+               }
+
+               $fromOrUntil = false;
+               if ( $this->from[$pagingType] !== null || $this->until[$pagingType] !== null ) {
+                       $fromOrUntil = true;
+               }
+
+               if ( $dbcnt == $rescnt || ( ( $rescnt == $this->limit || $fromOrUntil )
+                       && $dbcnt > $rescnt ) )
+               {
                        # Case 1: seems sane.
                        $totalcnt = $dbcnt;
-               } elseif($totalrescnt < $this->limit && !$this->from && !$this->until){
+               } elseif ( $rescnt < $this->limit && !$fromOrUntil ) {
                        # Case 2: not sane, but salvageable.  Use the number of results.
                        # Since there are fewer than 200, we can also take this opportunity
                        # to refresh the incorrect category table entry -- which should be
@@ -527,10 +642,14 @@ class CategoryViewer {
                        $this->cat->refreshCounts();
                } else {
                        # Case 3: hopeless.  Don't give a total count at all.
-                       return wfMsgExt("category-$type-count-limited", 'parse',
+                       return wfMsgExt( "category-$type-count-limited", 'parse',
                                $wgLang->formatNum( $rescnt ) );
                }
-               return wfMsgExt( "category-$type-count", 'parse', $wgLang->formatNum( $rescnt ),
-                       $wgLang->formatNum( $totalcnt ) );
+               return wfMsgExt(
+                       "category-$type-count",
+                       'parse',
+                       $wgLang->formatNum( $rescnt ),
+                       $wgLang->formatNum( $totalcnt )
+               );
        }
 }