tests/phpunit/includes/parser/ParserOptionsTest.php

   1 <?php
   2
   3 use Wikimedia\TestingAccessWrapper;
   4 use Wikimedia\ScopedCallback;
   5
   6 /**
   7  * @covers ParserOptions
   8  */
   9 class ParserOptionsTest extends MediaWikiTestCase {
  10
  11         private static function clearCache() {
  12                 $wrap = TestingAccessWrapper::newFromClass( ParserOptions::class );
  13                 $wrap->defaults = null;
  14                 $wrap->lazyOptions = [
  15                         'dateformat' => [ ParserOptions::class, 'initDateFormat' ],
  16                 ];
  17                 $wrap->inCacheKey = [
  18                         'dateformat' => true,
  19                         'numberheadings' => true,
  20                         'thumbsize' => true,
  21                         'stubthreshold' => true,
  22                         'printable' => true,
  23                         'userlang' => true,
  24                 ];
  25         }
  26
  27         protected function setUp() {
  28                 global $wgHooks;
  29
  30                 parent::setUp();
  31                 self::clearCache();
  32
  33                 $this->setMwGlobals( [
  34                         'wgRenderHashAppend' => '',
  35                         'wgHooks' => [
  36                                 'PageRenderingHash' => [],
  37                         ] + $wgHooks,
  38                 ] );
  39         }
  40
  41         protected function tearDown() {
  42                 self::clearCache();
  43                 parent::tearDown();
  44         }
  45
  46         /**
  47          * @dataProvider provideIsSafeToCache
  48          * @param bool $expect Expected value
  49          * @param array $options Options to set
  50          */
  51         public function testIsSafeToCache( $expect, $options ) {
  52                 $popt = ParserOptions::newCanonical();
  53                 foreach ( $options as $name => $value ) {
  54                         $popt->setOption( $name, $value );
  55                 }
  56                 $this->assertSame( $expect, $popt->isSafeToCache() );
  57         }
  58
  59         public static function provideIsSafeToCache() {
  60                 return [
  61                         'No overrides' => [ true, [] ],
  62                         'In-key options are ok' => [ true, [
  63                                 'thumbsize' => 1e100,
  64                                 'printable' => false,
  65                         ] ],
  66                         'Non-in-key options are not ok' => [ false, [
  67                                 'removeComments' => false,
  68                         ] ],
  69                         'Non-in-key options are not ok (2)' => [ false, [
  70                                 'wrapclass' => 'foobar',
  71                         ] ],
  72                         'Canonical override, not default (1)' => [ true, [
  73                                 'tidy' => true,
  74                         ] ],
  75                         'Canonical override, not default (2)' => [ false, [
  76                                 'tidy' => false,
  77                         ] ],
  78                 ];
  79         }
  80
  81         /**
  82          * @dataProvider provideOptionsHash
  83          * @param array $usedOptions Used options
  84          * @param string $expect Expected value
  85          * @param array $options Options to set
  86          * @param array $globals Globals to set
  87          */
  88         public function testOptionsHash( $usedOptions, $expect, $options, $globals = [] ) {
  89                 global $wgHooks;
  90
  91                 $globals += [
  92                         'wgHooks' => [],
  93                 ];
  94                 $globals['wgHooks'] += [
  95                         'PageRenderingHash' => [],
  96                 ] + $wgHooks;
  97                 $this->setMwGlobals( $globals );
  98
  99                 $popt = ParserOptions::newCanonical();
 100                 foreach ( $options as $name => $value ) {
 101                         $popt->setOption( $name, $value );
 102                 }
 103                 $this->assertSame( $expect, $popt->optionsHash( $usedOptions ) );
 104         }
 105
 106         public static function provideOptionsHash() {
 107                 $used = [ 'thumbsize', 'printable' ];
 108
 109                 $classWrapper = TestingAccessWrapper::newFromClass( ParserOptions::class );
 110                 $classWrapper->getDefaults();
 111                 $allUsableOptions = array_diff(
 112                         array_keys( $classWrapper->inCacheKey ),
 113                         array_keys( $classWrapper->lazyOptions )
 114                 );
 115
 116                 return [
 117                         'Canonical options, nothing used' => [ [], 'canonical', [] ],
 118                         'Canonical options, used some options' => [ $used, 'canonical', [] ],
 119                         'Used some options, non-default values' => [
 120                                 $used,
 121                                 'printable=1!thumbsize=200',
 122                                 [
 123                                         'thumbsize' => 200,
 124                                         'printable' => true,
 125                                 ]
 126                         ],
 127                         'Canonical options, used all non-lazy options' => [ $allUsableOptions, 'canonical', [] ],
 128                         'Canonical options, nothing used, but with hooks and $wgRenderHashAppend' => [
 129                                 [],
 130                                 'canonical!wgRenderHashAppend!onPageRenderingHash',
 131                                 [],
 132                                 [
 133                                         'wgRenderHashAppend' => '!wgRenderHashAppend',
 134                                         'wgHooks' => [ 'PageRenderingHash' => [ [ __CLASS__ . '::onPageRenderingHash' ] ] ],
 135                                 ]
 136                         ],
 137                 ];
 138         }
 139
 140         public static function onPageRenderingHash( &$confstr ) {
 141                 $confstr .= '!onPageRenderingHash';
 142         }
 143
 144         /**
 145          * @expectedException InvalidArgumentException
 146          * @expectedExceptionMessage Unknown parser option bogus
 147          */
 148         public function testGetInvalidOption() {
 149                 $popt = ParserOptions::newCanonical();
 150                 $popt->getOption( 'bogus' );
 151         }
 152
 153         /**
 154          * @expectedException InvalidArgumentException
 155          * @expectedExceptionMessage Unknown parser option bogus
 156          */
 157         public function testSetInvalidOption() {
 158                 $popt = ParserOptions::newCanonical();
 159                 $popt->setOption( 'bogus', true );
 160         }
 161
 162         public function testMatches() {
 163                 $classWrapper = TestingAccessWrapper::newFromClass( ParserOptions::class );
 164                 $oldDefaults = $classWrapper->defaults;
 165                 $oldLazy = $classWrapper->lazyOptions;
 166                 $reset = new ScopedCallback( function () use ( $classWrapper, $oldDefaults, $oldLazy ) {
 167                         $classWrapper->defaults = $oldDefaults;
 168                         $classWrapper->lazyOptions = $oldLazy;
 169                 } );
 170
 171                 $popt1 = ParserOptions::newCanonical();
 172                 $popt2 = ParserOptions::newCanonical();
 173                 $this->assertTrue( $popt1->matches( $popt2 ) );
 174
 175                 $popt1->enableLimitReport( true );
 176                 $popt2->enableLimitReport( false );
 177                 $this->assertTrue( $popt1->matches( $popt2 ) );
 178
 179                 $popt2->setTidy( !$popt2->getTidy() );
 180                 $this->assertFalse( $popt1->matches( $popt2 ) );
 181
 182                 $ctr = 0;
 183                 $classWrapper->defaults += [ __METHOD__ => null ];
 184                 $classWrapper->lazyOptions += [ __METHOD__ => function () use ( &$ctr ) {
 185                         return ++$ctr;
 186                 } ];
 187                 $popt1 = ParserOptions::newCanonical();
 188                 $popt2 = ParserOptions::newCanonical();
 189                 $this->assertFalse( $popt1->matches( $popt2 ) );
 190
 191                 ScopedCallback::consume( $reset );
 192         }
 193
 194         public function testAllCacheVaryingOptions() {
 195                 global $wgHooks;
 196
 197                 // $wgHooks is already saved in self::setUp(), so we can modify it freely here
 198                 $wgHooks['ParserOptionsRegister'] = [];
 199                 $this->assertSame( [
 200                         'dateformat', 'numberheadings', 'printable', 'stubthreshold',
 201                         'thumbsize', 'userlang'
 202                 ], ParserOptions::allCacheVaryingOptions() );
 203
 204                 self::clearCache();
 205
 206                 $wgHooks['ParserOptionsRegister'][] = function ( &$defaults, &$inCacheKey ) {
 207                         $defaults += [
 208                                 'foo' => 'foo',
 209                                 'bar' => 'bar',
 210                                 'baz' => 'baz',
 211                         ];
 212                         $inCacheKey += [
 213                                 'foo' => true,
 214                                 'bar' => false,
 215                         ];
 216                 };
 217                 $this->assertSame( [
 218                         'dateformat', 'foo', 'numberheadings', 'printable', 'stubthreshold',
 219                         'thumbsize', 'userlang'
 220                 ], ParserOptions::allCacheVaryingOptions() );
 221         }
 222
 223 }