From fe628f805719c53acc5ef47f29b6487882b42ed9 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Mon, 9 Feb 2009 16:34:40 +0000 Subject: [PATCH] Per code review, bit of cleanup to Special:Export. --- includes/specials/SpecialExport.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/includes/specials/SpecialExport.php b/includes/specials/SpecialExport.php index 6b7e55c443..9005cf7ce8 100644 --- a/includes/specials/SpecialExport.php +++ b/includes/specials/SpecialExport.php @@ -61,7 +61,7 @@ class SpecialExport extends SpecialPage { } } } - else if( $wgRequest->wasPosted() && $page == '' ) { + else if( $wgRequest->wasPosted() && $par == '' ) { $page = $wgRequest->getText( 'pages' ); $this->curonly = $wgRequest->getCheck( 'curonly' ); $rawOffset = $wgRequest->getVal( 'offset' ); @@ -125,7 +125,7 @@ class SpecialExport extends SpecialPage { $filename = urlencode( $wgSitename . '-' . wfTimestampNow() . '.xml' ); $wgRequest->response()->header( "Content-disposition: attachment;filename={$filename}" ); } - $this->doExport( $page, $history ); + $this->doExport( $page, $history, $list_authors ); return; } @@ -159,7 +159,7 @@ class SpecialExport extends SpecialPage { * @param string $page User input on what page(s) to export * @param mixed $history one of the WikiExporter history export constants */ - private function doExport( $page, $history ) { + private function doExport( $page, $history, $list_authors ) { global $wgExportMaxHistory; /* Split up the input and look up linked pages */ @@ -199,8 +199,8 @@ class SpecialExport extends SpecialPage { set_time_limit(0); wfRestoreWarnings(); } - $exporter = new WikiExporter( $db, $history, $buffer ); - $exporter->list_authors = $list_authors ; + $exporter = new WikiExporter( $db, $history, $buffer ); + $exporter->list_authors = $list_authors; $exporter->openStream(); foreach( $pages as $page ) { /* -- 2.20.1