From c2b3e27afeb20fef7386860ee8ed319587ccbef7 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Fri, 15 Apr 2016 04:43:04 +0000 Subject: [PATCH] mediawiki.special.upload.js: Remove spinner in .always() instead of .done() This removes the spinner even when the API request fails. Change-Id: Ic0f08312b9a1137772f5b6734256e7bd48d20fcf --- resources/src/mediawiki.special/mediawiki.special.upload.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index 8c89ed97d8..945bfb0ecd 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -74,8 +74,9 @@ if ( result.query ) { resultOut = result.query.pages[ result.query.pageids[ 0 ] ].imageinfo[ 0 ]; } - $spinnerDestCheck.remove(); uploadWarning.processResult( resultOut, uploadWarning.nameToCheck ); + } ).always( function () { + $spinnerDestCheck.remove(); } ); }, @@ -123,8 +124,9 @@ prop: 'text', pst: true } ).done( function ( result ) { - $spinnerLicense.remove(); uploadLicense.processResult( result, license ); + } ).always( function () { + $spinnerLicense.remove(); } ); }, -- 2.20.1