From b1c9a34d8b2b0a42fc78bc66216b20d22b628533 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 26 Nov 2014 06:15:30 +0000 Subject: [PATCH] mediawiki.util: Remove test for jsMessage jsMessage uses mw.notify, which involves an animation. mw.notify yields an mw.Notification object which has a reference to the relevant elements. However the deprecated jsMessage wrapper only returns boolean, so we have no link to the element and no way to wait for the animation to finish. We could set up a mock clock in the test to skip the animation. However, in this case the test was already useless as method isn't testable (hardcoded booolean return). This test was causing the QUnit test suite to fail occasionally as the mw.notify animation was unfinished and would leak into other tests. Change-Id: Iffa91a3969bf69264b585e27ca44f85883ae2892 --- .../suites/resources/mediawiki/mediawiki.util.test.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js index 9b620de406..7aa91336c6 100644 --- a/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js +++ b/tests/qunit/suites/resources/mediawiki/mediawiki.util.test.js @@ -228,13 +228,6 @@ assert.equal( tbRLDMemptyjquery, $( '#p-test-tb li:last' )[0], 'Fallback to adding at the end (nextnode as empty jQuery object)' ); } ); - QUnit.test( 'jsMessage', 1, function ( assert ) { - this.suppressWarnings(); - var a = mw.util.jsMessage( 'MediaWiki is Awesome.' ); - this.restoreWarnings(); - assert.ok( a, 'Basic checking of return value' ); - } ); - QUnit.test( 'validateEmail', 6, function ( assert ) { assert.strictEqual( mw.util.validateEmail( '' ), null, 'Should return null for empty string ' ); assert.strictEqual( mw.util.validateEmail( 'user@localhost' ), true, 'Return true for a valid e-mail address' ); -- 2.20.1