From 96effdf8f350e2dc928b9fcf931538235217b42f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Tue, 7 Nov 2017 18:45:17 +0100 Subject: [PATCH] Fix mergeMessageFileList.php --extensions-dir extensions:skins Only last directory of multiple was being used. Follows up e74bc3b32effac7e0bbf9e314f4a6f15eedf7bff Change-Id: I30190a30c387f1c34a41f9bbc033d421be631756 --- maintenance/mergeMessageFileList.php | 42 ++++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/maintenance/mergeMessageFileList.php b/maintenance/mergeMessageFileList.php index bb47631357..8d2534eec5 100644 --- a/maintenance/mergeMessageFileList.php +++ b/maintenance/mergeMessageFileList.php @@ -80,29 +80,29 @@ class MergeMessageFileList extends Maintenance { $extdirs = explode( ':', $extdir ); $entries = []; foreach ( $extdirs as $extdir ) { - $entries = array_merge( $entries, scandir( $extdir ) ); - } - foreach ( $entries as $extname ) { - if ( $extname == '.' || $extname == '..' || !is_dir( "$extdir/$extname" ) ) { - continue; - } - $possibilities = [ - "$extdir/$extname/extension.json", - "$extdir/$extname/skin.json", - "$extdir/$extname/$extname.php" - ]; - $found = false; - foreach ( $possibilities as $extfile ) { - if ( file_exists( $extfile ) ) { - $mmfl['setupFiles'][] = $extfile; - $found = true; - break; + $entries = scandir( $extdir ); + foreach ( $entries as $extname ) { + if ( $extname == '.' || $extname == '..' || !is_dir( "$extdir/$extname" ) ) { + continue; + } + $possibilities = [ + "$extdir/$extname/extension.json", + "$extdir/$extname/skin.json", + "$extdir/$extname/$extname.php" + ]; + $found = false; + foreach ( $possibilities as $extfile ) { + if ( file_exists( $extfile ) ) { + $mmfl['setupFiles'][] = $extfile; + $found = true; + break; + } } - } - if ( !$found ) { - $this->error( "Extension {$extname} in {$extdir} lacks expected entry point: " . - "extension.json, skin.json, or {$extname}.php." ); + if ( !$found ) { + $this->error( "Extension {$extname} in {$extdir} lacks expected entry point: " . + "extension.json, skin.json, or {$extname}.php." ); + } } } } -- 2.20.1