From 8edda967ab09d5e495f734ce6975faf4be89c7c6 Mon Sep 17 00:00:00 2001 From: Ori Livneh Date: Wed, 2 Nov 2016 15:49:22 -0400 Subject: [PATCH] mw.loader.store: Count modules which fail to execute, too "Failed" will probably always be either zero or one, because it is unlikely the asyncEval error callback can ever be called more than once. But the stats will let us verify this, and will give us an indication of how often errors happen in general. Change-Id: I6dea28d84bbca0f02ad8c5bf9a8e9d976622d815 --- resources/src/mediawiki/mediawiki.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index 6280c95eaa..da4c769805 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -1782,6 +1782,7 @@ // Depending on how corrupt the string is, it is likely that some // modules' implement() succeeded while the ones after the error will // never run and leave their modules in the 'loading' state forever. + mw.loader.store.stats.failed++; // Since this is an error not caused by an individual module but by // something that infected the implement call itself, don't take any @@ -2184,7 +2185,7 @@ items: {}, // Cache hit stats - stats: { hits: 0, misses: 0, expired: 0 }, + stats: { hits: 0, misses: 0, expired: 0, failed: 0 }, /** * Construct a JSON-serializable object representing the content of the store. -- 2.20.1