From 834882dfa05e1c760f947d23da93a0b49f2d7054 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Thu, 11 May 2017 17:52:45 -0700 Subject: [PATCH] RCFilters: Treat saved query with multiple spaces as empty Because it is empty, even if there's multiple spaces. Also, if the input is invalid and we didn't save the query, don't close the popup. Bug: T165113 Change-Id: I30e68b0b90e2a4077fb4068c1462d40b03cbfe8c --- .../ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js index 9b7a2fba8b..3f920f0013 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js @@ -39,7 +39,7 @@ this.popup.$head.prepend( ( new OO.ui.IconWidget( { icon: 'clip' } ) ).$element ); this.input = new OO.ui.TextInputWidget( { - validate: 'non-empty' + validate: /\S/ } ); layout = new OO.ui.FieldLayout( this.input, { label: mw.msg( 'rcfilters-savedqueries-new-name-label' ), @@ -151,8 +151,6 @@ widget.controller.saveCurrentQuery( label ); widget.input.setValue( this.input, '' ); widget.emit( 'saveCurrent' ); - } ) - .always( function () { widget.popup.toggle( false ); } ); }; -- 2.20.1