From 4dff2146cb0941d586dd9a3ecd0cca385eadd08d Mon Sep 17 00:00:00 2001 From: "James D. Forrester" Date: Mon, 20 Feb 2017 13:18:18 -0800 Subject: [PATCH] resources: Replace implicit Bugzilla bug numbers with Phab ones It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345" except where it doesn't, so let's just standardise on the real numbers. (This is just for resources/src for now; includes/ will be another day. :-)) Change-Id: I5c55bab4f7c8a26dda43de7d169cc7bddc74adc3 --- resources/src/jquery/jquery.badge.css | 2 +- resources/src/jquery/jquery.byteLimit.js | 4 ++-- resources/src/jquery/jquery.suggestions.js | 4 ++-- resources/src/jquery/jquery.tablesorter.js | 2 +- resources/src/jquery/jquery.textSelection.js | 8 ++++---- .../mediawiki.action.edit.preview.js | 2 +- .../mediawiki.action.view.dblClickEdit.js | 4 ++-- .../mediawiki.action.view.filepage.css | 2 +- .../mediawiki.action.view.rightClickEdit.js | 2 +- resources/src/mediawiki.legacy/shared.css | 12 ++++++------ .../src/mediawiki.skinning/content.externallinks.css | 2 +- resources/src/mediawiki.skinning/elements.css | 2 +- resources/src/mediawiki.skinning/interface.css | 4 ++-- .../mediawiki.special/mediawiki.special.upload.js | 2 +- resources/src/mediawiki.ui/components/buttons.less | 2 +- resources/src/mediawiki.ui/components/checkbox.less | 4 ++-- resources/src/mediawiki.ui/components/radio.less | 4 ++-- .../src/mediawiki.widgets/mw.widgets.TitleWidget.js | 2 +- resources/src/mediawiki/api.js | 2 +- resources/src/mediawiki/mediawiki.js | 6 +++--- resources/src/mediawiki/mediawiki.util.js | 2 +- resources/src/mediawiki/page/image-pagination.js | 2 +- resources/src/mediawiki/page/watch.js | 2 +- 23 files changed, 39 insertions(+), 39 deletions(-) diff --git a/resources/src/jquery/jquery.badge.css b/resources/src/jquery/jquery.badge.css index 7833979b41..8e0e512bab 100644 --- a/resources/src/jquery/jquery.badge.css +++ b/resources/src/jquery/jquery.badge.css @@ -19,7 +19,7 @@ .mw-badge-inline { margin-left: 3px; display: inline-block; - /* Hack for IE6 and IE7 (bug 47926) */ + /* Hack for IE6 and IE7 (T49926) */ zoom: 1; *display: inline; /* stylelint-disable-line declaration-block-no-duplicate-properties */ diff --git a/resources/src/jquery/jquery.byteLimit.js b/resources/src/jquery/jquery.byteLimit.js index 567bec8ad6..c75246c0f6 100644 --- a/resources/src/jquery/jquery.byteLimit.js +++ b/resources/src/jquery/jquery.byteLimit.js @@ -87,7 +87,7 @@ // Chop off characters from the end of the "inserted content" string // until the limit is statisfied. if ( fn ) { - // stop, when there is nothing to slice - bug 41450 + // stop, when there is nothing to slice - T43450 while ( $.byteLength( fn( inpParts.join( '' ) ) ) > byteLimit && inpParts[ 1 ].length > 0 ) { inpParts[ 1 ] = inpParts[ 1 ].slice( 0, -1 ); } @@ -225,7 +225,7 @@ } // Always adjust prevSafeVal to reflect the input value. Not doing this could cause // trimByteLength to compare the new value to an empty string instead of the - // old value, resulting in trimming always from the end (bug 40850). + // old value, resulting in trimming always from the end (T42850). prevSafeVal = res.newVal; } ); } ); diff --git a/resources/src/jquery/jquery.suggestions.js b/resources/src/jquery/jquery.suggestions.js index 8c1739c547..fdc8a266ad 100644 --- a/resources/src/jquery/jquery.suggestions.js +++ b/resources/src/jquery/jquery.suggestions.js @@ -681,7 +681,7 @@ // Don't interfere with special clicks (e.g. to open in new tab) if ( !( e.which !== 1 || e.altKey || e.ctrlKey || e.shiftKey || e.metaKey ) ) { // This will hide the link we're just clicking on, which causes problems - // when done synchronously in at least Firefox 3.6 (bug 62858). + // when done synchronously in at least Firefox 3.6 (T64858). setTimeout( function () { $.suggestions.hide( context ); }, 0 ); @@ -713,7 +713,7 @@ // Don't interfere with special clicks (e.g. to open in new tab) if ( !( e.which !== 1 || e.altKey || e.ctrlKey || e.shiftKey || e.metaKey ) ) { // This will hide the link we're just clicking on, which causes problems - // when done synchronously in at least Firefox 3.6 (bug 62858). + // when done synchronously in at least Firefox 3.6 (T64858). setTimeout( function () { $.suggestions.hide( context ); }, 0 ); diff --git a/resources/src/jquery/jquery.tablesorter.js b/resources/src/jquery/jquery.tablesorter.js index 1b64237d07..f84c091dba 100644 --- a/resources/src/jquery/jquery.tablesorter.js +++ b/resources/src/jquery/jquery.tablesorter.js @@ -63,7 +63,7 @@ var $node = $( node ), // Use data-sort-value attribute. // Use data() instead of attr() so that live value changes - // are processed as well (bug 38152). + // are processed as well (T40152). data = $node.data( 'sortValue' ); if ( data !== null && data !== undefined ) { diff --git a/resources/src/jquery/jquery.textSelection.js b/resources/src/jquery/jquery.textSelection.js index c897302c6c..c6ad945a1a 100644 --- a/resources/src/jquery/jquery.textSelection.js +++ b/resources/src/jquery/jquery.textSelection.js @@ -4,7 +4,7 @@ ( function ( $ ) { if ( document.selection && document.selection.createRange ) { // On IE, patch the focus() method to restore the windows' scroll position - // (bug 32241) + // (T34241) $.fn.extend( { focus: ( function ( jqFocus ) { return function () { @@ -56,7 +56,7 @@ */ function activateElementOnIE( element ) { if ( element.setActive ) { - element.setActive(); // bug 32241: doesn't scroll + element.setActive(); // T34241: doesn't scroll } else { $( element ).focus(); // may scroll (but we patched it above) } @@ -172,7 +172,7 @@ // IE // Note that IE9 will trigger the next section unless we check this first. - // See bug 35201. + // See bug T37201. activateElementOnIE( this ); if ( context ) { @@ -312,7 +312,7 @@ // IE doesn't properly report non-selected caret position through // the selection ranges when textarea isn't focused. This can // lead to saving a bogus empty selection, which then screws up - // whatever we do later (bug 31847). + // whatever we do later (T33847). activateElementOnIE( e ); preFinished = false; diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js index f26c336da1..15d0a39584 100644 --- a/resources/src/mediawiki.action/mediawiki.action.edit.preview.js +++ b/resources/src/mediawiki.action/mediawiki.action.edit.preview.js @@ -323,7 +323,7 @@ // This should be moved down to '#editform', but is kept on the body for now // because the LiquidThreads extension is re-using this module with only half - // the EditPage (doesn't include #editform presumably, bug 55463). + // the EditPage (doesn't include #editform presumably, T57463). $( document.body ).on( 'click', '#wpPreview, #wpDiff', doLivePreview ); } ); diff --git a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js index 7439754668..d89cd4a2d0 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js +++ b/resources/src/mediawiki.action/mediawiki.action.view.dblClickEdit.js @@ -8,9 +8,9 @@ // Recheck preference so extensions can do a hack to disable this code. if ( parseInt( mw.user.options.get( 'editondblclick' ), 10 ) ) { e.preventDefault(); - // Trigger native HTMLElement click instead of opening URL (bug 43052) + // Trigger native HTMLElement click instead of opening URL (T45052) $a = $( '#ca-edit a' ); - // Not every page has an edit link (bug 57713) + // Not every page has an edit link (T59713) if ( $a.length ) { $a.get( 0 ).click(); } diff --git a/resources/src/mediawiki.action/mediawiki.action.view.filepage.css b/resources/src/mediawiki.action/mediawiki.action.view.filepage.css index 85e5c2661a..185523a660 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.filepage.css +++ b/resources/src/mediawiki.action/mediawiki.action.view.filepage.css @@ -33,7 +33,7 @@ /* * Add a checkered background image on hover for file - * description pages. (bug 26470) + * description pages. (T28470) */ .filehistory a img, #file img:hover { diff --git a/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js b/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js index ada101eb16..ebd1ebccdf 100644 --- a/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js +++ b/resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js @@ -18,7 +18,7 @@ jQuery( function ( $ ) { // inside the heading (e.g. to do things like copy URL, open in new tab, ..). // e.target can be the heading, but it can also be anything inside the heading. if ( e.target.nodeName.toLowerCase() !== 'a' ) { - // Trigger native HTMLElement click instead of opening URL (bug 43052) + // Trigger native HTMLElement click instead of opening URL (T45052) e.preventDefault(); $edit.get( 0 ).click(); } diff --git a/resources/src/mediawiki.legacy/shared.css b/resources/src/mediawiki.legacy/shared.css index e788253b65..80bdf1a09e 100644 --- a/resources/src/mediawiki.legacy/shared.css +++ b/resources/src/mediawiki.legacy/shared.css @@ -244,7 +244,7 @@ input#wpSummary:active { #catlinks { /** * Overrides text justification (user preference) - * See bug 31990 + * See T33990 */ text-align: left; } @@ -274,7 +274,7 @@ input#wpSummary:active { border-left: 0; } -/* (bug 5346) make category redirects italic */ +/* (T7346) make category redirects italic */ .catlinks li a.mw-redirect { font-style: italic; } @@ -346,7 +346,7 @@ th.mw-revdel-checkbox { text-align: center; } -/* red links; see bug 36276 */ +/* red links; see T38276 */ a.new { color: #ba0000; } @@ -358,7 +358,7 @@ a.new { padding: 0 !important; } -/* External URLs should always be treated as LTR (bug 4330) */ +/* External URLs should always be treated as LTR (T6330) */ /* @noflip */ .rtl a.external.free, .rtl a.external.autonumber { direction: ltr; @@ -576,7 +576,7 @@ table.wikitable > caption { background-repeat: no-repeat; } -/* Language specific height correction for titles. Ref Bug 29405 and Bug 30809 */ +/* Language specific height correction for titles. Ref T31405 and T32809 */ /* Languages like hi or ml require slightly more vertical space to show diacritics properly */ h1:lang( anp ), h1:lang( as ), @@ -742,7 +742,7 @@ table.floatleft { position: relative; } -/* bug 12205 */ +/* T14205 */ #mw-credits a { unicode-bidi: embed; } diff --git a/resources/src/mediawiki.skinning/content.externallinks.css b/resources/src/mediawiki.skinning/content.externallinks.css index b7cc6ed399..a744e29b9a 100644 --- a/resources/src/mediawiki.skinning/content.externallinks.css +++ b/resources/src/mediawiki.skinning/content.externallinks.css @@ -2,7 +2,7 @@ * Icons and colors for external links. */ -/* Bug 66091 is blocking is from converting this file to LESS +/* T68091 is blocking is from converting this file to LESS * and using the .background-image-svg mixin. */ /* SVG support using a transparent gradient to guarantee cross-browser diff --git a/resources/src/mediawiki.skinning/elements.css b/resources/src/mediawiki.skinning/elements.css index b97868ebba..3fbbbc95d7 100644 --- a/resources/src/mediawiki.skinning/elements.css +++ b/resources/src/mediawiki.skinning/elements.css @@ -69,7 +69,7 @@ a.new:visited, #p-personal a.new:visited { } .mw-body a.external:visited { - color: #636; /* bug 3112 */ + color: #636; /* T5112 */ } .mw-body a.external:active { diff --git a/resources/src/mediawiki.skinning/interface.css b/resources/src/mediawiki.skinning/interface.css index 7b99268b2c..2be3bb2ac8 100644 --- a/resources/src/mediawiki.skinning/interface.css +++ b/resources/src/mediawiki.skinning/interface.css @@ -50,8 +50,8 @@ textarea { .firstHeading { margin-bottom: 0.1em; - /* These two rules hack around bug 2013 (fix for more limited bug 11325). - * When bug 2013 is fixed properly, they should be removed. */ + /* These two rules hack around T4013 (fix for more limited T13325). + * When T4013 is fixed properly, they should be removed. */ line-height: 1.2em; padding-bottom: 0; } diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index f818096377..0ddf7fe3f1 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -252,7 +252,7 @@ // Output result if ( $( '#wpDestFile' ).length ) { // Call decodeURIComponent function to remove possible URL-encoded characters - // from the file name (bug 30390). Especially likely with upload-form-url. + // from the file name (T32390). Especially likely with upload-form-url. // decodeURIComponent can throw an exception if input is invalid utf-8 try { $( '#wpDestFile' ).val( decodeURIComponent( fname ) ); diff --git a/resources/src/mediawiki.ui/components/buttons.less b/resources/src/mediawiki.ui/components/buttons.less index 5281862052..5dc025fb59 100644 --- a/resources/src/mediawiki.ui/components/buttons.less +++ b/resources/src/mediawiki.ui/components/buttons.less @@ -26,7 +26,7 @@ // // Styleguide 2.1. .mw-ui-button { - // Inherit the font rather than apply user agent stylesheet (bug 70072) + // Inherit the font rather than apply user agent stylesheet (T72072) font-family: inherit; font-size: 1em; // Container layout diff --git a/resources/src/mediawiki.ui/components/checkbox.less b/resources/src/mediawiki.ui/components/checkbox.less index b0fbf515e6..f983087ff5 100644 --- a/resources/src/mediawiki.ui/components/checkbox.less +++ b/resources/src/mediawiki.ui/components/checkbox.less @@ -43,7 +43,7 @@ display: table; * { - // reset font sizes (see bug 72727) + // reset font sizes (see T74727) font: inherit; vertical-align: middle; } @@ -58,7 +58,7 @@ // ensure the invisible checkbox takes up the required width width: @checkboxSize; height: @checkboxSize; - // This is needed for Firefox mobile (See bug 71750 to workaround default Firefox stylesheet) + // This is needed for Firefox mobile (See T73750 to workaround default Firefox stylesheet) max-width: none; margin: 0 0.4em 0 0; display: table-cell; diff --git a/resources/src/mediawiki.ui/components/radio.less b/resources/src/mediawiki.ui/components/radio.less index 53c22b4463..7538ff4e3e 100644 --- a/resources/src/mediawiki.ui/components/radio.less +++ b/resources/src/mediawiki.ui/components/radio.less @@ -43,7 +43,7 @@ line-height: @radioSize; * { - // reset font sizes (see bug 72727) + // reset font sizes (see T74727) font: inherit; vertical-align: middle; } @@ -55,7 +55,7 @@ // ensure the invisible radio takes up the required width width: @radioSize; height: @radioSize; - // This is needed for Firefox mobile (See bug 71750 to workaround default Firefox stylesheet) + // This is needed for Firefox mobile (See T73750 to workaround default Firefox stylesheet) max-width: none; margin-right: 0.4em; diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js index 3a4581d5dc..9703eeac73 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js @@ -255,7 +255,7 @@ } ); // If not found, run value through mw.Title to avoid treating a match as a - // mismatch where normalisation would make them matching (bug 48476) + // mismatch where normalisation would make them matching (T50476) pageExistsExact = ( Object.prototype.hasOwnProperty.call( pageData, this.getQueryValue() ) && diff --git a/resources/src/mediawiki/api.js b/resources/src/mediawiki/api.js index f3d48e691a..660064a4d9 100644 --- a/resources/src/mediawiki/api.js +++ b/resources/src/mediawiki/api.js @@ -51,7 +51,7 @@ } // Pre-populate with fake ajax promises to save http requests for tokens - // we already have on the page via the user.tokens module (bug 34733). + // we already have on the page via the user.tokens module (T36733). promises[ defaultOptions.ajax.url ] = {}; $.each( mw.user.tokens.get(), function ( key, value ) { // This requires #getToken to use the same key as user.tokens. diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index 4df2df7985..94ad2179e8 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -1252,7 +1252,7 @@ el.media = media; } // If you end up here from an IE exception "SCRIPT: Invalid property value.", - // see #addEmbeddedCSS, bug 31676, and bug 47277 for details. + // see #addEmbeddedCSS, T33676, and T49277 for details. el.href = url; $( getMarker() ).before( el ); @@ -1923,7 +1923,7 @@ * { : css } * { : [url, ..] } * - * The reason css strings are not concatenated anymore is bug 31676. We now check + * The reason css strings are not concatenated anymore is T33676. We now check * whether it's safe to extend the stylesheet. * * @protected @@ -2042,7 +2042,7 @@ // Support: IE 7-8 // Use properties instead of attributes as IE throws security // warnings when inserting a tag with a protocol-relative - // URL set though attributes - when on HTTPS. See bug 41331. + // URL set though attributes - when on HTTPS. See T43331. l = document.createElement( 'link' ); l.rel = 'stylesheet'; l.href = modules; diff --git a/resources/src/mediawiki/mediawiki.util.js b/resources/src/mediawiki/mediawiki.util.js index a8188dbcbd..78634f6474 100644 --- a/resources/src/mediawiki/mediawiki.util.js +++ b/resources/src/mediawiki/mediawiki.util.js @@ -358,7 +358,7 @@ } // Update tooltip for the access key after inserting into DOM - // to get a localized access key label (bug 67946). + // to get a localized access key label (T69946). $link.updateTooltipAccessKeys(); return $item[ 0 ]; diff --git a/resources/src/mediawiki/page/image-pagination.js b/resources/src/mediawiki/page/image-pagination.js index 6038a574c8..6a7d0b92e1 100644 --- a/resources/src/mediawiki/page/image-pagination.js +++ b/resources/src/mediawiki/page/image-pagination.js @@ -104,7 +104,7 @@ var page, url; // Generate the same URL on client side as the one generated in ImagePage::openShowImage. - // We avoid using the URL in the link directly since it could have been manipulated (bug 66608) + // We avoid using the URL in the link directly since it could have been manipulated (T68608) page = Number( mw.util.getParamValue( 'page', this.href ) ); url = mw.util.getUrl( mw.config.get( 'wgPageName' ), { page: page } ); diff --git a/resources/src/mediawiki/page/watch.js b/resources/src/mediawiki/page/watch.js index 7cfe058a89..7d35cb759c 100644 --- a/resources/src/mediawiki/page/watch.js +++ b/resources/src/mediawiki/page/watch.js @@ -149,7 +149,7 @@ updateWatchLink( $link, otherAction ); // Update the "Watch this page" checkbox on action=edit when the - // page is watched or unwatched via the tab (bug 12395). + // page is watched or unwatched via the tab (T14395). $( '#wpWatchthis' ).prop( 'checked', watchResponse.watched === true ); } ) .fail( function () { -- 2.20.1