From 16caf0f6265540b7ec3329e55f36aeaaafadfdae Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Tue, 7 Mar 2017 18:22:07 -0800 Subject: [PATCH] RCFilters UI: Anchor the highlight popup Due to a regression in popups positioning in OOUI, the popup renders wrongly when it is unanchored. Fixing this to an anchored popup while the OOUI bug is being fixed. Bug: T159906 Change-Id: I38ca560929f7f9488ff48b148b089f0613d67d97 --- .../ui/mw.rcfilters.ui.FilterItemHighlightButton.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js index 17aad51ce1..889ba08cf4 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js @@ -19,7 +19,11 @@ icon: 'highlight', indicator: 'down', popup: { - anchor: false, + // TODO: There is a bug in non-anchored popups in + // OOUI, so we set this popup to "anchored" until + // the bug is fixed. + // See: https://phabricator.wikimedia.org/T159906 + anchor: true, padded: true, align: 'backwards', horizontalPosition: 'end', -- 2.20.1