From 0b9e01c704b6603eb7a28540d1e1d299cad54931 Mon Sep 17 00:00:00 2001
From: Brian Wolff <bawolff@users.mediawiki.org>
Date: Sun, 18 Sep 2011 04:25:40 +0000
Subject: [PATCH] (bug 18424) Clean up paging links on Special:allpages and
 special:prefixindex.

*Make them normal font size (my eyes! my eyes! with the tiny writing)
*Special:prefindex needs a paging link on the bottom like special:allpages (added a class name here, because I couldn't use the existing id on both)
*special:prefindex was doing $wgLang->pipeList( "full html table here", "next link here" ) which was giving bad output for the obvious reason.
---
 RELEASE-NOTES-1.19                               |  2 ++
 includes/specials/SpecialPrefixindex.php         | 16 +++++++++-------
 .../mediawiki.special/mediawiki.special.css      |  6 +++---
 3 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19
index 6efeb24779..9246d361e9 100644
--- a/RELEASE-NOTES-1.19
+++ b/RELEASE-NOTES-1.19
@@ -92,6 +92,8 @@ production.
 * Allowing moving the associated talk pages of subpages even if the base page
   has no subpage.
 * (bug 30907) Special:Unusedcategories should sort ascendingly.
+* (bug 18424) Special:Prefixindex and Special:Allpages paging links are
+  really small, and somewhat inconsistent with each other.
 
 === API changes in 1.19 ===
 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php
index 3b64ee9a8f..fd5005e323 100644
--- a/includes/specials/SpecialPrefixindex.php
+++ b/includes/specials/SpecialPrefixindex.php
@@ -197,6 +197,7 @@ class SpecialPrefixindex extends SpecialAllpages {
 			}
 		}
 
+		$footer = '';
 		if ( $this->including() ) {
 			$out2 = '';
 		} else {
@@ -207,7 +208,7 @@ class SpecialPrefixindex extends SpecialAllpages {
 					<td>' .
 						$nsForm .
 					'</td>
-					<td id="mw-prefixindex-nav-form">';
+					<td id="mw-prefixindex-nav-form" class="mw-prefixindex-nav">';
 
 			if( isset( $res ) && $res && ( $n == $this->maxPerPage ) && ( $s = $res->fetchObject() ) ) {
 				$query = array(
@@ -219,20 +220,21 @@ class SpecialPrefixindex extends SpecialAllpages {
 					$query['namespace'] = $namespace;
 				}
 
-				$out2 = $this->getLang()->pipeList( array(
-					$out2,
-					Linker::linkKnown(
+				$nextLink = Linker::linkKnown(
 						$self,
 						wfMsgHtml( 'nextpage', str_replace( '_',' ', htmlspecialchars( $s->page_title ) ) ),
 						array(),
 						$query
-					)
-				) );
+					);
+				$out2 .= $nextLink;
+
+				$footer = "\n" . Html::element( "hr" )
+					. Html::rawElement( "div", array( "class" => "mw-prefixindex-nav" ), $nextLink );
 			}
 			$out2 .= "</td></tr>" .
 				Xml::closeElement( 'table' );
 		}
 
-		$this->getOutput()->addHTML( $out2 . $out );
+		$this->getOutput()->addHTML( $out2 . $out . $footer );
 	}
 }
diff --git a/resources/mediawiki.special/mediawiki.special.css b/resources/mediawiki.special/mediawiki.special.css
index 1d04d168b7..412a3fce6f 100644
--- a/resources/mediawiki.special/mediawiki.special.css
+++ b/resources/mediawiki.special/mediawiki.special.css
@@ -25,7 +25,6 @@ td.mw-allpages-alphaindexline {
 }
 .mw-allpages-nav {
 	text-align: right;
-	font-size: smaller;
 	margin-bottom: 1em;
 }
 table.mw-allpages-table-form tr {
@@ -72,11 +71,12 @@ table#mw-prefixindex-nav-table {
 	width: 98%;
 }
 td#mw-prefixindex-nav-form {
-	font-size: smaller;
 	margin-bottom: 1em;
-	text-align: right;
 	vertical-align: top;
 }
+.mw-prefixindex-nav {
+	text-align: right;
+}
 
 
 /**** Special:Search ****/
-- 
2.20.1