lhc/web/wiklou.git
14 years agoWhitespace fixes for r62532
Roan Kattouw [Mon, 15 Feb 2010 18:47:32 +0000 (18:47 +0000)]
Whitespace fixes for r62532

14 years ago* helps address bug 22453, Enables the api to return PLURAL transforms.
Michael Dale [Mon, 15 Feb 2010 17:56:55 +0000 (17:56 +0000)]
* helps address bug 22453, Enables the api to return PLURAL transforms.
* Adds support for parser to be run on msg keys with argument substitution.

14 years agofollow-up r62498 — use the new functionality of requireOnlyOneParameter of allowing...
Mark A. Hershberger [Mon, 15 Feb 2010 17:50:35 +0000 (17:50 +0000)]
follow-up r62498 — use the new functionality of requireOnlyOneParameter of allowing “false” defaults

14 years agoFix r62511: always select ipb_auto field
Roan Kattouw [Mon, 15 Feb 2010 12:20:52 +0000 (12:20 +0000)]
Fix r62511: always select ipb_auto field

14 years agoAPI: Don't display range info for autoblocks (effectively disclosing the IP address...
Roan Kattouw [Mon, 15 Feb 2010 12:13:01 +0000 (12:13 +0000)]
API: Don't display range info for autoblocks (effectively disclosing the IP address) in list=blocks, and don't list autoblocks when queried for a certain user's or IP's blocks. These constraints mirror the ones used by Special:Ipblocklist

14 years agoclean r61713 (and r61710) per code review
Conrad Irwin [Mon, 15 Feb 2010 09:34:51 +0000 (09:34 +0000)]
clean r61713 (and r61710) per code review

14 years agoFix fir r62482: PHP Notice: Undefined index: token in /www/w/includes/api/ApiMain...
Raimond Spekking [Mon, 15 Feb 2010 09:22:11 +0000 (09:22 +0000)]
Fix fir r62482: PHP Notice: Undefined index: token in /www/w/includes/api/ApiMain.php  on line 415

14 years agoUnit tests: don't fail miserably if we don't have CDB support
Max Semenik [Mon, 15 Feb 2010 08:40:02 +0000 (08:40 +0000)]
Unit tests: don't fail miserably if we don't have CDB support

14 years agofollow up r61101 for special pages like Special:Version and Special:RecentChanges
Mark A. Hershberger [Mon, 15 Feb 2010 08:36:10 +0000 (08:36 +0000)]
follow up r61101 for special pages like Special:Version and Special:RecentChanges

14 years agofollow up r62498 tests for the requireOnlyOneParameter() change
Mark A. Hershberger [Mon, 15 Feb 2010 07:10:58 +0000 (07:10 +0000)]
follow up r62498 tests for the requireOnlyOneParameter() change

14 years agofollow up r62353 Make ApiBase::requireOnlyOneParameter() accept parameters that are...
Mark A. Hershberger [Mon, 15 Feb 2010 07:06:49 +0000 (07:06 +0000)]
follow up r62353 Make ApiBase::requireOnlyOneParameter() accept parameters that are set, but false.  This means that you can pass in more than one parameter, as long as it is the same as the default (false).  Have to do it this way since we'd like to default boolean parameters to false in getAllowedParams() but by the time requireOnlyOneParameter() is called, the defaults are set, so we can't tell the difference between passing in a parameter set to the default and just getting the defaults.

14 years agoWas it supposed to be a comma instead of dot? :)
Max Semenik [Mon, 15 Feb 2010 05:49:10 +0000 (05:49 +0000)]
Was it supposed to be a comma instead of dot? :)

14 years agoParser tests: output article name in duplicate article message
Max Semenik [Mon, 15 Feb 2010 05:41:19 +0000 (05:41 +0000)]
Parser tests: output article name in duplicate article message

14 years agoSearch suggestion API requests make up a substantial portion of our total apache...
Tim Starling [Sun, 14 Feb 2010 23:52:45 +0000 (23:52 +0000)]
Search suggestion API requests make up a substantial portion of our total apache load and thus deserve some optimisation:
* Made the cache expiry time configurable via $wgSearchSuggestCacheExpiry
* Removed must-revalidate from the Cache-Control of such requests. Introduced a generic interface to ApiMain for doing that.

14 years agoStart of "Bug 21991 - Move common query parameter (uc, rc) validation, token requiri...
Sam Reed [Sun, 14 Feb 2010 22:20:27 +0000 (22:20 +0000)]
Start of "Bug 21991 -  Move common query parameter (uc, rc) validation, token requiringness/checking to ApiBase/Similar"

Move token requringness check to the ApiMain

Adding an exception if we're using "gettoken" (block/unblock)

Remove array( 'missingparam', 'token' ), from the getPossibleErrors of modules that set requireToken method to true

14 years agoRandom indentation and code formatting updates. No functional changes.
Siebrand Mazeland [Sun, 14 Feb 2010 22:07:30 +0000 (22:07 +0000)]
Random indentation and code formatting updates. No functional changes.

14 years ago* (bug 18771) List possible errors in action=paraminfo
Sam Reed [Sun, 14 Feb 2010 21:36:20 +0000 (21:36 +0000)]
* (bug 18771) List possible errors in action=paraminfo

Bug isn't quite complete, but majorly implemented. Marking in RELEASE-NOTES for reference

14 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Sun, 14 Feb 2010 21:23:38 +0000 (21:23 +0000)]
Fixed some doxygen warnings

14 years agoChange layout of the mustBePosted format to standardise it
Sam Reed [Sun, 14 Feb 2010 21:12:11 +0000 (21:12 +0000)]
Change layout of the mustBePosted format to standardise it

14 years agoRebuild MessagesLzz.php and add 'tr' as fallback.
Siebrand Mazeland [Sun, 14 Feb 2010 19:56:37 +0000 (19:56 +0000)]
Rebuild MessagesLzz.php and add 'tr' as fallback.

14 years agoAdd Laz language (lzz) per request of GerardM
Raimond Spekking [Sun, 14 Feb 2010 19:44:39 +0000 (19:44 +0000)]
Add Laz language (lzz) per request of GerardM

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 14 Feb 2010 19:33:39 +0000 (19:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-02-14 19:00 UTC)

14 years agoFollowup to r62465, should be in an array
Sam Reed [Sun, 14 Feb 2010 15:19:45 +0000 (15:19 +0000)]
Followup to r62465, should be in an array

14 years agoMove ( 'code' => 'show', 'info' => 'Incorrect parameter - mutually exclusive values...
Sam Reed [Sun, 14 Feb 2010 15:16:09 +0000 (15:16 +0000)]
Move ( 'code' => 'show', 'info' => 'Incorrect parameter - mutually exclusive values may not be supplied' ) to messageMap

14 years agoFixup spaces to tabs from r62404
Sam Reed [Sun, 14 Feb 2010 14:29:24 +0000 (14:29 +0000)]
Fixup spaces to tabs from r62404

14 years agoWhitespace fixes for r62402
Roan Kattouw [Sun, 14 Feb 2010 13:37:14 +0000 (13:37 +0000)]
Whitespace fixes for r62402

14 years agoFollow-up r62358: Wrap warning message into a div with the generic "error" and a...
Raimond Spekking [Sun, 14 Feb 2010 11:36:40 +0000 (11:36 +0000)]
Follow-up r62358: Wrap warning message into a div with the generic "error" and a specific "mw-moveuserpage-warning" class

14 years agoFollow up r62436 comments.
Platonides [Sat, 13 Feb 2010 23:58:30 +0000 (23:58 +0000)]
Follow up r62436 comments.
s/Title::newFromUrl/Title::newFromURL/
All these usages should be reviewed. Make it easy to grep using the canonical form.
Additionally fix the typo.

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sat, 13 Feb 2010 19:20:32 +0000 (19:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-02-13 19:00 UTC)

14 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Sat, 13 Feb 2010 17:09:52 +0000 (17:09 +0000)]
Fixed some doxygen warnings

14 years agoFix for <poem> after r62416
Conrad Irwin [Sat, 13 Feb 2010 14:41:04 +0000 (14:41 +0000)]
Fix for <poem> after r62416

14 years agoparserTests.txt shall be opened in text mode.
Platonides [Sat, 13 Feb 2010 13:46:29 +0000 (13:46 +0000)]
parserTests.txt shall be opened in text mode.
Followup of r62006 which broke parser tests on windows (crlf line endings).

14 years agoDon't need to set time limit here, already did in setup(), memory_limit still needs...
Chad Horohoe [Sat, 13 Feb 2010 03:27:47 +0000 (03:27 +0000)]
Don't need to set time limit here, already did in setup(), memory_limit still needs calling this late, user might have overriden this in LocalSettings

14 years agoOutput page title along with no revisions (just like we do when there are revs to...
Chad Horohoe [Sat, 13 Feb 2010 02:56:18 +0000 (02:56 +0000)]
Output page title along with no revisions (just like we do when there are revs to import). Looks confusing seeing multiple "All revisions were previously imported" entries

14 years agoLocalisation updates Cantonese, Chinese and Literary Chinese
Shinjiman [Sat, 13 Feb 2010 02:33:39 +0000 (02:33 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese

14 years agoDrop ancient PHP4 wrapper for cloning, completely unused
Chad Horohoe [Sat, 13 Feb 2010 02:29:59 +0000 (02:29 +0000)]
Drop ancient PHP4 wrapper for cloning, completely unused

14 years agoDeprecate old undocumented workaround to bug 2257 (setTransparentTagHook)
Conrad Irwin [Sat, 13 Feb 2010 02:22:14 +0000 (02:22 +0000)]
Deprecate old undocumented workaround to bug 2257 (setTransparentTagHook)

14 years agoStylize API files
Sam Reed [Sat, 13 Feb 2010 01:41:37 +0000 (01:41 +0000)]
Stylize API files

14 years ago4 More dieUsage calls
Sam Reed [Sat, 13 Feb 2010 01:38:12 +0000 (01:38 +0000)]
4 More dieUsage calls

Bar some from ApiBase.. These are done..

14 years agoMove this to one line to add space back after period. If these is to be split into...
Aaron Schulz [Sat, 13 Feb 2010 01:37:29 +0000 (01:37 +0000)]
Move this to one line to add space back after period. If these is to be split into 2 lines, then the msg() call needs changing to display correctly.

14 years agodieUsage getPossibleErrors in ApiQuerySearch and ApiQueryRevisions
Sam Reed [Sat, 13 Feb 2010 01:28:26 +0000 (01:28 +0000)]
dieUsage getPossibleErrors in ApiQuerySearch and ApiQueryRevisions

14 years agoFix fail in ApiEditPage.php
Sam Reed [Sat, 13 Feb 2010 01:24:00 +0000 (01:24 +0000)]
Fix fail in ApiEditPage.php

14 years agoComplete dieUsage errors in 7 more Api files
Sam Reed [Sat, 13 Feb 2010 01:21:52 +0000 (01:21 +0000)]
Complete dieUsage errors in 7 more Api files

14 years agoComplete dieUsage errors in 6 more Api files
Sam Reed [Sat, 13 Feb 2010 01:05:14 +0000 (01:05 +0000)]
Complete dieUsage errors in 6 more Api files

14 years agoAnd an erroneous )
Sam Reed [Sat, 13 Feb 2010 00:50:45 +0000 (00:50 +0000)]
And an erroneous )

14 years agoRem erroneous bracket, followup to r62404
Sam Reed [Sat, 13 Feb 2010 00:49:53 +0000 (00:49 +0000)]
Rem erroneous bracket, followup to r62404

14 years agoImplement 9 modules dieUsage errors
Sam Reed [Sat, 13 Feb 2010 00:48:31 +0000 (00:48 +0000)]
Implement 9 modules dieUsage errors

14 years agoRest of dieUsageMsg in getPossibleErrors
Sam Reed [Sat, 13 Feb 2010 00:28:27 +0000 (00:28 +0000)]
Rest of dieUsageMsg in getPossibleErrors

14 years agoStart of blanket coverage of dieUsageMsg in getPossibleErrors
Sam Reed [Sat, 13 Feb 2010 00:09:05 +0000 (00:09 +0000)]
Start of blanket coverage of dieUsageMsg in getPossibleErrors

Only basic ones done.

Couple of other modules done manually

14 years ago* Truncate summary of page moves in revision comment field to avoid broken multibyte...
Raimond Spekking [Fri, 12 Feb 2010 21:45:14 +0000 (21:45 +0000)]
* Truncate summary of page moves in revision comment field to avoid broken multibyte characters
Example: http://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Meister_Eiskalt/Babel3&action=history

14 years agoFixed a doxygen warning
Alexandre Emsenhuber [Fri, 12 Feb 2010 21:37:22 +0000 (21:37 +0000)]
Fixed a doxygen warning

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Fri, 12 Feb 2010 19:47:22 +0000 (19:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-02-12 19:00 UTC)

14 years agoLocalization update for he.
Rotem Liss [Fri, 12 Feb 2010 19:07:46 +0000 (19:07 +0000)]
Localization update for he.

14 years agoRemove debug logging introduced in r62354
Siebrand Mazeland [Fri, 12 Feb 2010 14:09:42 +0000 (14:09 +0000)]
Remove debug logging introduced in r62354

14 years agosort of fixing bug 14592: show warning when moving a user page that the user will...
Tobias [Fri, 12 Feb 2010 11:40:41 +0000 (11:40 +0000)]
sort of fixing bug 14592: show warning when moving a user page that the user will not be renamed

14 years agovarious eol whitespace now instead of when someone needs to do CR
Mark A. Hershberger [Fri, 12 Feb 2010 06:44:16 +0000 (06:44 +0000)]
various eol whitespace now instead of when someone needs to do CR

14 years agoFinal(?) changes to enable chunked uploading.
Mark A. Hershberger [Fri, 12 Feb 2010 06:28:03 +0000 (06:28 +0000)]
Final(?) changes to enable chunked uploading.

14 years agoDon't format old_id ranges in scientific (%E) notation.
Tim Starling [Fri, 12 Feb 2010 05:17:12 +0000 (05:17 +0000)]
Don't format old_id ranges in scientific (%E) notation.

14 years ago(bug 17947) Use current date/time on Special:Preferences rather than Wikipedia day...
Chad Horohoe [Fri, 12 Feb 2010 01:12:52 +0000 (01:12 +0000)]
(bug 17947) Use current date/time on Special:Preferences rather than Wikipedia day. It has been pointed out that an arbitrary date can be confusing for users on a different calendar system. Wikipedia day is cute, but not useful.

14 years agoSimplification as per Bryan on r62339 comment
Sam Reed [Thu, 11 Feb 2010 23:09:38 +0000 (23:09 +0000)]
Simplification as per Bryan on r62339 comment

14 years agoCater for some more errors in ApiBase.php
Sam Reed [Thu, 11 Feb 2010 22:28:30 +0000 (22:28 +0000)]
Cater for some more errors in ApiBase.php

14 years agoRemove old/deprecated $this->getMain()->isWriteMode(); from ApiUpload
Sam Reed [Thu, 11 Feb 2010 22:25:31 +0000 (22:25 +0000)]
Remove old/deprecated $this->getMain()->isWriteMode(); from ApiUpload

14 years agoFix r62331 - If we renamed a method, we need to to it everywhere!
Sam Reed [Thu, 11 Feb 2010 22:22:20 +0000 (22:22 +0000)]
Fix r62331 - If we renamed a method, we need to to it everywhere!

14 years ago$this->mModuleName to $this->getModuleName()
Sam Reed [Thu, 11 Feb 2010 22:18:16 +0000 (22:18 +0000)]
$this->mModuleName to $this->getModuleName()

14 years agoUpdate code documentation with Bryans help for r62282 and r62331
Sam Reed [Thu, 11 Feb 2010 22:06:45 +0000 (22:06 +0000)]
Update code documentation with Bryans help for r62282 and r62331

14 years agoFollowup to bryans comment for r62328
Sam Reed [Thu, 11 Feb 2010 21:53:57 +0000 (21:53 +0000)]
Followup to bryans comment for r62328

Rename possibleErrors to getPossibleErrors

14 years agoMove mustBePosted error into messageMap
Sam Reed [Thu, 11 Feb 2010 21:51:15 +0000 (21:51 +0000)]
Move mustBePosted error into messageMap

Switch call to dieUsage to dieUsageMsg

14 years agoMore of bug 18771 - List possible errors in action=paraminfo
Sam Reed [Thu, 11 Feb 2010 21:34:35 +0000 (21:34 +0000)]
More of bug 18771 - List possible errors in action=paraminfo

Followup to comments of r62282

14 years agoLocalization update for he.
Rotem Liss [Thu, 11 Feb 2010 21:27:26 +0000 (21:27 +0000)]
Localization update for he.

14 years agoSimplify a bit per Platonides CR http://www.mediawiki.org/wiki/Special:Code/MediaWiki...
Raimond Spekking [Thu, 11 Feb 2010 21:21:22 +0000 (21:21 +0000)]
Simplify a bit per Platonides CR mediawiki.org/wiki/Special:Code/MediaWiki/61661#c5509

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Thu, 11 Feb 2010 19:52:38 +0000 (19:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-02-11 19:30 UTC)

14 years agoAnother MonoBook whitespace fix
Aryeh Gregor [Thu, 11 Feb 2010 17:28:19 +0000 (17:28 +0000)]
Another MonoBook whitespace fix

14 years agoWar on xml:lang
Aryeh Gregor [Thu, 11 Feb 2010 17:25:10 +0000 (17:25 +0000)]
War on xml:lang

There is no reason to use this in HTML in addition to the lang
attribute.  No spec requires it (AFAIK) and it's completely redundant.

14 years agoAvoid silly markup like <ul >
Aryeh Gregor [Thu, 11 Feb 2010 17:25:03 +0000 (17:25 +0000)]
Avoid silly markup like <ul >

14 years agoWhitespaces fixes
Alexandre Emsenhuber [Thu, 11 Feb 2010 14:57:43 +0000 (14:57 +0000)]
Whitespaces fixes

14 years agoindividual message cache entries should start with ' ', also in memcached
Emil Podlaszewski [Thu, 11 Feb 2010 14:17:22 +0000 (14:17 +0000)]
individual message cache entries should start with ' ', also in memcached

14 years agoImplement keys() for APCBagOStuff
Alexandre Emsenhuber [Thu, 11 Feb 2010 12:33:17 +0000 (12:33 +0000)]
Implement keys() for APCBagOStuff

14 years agoA script for doing full scans of the text table and presenting some resulting statist...
Tim Starling [Thu, 11 Feb 2010 11:49:19 +0000 (11:49 +0000)]
A script for doing full scans of the text table and presenting some resulting statistics about storage types.

14 years agoMake sure Firefogg gets the json it needs.
Mark A. Hershberger [Thu, 11 Feb 2010 06:14:15 +0000 (06:14 +0000)]
Make sure Firefogg gets the json it needs.

14 years agofollow-up r61355
Mark A. Hershberger [Thu, 11 Feb 2010 05:35:21 +0000 (05:35 +0000)]
follow-up r61355
Actually test UploadChunks code against Firefogg.  Uploads work, but
feedback on the Firefogg side seems not too.  Also, Firefogg makes a
complete upload, but then attempts more uploads.

14 years agoFix whitespace in Monobook output
Aryeh Gregor [Thu, 11 Feb 2010 02:14:43 +0000 (02:14 +0000)]
Fix whitespace in Monobook output

Lots of craziness here.  Mainly random or excessive indentation, and
missing newlines (the latter due to the fact that a newline after ?> is
dropped).  The HTML looks a lot prettier now.  There are still some
annoying bits like <ul > that could be fixed.

14 years agoStart implementation of bug 18771 - List possible errors in action=paraminfo
Sam Reed [Thu, 11 Feb 2010 01:13:45 +0000 (01:13 +0000)]
Start implementation of bug 18771 - List possible errors in action=paraminfo

Base has empty array() returning method, ApiBlock has implementation of possibleErrors from code above (possibly not complete)

Can be finished incrementally, so serves as a review point for Roan

14 years agoAdd comment for r62191
Aryeh Gregor [Wed, 10 Feb 2010 23:02:06 +0000 (23:02 +0000)]
Add comment for r62191

14 years agoMove some new features from the list of fixed bugs
Aryeh Gregor [Wed, 10 Feb 2010 21:56:59 +0000 (21:56 +0000)]
Move some new features from the list of fixed bugs

Follow-up to r62194.

14 years agoFixed some doxygen warnings
Alexandre Emsenhuber [Wed, 10 Feb 2010 21:42:31 +0000 (21:42 +0000)]
Fixed some doxygen warnings

14 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 10 Feb 2010 21:40:49 +0000 (21:40 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-02-09 21:30 UTC)

14 years agoFixed E_STRICT errors about method signatures not matching
Alexandre Emsenhuber [Wed, 10 Feb 2010 20:26:07 +0000 (20:26 +0000)]
Fixed E_STRICT errors about method signatures not matching

14 years agoRevert r62022: breaks tab order on section=new edits, see also CR.
Roan Kattouw [Wed, 10 Feb 2010 15:15:36 +0000 (15:15 +0000)]
Revert r62022: breaks tab order on section=new edits, see also CR.

14 years agoSome tweaks to edit.js to make currentFocused detection work in IE (was completely...
Roan Kattouw [Wed, 10 Feb 2010 13:19:21 +0000 (13:19 +0000)]
Some tweaks to edit.js to make currentFocused detection work in IE (was completely broken) and with the usability iframe. Will backport a simplified version to wmf-deployment shortly.

14 years agoshowLogExtract of block log on user (talk) pages of blocked users
Tobias [Wed, 10 Feb 2010 13:08:24 +0000 (13:08 +0000)]
showLogExtract of block log on user (talk) pages of blocked users

14 years agofollow-up r62231 Document FileRepo::append()
Mark A. Hershberger [Wed, 10 Feb 2010 11:08:39 +0000 (11:08 +0000)]
follow-up r62231 Document FileRepo::append()

14 years agoWhitespace fixes for r62195, remove out-of-context comment
Roan Kattouw [Wed, 10 Feb 2010 10:54:00 +0000 (10:54 +0000)]
Whitespace fixes for r62195, remove out-of-context comment

14 years agoFollowup r62231, reduce code duplication in $request->response()
Chad Horohoe [Wed, 10 Feb 2010 10:49:17 +0000 (10:49 +0000)]
Followup r62231, reduce code duplication in $request->response()

14 years agocommit changes to ApiSetup that are needed to make the
Mark A. Hershberger [Wed, 10 Feb 2010 10:47:02 +0000 (10:47 +0000)]
commit changes to ApiSetup that are needed to make the
chunked uploading tests work.

14 years ago* new FauxResponse class to help with unit testing
Mark A. Hershberger [Wed, 10 Feb 2010 10:36:11 +0000 (10:36 +0000)]
* new FauxResponse class to help with unit testing
* Add append() method to FileRepo classes to enable chunked uploading
* Change chunksessionkey to chunksession
* Remove echo json stuff
* Fix a multitude of bugs in my own code
* still to test: mwEmbed use of chunked upload

14 years agofollow-up r62164
Mark A. Hershberger [Wed, 10 Feb 2010 09:59:02 +0000 (09:59 +0000)]
follow-up r62164

14 years ago* Fix for r60163: in RC/RCL, hash together all the options, not just namespace, in...
Tim Starling [Wed, 10 Feb 2010 04:13:43 +0000 (04:13 +0000)]
* Fix for r60163: in RC/RCL, hash together all the options, not just namespace, in order to form the cache key.
* Removed Crb from the credits since none of his code remains.
* Fixed two bugs which both broke feed links on RCL: $this->mTargetTitle not initialised when setTopText() is called, and $out->setFeedAppendQuery() in setBottomText() overridden by a subsequent call to setSyndicated(). Fixed both by rearranging data flow, using memoized accessors instead of setup functions to eliminate bugs due to execution order.
* Renamed a few variables which were unclear ($feed and $feedObj).

14 years agoReduce code duplication in requires
Chad Horohoe [Wed, 10 Feb 2010 01:44:09 +0000 (01:44 +0000)]
Reduce code duplication in requires

14 years agoFollowup r62067, drop $wgUseNormalUser as un-needed
Chad Horohoe [Wed, 10 Feb 2010 01:43:18 +0000 (01:43 +0000)]
Followup r62067, drop $wgUseNormalUser as un-needed

14 years agoFix for r56885, r58364, r58364: use a two-part GROUP BY even on MySQL. The implicit...
Tim Starling [Wed, 10 Feb 2010 00:41:59 +0000 (00:41 +0000)]
Fix for r56885, r58364, r58364: use a two-part GROUP BY even on MySQL. The implicit sort shouldn't cause any problems here. Query runs without errors on MySQL (with or without ONLY_FULL_GROUP_BY), SQLite and PostgreSQL. The previous version in the non-MySQL case was plainly broken, see CR r58915.