lhc/web/wiklou.git
13 years agoRemoving the last occurrences/mentions of mw.loader.go
Krinkle [Wed, 25 May 2011 17:18:52 +0000 (17:18 +0000)]
Removing the last occurrences/mentions of mw.loader.go
* Follow-up r88125, r88790.
* Also cleaned up some comments to use the same uppercase/colon use as the rest of this file.

Search results: http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=202&hash=96029a8f5c6a5aaadc61767532e01571

13 years agoMove DB utility classes into own file
Sam Reed [Wed, 25 May 2011 17:06:04 +0000 (17:06 +0000)]
Move DB utility classes into own file

Updated AutoLoader to match

13 years agoMove DB(.*?)Error classes into own file
Sam Reed [Wed, 25 May 2011 17:03:15 +0000 (17:03 +0000)]
Move DB(.*?)Error classes into own file

Updated AutoLoader to match

13 years agoFix undefined variable from r39635
Sam Reed [Wed, 25 May 2011 16:14:59 +0000 (16:14 +0000)]
Fix undefined variable from r39635

13 years agoFollowup r87468: remove refs to CleanUpTest from Makefile
Chad Horohoe [Wed, 25 May 2011 15:59:30 +0000 (15:59 +0000)]
Followup r87468: remove refs to CleanUpTest from Makefile

13 years agoMisc EOL w/s and spaces-instead-of-tabs fixes. One day I'll get around to nagging...
Mark A. Hershberger [Wed, 25 May 2011 15:39:47 +0000 (15:39 +0000)]
Misc EOL w/s and spaces-instead-of-tabs fixes.  One day I'll get around to nagging people for this stuff, but for now, I'll JFDI myself.

13 years agoFix syntax error in r88794
Roan Kattouw [Wed, 25 May 2011 15:28:21 +0000 (15:28 +0000)]
Fix syntax error in r88794

13 years agoFixes Bug #29133: “Special:PasswordReset button text not i18n-able” by
Mark A. Hershberger [Wed, 25 May 2011 15:19:38 +0000 (15:19 +0000)]
Fixes Bug #29133: “Special:PasswordReset button text not i18n-able” by
adding the alterForm() method to set the submit button text.

13 years agoUse $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order...
Roan Kattouw [Wed, 25 May 2011 15:19:16 +0000 (15:19 +0000)]
Use $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order. This means mw.util.jpegmeta doesn't depend on mw.util loading first any more

13 years agoFix r88125: forgot to remove another call to mw.loader.go()
Roan Kattouw [Wed, 25 May 2011 14:16:21 +0000 (14:16 +0000)]
Fix r88125: forgot to remove another call to mw.loader.go()

13 years ago* Follow-up r88740:
Aaron Schulz [Wed, 25 May 2011 10:11:06 +0000 (10:11 +0000)]
* Follow-up r88740:
* Fixed parse() arguments in getRevIncludes()
* Changed clearTagHook() to avoid preprocessed-xml cache corruption
* Check current version cache in getRevIncludes()

13 years agoFinish r88768, *ahem*
Aaron Schulz [Wed, 25 May 2011 05:26:54 +0000 (05:26 +0000)]
Finish r88768, *ahem*

13 years agoWorkaround for duplicate key errors
Chad Horohoe [Wed, 25 May 2011 00:49:51 +0000 (00:49 +0000)]
Workaround for duplicate key errors

13 years agoExtend MediaWikiTestCase in a few places
Chad Horohoe [Wed, 25 May 2011 00:30:06 +0000 (00:30 +0000)]
Extend MediaWikiTestCase in a few places

13 years ago* Changed @ => wfSuppressWarnings
Aaron Schulz [Wed, 25 May 2011 00:25:29 +0000 (00:25 +0000)]
* Changed @ => wfSuppressWarnings
* Added wfSuppressWarnings to Bitmap.php:
Notice: unserialize(): Error at offset 0 of 2 bytes in D:\www\MW_trunk\phase3\includes\media\Bitmap.php on line 685

13 years agoDon't generate the footer div if there isn't any footer link.
Platonides [Tue, 24 May 2011 22:56:42 +0000 (22:56 +0000)]
Don't generate the footer div if there isn't any footer link.
Removed blank line between the <li>s of $validFooterLinks

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Tue, 24 May 2011 21:34:27 +0000 (21:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-24 20:59:00 UTC)

13 years agoFixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST.
Chad Horohoe [Tue, 24 May 2011 21:22:36 +0000 (21:22 +0000)]
Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST.
Now just create them on the first test that needsDB() and skip creation on the rest.
Leaves you with a bunch of useless tables at the end of a run, but oh well at least its faster :)

13 years ago* (bug 29116) Fix regression breaking CheckUser extension
Brion Vibber [Tue, 24 May 2011 21:04:50 +0000 (21:04 +0000)]
* (bug 29116) Fix regression breaking CheckUser extension

Fixes regression from r84475 and friends which made Block->load() and its new front-end Block::newFromTarget() fail when an empty string was passed in as the IP / $vagueTarget parameter to indicate skipping IP-based lookups.
Added phpunit test cases to confirm that both Block->load() and Block::newFromTarget() work when given null (already ok), '' (as done from CheckUser), or false (not seen, but perfectly legit sounding).
Adjusted comparisons to work as expected.

13 years agoFollow-up r88740: forgot to commit this guy
Aaron Schulz [Tue, 24 May 2011 19:52:27 +0000 (19:52 +0000)]
Follow-up r88740: forgot to commit this guy

13 years ago(bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTar...
Happy-melon [Tue, 24 May 2011 19:03:41 +0000 (19:03 +0000)]
(bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget().

13 years agor88734 followup: pretty up the doc link added to qunit test result page; per Krinkle...
Brion Vibber [Tue, 24 May 2011 18:50:43 +0000 (18:50 +0000)]
r88734 followup: pretty up the doc link added to qunit test result page; per Krinkle's suggestion moved it into the qunit toolbar div and it's much happier :D

13 years agoAdd quick and dirty link to http://www.mediawiki.org/wiki/Manual:JavaScript_unit_test...
Brion Vibber [Tue, 24 May 2011 18:41:26 +0000 (18:41 +0000)]
Add quick and dirty link to mediawiki.org/wiki/Manual:JavaScript_unit_testing from the qunit runner page
It's not styled; qunit result styles are entirely id-based for some reason so you can't just add a div or p with matching style.

13 years agoadd a @fixme comment about toggleToc test case: doesn't actually test if the function...
Brion Vibber [Tue, 24 May 2011 18:35:30 +0000 (18:35 +0000)]
add a @fixme comment about toggleToc test case: doesn't actually test if the function works, just confirms that it exists.

13 years agoIntroduced Maintenance::getDB() and corresponding setDB() to control externally what...
Max Semenik [Tue, 24 May 2011 17:48:22 +0000 (17:48 +0000)]
Introduced Maintenance::getDB() and corresponding setDB() to control externally what database object should be used by maintenance script. Currently used by updater to avoid DatabaseSqliteTest from running stuff like Populate* on the live database instead of the one used for testing.

13 years agoSimplify message existence checks by using wfMessage() instead of wfEmptyMsg()
Alexandre Emsenhuber [Tue, 24 May 2011 17:28:21 +0000 (17:28 +0000)]
Simplify message existence checks by using wfMessage() instead of wfEmptyMsg()

13 years agoReverting r88607. This downgrades jQuery from 1.5.2 back to 1.4.4.
Krinkle [Tue, 24 May 2011 16:52:28 +0000 (16:52 +0000)]
Reverting r88607. This downgrades jQuery from 1.5.2 back to 1.4.4.
* The main reason being the problems with $.ajax that arose in UploadWizard (as remarked on wikitech-l).
* My plan is to take the following week (or two) to talk a bit about JavaScript unit testing and how we plan to do distributed continuous integration testing for it. After that we could upgrade right to 1.6.1
* See also bug 28904 and "[Wikitech-l] Any issues with pending jQuery 1.6.1 update on trunk?"

13 years agoFixed api=compare example to use existing parameters
Alexandre Emsenhuber [Tue, 24 May 2011 16:16:00 +0000 (16:16 +0000)]
Fixed api=compare example to use existing parameters

13 years ago* (bug 29120) ApiQueryLogEvents: let letype accept multiple values
Sam Reed [Tue, 24 May 2011 16:04:03 +0000 (16:04 +0000)]
* (bug 29120) ApiQueryLogEvents: let letype accept multiple values

Description already hinted at multiple

13 years ago* (bug 29107) Fix regression in ResourceLoader debug mode for WikiEditor
Brion Vibber [Tue, 24 May 2011 00:42:42 +0000 (00:42 +0000)]
* (bug 29107) Fix regression in ResourceLoader debug mode for WikiEditor

One of WikiEditor's modules had only messages, no scripts; updates to the debug mode loader had ended up failing in the case where no scripts got passed in (if passed with a loader function we were fine, hence non-debug mode being ok)
This commit explicitly checks for the empty-array case and marks the module as ready immediately, instead of waiting for the last item in the loop to finish, which never happens. :)

Also consolidated three calls to the same few lines of code into a lambda function.

13 years agoRewriting mw.loader test suite. The previous one didn't work properly in IE6-IE8.
Krinkle [Tue, 24 May 2011 00:21:42 +0000 (00:21 +0000)]
Rewriting mw.loader test suite. The previous one didn't work properly in IE6-IE8.

13 years agoRemoving tests for no longer existing methods (Follow-up r88667). Should calm down...
Krinkle [Mon, 23 May 2011 22:35:51 +0000 (22:35 +0000)]
Removing tests for no longer existing methods (Follow-up r88667). Should calm down TestSwarm.

13 years agoFollow-up to r88667; finish reverting bogus test cases from r87964. It looks like...
Brion Vibber [Mon, 23 May 2011 20:24:09 +0000 (20:24 +0000)]
Follow-up to r88667; finish reverting bogus test cases from r87964. It looks like these cases need to be re-added, but correctly; for instance getLocalUrl() **DOES NOT** return something in $wgArticlePath space when an action is given that's not view. It **MUST** return the matching $wgActionPath or else use $wgScript directly, to ensure that URL structuring rules & security rules are followed.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Mon, 23 May 2011 20:06:24 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-23 19:53:00 UTC)

13 years agoSpace cadet\!
Russ Nelson [Mon, 23 May 2011 19:53:49 +0000 (19:53 +0000)]
Space cadet\!

13 years agoMoved wfEmptyMsg() near other message functions
Alexandre Emsenhuber [Mon, 23 May 2011 19:42:00 +0000 (19:42 +0000)]
Moved wfEmptyMsg() near other message functions

13 years agoMoving check higher up in case there's a premade toggle _but_ no .wm-collapsible...
Krinkle [Mon, 23 May 2011 19:08:26 +0000 (19:08 +0000)]
Moving check higher up in case there's a premade toggle _but_ no .wm-collapsible-content premade. This way the link will be caught before it's inner-wrapped, after which it would no longer be a direct child.

13 years agoRevert r87964: destroyed standard segregation of non-view action links outside of...
Brion Vibber [Mon, 23 May 2011 19:03:17 +0000 (19:03 +0000)]
Revert r87964: destroyed standard segregation of non-view action links outside of $wgArticlePath, which would have created huge extra search spider traffic to sites and put more bogus URLs into indexes.

This also reverts some convenience functions that were being added at the same time (??) to attempt to parse local links from JS.

13 years agoFollow-up r85403: rm unwanted "new" declaration.
Happy-melon [Mon, 23 May 2011 18:57:30 +0000 (18:57 +0000)]
Follow-up r85403: rm unwanted "new" declaration.

13 years agoFollow-up r84475: Block::parseTarget() should always return an array.
Happy-melon [Mon, 23 May 2011 18:52:36 +0000 (18:52 +0000)]
Follow-up r84475: Block::parseTarget() should always return an array.

13 years agoFollow-up r84475: update userBlockedMessage() caller.
Happy-melon [Mon, 23 May 2011 18:49:14 +0000 (18:49 +0000)]
Follow-up r84475: update userBlockedMessage() caller.

13 years agoUse $act instead of a second call to $this->getAction()
Alexandre Emsenhuber [Mon, 23 May 2011 17:55:26 +0000 (17:55 +0000)]
Use $act instead of a second call to $this->getAction()

13 years agoFollow-up r88653: removed the remaining of OutputPage's stubbing
Alexandre Emsenhuber [Mon, 23 May 2011 17:53:31 +0000 (17:53 +0000)]
Follow-up r88653: removed the remaining of OutputPage's stubbing

13 years ago* (bug 29117) A string is missing when the UI is in Hebrew
Sam Reed [Mon, 23 May 2011 17:52:37 +0000 (17:52 +0000)]
* (bug 29117) A string is missing when the UI is in Hebrew

13 years agoPer comment on r87680: make parser tests work again.
Alexandre Emsenhuber [Mon, 23 May 2011 17:22:14 +0000 (17:22 +0000)]
Per comment on r87680: make parser tests work again.
Can somebody explain me why on earth do we need ParserTest::setUp() since all of this is done before each test in ParserTest::setupGlobals()?

13 years agoexit -> return now that we are in a function
Alexandre Emsenhuber [Mon, 23 May 2011 16:37:56 +0000 (16:37 +0000)]
exit -> return now that we are in a function

13 years ago* Simplify message existence checks by using wfMessage() instead of wfMsg() with...
Alexandre Emsenhuber [Mon, 23 May 2011 16:32:52 +0000 (16:32 +0000)]
* Simplify message existence checks by using wfMessage() instead of wfMsg() with wfEmptyMsg()
* Fixed one check in Skin::addToSidebarPlain() that used user language for existence and content language for message's content
* Changed SkinTemplate::buildContentNavigationUrls() to use Title::getDefaultMessageText() instead of wfEmptyMsg()

13 years ago* In core:
Aaron Schulz [Mon, 23 May 2011 04:28:58 +0000 (04:28 +0000)]
* In core:
** Added hooks for custom RC/newpages filters
** Added tables,fields,and join_conds to SpecialNewPagesConditions hook
** Removed superflous $nameSpace logic in watchlist code
** Removed some copy-paste code for RC/watchlist filters
** Updates hooks.txt
* In FlaggedRevs:
* Added "hide reviewed edits" filter to RC/newpages
* Combined two handlers into modifyChangesListQuery. Removed is_array() check - always true now.
* Fixed onBeforePageDisplay() so that CSS worked on sp:Watchlist
* @TODO: remove $wgUseRCPatrol stuff...this gets us closer.

13 years agoFill-in missing implementations of abstract function appendFinish()
Russ Nelson [Mon, 23 May 2011 02:30:20 +0000 (02:30 +0000)]
Fill-in missing implementations of abstract function appendFinish()

13 years agoAdded missing getUser() function to Pager:
Aaron Schulz [Mon, 23 May 2011 01:47:39 +0000 (01:47 +0000)]
Added missing getUser() function to Pager:
Fatal error: Call to undefined method NewPagesPager::getUser() in D:\www\MW_trunk\phase3\includes\specials\SpecialNewpages.php on line 491

13 years agoSwift needs to rewrite entire files. We need this call to prevent N**2 operations...
Russ Nelson [Mon, 23 May 2011 01:18:06 +0000 (01:18 +0000)]
Swift needs to rewrite entire files. We need this call to prevent N**2 operations while appending

13 years agoRelease notes for r88625, r88553, r88511 (bringing back 'Other changes' like in REL1_...
Krinkle [Mon, 23 May 2011 00:01:06 +0000 (00:01 +0000)]
Release notes for r88625, r88553, r88511 (bringing back 'Other changes' like in REL1_17 release notes)

13 years agojquery.tabIndex.js was broken, not it works (for the first time?)
Krinkle [Sun, 22 May 2011 23:52:16 +0000 (23:52 +0000)]
jquery.tabIndex.js was broken, not it works (for the first time?)
* Defaulting to null
* Setting to initial value during first iteration (instead of outside the loop), that way we dont have to set minTabIndex to some insane high value to let if (  .. > .. ) work
* (bug 29048) jQuery.tabIndex: firstTabIndex() outputs the same as lastTabIndex()
* Added extra <textarea> to test suite to make sure the 'correct answer' is not the first or last element

13 years agoRevert unintended change in r88620
Platonides [Sun, 22 May 2011 23:36:17 +0000 (23:36 +0000)]
Revert unintended change in r88620

13 years agoAdding test suite for jquery.tabIndex.js, currently broken per:
Krinkle [Sun, 22 May 2011 23:36:17 +0000 (23:36 +0000)]
Adding test suite for jquery.tabIndex.js, currently broken per:
(bug 29048) jQuery.tabIndex: firstTabIndex() outputs the same as lastTabIndex()

13 years agoUse doc comment
Platonides [Sun, 22 May 2011 23:24:56 +0000 (23:24 +0000)]
Use doc comment

13 years ago* (bug 29101) Special:FileDuplicateSearch shows silly message
Sam Reed [Sun, 22 May 2011 23:20:59 +0000 (23:20 +0000)]
* (bug 29101) Special:FileDuplicateSearch shows silly message

Patch by William Demchick

13 years ago/* to /**
Platonides [Sun, 22 May 2011 22:10:08 +0000 (22:10 +0000)]
/* to /**

13 years agoChanges to doc-comments. /* to /** in language folder.
Platonides [Sun, 22 May 2011 22:05:18 +0000 (22:05 +0000)]
Changes to doc-comments. /* to /** in language folder.

13 years agoUpdate our jQuery from 1.4.4 to the latest version of 1.5 (1.5.2). See also bug 28904.
Krinkle [Sun, 22 May 2011 21:54:32 +0000 (21:54 +0000)]
Update our jQuery from 1.4.4 to the latest version of 1.5 (1.5.2). See also bug 28904.

13 years ago* (bug 28272) Special:Allmessages should have only one "Go" button
Sam Reed [Sun, 22 May 2011 19:21:22 +0000 (19:21 +0000)]
* (bug 28272) Special:Allmessages should have only one "Go" button

Patch by MZMcBride

13 years agoMoved MediaWiki::articleFromTitle() to Article::newFromTitle(), this has nothing...
Alexandre Emsenhuber [Sun, 22 May 2011 18:38:04 +0000 (18:38 +0000)]
Moved MediaWiki::articleFromTitle() to Article::newFromTitle(), this has nothing to do in the MediaWiki class

13 years ago$wgArticle ain't needed here either ;) (followup r88588)
Chad Horohoe [Sun, 22 May 2011 18:05:17 +0000 (18:05 +0000)]
$wgArticle ain't needed here either ;) (followup r88588)

13 years ago$wgArticle is deprecated! Possible removal in 1.20 or 1.21!
Chad Horohoe [Sun, 22 May 2011 17:59:47 +0000 (17:59 +0000)]
$wgArticle is deprecated! Possible removal in 1.20 or 1.21!
* Encapsulate index.php in wfIndexMain() (similar to r77873)
* Kill $wgArticle check in Exception, not necessary anymore
* Kill $wgArticle in Setup, also not necessary
* Add angry note about $wgArticle to rebuildFileCache.
* Remove note about $wgArticle in Parser since it's dying anyway

13 years agoJust throw an exception, rather than calling wfDie()
Chad Horohoe [Sun, 22 May 2011 17:57:29 +0000 (17:57 +0000)]
Just throw an exception, rather than calling wfDie()

13 years agoAdding fixme note for bug 29088.
Krinkle [Sun, 22 May 2011 10:40:57 +0000 (10:40 +0000)]
Adding fixme note for bug 29088.

13 years agoSimplify a bit message existence checks, and also check existence of grouppage-*...
Alexandre Emsenhuber [Sun, 22 May 2011 08:41:24 +0000 (08:41 +0000)]
Simplify a bit message existence checks, and also check existence of grouppage-* messages in content language

13 years agoHighlighting breaking change
Krinkle [Sun, 22 May 2011 08:33:34 +0000 (08:33 +0000)]
Highlighting breaking change

13 years agoUse wfMessage() so that we can check message existence in content language instead...
Alexandre Emsenhuber [Sun, 22 May 2011 08:24:07 +0000 (08:24 +0000)]
Use wfMessage() so that we can check message existence in content language instead of user language

13 years agoFollow-up r88554: Passing null for now, fixed php error about missing arguments.
Krinkle [Sat, 21 May 2011 23:41:41 +0000 (23:41 +0000)]
Follow-up r88554: Passing null for now, fixed php error about missing arguments.

13 years agoReport importDump to subclass Maintenance
Chad Horohoe [Sat, 21 May 2011 23:22:47 +0000 (23:22 +0000)]
Report importDump to subclass Maintenance

13 years agoPassing token paremeter in mw.action.watch.ajax since this is required as of r88522.
Krinkle [Sat, 21 May 2011 23:14:53 +0000 (23:14 +0000)]
Passing token paremeter in mw.action.watch.ajax since this is required as of r88522.

Follow-up: r88511, r88522, r88527, r88553

13 years agoAdding user.tokens module and loading by default. (ResourceLoaderUserTokensModule...
Krinkle [Sat, 21 May 2011 22:52:32 +0000 (22:52 +0000)]
Adding user.tokens module and loading by default. (ResourceLoaderUserTokensModule Class)

13 years agoChanging float to text-align for conveniencelinks and editreasons links. Since headin...
Krinkle [Sat, 21 May 2011 21:05:55 +0000 (21:05 +0000)]
Changing float to text-align for conveniencelinks and editreasons links. Since headings have overflow:hidden this is causing the border to stop when this block is touched (atleast in Chrome/Safari), since headings don't clear float. This doesn't have to be a float from what I can see and is better done as text-align so that any later elements on the page will not be affected by the page flow.
Remove the line from Vector's main.css since it was already in shared.css

13 years agoQuick unbreak r88495: initialising the variable caused it not to be filled with messages
Niklas Laxström [Sat, 21 May 2011 20:39:31 +0000 (20:39 +0000)]
Quick unbreak r88495: initialising the variable caused it not to be filled with messages

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sat, 21 May 2011 20:30:39 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-21 20:20:00 UTC)

13 years agoPutting debughtml after visualClear in Vector skin. Messed up Special:UserLogin ...
Krinkle [Sat, 21 May 2011 20:06:58 +0000 (20:06 +0000)]
Putting debughtml after visualClear in Vector skin. Messed up Special:UserLogin (debug starts to the right of the form. Doesn't affect other skins.

13 years agoMore documentation updates and additions
Sam Reed [Sat, 21 May 2011 20:06:57 +0000 (20:06 +0000)]
More documentation updates and additions

Getting bored of this tonight now I think...

13 years agoLots more documentation lines to MagicWord
Sam Reed [Sat, 21 May 2011 19:55:05 +0000 (19:55 +0000)]
Lots more documentation lines to MagicWord

13 years agoMore documentation tweaks and updates
Sam Reed [Sat, 21 May 2011 19:54:24 +0000 (19:54 +0000)]
More documentation tweaks and updates

13 years agoFollow-up r88527: Fix array item name
Krinkle [Sat, 21 May 2011 19:46:32 +0000 (19:46 +0000)]
Follow-up r88527: Fix array item name

13 years agoMore comment updates, addition of some braces also
Sam Reed [Sat, 21 May 2011 19:36:03 +0000 (19:36 +0000)]
More comment updates, addition of some braces also

13 years agoFix function level comments that start with /* not /**
Sam Reed [Sat, 21 May 2011 19:35:16 +0000 (19:35 +0000)]
Fix function level comments that start with /* not /**

13 years agoMore documentation
Sam Reed [Sat, 21 May 2011 19:22:01 +0000 (19:22 +0000)]
More documentation

Addition of spaces according to our coding style guidelines

13 years agoMore adding, updating and tweaking of documentation
Sam Reed [Sat, 21 May 2011 19:07:24 +0000 (19:07 +0000)]
More adding, updating and tweaking of documentation

13 years agoFixing mediawiki.action.watch.ajax
Krinkle [Sat, 21 May 2011 18:33:48 +0000 (18:33 +0000)]
Fixing mediawiki.action.watch.ajax
* Adding error capturing in case there is an error (either in the API or with the request itself). Right now if it fails it just keeps reading "Watching..." and no error is displayed.
This lack became visible when r88522 changed ApiWatch to require a token and POST.
* Added message 'watcherrortext'.
* Moved messages-array in Resources.php form legacy.ajax to action.watch.ajax (looks like this was forgotten in r78147)
* Switched it to make a POST request in preparation of making it work with the changed API backend as of r88522.

13 years ago* (bug 29047) Follow-up r86508, update RELEASE-NOTES entry
Alexandre Emsenhuber [Sat, 21 May 2011 18:32:18 +0000 (18:32 +0000)]
* (bug 29047) Follow-up r86508, update RELEASE-NOTES entry

13 years agoFixup/add documentation
Sam Reed [Sat, 21 May 2011 17:45:20 +0000 (17:45 +0000)]
Fixup/add documentation

Remove trailing whitespace

13 years agowfDeprecated() plus doc update
Chad Horohoe [Sat, 21 May 2011 17:20:12 +0000 (17:20 +0000)]
wfDeprecated() plus doc update

13 years ago* (bug 29070) Add token to action=watch
Sam Reed [Sat, 21 May 2011 16:38:40 +0000 (16:38 +0000)]
* (bug 29070) Add token to action=watch

13 years agoFollow-up r88513: /me blames Chrome for ignoring trailing comma's in object notation
Krinkle [Sat, 21 May 2011 12:27:24 +0000 (12:27 +0000)]
Follow-up r88513: /me blames Chrome for ignoring trailing comma's in object notation

13 years agoAdding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js
Krinkle [Sat, 21 May 2011 11:26:27 +0000 (11:26 +0000)]
Adding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js
* Moving wiki* functions together in mediawiki.util.js
* Adding Adding mw.util.wikiScript (like wfScript() in GlobalFunctions.php)
* Adding test suite for it
* Example to use it in mediawiki.action.watch.ajax.js
* (bug 29071) mediawiki.action.watch.ajax.js doesn't use uselang

13 years agoRemoving wgAjaxWatch javascript global object.
Krinkle [Sat, 21 May 2011 11:06:52 +0000 (11:06 +0000)]
Removing wgAjaxWatch javascript global object.
* Not in use anywhere in /trunk: http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=199&hash=b56d9bd81e14ebca5e02ce7cbc19c2b6#F5 (never has been from what I can remember)
* Wrapping in an IIFE instead with local variables.
* Removed unused "supported" variable (it was declared and then checked to see if it's false), jQuery takes care of this in $.ajax (through $.getJSON etc.)

13 years agoqunit: add some tests for getActionFrom / getTitleFrom
Antoine Musso [Sat, 21 May 2011 09:27:17 +0000 (09:27 +0000)]
qunit: add some tests for getActionFrom / getTitleFrom

fu r88276

13 years agoFix the mw.loader when running test with a file:// URL
Antoine Musso [Sat, 21 May 2011 09:16:59 +0000 (09:16 +0000)]
Fix the mw.loader when running test with a file:// URL

When running the tests using a local url, the href will include index.html
which was not stripped by the regular expression.  This patch capture path
tokens which are not followed by 'index.html' (regexp lookahead).

Let us run tests using file://path/tests/qunit/index.html

13 years ago(bug 29031) When translating block log entries, indefinite, infinite, and
Brian Wolff [Sat, 21 May 2011 03:41:16 +0000 (03:41 +0000)]
(bug 29031) When translating block log entries, indefinite, infinite, and
infinity are now considered the same.

Before it just looked at the translations of the options for the drop down on
special:block, now it still does that, but if that fails, and the string
is infinite/indefinite/infinity, it will also check for the synonyms.

13 years agor88502 tabs, not spaces.
Mark A. Hershberger [Sat, 21 May 2011 00:15:14 +0000 (00:15 +0000)]
r88502 tabs, not spaces.

13 years agoTrial commit to fix bug #29043: “The 'Contents box' in the "Printable version" render...
Mark A. Hershberger [Sat, 21 May 2011 00:02:00 +0000 (00:02 +0000)]
Trial commit to fix bug #29043: “The 'Contents box' in the "Printable version" rendering is stupid”

Other people should try my patch and see if they agree that printing the
contents box on paper is stupid.  Just commenting on the bug with your
opinion would be helpful.

13 years agoPatch for Bug #29040, “Web installer fails to show help boxes”
Mark A. Hershberger [Fri, 20 May 2011 23:36:26 +0000 (23:36 +0000)]
Patch for Bug #29040, “Web installer fails to show help boxes”
fix from William Demchick

13 years agoFollowup r88118. Fix Bug 28979 — “remove some CSS for abbr and acronym
Mark A. Hershberger [Fri, 20 May 2011 22:27:05 +0000 (22:27 +0000)]
Followup r88118. Fix Bug 28979 — “remove some CSS for abbr and acronym
tags”
Add missing fix for monobook.