lhc/web/wiklou.git
11 years agoUpdated profiling table definition.
freakolowsky [Sun, 26 May 2013 10:14:58 +0000 (12:14 +0200)]
Updated profiling table definition.

Change-Id: I20e92f2bc9b57a9c06cbcdfd30370fedf3c0e2f7

11 years ago[JobQueue] Allow using gzip on larger jobs in JobQueueRedis.
Aaron Schulz [Wed, 1 May 2013 03:00:20 +0000 (20:00 -0700)]
[JobQueue] Allow using gzip on larger jobs in JobQueueRedis.

Change-Id: I74ebdcfa0d3f2bcdc429394f7873fa25b7eb0f58

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sun, 26 May 2013 08:40:58 +0000 (08:40 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ie17b0ec177b58826a9fa3e8131d29ffdb75dc8dd

11 years agoEnsure title in NS_FILE before showing archived file
Kevin Israel [Sun, 26 May 2013 01:27:56 +0000 (21:27 -0400)]
Ensure title in NS_FILE before showing archived file

Avoid an MWException "X is not a valid file title." with invalid
input such as index.php?title=Special:Undelete&title=X&file=Y .

Change-Id: Ie915726fdde8e772a63713d3eb9da232d9fd83bd

11 years agoMerge "Rename $usableSkins to $allowedSkins"
jenkins-bot [Sat, 25 May 2013 11:22:57 +0000 (11:22 +0000)]
Merge "Rename $usableSkins to $allowedSkins"

11 years agoRename $usableSkins to $allowedSkins
Waldir Pimenta [Sat, 25 May 2013 11:10:34 +0000 (12:10 +0100)]
Rename $usableSkins to $allowedSkins

This change is entirely in local scope.
The function is still called getUsableSkins()
so this change won't break anything.
But the variable name and the updated documentation comment
make it clearer what the purpose of this function is,
for anyone reading the code or reading the autogenerated docs.

This change also includes minor changes to documentation
in skin-related files (typos and small edits for clarity).

Change-Id: I4220408f4d3b64cf87be4ad1af4b72d3a4524922

11 years agoMerge "Patrol overhaul phase 1: Remove rcid parameters"
jenkins-bot [Sat, 25 May 2013 10:08:50 +0000 (10:08 +0000)]
Merge "Patrol overhaul phase 1: Remove rcid parameters"

11 years agoPatrol overhaul phase 1: Remove rcid parameters
Marius Hoch [Sat, 29 Dec 2012 02:53:18 +0000 (03:53 +0100)]
Patrol overhaul phase 1: Remove rcid parameters

I've changed the logic in Article::showPatrolFooter to be able
to fetch the recent changes id and to only show the patrol link
in case the change hasn't yet been patrolled.

In case recentchanges patrolling is enabled this will try to
create a patrol link for the revision the user is currently
viewing. If only new page patrolling is enabled it tries to
create a patrol link for the first revision of the page.

Furthermore I've removed the passing around of &rcid parameters
within MediaWiki as those had several issues (some even security
related) and were only a workaround to protect the DB from some
queries, which is no longer needed.

This has already been partly implemented in a different manner in
r45778 but had to be reverted in r46542 due to performance issues.
This version shouldn't cause such issues as I'm only adding one or
two indexed database queries per page view.

I've written this new version of the patch with mostly
performance in mind and even tested the database queries it uses
against the replicated databases of enwiki on the toolserver. I'm
pretty sure this can't be implemented any faster without creating
a new index on the recentchanges table.

As I was on it I've implemented RecentChange::isInRCLifespan which
checks whether the given timestamp is new enough to may have a RC
row. That way we can avoid some DB queries for timestamps which are
older than the max RC age.

Fixes bugs:
(bug 15936) New page's patrol button should always be visible
(bug 35810) ! N pages non-patrol-able
(bug 36641) Patrol page link shows on non-existent revs

Change-Id: I1e24733cafbfdc51b7a5a9a1c1baf948e760fe1a

11 years agoMerge "Remove 'SkinTemplateTabs' from docs/hooks.txt"
jenkins-bot [Sat, 25 May 2013 08:40:30 +0000 (08:40 +0000)]
Merge "Remove 'SkinTemplateTabs' from docs/hooks.txt"

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Sat, 25 May 2013 08:31:38 +0000 (08:31 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Sat, 25 May 2013 08:18:55 +0000 (08:18 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I95c3d4327c845da676a4f646e5ffaa925d453a0b

11 years agoMerge "Set context when using UserrightsPage"
jenkins-bot [Sat, 25 May 2013 07:59:47 +0000 (07:59 +0000)]
Merge "Set context when using UserrightsPage"

11 years agoRemove 'SkinTemplateTabs' from docs/hooks.txt
Kevin Israel [Sat, 25 May 2013 03:50:26 +0000 (23:50 -0400)]
Remove 'SkinTemplateTabs' from docs/hooks.txt

According to online documentation: "This feature was removed completely
in version 1.18.0."

Change-Id: I410dce8b04ff788cd6573b3b11fd56ce41a96395

11 years agoMerge "displaytitle: reject some CSS if $wgRestrictDisplayTitle set"
jenkins-bot [Fri, 24 May 2013 21:19:46 +0000 (21:19 +0000)]
Merge "displaytitle: reject some CSS if $wgRestrictDisplayTitle set"

11 years agoMerge "Reset the error string in LoadBalancer::getConnection() to avoid it crufting...
jenkins-bot [Fri, 24 May 2013 20:52:50 +0000 (20:52 +0000)]
Merge "Reset the error string in LoadBalancer::getConnection() to avoid it crufting up."

11 years agoMerge "Added a --profiler option to all maintenance scripts."
jenkins-bot [Fri, 24 May 2013 20:48:56 +0000 (20:48 +0000)]
Merge "Added a --profiler option to all maintenance scripts."

11 years agoFixed misleading @since tag.
Aaron Schulz [Fri, 24 May 2013 20:00:59 +0000 (13:00 -0700)]
Fixed misleading @since tag.

Change-Id: Ief77172a286ffb98389b22968296217d37dac35f

11 years agoPreferences: Add link to user contributions on value of "Number of edits".
Michał Zieliński [Fri, 24 May 2013 19:04:52 +0000 (21:04 +0200)]
Preferences: Add link to user contributions on value of "Number of edits".

Bug: 43637
Change-Id: I10a662051fc23ff007b8749c4dc46a4b53a7f4bd

11 years agoActually update $lastTime in runJobs.php
Aaron Schulz [Wed, 22 May 2013 23:26:46 +0000 (16:26 -0700)]
Actually update $lastTime in runJobs.php

Change-Id: Ic51b0941aa72f444b1bad919e6a05ff0ba273ce7

11 years agoApply default robot policy for non-existing user pages
umherirrender [Fri, 24 May 2013 14:17:12 +0000 (16:17 +0200)]
Apply default robot policy for non-existing user pages

MediaWiki is sending HTTP 200 for every user page, this can result in
search engine indexing user pages with block hint. This is not happen,
when the page exists (even it is empty), so applying the default robot
policy also for non-existing user pages to avoid this.

Change-Id: Ia62b977b3488d6b002c7b129d9308b7887e4f42d

11 years agoSet context when using UserrightsPage
umherirrender [Fri, 24 May 2013 13:58:54 +0000 (15:58 +0200)]
Set context when using UserrightsPage

SpecialPage::getContext called and $mContext is null. Return
RequestContext::getMain(); for sanity

Change-Id: Ie0ed360835164e8a4eb1c675ec8edd944ab95898

11 years agodisplaytitle: reject some CSS if $wgRestrictDisplayTitle set
MatmaRex [Wed, 22 May 2013 08:48:14 +0000 (10:48 +0200)]
displaytitle: reject some CSS if $wgRestrictDisplayTitle set

$wgRestrictDisplayTitle is intended to make it possible to simply
copy-and-paste the title text even if it requires some styling like
subscript or superscript. Using a <span style="display: none;" />
broke that expectation, as the text hidden in such way becomes
completely invisible and unselectable. This patch rejects such styles.

Also disallowed 'user-select' and 'visibility', since they both
prevent the user from selecting and/or copying the text as well.

Minor changes in Sanitizer:
* checkCss() was made to pass through values which consist of nothing
  but a single comment, to allow this rejection to display some sort
  of a notification to the user.
* encodeTagAttributes() was added as a counterpart to
  decodeTagAttributes(), pulling some code out of fixTagAttributes().

Bug: 26547
Change-Id: Ie162535b6bcbebce4ee69f6dcc1957ccccc3c672

11 years agoMerge "Change space to non-breaking space to keep headers aligned"
jenkins-bot [Fri, 24 May 2013 11:09:55 +0000 (11:09 +0000)]
Merge "Change space to non-breaking space to keep headers aligned"

11 years agoMerge "jquery.byteLimit: Fix infinite loop if text is longer than max"
jenkins-bot [Fri, 24 May 2013 09:34:23 +0000 (09:34 +0000)]
Merge "jquery.byteLimit: Fix infinite loop if text is longer than max"

11 years agoMerge "jquery.byteLimit: Improve unit tests"
jenkins-bot [Fri, 24 May 2013 09:29:33 +0000 (09:29 +0000)]
Merge "jquery.byteLimit: Improve unit tests"

11 years agojquery.byteLimit: Fix infinite loop if text is longer than max
umherirrender [Mon, 13 May 2013 18:34:26 +0000 (20:34 +0200)]
jquery.byteLimit: Fix infinite loop if text is longer than max

When the length of the returned text of the callback is longer than the
max, the slicing of the input text, should not go into a endless loop.

Without this change, the added unit tests would fail as a result of
the infinite loop.

Bug: 41450
Change-Id: Iad84522659ab160e18828cbfc463db83bc7e4795

11 years agoMerge "Actually try to load intl for test which requires it."
jenkins-bot [Fri, 24 May 2013 09:23:32 +0000 (09:23 +0000)]
Merge "Actually try to load intl for test which requires it."

11 years agojquery.byteLimit: Improve unit tests
Timo Tijhof [Tue, 21 May 2013 20:33:38 +0000 (22:33 +0200)]
jquery.byteLimit: Improve unit tests

* Update outdated documentation
* Remove hasLimit and limit properties of the test helper
  function. These just repeated data already provided
  (hasLimit if input != output, limit == expected.length)
* Add tests for a filter that increases the length
  (currently only a decreasing filter was tested).

Change-Id: Ib4c19f4d49ed9d19117bbbaccedb0fccaeb34719

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 24 May 2013 08:32:06 +0000 (08:32 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I394beb54391ba868283759f889e64c86e8af8538

11 years agoAdded a --profiler option to all maintenance scripts.
Aaron Schulz [Thu, 23 May 2013 21:06:00 +0000 (14:06 -0700)]
Added a --profiler option to all maintenance scripts.

* This dumps profiling information in list or trace format as specified.
* Also optimized wfProfile* function like the ProfileSection class, which
  also plays better with Profiler::setInstance().
* Fixed fatals due to wfDebug() calls in Profiler::instance() due to that
  function not yet being loaded. The calls were simply removed.
* Cleaned up file performance test script a bit.

Change-Id: I6b8cd8b30fefc1904eeeeacada7a30a46f62fe2a

11 years agoAvoid select/writes for anon user in WatchedItem
umherirrender [Thu, 23 May 2013 18:38:05 +0000 (20:38 +0200)]
Avoid select/writes for anon user in WatchedItem

For a page view of a anon user the following select is executed:
SELECT  wl_notificationtimestamp  FROM `watchlist`  WHERE wl_user = '0'
AND wl_namespace = '0' AND wl_title = 'Hauptseite'  LIMIT 1

Change-Id: I1cf77a2d024956ed7c150bdf1687eb80c7eccc6f

11 years agoMerge "Add ss_active_users in SiteStats::isSane"
jenkins-bot [Thu, 23 May 2013 17:57:52 +0000 (17:57 +0000)]
Merge "Add ss_active_users in SiteStats::isSane"

11 years agoMerge "Removing prefix exception for HTMLCheckMatrix"
jenkins-bot [Thu, 23 May 2013 17:53:08 +0000 (17:53 +0000)]
Merge "Removing prefix exception for HTMLCheckMatrix"

11 years agoAdd ss_active_users in SiteStats::isSane
umherirrender [Thu, 23 May 2013 17:05:13 +0000 (19:05 +0200)]
Add ss_active_users in SiteStats::isSane

Also changed the array to the full row name, avoids unnecessary string
concat

Change-Id: Id8f1cb7035ae0058fb34a6c7bdf7bf9f6c740a69

11 years agoUser::getDefaultOptions duplicate call
Antoine Musso [Thu, 23 May 2013 14:17:15 +0000 (16:17 +0200)]
User::getDefaultOptions duplicate call

The User::getDefaultOptions() has to set up the 'language' and 'variant'
language. That was done using two calls of $wgContLang->getCode().

This patch reduce it to one call.

Change-Id: I0a30f2541e35c115d1cda72ce40d5e3dcd405c5b

11 years agoReset the error string in LoadBalancer::getConnection() to avoid it crufting up.
Aaron Schulz [Thu, 23 May 2013 07:26:33 +0000 (00:26 -0700)]
Reset the error string in LoadBalancer::getConnection() to avoid it crufting up.

Change-Id: I89e9fb46367970a0877986cd72d397eef51a0a06

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Thu, 23 May 2013 05:40:00 +0000 (05:40 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ie897be7438e5e494fcd53fb61421204e0e146a13

11 years agoRemoving prefix exception for HTMLCheckMatrix
kaldari [Wed, 22 May 2013 20:15:40 +0000 (13:15 -0700)]
Removing prefix exception for HTMLCheckMatrix

Unifying how the option prefix is handled for HTMLCheckMatrix and
HTMLMultiSelectField. This needs to be deployed at the same time
as the dependant Echo extension change Ic8420b89.

Change-Id: I4049b666db554283ce953387a30a0a8a7d0cd920

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Wed, 22 May 2013 18:45:54 +0000 (18:45 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoMerge "Fix for wrong prefixing of multi checkbox"
jenkins-bot [Wed, 22 May 2013 18:01:52 +0000 (18:01 +0000)]
Merge "Fix for wrong prefixing of multi checkbox"

11 years agoFix for wrong prefixing of multi checkbox
Erik Bernhardson [Wed, 22 May 2013 16:58:53 +0000 (09:58 -0700)]
Fix for wrong prefixing of multi checkbox

Bug: 48693
Change-Id: Ifd8d1d54d5252da958c30cdc0ffa1155ba4cf924

11 years agoAdd page language to prop=info
umherirrender [Wed, 22 May 2013 15:10:25 +0000 (17:10 +0200)]
Add page language to prop=info

This can be useful to determine the language of a page, for example
javascript has english as page language. MediaWiki pages has it page
language corresponding to the lang code in the sub page.

Change-Id: Idd0412574b314ecf52d92243a3f8a08755474663

11 years agoUse square brackets instead of curly braces for char of a string
umherirrender [Wed, 22 May 2013 15:59:59 +0000 (17:59 +0200)]
Use square brackets instead of curly braces for char of a string

The use of curly braces is deprecated in php 4.0, so changing it to
square brackets

Change-Id: Iffab398c8d18b386ec2e1a5de751c095b7a9cc77

11 years agoDo not returning external title in ApiPageSet::getRedirectTargets
umherirrender [Sat, 11 May 2013 18:44:55 +0000 (20:44 +0200)]
Do not returning external title in ApiPageSet::getRedirectTargets

Having a page with a redirect to "en:Main Page" will be added as "Main
Page" to the output, that is wrong

http://test.wikipedia.org/w/api.php?action=query&titles=Redirect%20to%20interwiki%20page&redirects

Change-Id: I7b59f592c1293dbb96f4c4279201bf04fcfea29d

11 years agoMerge "Add more tests for paragraphs and headings with extra spacing"
jenkins-bot [Wed, 22 May 2013 08:05:22 +0000 (08:05 +0000)]
Merge "Add more tests for paragraphs and headings with extra spacing"

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Wed, 22 May 2013 07:50:17 +0000 (07:50 +0000)]
Localisation updates from translatewiki.net.

Change-Id: I7779db39f74f4f92ac36ac1eb9d3941eb5ad0e50

11 years agophpcs: More require/include is not a function
Timo Tijhof [Fri, 17 May 2013 00:16:59 +0000 (02:16 +0200)]
phpcs: More require/include is not a function

Follows-up I1343872de7, Ia533aedf63 and I2df2f80b81.

Also updated usage in text in documentation and the
installer LocalSettingsGenerator.

Most of them were handled by this regex:
- find: (require|include|require_once|include_once)\s*\(\s*(.+?)\s*\)\s*;$
- replace: $1 $2;

Change-Id: I6b38aad9a5149c9c43ce18bd8edbab14b8ce43fa

11 years agoSECURITY: Do checks on all upload types
csteipp [Thu, 16 May 2013 22:09:44 +0000 (15:09 -0700)]
SECURITY: Do checks on all upload types

Also, verify file before stashing it

Change-Id: Ib2474cb778d53959a4f479e53d0392f916b18d83

11 years agoMerge "TitleSquidURLs hook for changing the URLs to purge"
jenkins-bot [Tue, 21 May 2013 20:06:10 +0000 (20:06 +0000)]
Merge "TitleSquidURLs hook for changing the URLs to purge"

11 years agoTitleSquidURLs hook for changing the URLs to purge
daniel [Fri, 17 May 2013 13:18:48 +0000 (15:18 +0200)]
TitleSquidURLs hook for changing the URLs to purge

This allows extensions to purge derivative resources that need
updating when a wiki page is changed.

Change-Id: Ic28ce7f57f29376b041627288979981fcb218a44

11 years agoMerge "Add parsoid-specific image testing"
jenkins-bot [Tue, 21 May 2013 19:51:50 +0000 (19:51 +0000)]
Merge "Add parsoid-specific image testing"

11 years agoAdd parsoid-specific image testing
Mark Holmquist [Mon, 8 Apr 2013 17:34:08 +0000 (10:34 -0700)]
Add parsoid-specific image testing

Using the wonderful
http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Images
to come up with some more sane image formats.

Change-Id: Ie98a2270ef7246d1e7b6e361d505c0bff7277c69

11 years agoMerge "Adding short date format i18n strings to Language message files"
TheDJ [Tue, 21 May 2013 18:18:58 +0000 (18:18 +0000)]
Merge "Adding short date format i18n strings to Language message files"

11 years agoAdding short date format i18n strings to Language message files
kaldari [Fri, 17 May 2013 21:24:50 +0000 (14:24 -0700)]
Adding short date format i18n strings to Language message files

For the short date format 'Month XX', different languages are inconsistent about
whether they apply the genitive case. For example, in Czech using the genitive
form is correct. For German it's not. Because of this inconsistancy, we have to
have a separate set of i18n messages for this date format.

Bug: 47211
Change-Id: Idca1bfc9f4eff7dc561253424f15c15ea007ab6d

11 years agoMerge "Fixed behavior of Title::invalidateCache."
jenkins-bot [Tue, 21 May 2013 17:55:44 +0000 (17:55 +0000)]
Merge "Fixed behavior of Title::invalidateCache."

11 years agoMerge "newlines in wfDebug() calls"
TheDJ [Tue, 21 May 2013 17:52:59 +0000 (17:52 +0000)]
Merge "newlines in wfDebug() calls"

11 years agoFixed behavior of Title::invalidateCache.
Tyler Anthony Romeo [Mon, 6 May 2013 01:08:27 +0000 (11:08 +1000)]
Fixed behavior of Title::invalidateCache.

Removed actions that should not be in Title::invalidateCache,
specifically the clearing of the InfoAction cache, and added
those actions to their appropriate locations.

Added a new method InfoAction::invalidateCache that clears the
cache for a given title.

Bug: 46816
Change-Id: Ic12c66446c0d71f567dceb5d4630382ff41ad8bf

11 years agoMerge "autoloader missed some entries"
jenkins-bot [Tue, 21 May 2013 16:45:58 +0000 (16:45 +0000)]
Merge "autoloader missed some entries"

11 years agoMerge "jquery.textSelection: Fix typos in documentation"
jenkins-bot [Tue, 21 May 2013 15:31:18 +0000 (15:31 +0000)]
Merge "jquery.textSelection: Fix typos in documentation"

11 years agojquery.textSelection: Fix typos in documentation
XP1 [Mon, 20 May 2013 12:53:19 +0000 (08:53 -0400)]
jquery.textSelection: Fix typos in documentation

Change-Id: I8260b7a43937e9fdddeb681333defaa337fcb397

11 years agoautoloader missed some entries
Antoine Musso [Tue, 21 May 2013 09:56:26 +0000 (11:56 +0200)]
autoloader missed some entries

Jenkins does not run the autoloader test (will be fixed in a different
commit).  This patch fix the main and test autoloader to add in all the
missing entries.

bug: 47750
Change-Id: I285fa7ed24a6fc45a4dc475b54d80cf3816436fb

11 years agoPoint to repo for 'normal' extension, rather than referring to CVS.
Matthew Flaschen [Tue, 21 May 2013 06:31:51 +0000 (02:31 -0400)]
Point to repo for 'normal' extension, rather than referring to CVS.

Change-Id: I0b8b310fa92e66fb184ed6e0c48f16b8f60b2100

11 years agoMerge "Add $namespaceGenderAliases for 'eo'"
jenkins-bot [Tue, 21 May 2013 05:56:14 +0000 (05:56 +0000)]
Merge "Add $namespaceGenderAliases for 'eo'"

11 years agoAdd $namespaceGenderAliases for 'eo'
raymond [Wed, 8 May 2013 10:11:58 +0000 (12:11 +0200)]
Add $namespaceGenderAliases for 'eo'

Per discussion on
https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=118297156#Benutzernamensraum_ignoriert_Einstellung_bei_.22Geschlecht.22

Change-Id: I4a46d0d50a247b028d8cf84a7da30300b19cf07b

11 years agoDeprecate $wgJsMimeType
Timo Tijhof [Mon, 20 May 2013 22:43:49 +0000 (00:43 +0200)]
Deprecate $wgJsMimeType

It hasn't been used for its documented purpose for a while.
In fact the one significant thing it can cause wasn't even
documented. If set to anything other than "text/javascript"
it will cause action=raw to no longer respond to
ctype=text/javascript requests (such as done by wikibits'
importScript function).

Follows-up 97caae596d5493.

Change-Id: Ib04ff5b21eb0ae172b94e31bc0dc16c9649e1864

11 years agoDrop redundant attributes in hardcoded html
Timo Tijhof [Mon, 20 May 2013 21:47:56 +0000 (23:47 +0200)]
Drop redundant attributes in hardcoded html

Follows-up 97caae596d5493 which makes HTML5 the default
and removes support for XHTML 1.0 and HTML < 5.

* <script type>
* <style type>
* <html xmlns>
* Quick-closing slash in non-XML HTML5 documents

Change-Id: I71855fa8d4095a5a448ebdc3dc36506ddab6f70c

11 years agoImprove doc for mw.util.getParamValue
Matthew Flaschen [Mon, 20 May 2013 21:02:25 +0000 (17:02 -0400)]
Improve doc for mw.util.getParamValue

Change-Id: I4f008617c278a30eb43d21c942e1ab06a6db1c0a

11 years agoresourceloader: Write to debug log for all fatal errors
Timo Tijhof [Thu, 2 May 2013 01:27:58 +0000 (03:27 +0200)]
resourceloader: Write to debug log for all fatal errors

There's various fatal errors that can happen in ResourceLoader.
Since in a javascript/css response there is no error page we can
show, we currently catch them all and output them in a block
comment on top of load.php.

This maintains valid syntax for the response and keeps the error
easy to view (if you're looking for it in the browser).

However from a debugging perspective it is a nightmare. Literally
the only visible difference from a normal request response is
the cache maxage (if hasErrors: use unversionsed maxage).

For all errors we currently already catch and write to request
response outpout, also write to debug log.

This also helps in fixing bug #.

This commit basically changes the following pattern:

    // Add exception to the output as a comment
    $errors .= $this->makeComment( $e->__toString() );
    $this->hasErrors = true;

to:

    wfDebugLog( 'resourceloader', __METHOD__ . ": <failure summary>: $e\n" );
    $this->hasErrors = true;
    // Add exception to the output as a comment
    $errors .= $this->makeComment( $e->__toString() );

Bug: 44018
Change-Id: I684f6492f839a6c6adb07b0640e88cfea21fcf60

11 years agoresourceloader: Consistently use 'resourceloader' log group
Timo Tijhof [Thu, 2 May 2013 02:13:13 +0000 (04:13 +0200)]
resourceloader: Consistently use 'resourceloader' log group

Some were using generic wfDebug().

Removed obsolete new-line which is already added by wfDebugLog.

Bug: 44018
Change-Id: I9907b374fa868c04ff2ce40964238936b9084a4a

11 years agoMerge "Update formatting"
jenkins-bot [Mon, 20 May 2013 19:30:10 +0000 (19:30 +0000)]
Merge "Update formatting"

11 years agoMerge "Make checkUsernames.php use batches"
jenkins-bot [Mon, 20 May 2013 19:25:20 +0000 (19:25 +0000)]
Merge "Make checkUsernames.php use batches"

11 years agonewlines in wfDebug() calls
Antoine Musso [Mon, 20 May 2013 18:57:43 +0000 (20:57 +0200)]
newlines in wfDebug() calls

Spotted while running unit tests.

Change-Id: Idf863bed71b5f11b41b81d37fb190e6e7a4d0268

11 years agoMake checkUsernames.php use batches
Reedy [Fri, 17 May 2013 00:32:13 +0000 (01:32 +0100)]
Make checkUsernames.php use batches

Bug: 3507
Change-Id: Idb4b84b853f4f86e90a470e937af9017cee15e44

11 years agoUpdate formatting
Siebrand Mazeland [Mon, 20 May 2013 18:28:37 +0000 (20:28 +0200)]
Update formatting

Fixes for issues CodeSniffer complained about at
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-HEAD/9920/console
for 4f98011fdd98328028d152baf27627fea0c28d3e.

Change-Id: I2cc0cee6ff8260e74ad8b1721614ae16a360e68d

11 years agoFix fatal, use Message::isDisabled()
Siebrand Mazeland [Mon, 20 May 2013 18:14:37 +0000 (20:14 +0200)]
Fix fatal, use Message::isDisabled()

Follow-up to dd85e115075661e9e0bb92c7f6d4ab9604efd980 where this issue was
introduced.

Change-Id: I46bd11ca7158d1dec4d8a3533d2607dde9928cc2

11 years agoMerge "Non existent user subpages should return 404"
jenkins-bot [Mon, 20 May 2013 17:40:59 +0000 (17:40 +0000)]
Merge "Non existent user subpages should return 404"

11 years agoMerge "Move the global to the place it is needed."
jenkins-bot [Mon, 20 May 2013 14:25:06 +0000 (14:25 +0000)]
Merge "Move the global to the place it is needed."

11 years agoMerge "Localisation updates from http://translatewiki.net."
jenkins-bot [Mon, 20 May 2013 12:20:03 +0000 (12:20 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Mon, 20 May 2013 12:08:40 +0000 (12:08 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ic862c638ed6ce33d3fe4dad9743c88136d832433

11 years agoMerge "Remove the $wgHandheldStyle config variable entirely"
TheDJ [Mon, 20 May 2013 12:04:03 +0000 (12:04 +0000)]
Merge "Remove the $wgHandheldStyle config variable entirely"

11 years agoMove the global to the place it is needed.
Platonides [Mon, 20 May 2013 09:28:27 +0000 (11:28 +0200)]
Move the global to the place it is needed.

Follow-up 8be2e118

Change-Id: Ic72a8f24fdcbafcb689370c845dcf6df4f864493

11 years agoMerge "SpecialWatchlist: Page header cleanup"
jenkins-bot [Mon, 20 May 2013 08:26:40 +0000 (08:26 +0000)]
Merge "SpecialWatchlist: Page header cleanup"

11 years agoMerge "(bug 17602) fix Monobook action tabs not quite touching the page body"
TheDJ [Sun, 19 May 2013 19:44:43 +0000 (19:44 +0000)]
Merge "(bug 17602) fix Monobook action tabs not quite touching the page body"

11 years agoNon existent user subpages should return 404
Marius Hoch [Sun, 19 May 2013 17:27:53 +0000 (19:27 +0200)]
Non existent user subpages should return 404

Bug: 46491
Change-Id: I900f1542b077b569ed64306ecf9f965ddabe59f8

11 years agoRemoved Closure type hints where not needed.
Tyler Anthony Romeo [Fri, 15 Mar 2013 02:09:14 +0000 (22:09 -0400)]
Removed Closure type hints where not needed.

Closures are not the only types of callable objects in PHP.
Specifically, any string referencing a valid function, any object with a __call(),
or any class with a __callStatic() can all be called.
Therefore, removed type hinting for Closures in places where a callable is expected.
(Unfortunately, the callable type-hint only comes in PHP 5.4.)

Change-Id: I6bff7e4a95716ef63aa7e07d3d9fef6d20eb65a6

11 years agoSpecialWatchlist: Page header cleanup
MatmaRex [Sun, 19 May 2013 15:53:14 +0000 (17:53 +0200)]
SpecialWatchlist: Page header cleanup

Format the three messages in header as one paragraph with three
sentences, instead of a paragraph and two split unordered lists with
one item each and inconsistent full stops.

Message changes: In 'wlheader-enotif' and 'wlheader-showupdated',
remove initial bullet point if present and add final full stop if
missing. First used the regexes below, then went through each language
file and manually changed the messages if applicable (e.g., Thai not
using full stops at all, Asian languages using '。', Devanagari
languages using '।' etc.)
  Find: ('wlheader-[^']+'\s*=>\s*)(['"])(?:\*\s*)?([\s\S]+?)\.?\2,\n
  Replace with: $1$2$3.$2,\n

Bug: 48615
Change-Id: I856f71f36d7f4b4baff5e968d88e4d3f7aeecce2

11 years agoRemove the $wgHandheldStyle config variable entirely
MatmaRex [Mon, 22 Apr 2013 12:39:53 +0000 (14:39 +0200)]
Remove the $wgHandheldStyle config variable entirely

Added back in 2008 (dc821ec1 / r38116), it was only ever implemented
for Monobook and didn't do anything in other skins.

The only use-case given was using Chick's CSS for mobile devices with
Monobook being the default skin - and now Chick is no more and
Monobook isn't the default.

It was also used to decide whether to load styles from
MediaWiki:Handheld.css (they were loaded if it was set to anything).
That message has been removed as well.

Bug: 47504
Change-Id: Ia8d79b4a637a227eb1879fbb874173fdd9bd6d99

11 years agoMerge "ForeignAPIRepo: Fetch thumb error from foreign repo"
TheDJ [Sun, 19 May 2013 13:20:17 +0000 (13:20 +0000)]
Merge "ForeignAPIRepo: Fetch thumb error from foreign repo"

11 years agodisplay: inline-block for .errorbox, .warningbox, .successbox
MatmaRex [Mon, 6 May 2013 14:34:31 +0000 (16:34 +0200)]
display: inline-block for .errorbox, .warningbox, .successbox

It previously used float: left to generate a box with intrinsic width,
which required the next element to have clear: left to avoid display
quirks. display: inline-block is the proper way to do this.

Includes hacks for IE6 and FF2.

Bug: 33438
Change-Id: Ibb9371eecb99b627ba9dfca5b0a60143fbd6f84f

11 years agoUpdate formatting
Siebrand Mazeland [Thu, 9 May 2013 14:51:30 +0000 (16:51 +0200)]
Update formatting

Also removed some commented out code and one or more unneeded elses.

Change-Id: I8a7f5c683e3aa570522fb31b027b695f195a3970

11 years agoMerge "Localisation updates from http://translatewiki.net."
Translation updater bot [Fri, 17 May 2013 20:58:04 +0000 (20:58 +0000)]
Merge "Localisation updates from translatewiki.net."

11 years agoMerge "Make sure job runner exceptions get logged."
jenkins-bot [Fri, 17 May 2013 20:41:50 +0000 (20:41 +0000)]
Merge "Make sure job runner exceptions get logged."

11 years agoMerge "[FileBackend] Avoid concurrency for the 1 op case in doQuickOperationsInternal()."
jenkins-bot [Fri, 17 May 2013 20:21:09 +0000 (20:21 +0000)]
Merge "[FileBackend] Avoid concurrency for the 1 op case in doQuickOperationsInternal()."

11 years agoLocalisation updates from http://translatewiki.net.
Translation updater bot [Fri, 17 May 2013 18:09:29 +0000 (18:09 +0000)]
Localisation updates from translatewiki.net.

Change-Id: Ic916a0853dda60a68eab6ad9284fca04e4775c05

11 years agoMerge "deleteEqualMessages: Refactor to support all langcode subpages"
jenkins-bot [Fri, 17 May 2013 17:42:02 +0000 (17:42 +0000)]
Merge "deleteEqualMessages: Refactor to support all langcode subpages"

11 years agoMerge "Slight improvements to FormSpecialPage behavior."
jenkins-bot [Fri, 17 May 2013 17:29:01 +0000 (17:29 +0000)]
Merge "Slight improvements to FormSpecialPage behavior."

11 years agodeleteEqualMessages: Refactor to support all langcode subpages
Timo Tijhof [Fri, 3 May 2013 15:48:36 +0000 (17:48 +0200)]
deleteEqualMessages: Refactor to support all langcode subpages

Previously it ran for either the base pages (comparing against
content language) or 1 lang-code subpage.

And the latter was actually broken as it forgot to add the
subpage back on, thus resulting in incorrect deletions
(deleting MediaWiki:Foo instead of MediaWiki:Foo/nl).

Also fixed a bug where it used the subpage lang-code to create
a Language object and call ucfirst(). Page titles should only be
capitalized by content language.

Bug: 48050
Bug: 43917
Change-Id: I2680413c276365a44c935a6f6fdd740daa86341e

11 years agoFixed spacing and removed unneeded parenthesis
umherirrender [Fri, 17 May 2013 14:47:00 +0000 (16:47 +0200)]
Fixed spacing and removed unneeded parenthesis

Added spaces after/before parenthesis
Removed unneeded parenthesis around some statements
Broke a long line

Change-Id: I7fbe129f7bbf524dd0598ece2a9708643f08453b

11 years agoDeprecate OutputPage::out.
Daniel Friesen [Sun, 12 May 2013 09:00:16 +0000 (02:00 -0700)]
Deprecate OutputPage::out.

OutputPage is supposed to be a container for output. It should NOT be used as a replacement for echo.

Only one seemingly unmaintained extension uses this method.
This method is deprecated now and should be removed in the next release.

Change-Id: I82711cee7204604a47cfbb5e4496b4cc737a837c

11 years agoAdd RC_EXTERNAL to comment in tables.sql
umherirrender [Fri, 17 May 2013 14:59:26 +0000 (16:59 +0200)]
Add RC_EXTERNAL to comment in tables.sql

Change-Id: If3156984e9ff447fec6644681d96c1095b709a99