lhc/web/wiklou.git
11 years agoAdd testRomanNumerals
Reedy [Tue, 17 Jul 2012 22:56:51 +0000 (23:56 +0100)]
Add testRomanNumerals

Up Language::romanNumeral() to work upto 10,000

Does anyone know how do do letters with an underscore ontop of them? ;)

Change-Id: Ib1b1415126af855ce5fb55f81b71534c26d84cc9

11 years agoMerge "Fixed DATA_FOR_UPDATE loading in WikiPage."
Tim Starling [Mon, 23 Jul 2012 03:29:55 +0000 (03:29 +0000)]
Merge "Fixed DATA_FOR_UPDATE loading in WikiPage."

11 years agoMerge "Reverted "FOR UPDATE" in 61f246aa786d824d0653522ed679c16be719da80."
Tim Starling [Mon, 23 Jul 2012 03:28:54 +0000 (03:28 +0000)]
Merge "Reverted "FOR UPDATE" in 61f246aa786d824d0653522ed679c16be719da80."

11 years agoMerge "Fix missing occurence change in I6b69919a (747e89e)."
Aaron Schulz [Sun, 22 Jul 2012 19:42:28 +0000 (19:42 +0000)]
Merge "Fix missing occurence change in I6b69919a (747e89e)."

11 years agoFix missing occurence change in I6b69919a (747e89e).
Alexandre Emsenhuber [Sun, 22 Jul 2012 19:03:43 +0000 (21:03 +0200)]
Fix missing occurence change in I6b69919a (747e89e).

The line above changed in that revision, but not this one,
so I highly suspect that this occurence of deleterevision
should have been changed to deletelogentry.

Change-Id: Ief4ca9acf08bccc8ff064cea5795a2dbeae44d19

11 years agoMerge "Use User::getDefaultOption() instead of $wgDefaultUserOptions"
Aaron Schulz [Sun, 22 Jul 2012 09:45:18 +0000 (09:45 +0000)]
Merge "Use User::getDefaultOption() instead of $wgDefaultUserOptions"

11 years agoMerge "(bug 37926) Split 'deleterevision' right for log entries"
Aaron Schulz [Sat, 21 Jul 2012 19:57:07 +0000 (19:57 +0000)]
Merge "(bug 37926) Split 'deleterevision' right for log entries"

11 years ago(bug 37926) Split 'deleterevision' right for log entries
Alex Monk [Mon, 25 Jun 2012 16:07:51 +0000 (17:07 +0100)]
(bug 37926) Split 'deleterevision' right for log entries

This change adds a new permission ('deletelogentry') which is required to be able
to delete log entries.

It does not affect who can see deleted content.

Change-Id: I6b69919a1bdc502becc1ae4ac9169b8b0e85bfdc

11 years agoMerge "[LockManager] Made LSLockManager session 32 chars (128 bits)."
Aaron Schulz [Sat, 21 Jul 2012 18:45:50 +0000 (18:45 +0000)]
Merge "[LockManager] Made LSLockManager session 32 chars (128 bits)."

11 years agoReverted "FOR UPDATE" in 61f246aa786d824d0653522ed679c16be719da80.
Aaron Schulz [Sat, 21 Jul 2012 18:39:18 +0000 (11:39 -0700)]
Reverted "FOR UPDATE" in 61f246aa786d824d0653522ed679c16be719da80.

* Previously, this code would select FOR UPDATE unless ALF_NO_LINK_LOCK
was set in $wgAntiLockFlags (which in fact was set for wmf sites for ages
to reduce contention). In this case, it was just loading from the master,
without locking, and relying on the page_latest check. Now, it just never
selects FOR UPDATE, regardless of the lock flags, relying on page_latest.

Change-Id: Ie6301de4415f56e6be3899cf4ab37924963ce8c4

11 years agoFixed DATA_FOR_UPDATE loading in WikiPage.
Aaron Schulz [Sat, 21 Jul 2012 18:21:15 +0000 (11:21 -0700)]
Fixed DATA_FOR_UPDATE loading in WikiPage.

Change-Id: Ifc4259942eb8bf5e91e80ec0009c2a2ab191ae11

11 years agoUse User::getDefaultOption() instead of $wgDefaultUserOptions
umherirrender [Sat, 16 Jun 2012 08:16:28 +0000 (10:16 +0200)]
Use User::getDefaultOption() instead of $wgDefaultUserOptions

Using User::getDefaultOption() in User::setOption() sets preferences like
'language' to the right default value, whereas using $wgDefaultOptions
sets the language to null because language is not part of $wgDefaultUserOptions,
but it is part of return value of User::getDefaultOption().

This only makes problems when reusing the same user object, because when
a new user object is created, the value of 'language' is correct.

Change-Id: I43a32c66fc3997a4f842c63af374e84d234602b2

11 years agoMerge "Updated result properties in paraminfo API"
Aaron Schulz [Sat, 21 Jul 2012 09:09:02 +0000 (09:09 +0000)]
Merge "Updated result properties in paraminfo API"

11 years agoMerge "Revert "Do not show empty categories with list=allcategories""
Aaron Schulz [Sat, 21 Jul 2012 09:07:36 +0000 (09:07 +0000)]
Merge "Revert "Do not show empty categories with list=allcategories""

11 years agoExecute jobs on all index.php requests.
Alexandre Emsenhuber [Fri, 20 Jul 2012 20:38:24 +0000 (22:38 +0200)]
Execute jobs on all index.php requests.

The problem is that currently deferred updates are not executed
after action=ajax requests or file cache hits. This means that,
e.g. ViewCountUpdates are not executed after file cache hits.
The code to execute jobs (both deferred updates and job queue)
is now in MediaWiki::restInPeace() so that it's also executed
after what is mentioned above, and the remaining code of
MediaWiki::finalCleanup() is moved directly MediaWiki::main()
since that function is only used in one place and it make no
sense to keep a method for such little code.

Change-Id: I6f511a74c59a2e3653c10bfcff9b0d15118e699f

11 years ago(bug 38190) Add "required" flag to some token params
umherirrender [Wed, 18 Jul 2012 17:24:38 +0000 (19:24 +0200)]
(bug 38190) Add "required" flag to some token params

action=block/action=unblock can not have the token required because when
using the gettoken param, the token param can not set.

Change-Id: I15317f16c06f150d29c1b17de76f41a6cfa84820

11 years agoMerge "(bug 260) Handle <pre> overflow automatically with a scroll bar"
Trevor Parscal [Fri, 20 Jul 2012 20:59:32 +0000 (20:59 +0000)]
Merge "(bug 260) Handle <pre> overflow automatically with a scroll bar"

11 years agoUse WebRequest instead of $_SERVER in EditPage.
Alexandre Emsenhuber [Fri, 20 Jul 2012 18:46:24 +0000 (20:46 +0200)]
Use WebRequest instead of $_SERVER in EditPage.

Change-Id: I30cdcffe8c520f9a4031c31e3e08db9b699da597

11 years agoMerge "Undo feature: Add a wpUndidRevision field that can be used to distinguish...
Reedy [Fri, 20 Jul 2012 18:31:48 +0000 (18:31 +0000)]
Merge "Undo feature: Add a wpUndidRevision field that can be used to distinguish (undo) edits from other edits"

11 years ago[FileBackend] Cleanups for doxygen.
Aaron Schulz [Fri, 20 Jul 2012 10:13:43 +0000 (03:13 -0700)]
[FileBackend] Cleanups for doxygen.

Change-Id: I82cd7e4ef01c6fa10fbdb6ccce5cc8e42e8aac67

11 years agocleanup temp files left around by UploadStash
Jan Gerber [Fri, 20 Jul 2012 01:18:31 +0000 (01:18 +0000)]
cleanup temp files left around by UploadStash

stashFile renames files to add an extension, this way it is no longer
cleaned up by php. So we have to unlink it after storing it in the FileRepo.

Change-Id: Iab697fc4535546dd25231dddf220e18f3b0b73be

11 years agoFix bug in moveTo() with $auth=false and $createRedirect=false
Catrope [Thu, 19 Jul 2012 21:22:27 +0000 (14:22 -0700)]
Fix bug in moveTo() with $auth=false and $createRedirect=false

Even when $auth=false, moveToInternal() would unconditionally check
$wgUser's 'suppressredirect' permissions and override $createRedirect.
This means it was impossible to suppress redirect creation when moving
pages in a maintenance script, even when telling moveTo() to disable
permissions checks.

Fixed by moving the check from moveToInternal() up into moveTo() and
respecting $auth there

Change-Id: I9b52dc67c7ae2dbda3ca62f78d4d7df118771c0f

11 years ago(bug 35060) more allowed params to Special:MyPage, Special:MyTalk
Derrick Coetzee [Thu, 10 May 2012 03:12:42 +0000 (20:12 -0700)]
(bug 35060) more allowed params to Special:MyPage, Special:MyTalk

I investigated the available parameters and considered which could be
plausibly useful for Special:MyPage and Special:MyTalk, and there are
quite a few. See inline documentation for a list of them. More could
potentially be added in the future if a use case is discovered.

This patch also make it possible for extensions to add their own
parameters to this list, through the new hook:
RedirectSpecialArticleRedirectParams

It has at least one application - with FlaggedRevs, it's desirable to
pass the "stable" flag through Special:MyPage. It also makes it simple
for individual servers that have some special reason to pass on a
particular parameter to do so in LocalSettings.php, simplifying
upgrades.

Change-Id: I3101fbe2eba8712b87a53706583f4e8f3e907478

11 years ago(bug 38333) test blocked user cant createaccount
Antoine Musso [Fri, 13 Jul 2012 09:43:17 +0000 (11:43 +0200)]
(bug 38333) test blocked user cant createaccount

This patch adds BlockTest::testBlockedUserCanNotCreateAccount() which
test that a new user can createaccount and that blocking him will
prevents to the createaccount right.

Does not solve bug 38333 though!

Change-Id: Ia10e26825d50d47b4770900ee91dea666337f969

11 years ago(bug 30836) API siteinfo specialpagealiases should not return nonexistent special...
Brad Jorsch [Sat, 2 Jun 2012 20:20:14 +0000 (22:20 +0200)]
(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages

Some special pages are conditionally registered (e.g.
Special:Popularpages only exists when $wgDisableCounters is false), or
sometimes an alias exists for a special page that does not. The API
should probably not return entries for these from
meta=siteinfo&siprop=specialpagealiases.

This also fixes bug 38464 correctly, rather than blindly reverting.

Change-Id: Ic021a47754ea7a1574e818dad47151ab6698e06f

11 years ago[LockManager] Made LSLockManager session 32 chars (128 bits).
Aaron Schulz [Wed, 18 Jul 2012 20:43:36 +0000 (13:43 -0700)]
[LockManager] Made LSLockManager session 32 chars (128 bits).

Change-Id: I1eba3eb44ebef02c771b518c2bcbdc0d41eb8086

11 years ago[FileBackend] Make sure multiwrite sub-backends use the proxy backend wiki ID.
Aaron Schulz [Wed, 18 Jul 2012 20:12:16 +0000 (13:12 -0700)]
[FileBackend] Make sure multiwrite sub-backends use the proxy backend wiki ID.

Change-Id: I886b0aeb891a108e3a61e9d98e70b5a0bdc2bdc5

11 years agoUndo feature: Add a wpUndidRevision field that can be used to distinguish (undo)...
Andrew Garrett [Wed, 18 Jul 2012 19:25:02 +0000 (12:25 -0700)]
Undo feature: Add a wpUndidRevision field that can be used to distinguish (undo) edits from other edits

Change-Id: I85d485d89ab87c9478552183ffdb10b0bfaad648

11 years agoMerge "escape HTML elements in docblock with double quotes"
Aaron Schulz [Wed, 18 Jul 2012 19:17:46 +0000 (19:17 +0000)]
Merge "escape HTML elements in docblock with double quotes"

11 years agoMerge "Various doc cleanups for doxygen."
Hashar [Wed, 18 Jul 2012 19:13:36 +0000 (19:13 +0000)]
Merge "Various doc cleanups for doxygen."

11 years agoMerge "Free up some memory by unsetting large arrays in backend copy script."
Demon [Wed, 18 Jul 2012 19:13:26 +0000 (19:13 +0000)]
Merge "Free up some memory by unsetting large arrays in backend copy script."

11 years agoVarious doc cleanups for doxygen.
Aaron Schulz [Wed, 18 Jul 2012 19:08:30 +0000 (12:08 -0700)]
Various doc cleanups for doxygen.

Change-Id: I079f66997111d27d89910505dd5978aac613d383

11 years agoMerge "Minor documentation tweaks"
Demon [Wed, 18 Jul 2012 18:28:57 +0000 (18:28 +0000)]
Merge "Minor documentation tweaks"

11 years agoMerge "Api method documentation tweaks"
Demon [Wed, 18 Jul 2012 18:24:43 +0000 (18:24 +0000)]
Merge "Api method documentation tweaks"

11 years agoRevert "(bug 30836) API siteinfo specialpagealiases should not return nonexistent...
Reedy [Wed, 18 Jul 2012 16:39:48 +0000 (16:39 +0000)]
Revert "(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages"

Caused Bug 38464 - API showing internal error with ?action=query&meta=siteinfo&siprop=specialpagealiases&format=xmlfm

This reverts commit 48523016ef0d4a3d15e7417dfb3048d34cac69f7

Change-Id: I470e87d21d98d4436bd5e27d0a3796559f9c41bb

11 years agoMediaWikiLangTestCase now call parent setUp/tearDown
Antoine Musso [Wed, 18 Jul 2012 15:46:57 +0000 (17:46 +0200)]
MediaWikiLangTestCase now call parent setUp/tearDown

Fix the temporary file garbage collection which was not occuring on lang
tests. Fix at least:

(bug 37252) filebackend-unittest temp dirs not deleted

Change-Id: I446d5ad21c8a3b12020e2424d09ba71dde410221

11 years agoIncrease the readability of provideFormattableTimes by adding newlines
Reedy [Tue, 17 Jul 2012 17:31:23 +0000 (18:31 +0100)]
Increase the readability of provideFormattableTimes by adding newlines

Change-Id: I7f96f44c2e18153ecfd7ea6d593229808a835a63

11 years agoRevert "Do not show empty categories with list=allcategories"
Petr Onderka [Wed, 18 Jul 2012 10:10:41 +0000 (12:10 +0200)]
Revert "Do not show empty categories with list=allcategories"

This reverts commit 4b9bd6a4dba57026b2f18d4024b021407e52ff4f.

This change made allcategories less useful,
because it means it's impossible to list empty categories
(previously, acmax=0 did that).

To exclude empty categories, acmin=1 can be used.

Change-Id: I7943507c4cb7d752f82caa69ce3edb0b31ca9463

11 years agoUse Linker::userToolLinksRedContribs() in LogFormatter.
Alexandre Emsenhuber [Wed, 18 Jul 2012 10:10:13 +0000 (12:10 +0200)]
Use Linker::userToolLinksRedContribs() in LogFormatter.

It is much more self-describing to use that method instead of
Linker::userToolLinks() with true as third parameter.

Change-Id: I30fbef2e06c7a835a66130cc54e10e114e286914

11 years agoFree up some memory by unsetting large arrays in backend copy script.
Aaron Schulz [Wed, 18 Jul 2012 06:25:30 +0000 (23:25 -0700)]
Free up some memory by unsetting large arrays in backend copy script.

Change-Id: I55b6a6f8228370d948821dcd4de22fda51539fd0

11 years agoMerge "[FileBackend] Removed @since formatting for options to fix doxygen."
Aaron Schulz [Wed, 18 Jul 2012 04:28:09 +0000 (04:28 +0000)]
Merge "[FileBackend] Removed @since formatting for options to fix doxygen."

11 years ago[FileBackend] Removed @since formatting for options to fix doxygen.
Aaron Schulz [Wed, 18 Jul 2012 04:24:19 +0000 (21:24 -0700)]
[FileBackend] Removed @since formatting for options to fix doxygen.

Change-Id: Ic1cb55dc9317de34fc50b7c590a2cd6e80c800ad

11 years agoMerge "updateCollation.php size histogram feature"
Aaron Schulz [Wed, 18 Jul 2012 04:12:44 +0000 (04:12 +0000)]
Merge "updateCollation.php size histogram feature"

11 years ago[FileBackend] Added "bypassReadOnly" flag.
Aaron Schulz [Thu, 12 Jul 2012 19:48:16 +0000 (12:48 -0700)]
[FileBackend] Added "bypassReadOnly" flag.

* Added flag to bypass read-only checks to the 6 write functions.
* Made backend copy and sync scripts pass in this new flag.
* Also made sync script use doQuickOperations() since its faster.

Change-Id: Iee47f79ed7ab002cfc2d0adb5321c3a8520f971d

11 years agoupdateCollation.php size histogram feature
Tim Starling [Wed, 11 Jul 2012 03:39:39 +0000 (13:39 +1000)]
updateCollation.php size histogram feature

Added a feature allowing updateCollation.php to show a histogram of
sort key sizes, to assess the effect of index size truncation. Added
--dry-run and --target-collation options to allow the index truncation
to be assessed without actually changing the collation.

Change-Id: I497b5d0740384f5d6fdebc6d5ccfea5d853fbd37

11 years ago[FileBackend] MultiWrite code improvements and sanity checks.
Aaron [Thu, 17 May 2012 23:34:52 +0000 (16:34 -0700)]
[FileBackend] MultiWrite code improvements and sanity checks.

* Automatically override a few sub-backend settings in FileBackendMultiWrite.
  We should ignore locking, journaling, or read-only settings of sub-backends.
  Journaling is now done just for master sub-backend paths (under the proxy backend name).
  We don't need to log for each sub-backend, which is a waste of disk space.
* Changed FileBackendMultiWrite::doOperationsInternal() to be similiar to the
  other write functions. It now uses doOperations() of the sub-backends rather
  than manual code. This makes settings like 'concurrency' easier to manage;
  we might want to have some sub-backends with varying setings for that.
* Made FileBackendMultiWrite::doQuickOperationsInternal() compliant with docs.
* Added CHECK_SHA1 option for consistency checking.
* Fixed function visibility in two places.
* Improved multiwrite backend tests by calling consistencyCheck().

Change-Id: Iac7bfe10c77ecd069fb9ef0ec26a01512f5f4eea

11 years agoMerge "(bug 37249) validate export-demo.xml against current export.xsd"
Catrope [Wed, 18 Jul 2012 02:16:44 +0000 (02:16 +0000)]
Merge "(bug 37249) validate export-demo.xml against current export.xsd"

11 years agoMerge "Allow extensions to abort (and replace) email notifications"
Catrope [Wed, 18 Jul 2012 02:14:27 +0000 (02:14 +0000)]
Merge "Allow extensions to abort (and replace) email notifications"

11 years agoMerge "API: Cleanup around comment/reason params"
Catrope [Wed, 18 Jul 2012 01:59:34 +0000 (01:59 +0000)]
Merge "API: Cleanup around comment/reason params"

11 years agoMerge "prop=imageinfo&iiprop=url|thumbmime needs iiurlwidth="
Catrope [Wed, 18 Jul 2012 01:42:33 +0000 (01:42 +0000)]
Merge "prop=imageinfo&iiprop=url|thumbmime needs iiurlwidth="

11 years agoMerge "merge msg script now detects extensions main files"
Catrope [Tue, 17 Jul 2012 23:20:15 +0000 (23:20 +0000)]
Merge "merge msg script now detects extensions main files"

11 years agoMerge "Avoid mangling fields in API continuation parameters"
Catrope [Tue, 17 Jul 2012 23:18:31 +0000 (23:18 +0000)]
Merge "Avoid mangling fields in API continuation parameters"

11 years agoMerge "Notice: Undefined index: page_is_redirect in \includes\api\ApiPageSet.php...
Catrope [Tue, 17 Jul 2012 23:18:20 +0000 (23:18 +0000)]
Merge "Notice: Undefined index: page_is_redirect in \includes\api\ApiPageSet.php on line 111"

11 years agoAvoid mangling fields in API continuation parameters
Brad Jorsch [Mon, 21 May 2012 17:07:37 +0000 (13:07 -0400)]
Avoid mangling fields in API continuation parameters

API continuation parameters encode sufficient state for a subsequent
query to continue where the previous one left off; this may sometimes
include page titles, with or without the namespace. Given that these
page titles are already in the exact format required for the next
request's SQL query, it is not necessary to "normalize" them in any way.
And if normalization does more than just change spaces to underscores or
vice versa (e.g. it canonicalizes namespace aliases or capitalizes the
first letter of the title), it can be actively harmful: see bug 36987
and bug 29290.

Note this patch involves a breaking API change: the values for the
"continue" parameter of various modules have been changed, and some
modules will now return "continue" as the continuation parameter instead
of reusing "from".

Note this patch also corrects a minor logic bug in ApiQueryAllLinks,
changing ">" to ">=". The line is being changed anyway, so I didn't
bother doing a separate changeset.

Change-Id: I459232e919d20f89f6de9d20640fd48c8fd5781c

11 years agoAdd wfProfileIn/wfProfileOut calls to InfoAction::pageCountInfo()
Reedy [Tue, 17 Jul 2012 21:01:31 +0000 (22:01 +0100)]
Add wfProfileIn/wfProfileOut calls to InfoAction::pageCountInfo()

Change-Id: Ice4eff38253b189a60885be36dadd2a3cf5d6297

11 years agoOnly query page_counter if $wgDisableCounters is false
Reedy [Tue, 17 Jul 2012 21:16:15 +0000 (22:16 +0100)]
Only query page_counter if $wgDisableCounters is false

Change-Id: Ie134090cdd6573d11a7f5510e1d90dab9b06f117

11 years agoAllow extensions to abort (and replace) email notifications
Andrew Garrett [Tue, 17 Jul 2012 19:58:53 +0000 (12:58 -0700)]
Allow extensions to abort (and replace) email notifications

Change-Id: I769ad24fcd6f3e3c03fb67122eab25a8472047b6

11 years agoMerge "add optional limits argument to wgShellExec"
Reedy [Tue, 17 Jul 2012 18:23:14 +0000 (18:23 +0000)]
Merge "add optional limits argument to wgShellExec"

11 years agoMerge "[LockManager] Memc lockmanager improvements."
Aaron [Tue, 17 Jul 2012 17:02:56 +0000 (17:02 +0000)]
Merge "[LockManager] Memc lockmanager improvements."

11 years ago[LockManager] Memc lockmanager improvements.
Aaron [Mon, 9 Jul 2012 22:29:23 +0000 (15:29 -0700)]
[LockManager] Memc lockmanager improvements.

* Throttled key lock polling and changed the key locking to happen in sorted key order.
  This should reduce deadlocks and wasted RTTs for frequently used items.
* Also tweaked the wfRandomString() argument to be 32 (128 bit).

Change-Id: I12bbc988251ad3c895aa40a08b0215b2bcdb5e4f

11 years agoMerge "[Database] mark some methods as explicitly public"
Reedy [Tue, 17 Jul 2012 15:39:45 +0000 (15:39 +0000)]
Merge "[Database] mark some methods as explicitly public"

11 years agoRemove some optional messages from ba and shi
Amir E. Aharoni [Tue, 17 Jul 2012 13:25:00 +0000 (16:25 +0300)]
Remove some optional messages from ba and shi

Removed pagetitle-view-mainpage and pagetitle from languages ba and shi.
The current pagetitle caused strange display of the title in
Bashkir projects.

Change-Id: Icba106e30916a2c15213fdc771c871a2f5df632e

11 years ago[Database] mark some methods as explicitly public
Aaron Schulz [Mon, 16 Jul 2012 17:56:00 +0000 (19:56 +0200)]
[Database] mark some methods as explicitly public

Change-Id: I95fca6d346ae812c22b88b577477be02b5a0676b

11 years ago[FileBackend] Doc formatting tweaks for doxygen.
Aaron Schulz [Tue, 17 Jul 2012 03:56:49 +0000 (20:56 -0700)]
[FileBackend] Doc formatting tweaks for doxygen.

Change-Id: I2741cb90d0afae4c38515d0c295b5f0085b54d56

11 years agoAdd Timo Tijhof (Krinkle) to the Special:Version credits.
Platonides [Mon, 16 Jul 2012 22:39:42 +0000 (00:39 +0200)]
Add Timo Tijhof (Krinkle) to the Special:Version credits.

Contributing as a core developer since October 2010, he is
known for his work on MediaWiki JavaScript.
Moreover, he was the only author with more than 500 commits
missing here. :)

Welcome, Timo!

Change-Id: Ibe0c0643cebb6cbaff2f84f265a0871c99d6807a

11 years agoadd optional limits argument to wgShellExec
Jan Gerber [Mon, 16 Jul 2012 20:06:57 +0000 (13:06 -0700)]
add optional limits argument to wgShellExec

add optional limits argument to overwrite
filesize, memory and time limits or a command
executed with wfShellExec.
Just having once size fits all $wgMaxShell* options
is not good enough for tasks that take long
or create large files (i.e. video transcoding)

Change-Id: I54148907bfd103fd28aff69baae03437efcfe1ee

11 years agoprevents some doxygen warnings
Antoine Musso [Sun, 15 Jul 2012 20:32:48 +0000 (22:32 +0200)]
prevents some doxygen warnings

This patch fix misc issues reported by doxygen. Nothing fancy.

Change-Id: I98edc8c877019f1dc4a82a37bca518df2eb904fc

11 years agoMerge "In LinkHolderArray::doVariants(), redlinks need to be checked as well."
Aaron Schulz [Sun, 15 Jul 2012 20:15:49 +0000 (20:15 +0000)]
Merge "In LinkHolderArray::doVariants(), redlinks need to be checked as well."

11 years agoescape HTML elements in docblock with double quotes
Antoine Musso [Sun, 15 Jul 2012 20:13:02 +0000 (22:13 +0200)]
escape HTML elements in docblock with double quotes

Doxygen choke on text enclosed by '<' and '>' since it tries to
interpret them as HTML or XML elements. This patch adds double quotes
in includes/api/*.php files around the two following strings:

 <Firstname>.<Lastname>@gmail.com
 <Firstname><Lastname>@gmail.com

Which becomes:

 "<Firstname>.<Lastname>@gmail.com"
 "<Firstname><Lastname>@gmail.com"

Tested locally, it prevents doxygen 1.8.0 related warnings.

Change-Id: I36d82eb3fd4989ee3ffc65b0b527b83711d1ba69

11 years agoMerge "Retrieve rev_len for sizediff in usercontributions API"
Aaron Schulz [Sun, 15 Jul 2012 20:12:16 +0000 (20:12 +0000)]
Merge "Retrieve rev_len for sizediff in usercontributions API"

11 years agoenhance DefaultSettings.php documentation
Antoine Musso [Tue, 10 Jul 2012 10:59:41 +0000 (12:59 +0200)]
enhance DefaultSettings.php documentation

This tweak our doxygen documentation for the DefaultSettings.php. Some
paragraphs were simply reformatted, some received additions.

To nicely render examples, I used the following snippet:

  @par Example:
  @code
  // some code there
  @endcode

That replaces all the <code> occurences.

Replaced some notes and warnings with @note and @warning to output a
nicely formatted box in our HTML documentation.

Change-Id: Iea8d4e46eac2d971af43d47499d121d0c4e2bff3

11 years agojshint: resources/jquery/*
Timo Tijhof [Tue, 3 Jul 2012 15:21:32 +0000 (17:21 +0200)]
jshint: resources/jquery/*

* .jshintrc: Updated to include more strict options that match
  our code conventions.
  Also separated into 3 groups:
  - stricter (curly, eqeqeq etc.)
  - laxer (smarttabs, laxbreak)
  - envrionment (browser)

* .jshintignore: Updated to include more third-party/upstream files
   that should not be linted.

* Most of it is just routine cleanup, a few notable points:

 - jquery.autoEllipsis: Removed unused variable $protectedText.

 - jquery.arrowSteps.js: Remove <!-- --> and language="javascript"
   that hasn't been needed for almost a decade.

 - jquery.byteLimit: Use dashToCamel key for .data(), this already
   happens internally in jQuery data(), since data storage should use
   keys that are usable as identifiers. The dashed versions are to
   populate these from data-attribute-names, which then becomes
   data.attributeNames. jQuery data() takes both forms as
   convenience.

 - jquery.client.js: To avoid a rewrite of it, allowing unexpected
   assignments (boss) and eval (evil) in the functions that use that.
   Left as it is for now, could use a rewrite later.

 - jquery.color.js: Tolerate unexpected assignment for now (boss).
   Left as it is for now, should perhaps be refactored later.
   Also re-ordered per jshint/jslint to put definition before
   invocation. This option can be disabled, but then it doesn't
   warn for invoking undefined functions (or typos) at all.

 - jquery.expandableField.js: Remove empty switch/case.

 - jquery.localize.js: Alias mw global.

 - jquery.suggestions.js: Use e.which; jQuery.Event normalizes
   e.keyCode etc.

 - jquery.tablesorter.js: Alias mw global.

 - jquery.textSelection.js: Fix leakage of variable in global scope
   of var "i" and "j".

 - mediawiki.util.test.js: Fixed implied global `pCustom`.

* Review with -w for your own sanity.

Change-Id: Ia972f79539a96a38357ec4e92b0b6e38cc301681

11 years ago(bug 38376) call to undefined method ThumbnailImage::getPath()
umherirrender [Fri, 13 Jul 2012 15:07:56 +0000 (17:07 +0200)]
(bug 38376) call to undefined method ThumbnailImage::getPath()

* Added MediaTransformOutput::getExtension() function and use it instead.
* Also fixed getScriptedTransform() to not pass the page as the path parameter.

Change-Id: I6c530aa155d62a6bfd5727c6f3d104fe91453745

11 years agoMerge "Make dates in sortable tables depend on page content language"
Nikerabbit [Sat, 14 Jul 2012 23:21:49 +0000 (23:21 +0000)]
Merge "Make dates in sortable tables depend on page content language"

11 years agoFor consistency of the interface, don't do expensive checks on page view.
Alexandre Emsenhuber [Sat, 14 Jul 2012 19:30:49 +0000 (21:30 +0200)]
For consistency of the interface, don't do expensive checks on page view.

Also replaced two $this->getUser() calls with $user since that variable is
already in that method.

Change-Id: Iccda9f44a9cf6d3187895a8b6111bc62dca1e811

11 years agoFix for: Fatal error: Call to undefined method ApiDelete::getErrorsArray()
Reedy [Sat, 14 Jul 2012 00:11:54 +0000 (01:11 +0100)]
Fix for: Fatal error:  Call to undefined method ApiDelete::getErrorsArray()

Fatal error:  Call to undefined method ApiDelete::getErrorsArray() in /usr/local/apache/common-local/php-1.20wmf7/includes/api/ApiDelete.php on line 65

Caused by https://gerrit.wikimedia.org/r/#/c/7572/

Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0

11 years agoMerge "Moved getDatabase() from contribs pager to Pager class."
MaxSem [Fri, 13 Jul 2012 22:07:44 +0000 (22:07 +0000)]
Merge "Moved getDatabase() from contribs pager to Pager class."

11 years agoMerge "'lang' attrib in #mw-imagepage-content should use ->getHtmlCode()"
Siebrand [Fri, 13 Jul 2012 20:36:30 +0000 (20:36 +0000)]
Merge "'lang' attrib in #mw-imagepage-content should use ->getHtmlCode()"

11 years agoMerge "Update messages.inc and rebuild MessagesEn.php."
Siebrand [Fri, 13 Jul 2012 20:34:43 +0000 (20:34 +0000)]
Merge "Update messages.inc and rebuild MessagesEn.php."

11 years agoMerge "(bug 37587) Enforce language codes to be html safe"
Siebrand [Fri, 13 Jul 2012 19:47:33 +0000 (19:47 +0000)]
Merge "(bug 37587) Enforce language codes to be html safe"

11 years ago(bug 37249) validate export-demo.xml against current export.xsd
umherirrender [Sat, 30 Jun 2012 08:06:35 +0000 (10:06 +0200)]
(bug 37249) validate export-demo.xml against current export.xsd

Change-Id: I9031a1b3338fe69b8860caf9cac59a66e0e09fc1

11 years agoUpdate messages.inc and rebuild MessagesEn.php.
Alexandre Emsenhuber [Sat, 7 Jul 2012 14:16:00 +0000 (16:16 +0200)]
Update messages.inc and rebuild MessagesEn.php.

It allways annoys me to have lot of unwanted changes when
changing MessagesEn.php and rebuilding it when adding a new
messages, so I'm doing this in a separate change.

Change-Id: I71e1a7028e96eedfa522f6270aa618aa33e3ce17

11 years agoMoved getDatabase() from contribs pager to Pager class.
Aaron [Fri, 13 Jul 2012 18:47:01 +0000 (11:47 -0700)]
Moved getDatabase() from contribs pager to Pager class.

Change-Id: I9443ecd18cdaca614aa446b5457c837a039dafe3

11 years agoMerge "merge two foreach in Special:Contributions"
Aaron Schulz [Fri, 13 Jul 2012 18:44:18 +0000 (18:44 +0000)]
Merge "merge two foreach in Special:Contributions"

11 years agoMerge "(bug 38093) Gender of changed user groups missing in log"
Aaron Schulz [Fri, 13 Jul 2012 18:40:44 +0000 (18:40 +0000)]
Merge "(bug 38093) Gender of changed user groups missing in log"

11 years agoMerge "Add call to GenderCache in list=allpages"
Aaron Schulz [Fri, 13 Jul 2012 18:38:16 +0000 (18:38 +0000)]
Merge "Add call to GenderCache in list=allpages"

11 years agoMerge "Add userToolLinks on Special:FileDuplicateSearch"
Aaron Schulz [Fri, 13 Jul 2012 18:30:16 +0000 (18:30 +0000)]
Merge "Add userToolLinks on Special:FileDuplicateSearch"

11 years agoMerge "fix diff against archived revision deleted version"
Aaron Schulz [Fri, 13 Jul 2012 18:17:56 +0000 (18:17 +0000)]
Merge "fix diff against archived revision deleted version"

11 years agoMerge "Sort result of FileRepo::findBySha1"
Aaron Schulz [Fri, 13 Jul 2012 18:14:28 +0000 (18:14 +0000)]
Merge "Sort result of FileRepo::findBySha1"

11 years agoMerge "Increase length of edit summary by 5 bytes"
Aaron Schulz [Fri, 13 Jul 2012 18:13:48 +0000 (18:13 +0000)]
Merge "Increase length of edit summary by 5 bytes"

11 years agoSort result of FileRepo::findBySha1
umherirrender [Sun, 8 Jul 2012 08:45:21 +0000 (10:45 +0200)]
Sort result of FileRepo::findBySha1

This sorts the result on Special:FileDuplicateSearch, which is unsorted,
when merged from different repos.

Adding File::compare similar to Title::compare for this

Change-Id: I32e8be92c6067f9e13f3ecd1039c337b0fc3e840

11 years agoIncrease length of edit summary by 5 bytes
umherirrender [Fri, 13 Jul 2012 18:07:34 +0000 (20:07 +0200)]
Increase length of edit summary by 5 bytes

Language::truncate subtracts the length of ellipses from the whole
length since 1.18, that means, there is no need for a buffer for the
ellipses.

Change-Id: I5c39a6c4160f16156c8928dd954f065f9e3c7a5c

11 years agoMerge "memcached: better error messaging"
Aaron Schulz [Fri, 13 Jul 2012 18:04:47 +0000 (18:04 +0000)]
Merge "memcached: better error messaging"

11 years agoMerge "Fix casing of wgDBerrorLogInUtc"
Reedy [Fri, 13 Jul 2012 18:03:15 +0000 (18:03 +0000)]
Merge "Fix casing of wgDBerrorLogInUtc"

11 years agoFix casing of wgDBerrorLogInUtc
Reedy [Fri, 13 Jul 2012 18:02:12 +0000 (19:02 +0100)]
Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de

11 years agoMerge "Do not show empty categories with list=allcategories"
Aaron Schulz [Fri, 13 Jul 2012 17:27:05 +0000 (17:27 +0000)]
Merge "Do not show empty categories with list=allcategories"

11 years agoMerge "Exception on Special:NewFiles, when no bot group is defined"
Aaron Schulz [Fri, 13 Jul 2012 17:25:29 +0000 (17:25 +0000)]
Merge "Exception on Special:NewFiles, when no bot group is defined"

11 years agoMerge "cleanup callback in usort call"
Aaron Schulz [Fri, 13 Jul 2012 17:24:57 +0000 (17:24 +0000)]
Merge "cleanup callback in usort call"

11 years agomemcached: better error messaging
Antoine Musso [Fri, 13 Jul 2012 16:20:00 +0000 (18:20 +0200)]
memcached: better error messaging

MemcachedClient output a generic error message: "Error parsing memcached
response\n" whenever it is not able to read from the socket. It is also
lacking the remote peer it is reading form.

This patch add a new message when fgets( <socket> ) return false and
attempt to get the remote peer address / port to append to the error
message. Might help us find out which memcached server is wild.

Change-Id: If918e824970aaa8231078e42fd28d31e8dd4e319

11 years agoMerge "ignore all local bot groups in newbie mode on Special:Contribs"
Aaron Schulz [Fri, 13 Jul 2012 15:38:16 +0000 (15:38 +0000)]
Merge "ignore all local bot groups in newbie mode on Special:Contribs"