lhc/web/wiklou.git
8 years agoMerge "Introduce top level service locator."
jenkins-bot [Sun, 3 Apr 2016 07:26:31 +0000 (07:26 +0000)]
Merge "Introduce top level service locator."

8 years agoMerge "Update IP address related message text"
jenkins-bot [Sun, 3 Apr 2016 06:26:52 +0000 (06:26 +0000)]
Merge "Update IP address related message text"

8 years agoMerge "resourceloader: Make action=purge affect ResourceLoaderWikiModule"
jenkins-bot [Sun, 3 Apr 2016 02:50:29 +0000 (02:50 +0000)]
Merge "resourceloader: Make action=purge affect ResourceLoaderWikiModule"

8 years agoresourceloader: Make action=purge affect ResourceLoaderWikiModule
Timo Tijhof [Sat, 2 Apr 2016 20:50:48 +0000 (21:50 +0100)]
resourceloader: Make action=purge affect ResourceLoaderWikiModule

Purging a wiki page included in a WikiModule should bump its version hash.
This is not needed by design, but it's a workaround until our caching layers
are more resilient against cache poisoning.

This gives users the power to resolve issues themselves.

Change-Id: I37d3379e76a6b652268c5a007e0ad741470fe6e1

8 years agoMerge "mediawiki.user: Use wgUserGroups for getGroups() rather than AJAX"
jenkins-bot [Sat, 2 Apr 2016 21:22:25 +0000 (21:22 +0000)]
Merge "mediawiki.user: Use wgUserGroups for getGroups() rather than AJAX"

8 years agomediawiki.user: Use wgUserGroups for getGroups() rather than AJAX
Matthew Flaschen [Thu, 31 Mar 2016 20:50:28 +0000 (16:50 -0400)]
mediawiki.user: Use wgUserGroups for getGroups() rather than AJAX

Use wgUserGroups to implement getGroups, rather than an API request.

wgUserGroups and ApiQueryUserInfo both use $user->getEffectiveGroups()
unprocessed.

mw.Api.plugin.user is still useful because rights are not available
client-side, and it can be used for groups with ForeignApi.

Change-Id: Id9c7805de1d02e267dbd2bba833e90a6df117dee

8 years agoReword and clarify API messages
IoannisKydonis [Wed, 20 Jan 2016 21:22:31 +0000 (23:22 +0200)]
Reword and clarify API messages

Threads:
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-upload-param-leavemessage/uk
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-main-param-maxlag/ksh
https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-import-param-summary/en

Change-Id: I71404b96fe48fed62b50ff2f544da97bd925e9d7

8 years agoUpdate IP address related message text
Siebrand Mazeland [Sat, 2 Apr 2016 19:14:29 +0000 (21:14 +0200)]
Update IP address related message text

Follow-up to Change-Id: I02fecf0b9e6a5b90f7a24209c7a1cdce64060b23

Change-Id: I36a99f21b4269af0799ce73faee7e19865c5f22f

8 years agoBump composer/semver to 1.4.0
Reedy [Sat, 2 Apr 2016 18:19:44 +0000 (19:19 +0100)]
Bump composer/semver to 1.4.0

Depends-On: I4463dd4abe1972f4e3a4bcc6389dc861ecc8201a
Change-Id: I263b1ad4b45410d0704c195f485d27cbbe068e26

8 years agoRemove deprecated calling style of UserMailer::send()
Reedy [Thu, 21 Jan 2016 01:12:41 +0000 (01:12 +0000)]
Remove deprecated calling style of UserMailer::send()

Depends-On: I513639f706ce16334180908f55638eebf8a4de80
Depends-On: I3fce6c666e2c878a221e2e4c6acacfd0254d173a
Change-Id: I475932f37a579dd86bfd98e6b14509d6ba86f128

8 years agoMerge "Don't construct SpecialPages twice"
jenkins-bot [Sat, 2 Apr 2016 17:51:43 +0000 (17:51 +0000)]
Merge "Don't construct SpecialPages twice"

8 years agoMerge "Use IP address range instead of IP range"
jenkins-bot [Sat, 2 Apr 2016 17:47:31 +0000 (17:47 +0000)]
Merge "Use IP address range instead of IP range"

8 years agoMerge "Better punctuation in uploadstash-badtoken"
jenkins-bot [Sat, 2 Apr 2016 17:43:01 +0000 (17:43 +0000)]
Merge "Better punctuation in uploadstash-badtoken"

8 years agoUse IP address range instead of IP range
Siebrand Mazeland [Sat, 2 Apr 2016 15:55:34 +0000 (17:55 +0200)]
Use IP address range instead of IP range

We use "IP address" consistently instead of "IP", but this was never
applied to the "range" addition.

Change-Id: I02fecf0b9e6a5b90f7a24209c7a1cdce64060b23

8 years agoMerge "Fix Undefined index: 0 in SearchExactMatchRescorer.php on line 44"
jenkins-bot [Sat, 2 Apr 2016 17:21:13 +0000 (17:21 +0000)]
Merge "Fix Undefined index: 0 in SearchExactMatchRescorer.php on line 44"

8 years agoMerge "Generalize recentChangesFlags rollup"
jenkins-bot [Sat, 2 Apr 2016 16:21:12 +0000 (16:21 +0000)]
Merge "Generalize recentChangesFlags rollup"

8 years agoMerge "Improve blocked-mailpassword phrasing"
jenkins-bot [Sat, 2 Apr 2016 16:20:17 +0000 (16:20 +0000)]
Merge "Improve blocked-mailpassword phrasing"

8 years agoMerge "Rename Special:ListGroupRights in Czech"
jenkins-bot [Sat, 2 Apr 2016 16:05:32 +0000 (16:05 +0000)]
Merge "Rename Special:ListGroupRights in Czech"

8 years agoMerge "resourceloader: Remove wfExpandUrl() from ResourceLoaderImage"
jenkins-bot [Sat, 2 Apr 2016 15:54:18 +0000 (15:54 +0000)]
Merge "resourceloader: Remove wfExpandUrl() from ResourceLoaderImage"

8 years agoImprove blocked-mailpassword phrasing
Amire80 [Sat, 2 Apr 2016 15:46:36 +0000 (18:46 +0300)]
Improve blocked-mailpassword phrasing

Change-Id: I2fa9d0050908fa40c3a5808aa0ed9cd53dc0e345

8 years agoDon't construct SpecialPages twice
Florian [Sat, 2 Apr 2016 14:39:50 +0000 (16:39 +0200)]
Don't construct SpecialPages twice

If the special page object was already created for the request, there's
no need to create the object again. Save the created result (object, null)
in a global static array and return the value if the realName was already
created.

Bug: T123995
Change-Id: I70bf0e93e45f4b0597deaef717f5eb87c66f0a71

8 years agoIntroduce top level service locator.
daniel [Mon, 12 Oct 2015 08:05:45 +0000 (10:05 +0200)]
Introduce top level service locator.

The service locator, MediaWikiServices, is intended to facilitate
"manual" dependency injection in static entry points.

See also the Dependency Injection RFC T384 and Service Locator
RFC T124792 for details.
The following key points were implemented according the
discussion surrounding these RFCs:

* a configurable DI container that allows extensions to add and replace services.
* no auto-wiring, since it's prone to add confusion in large and complex applications.
* no 3rd party framework, since they typically do too much.

The following services in MediaWiki core are made accessible via the service locator
mechanism to showcase the bootstrapping mechanism:

* ConfigFactory and MainConfig
* SiteLookup and SiteStore

However, the implementation of these services was not yet converted to using proper DI
throughout the code.

Bug: T124792
Change-Id: I3c25c0ac17300d3dd13e1cf5100558a605eee15f

8 years agoMerge "Split Page interface into own file"
jenkins-bot [Sat, 2 Apr 2016 13:52:04 +0000 (13:52 +0000)]
Merge "Split Page interface into own file"

8 years agoMerge "Introduce StatsdAwareInterface"
jenkins-bot [Sat, 2 Apr 2016 13:43:23 +0000 (13:43 +0000)]
Merge "Introduce StatsdAwareInterface"

8 years agoSplit Page interface into own file
addshore [Sat, 2 Apr 2016 13:35:20 +0000 (16:35 +0300)]
Split Page interface into own file

Change-Id: Ib2e23f63e47a3da19e30f4a8d61372ee0f26851d

8 years agoGeneralize recentChangesFlags rollup
amir [Wed, 23 Mar 2016 15:25:44 +0000 (19:55 +0430)]
Generalize recentChangesFlags rollup

Flags can be either 'any' or 'all' type, and both core and extension flags will be
rolled up into the top-level line of grouped changes.

See Ic49a355a2

Bug: T120921
Bug: T112856
Change-Id: If9fd6af3ac7ac2fbee9aa5536fe94d7574699966

8 years agoIntroduce StatsdAwareInterface
addshore [Sat, 2 Apr 2016 09:24:59 +0000 (12:24 +0300)]
Introduce StatsdAwareInterface

Change-Id: Iac343e4b448d9af852b4c479c35a9ff60359b6d5

8 years agoRemove Title::newFromRedirectArray
Florian [Sat, 2 Apr 2016 08:18:20 +0000 (10:18 +0200)]
Remove Title::newFromRedirectArray

Bug: T122754
Change-Id: I2cdeb98c81d4b98ea986bd2f7b23cd93c62c5930

8 years agoMove statsd files in libs to own directory
addshore [Sat, 2 Apr 2016 09:22:00 +0000 (12:22 +0300)]
Move statsd files in libs to own directory

Change-Id: Ia3ac9441d7548fedb672e3f2567be7c4eafae208

8 years agoIntroduce NullStatsdDataFactory
addshore [Sat, 2 Apr 2016 09:18:54 +0000 (12:18 +0300)]
Introduce NullStatsdDataFactory

I have left the phpdocs in NullStatsdDataFactory
to clearly show the return types of the interface
implemented.

Change-Id: I96cb64b4af16fc087028269a53d539f8c132f81c

8 years agoMerge "Show time left until block expiry in BlockListPager"
jenkins-bot [Sat, 2 Apr 2016 12:08:56 +0000 (12:08 +0000)]
Merge "Show time left until block expiry in BlockListPager"

8 years agoShow time left until block expiry in BlockListPager
Florian [Thu, 24 Mar 2016 17:52:25 +0000 (18:52 +0100)]
Show time left until block expiry in BlockListPager

Bug: T130441
Change-Id: I1729b49ebb631a597bb88655b37dd45746e4d646

8 years agoMerge "jquery.ui.datepicker: Add translations in de-AT and de-CH"
jenkins-bot [Sat, 2 Apr 2016 11:54:58 +0000 (11:54 +0000)]
Merge "jquery.ui.datepicker: Add translations in de-AT and de-CH"

8 years agoMerge "Allow SiteStatsInit to run on vslow hosts"
jenkins-bot [Sat, 2 Apr 2016 11:30:00 +0000 (11:30 +0000)]
Merge "Allow SiteStatsInit to run on vslow hosts"

8 years agoMerge "Fix typo in HtmlForm::setName phpdoc"
jenkins-bot [Sat, 2 Apr 2016 09:48:20 +0000 (09:48 +0000)]
Merge "Fix typo in HtmlForm::setName phpdoc"

8 years agoMerge "DifferenceEngine::setText() was removed"
jenkins-bot [Sat, 2 Apr 2016 09:39:13 +0000 (09:39 +0000)]
Merge "DifferenceEngine::setText() was removed"

8 years agoFix typo in HtmlForm::setName phpdoc
Gergő Tisza [Sat, 2 Apr 2016 09:34:51 +0000 (09:34 +0000)]
Fix typo in HtmlForm::setName phpdoc

Fixes I85f5492e0b99a5661dbed9814a0e3f3b9bc63d32.

Change-Id: I1a034c4fd3eb3020a4a725604ece6e992d34a271

8 years agoMerge "Add GENDER support to $3 in logentry-rights-rights"
jenkins-bot [Sat, 2 Apr 2016 09:23:14 +0000 (09:23 +0000)]
Merge "Add GENDER support to $3 in logentry-rights-rights"

8 years agoDifferenceEngine::setText() was removed
Reedy [Sat, 2 Apr 2016 08:21:09 +0000 (09:21 +0100)]
DifferenceEngine::setText() was removed

Bug: T122754
Change-Id: I796f0c4d86d0d5a8c2b24820dc84b18a7dc50981
Depends-On: Ia52054a85944f51adb8a644e703db02f6833b262

8 years agoAdd hint to /qqq about GENDER support
matejsuchanek [Sat, 2 Apr 2016 09:07:49 +0000 (11:07 +0200)]
Add hint to /qqq about GENDER support

https://translatewiki.net/wiki/MediaWiki:Ipb-needreblock/qqq

Bug: T125230
Change-Id: I71bf5e87a9076bc75c4f454cbc491a6d2521192c

8 years agoMerge "Article::getUndoText() and WikiPage::getUndoText were removed"
jenkins-bot [Sat, 2 Apr 2016 08:57:07 +0000 (08:57 +0000)]
Merge "Article::getUndoText() and WikiPage::getUndoText were removed"

8 years agoMerge "Add prefered magic words first"
jenkins-bot [Sat, 2 Apr 2016 08:43:43 +0000 (08:43 +0000)]
Merge "Add prefered magic words first"

8 years agoArticle::getUndoText() and WikiPage::getUndoText were removed
Reedy [Sat, 2 Apr 2016 08:34:14 +0000 (09:34 +0100)]
Article::getUndoText() and WikiPage::getUndoText were removed

Bug: T122754
Change-Id: I9eb4094e313325be3dfbf1409f8caffdcc3abfc2
Depends-On: I6aed90eb6064bb0d3055aed7b6cdefc45e6de878

8 years agoAdd prefered magic words first
eranroz [Wed, 21 Oct 2015 20:15:04 +0000 (23:15 +0300)]
Add prefered magic words first

When there are multiple aliases, the first alias MUST be the
preferred alias in that language, so that wikitext code
generators can generate the desired syntax.

The other aliases SHOULD be sorted by the following convention:
- Local first, English last
- Most common first, least common last

Bug: T116020
Change-Id: Ia670512e0cb375335873e7f9a08b638bbe039e45

8 years agoMerge "Collapse superfluous isset() call"
jenkins-bot [Sat, 2 Apr 2016 08:13:10 +0000 (08:13 +0000)]
Merge "Collapse superfluous isset() call"

8 years agopage: Remove outdated comment in getRedirectHeaderHtml()
Timo Tijhof [Thu, 24 Mar 2016 21:49:48 +0000 (21:49 +0000)]
page: Remove outdated comment in getRedirectHeaderHtml()

Follows-up c24a0a15b.

Change-Id: Ie4e7d5bb1dc34130d54fa0a61cd03f97fd1f9145

8 years agoLoadBalancer::pickRandom() was removed
Reedy [Fri, 1 Apr 2016 20:21:59 +0000 (21:21 +0100)]
LoadBalancer::pickRandom() was removed

Bug: T122754
Change-Id: I85d0c4387195cb60c70e24a0a7ab338723e6e7f4

8 years agoSkin::getUsableSkins() was removed
Siebrand Mazeland [Wed, 9 Mar 2016 00:12:14 +0000 (01:12 +0100)]
Skin::getUsableSkins() was removed

Deprecated since 1.23. The remaining use in extension ThemeDesigner was
replaced.

Change-Id: I36b6c1e1d95036d40a01395f86a01906e8c50a76

8 years agoMerge "Support custom query in pt-heartbeat lag detection "
jenkins-bot [Sat, 2 Apr 2016 00:16:24 +0000 (00:16 +0000)]
Merge "Support custom query in pt-heartbeat lag detection  "

8 years agoMerge "resourceloader: Avoid Title::newMainPage() to support $wgForceUIMsgAsContentMsg"
jenkins-bot [Sat, 2 Apr 2016 00:15:19 +0000 (00:15 +0000)]
Merge "resourceloader: Avoid Title::newMainPage() to support $wgForceUIMsgAsContentMsg"

8 years agoMerge "Skin::newFromKey() was removed"
jenkins-bot [Sat, 2 Apr 2016 00:15:15 +0000 (00:15 +0000)]
Merge "Skin::newFromKey() was removed"

8 years agoMerge "Skin::getCommonStylePath() was removed"
jenkins-bot [Sat, 2 Apr 2016 00:09:16 +0000 (00:09 +0000)]
Merge "Skin::getCommonStylePath() was removed"

8 years agoMerge "Skin::commonPrintStylesheet() was removed"
jenkins-bot [Sat, 2 Apr 2016 00:09:07 +0000 (00:09 +0000)]
Merge "Skin::commonPrintStylesheet() was removed"

8 years agoSupport custom query in pt-heartbeat lag detection
Aaron Schulz [Tue, 8 Mar 2016 20:36:03 +0000 (12:36 -0800)]
Support custom query in pt-heartbeat lag detection

Bug: T111266
Change-Id: Ib0f9ca8072d9becebacfa8c9afe9d61567f73912

8 years agoresourceloader: Avoid Title::newMainPage() to support $wgForceUIMsgAsContentMsg
Brad Jorsch [Tue, 29 Mar 2016 18:15:12 +0000 (14:15 -0400)]
resourceloader: Avoid Title::newMainPage() to support $wgForceUIMsgAsContentMsg

$wgForceUIMsgAsContentMsg forces Message::inContentLanguage() to not
actually do anything, thus falling back to the session user's language
which we can't use in ResourceLoader. And 'mainpage' is added to that
array on various multi-lingual wikis.

Bug: T127233
Change-Id: I9dc1e57922641881b36c70658083c2c8c8a608a0

8 years agoresourceloader: Remove wfExpandUrl() from ResourceLoaderImage
Timo Tijhof [Fri, 1 Apr 2016 23:22:29 +0000 (00:22 +0100)]
resourceloader: Remove wfExpandUrl() from ResourceLoaderImage

Follows-up b5e69c4ef which did the same for already for ResourceLoader.php.

There's no need to expand the hostname into these urls. If load.php
is on the same domain (e.g. set to '/w/load.php') then this can be
resolved by the browser normally.

If load.php is on a custom domain, the stylesheet would be served
from there instead of from the wiki domain. However in that case
the hostname would already be part of $script value ($wgLoadScript).

Bug: T125292
Change-Id: I7242445335d69d7ae290da5f321a59edd537d819

8 years agoDisable flaky UIDGeneratorTest::testTimestampedUID test
Timo Tijhof [Fri, 1 Apr 2016 23:05:47 +0000 (00:05 +0100)]
Disable flaky UIDGeneratorTest::testTimestampedUID test

Currently causing builds to break all over the place. Disable
until someone can attend to it.

Bug: T131549
Change-Id: I0eb29c53e70ef84a4facc137a3bf20f64a673511

8 years agoSkin::newFromKey() was removed
Siebrand Mazeland [Wed, 9 Mar 2016 00:09:54 +0000 (01:09 +0100)]
Skin::newFromKey() was removed

Deprecated since 1.24. No uses in core or Gerrit extensions remaining.

Change-Id: If5d18ec56a066ea3ab28503b1bf5a84a8588ba5a

8 years agoSkin::getCommonStylePath() was removed
Siebrand Mazeland [Wed, 9 Mar 2016 00:03:04 +0000 (01:03 +0100)]
Skin::getCommonStylePath() was removed

Deprecated since 1.24. No uses in core or Gerrit extensions remaining.

Change-Id: I15629292f00b6d2493f7a329670d85c76da50db9

8 years agoSkin::commonPrintStylesheet() was removed
Siebrand Mazeland [Wed, 9 Mar 2016 00:01:12 +0000 (01:01 +0100)]
Skin::commonPrintStylesheet() was removed

Deprecated since 1.22. Removed from only use in Gerrit extension
ThemeDesigner.

Change-Id: Ib6d72eff90f4ffef69274db364157b416455f17d

8 years agoRemove Title::newFromRedirect()
Florian [Fri, 1 Apr 2016 20:32:36 +0000 (22:32 +0200)]
Remove Title::newFromRedirect()

Deprecated since 1.21.

Bug: T122754
Change-Id: Iddf1c2d61cafc017bf361b747db38ac1bc5f3f09

8 years agoMove changes to the right section in RELEASE-NOTES
Florian [Fri, 1 Apr 2016 20:35:44 +0000 (22:35 +0200)]
Move changes to the right section in RELEASE-NOTES

Change-Id: I4808d627d7bdb6b16e7f75d82de0ed5de6dc18fa

8 years agoMerge "Remove (WikiPage|Article)::replaceSection()"
Reedy [Fri, 1 Apr 2016 21:23:45 +0000 (21:23 +0000)]
Merge "Remove (WikiPage|Article)::replaceSection()"

8 years agoCollapse superfluous isset() call
Reedy [Fri, 1 Apr 2016 21:12:00 +0000 (22:12 +0100)]
Collapse superfluous isset() call

Change-Id: I525f5ce4553f67eb4a5ceea2b622dbdb034c88e1

8 years agoFollow up I63cdc0
Florian [Fri, 1 Apr 2016 21:06:35 +0000 (23:06 +0200)]
Follow up I63cdc0

Don't unset the default configuration in Setup.php.

Change-Id: I8d8c54a6188b541dbdb7b2b84c0061fe4ac7cc49
Follow-up: I63cdc0a7fd51ca3a45dc2fd83b22eb58a8de520c

8 years agoRemove (WikiPage|Article)::replaceSection()
Florian [Fri, 1 Apr 2016 19:56:56 +0000 (21:56 +0200)]
Remove (WikiPage|Article)::replaceSection()

Bug: T122754
Change-Id: I1415c8de7be3b9d952fad265b439dd820e284fb2
Depends-On: I3d37f7e778d569970ed749c22ba49a63cc4ba0ec

8 years agoRemove MediaWikiSite::newFromGlobalId (deprecated since 1.21)
Florian [Fri, 1 Apr 2016 19:31:37 +0000 (21:31 +0200)]
Remove MediaWikiSite::newFromGlobalId (deprecated since 1.21)

Isn't used anymore anywhere.

Bug: T122754
Change-Id: I95b20c005721837dcbf9ab979674ac09c460cdd0

8 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 1 Apr 2016 20:09:37 +0000 (20:09 +0000)]
Merge "Localisation updates from https://translatewiki.net."

8 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 1 Apr 2016 19:58:59 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie0a08fde2970106bae564551bb6ed6bd76f8a9da

8 years agoApiPageSet::finishPageSetGeneration() was removed
Reedy [Fri, 1 Apr 2016 19:41:59 +0000 (20:41 +0100)]
ApiPageSet::finishPageSetGeneration() was removed

Bug:T122754
Change-Id: I106f37f5f83e30222a602d88704069ceccc91a29

8 years agoRemoved ApiMain::(getFormats|addFormat|addModule|getShowVersions).
Reedy [Fri, 1 Apr 2016 19:38:11 +0000 (20:38 +0100)]
Removed ApiMain::(getFormats|addFormat|addModule|getShowVersions).

Deprecated since 1.21

Bug: T122754
Change-Id: Id5cbc50e45cdfdfeb2e92faffc7ded868a350f4b

8 years agoRemove $wgCopyrightIcon
Florian [Sat, 2 Jan 2016 21:49:29 +0000 (22:49 +0100)]
Remove $wgCopyrightIcon

Bug: T122754
Depends-On: I3181d4830153d052bff87de5d2347a51fbd5f520
Change-Id: I63cdc0a7fd51ca3a45dc2fd83b22eb58a8de520c

8 years agoRemove Revision::getRawText()
Florian [Wed, 13 Jan 2016 19:38:12 +0000 (20:38 +0100)]
Remove Revision::getRawText()

Bug: T122754
Depends-On: I742f02021959587edd83a4cfb25e0338d05a8e81
Depends-On: I10283802c26b99d7e345c5c06d59c4ea24002e52
Depends-On: I6da4fab1e0e8f698b824e977dd2336e4415ae1ba
Change-Id: Id1cfda59e381673be99d9561c9997c0baf26d425

8 years agoMerge "Track the use of the WatchedItemStore Cache"
jenkins-bot [Fri, 1 Apr 2016 14:59:43 +0000 (14:59 +0000)]
Merge "Track the use of the WatchedItemStore Cache"

8 years agoMerge "Allow SpecialPage::beforeExecute to prevent execution"
jenkins-bot [Fri, 1 Apr 2016 14:58:49 +0000 (14:58 +0000)]
Merge "Allow SpecialPage::beforeExecute to prevent execution"

8 years agoMerge "Add WatchedItemStoreUnitTest::newWatchedItemStore"
jenkins-bot [Fri, 1 Apr 2016 14:54:13 +0000 (14:54 +0000)]
Merge "Add WatchedItemStoreUnitTest::newWatchedItemStore"

8 years agoMerge "Allow HTMLFormField placeholder to be a message"
jenkins-bot [Fri, 1 Apr 2016 14:48:23 +0000 (14:48 +0000)]
Merge "Allow HTMLFormField placeholder to be a message"

8 years agoMerge "Unify handling of *-message(s) settings in HTMLForm"
jenkins-bot [Fri, 1 Apr 2016 14:48:19 +0000 (14:48 +0000)]
Merge "Unify handling of *-message(s) settings in HTMLForm"

8 years agoAllow HTMLFormField placeholder to be a message
Gergő Tisza [Fri, 1 Apr 2016 12:06:49 +0000 (15:06 +0300)]
Allow HTMLFormField placeholder to be a message

Change-Id: Ib135a8792dcf03fd2246c208ab4c8185caef2ac6

8 years agoMerge "Fix Session::getToken phpdoc"
jenkins-bot [Fri, 1 Apr 2016 14:17:03 +0000 (14:17 +0000)]
Merge "Fix Session::getToken phpdoc"

8 years agoMerge "Fix StatusValue phpdoc"
jenkins-bot [Fri, 1 Apr 2016 14:16:24 +0000 (14:16 +0000)]
Merge "Fix StatusValue phpdoc"

8 years agoMerge "Allow setting HTMLForm name"
jenkins-bot [Fri, 1 Apr 2016 14:16:20 +0000 (14:16 +0000)]
Merge "Allow setting HTMLForm name"

8 years agoMerge "Add flag to HTMLTextField to not persist submitted data"
jenkins-bot [Fri, 1 Apr 2016 14:16:16 +0000 (14:16 +0000)]
Merge "Add flag to HTMLTextField to not persist submitted data"

8 years agoMerge "Use default value instead of submitted value in HTMLForm buttons"
jenkins-bot [Fri, 1 Apr 2016 14:16:12 +0000 (14:16 +0000)]
Merge "Use default value instead of submitted value in HTMLForm buttons"

8 years agoUnify handling of *-message(s) settings in HTMLForm
Gergő Tisza [Fri, 1 Apr 2016 12:00:44 +0000 (15:00 +0300)]
Unify handling of *-message(s) settings in HTMLForm

*-message(s) settings were documented as message key strings or arrays
of message key strings, but some actually accepted [key, params...]
arrays as well. They did not accept Message objects, which would be
the cleanest and most flexible method of message passing.

The patch adds a new method to process these settings (which accepts
a messages key, a [key, params...] array or a Message object), and
makes all *-message(s) usage call that.

Change-Id: Ida647973a58bea83fdbd53335e63b5a8615c16e4

8 years agoMerge "Fix missing variable in HTMLFormField exceptions"
jenkins-bot [Fri, 1 Apr 2016 13:49:40 +0000 (13:49 +0000)]
Merge "Fix missing variable in HTMLFormField exceptions"

8 years agoAllow SpecialPage::beforeExecute to prevent execution
Gergő Tisza [Fri, 1 Apr 2016 12:51:04 +0000 (15:51 +0300)]
Allow SpecialPage::beforeExecute to prevent execution

Allos SpecialPage::beforeExecute() (and the equivalent
SpecialPageBeforeExecute hook) to prevent execution of the page
by returning false.

Needed by I8b52ec8ddf494f23941807638f149f15b5e46b0c.

Change-Id: I71423b920d596ee9ae6da60d95b14255eddfbcd6

8 years agoFix Session::getToken phpdoc
Gergő Tisza [Fri, 1 Apr 2016 12:46:11 +0000 (15:46 +0300)]
Fix Session::getToken phpdoc

Change-Id: I332c623b08bbc980494c9ba01da77bad5c205038

8 years agoFix StatusValue phpdoc
Gergő Tisza [Fri, 1 Apr 2016 12:44:10 +0000 (15:44 +0300)]
Fix StatusValue phpdoc

Change-Id: Ie30ebf9bd89c4e2594e806a1b52f5716a32e11ec

8 years agoAllow setting HTMLForm name
Gergő Tisza [Fri, 1 Apr 2016 12:08:18 +0000 (15:08 +0300)]
Allow setting HTMLForm name

Change-Id: I85f5492e0b99a5661dbed9814a0e3f3b9bc63d32

8 years agoFix missing variable in HTMLFormField exceptions
Gergő Tisza [Fri, 1 Apr 2016 12:05:12 +0000 (15:05 +0300)]
Fix missing variable in HTMLFormField exceptions

Change-Id: Ie61f170e9117dde7ece05b04573a3c4902b19e56

8 years agoAdd flag to HTMLTextField to not persist submitted data
Gergő Tisza [Fri, 1 Apr 2016 11:54:15 +0000 (14:54 +0300)]
Add flag to HTMLTextField to not persist submitted data

Sometimes the submitted text is not expected to show up as default
when the form is redisplayed after an error; password fields are
the obvious example for this, but in some cases (e.g. two-factor
token) it is useful for a normal text field to act like that as well.

The patch adds a new 'persistent' flag to HTMLTextField, which
defaults to false for passwords and true otherwise.

Change-Id: If0a52f61aa061bbb55bfdc76321ace7d3eaed934

8 years agoUse default value instead of submitted value in HTMLForm buttons
Gergő Tisza [Fri, 1 Apr 2016 11:49:49 +0000 (14:49 +0300)]
Use default value instead of submitted value in HTMLForm buttons

In some exotic use cases where the form is rendered straight from
a successful submit this prevents unexpected button text changes.

Change-Id: I61619b6222d9fb29c63ce7c1f3ceff512143c4f7

8 years agoTrack the use of the WatchedItemStore Cache
addshore [Fri, 1 Apr 2016 12:03:52 +0000 (15:03 +0300)]
Track the use of the WatchedItemStore Cache

Change-Id: Idc33dd6a52471e895b312fa2c6562a90bf3d7861

8 years agoMerge "Add phpdoc and @since to SpecialUserrights::makeGroupNameList"
jenkins-bot [Fri, 1 Apr 2016 11:59:30 +0000 (11:59 +0000)]
Merge "Add phpdoc and @since to SpecialUserrights::makeGroupNameList"

8 years agoAdd WatchedItemStoreUnitTest::newWatchedItemStore
addshore [Fri, 1 Apr 2016 11:46:15 +0000 (14:46 +0300)]
Add WatchedItemStoreUnitTest::newWatchedItemStore

Change-Id: Ic3e1d23b8f707ae5e3221d1c2fd08878ae8bfff9

8 years agoMerge "UserrightsPage::makeGroupNameListForLog() was removed"
jenkins-bot [Fri, 1 Apr 2016 11:47:19 +0000 (11:47 +0000)]
Merge "UserrightsPage::makeGroupNameListForLog() was removed"

8 years agoAllow SiteStatsInit to run on vslow hosts
Sébastien Santoro [Fri, 1 Apr 2016 11:35:40 +0000 (11:35 +0000)]
Allow SiteStatsInit to run on vslow hosts

SiteStatsInits queries could be long running, and so lead to buffers
and undo table issues.

This change allows SiteStatsInits to connect to vslow host.

Bug: T131475
Change-Id: I63c643ef3cc12f38c24374592c55364ba7569a26

8 years agoAdd phpdoc and @since to SpecialUserrights::makeGroupNameList
addshore [Fri, 1 Apr 2016 11:28:42 +0000 (14:28 +0300)]
Add phpdoc and @since to SpecialUserrights::makeGroupNameList

Change-Id: I015a851d9fa9649ec79386071fcab2c4589f88ad

8 years agoUserrightsPage::makeGroupNameListForLog() was removed
Siebrand Mazeland [Tue, 8 Mar 2016 23:53:03 +0000 (00:53 +0100)]
UserrightsPage::makeGroupNameListForLog() was removed

Deprecated since 1.21. Use in Gerrit extensions was replaced.

Bug: T122754
Depends-on: If9a2764c5c15be9c07d066a52543c4c9d97e0f35
Change-Id: If45eafca7ea332475eb864f04665d0a0bf1603d1