lhc/web/wiklou.git
9 years agoMerge "Allow custom event handlers for the click event of toolbar buttons"
jenkins-bot [Tue, 26 Aug 2014 15:31:45 +0000 (15:31 +0000)]
Merge "Allow custom event handlers for the click event of toolbar buttons"

9 years agoMerge "Delete feed.css"
jenkins-bot [Tue, 26 Aug 2014 15:06:27 +0000 (15:06 +0000)]
Merge "Delete feed.css"

9 years agoDelete feed.css
Bartosz Dziewoński [Tue, 26 Aug 2014 14:50:16 +0000 (16:50 +0200)]
Delete feed.css

It was a stylesheet loaded with our RSS and Atom feeds, intended to make
them legible when shown in a regular browser. Browsers these days tend
to have their own UI for feeds (for example IE 11 and Firefox 31), and
these that don't pretty-print the XML, which means the stylesheet
provides very little added value.

Per discussion on I6268d663.

Bug: 69277
Change-Id: I2ce9650c01f8f245707f5e88ee46520c5e598ce4

9 years agoMerge "AjaxDispatcher: Use Config instead of globals"
jenkins-bot [Tue, 26 Aug 2014 14:56:27 +0000 (14:56 +0000)]
Merge "AjaxDispatcher: Use Config instead of globals"

9 years agoMerge "Improve GlobalVarConfigTest"
jenkins-bot [Tue, 26 Aug 2014 13:54:14 +0000 (13:54 +0000)]
Merge "Improve GlobalVarConfigTest"

9 years agophpcs: Pass ResourceLoader.php
Timo Tijhof [Mon, 25 Aug 2014 11:43:41 +0000 (13:43 +0200)]
phpcs: Pass ResourceLoader.php

There was only one warning left.

> 1184 | WARNING | Line exceeds 100 characters; contains 107 characters
>      |         | (Generic.Files.LineLength.TooLong)

Change-Id: I99c729e02dac6aaf13a05568fd04e7bb5ad7bcb5

9 years agoMerge "includes/htmlform/: Use Config instead of globals"
jenkins-bot [Tue, 26 Aug 2014 10:56:46 +0000 (10:56 +0000)]
Merge "includes/htmlform/: Use Config instead of globals"

9 years agoAjaxDispatcher: Use Config instead of globals
Kunal Mehta [Tue, 26 Aug 2014 02:14:41 +0000 (19:14 -0700)]
AjaxDispatcher: Use Config instead of globals

Also removed a usage of $wgUser, and converted
AjaxResponse to use Config.

Change-Id: Ia9a1e17da26908b81f7f9691445ff75db2fdefb1

9 years agoAdd "chemical" major MIME type to the image tables
rillke [Sun, 25 May 2014 11:23:09 +0000 (13:23 +0200)]
Add "chemical" major MIME type to the image tables

The American Chemical Society suggested a new major MIME type for files
containing chemical data in 1998: http://dx.doi.org/10.1021/ci9803233
This suggestion got widely adopted and is now a de-facto-standard despite
not registered with IANA.

Applying this patch will allow us to continue with extension MolHandler
and PDBHandler.
http://fab.wmflabs.org/T352

- Fixes bug 66412 by creating a logic that will prevent running unneeded
  updates.

Bug: 66412
Change-Id: Ic45dc1bce796a0406ed8a84e6274df1c4bda4967

9 years agoAdd missing '()' to some release notes
umherirrender [Mon, 25 Aug 2014 17:35:36 +0000 (19:35 +0200)]
Add missing '()' to some release notes

All other remove of deprecated functions ends with (), so add the () to
the two missing one.

Change-Id: I72959fe64d31e5e61e8e6edc58b3370e8b569dd1

9 years agoMerge "startup: Blacklist Opera < 12"
jenkins-bot [Mon, 25 Aug 2014 17:32:12 +0000 (17:32 +0000)]
Merge "startup: Blacklist Opera < 12"

9 years agoMerge "Remove wrong @return from doc blocks"
jenkins-bot [Mon, 25 Aug 2014 17:21:45 +0000 (17:21 +0000)]
Merge "Remove wrong @return from doc blocks"

9 years agoNo space within the ?: operator
Bartosz Dziewoński [Mon, 25 Aug 2014 15:40:51 +0000 (17:40 +0200)]
No space within the ?: operator

This style is a lot more common in our code.

Change-Id: I7f2fb3716c24c4a95a4c6c4a732b0226c315f242

9 years agoRemove wrong @return from doc blocks
umherirrender [Sun, 24 Aug 2014 09:26:41 +0000 (11:26 +0200)]
Remove wrong @return from doc blocks

These functions actually does not return anything, so the @return is
wrong here. '@return void' is ignored.

Change-Id: I11495ee05b943c16c1c4715d617c8b50de22276c

9 years agostartup: Blacklist Opera < 12
Timo Tijhof [Sun, 24 Aug 2014 13:57:31 +0000 (15:57 +0200)]
startup: Blacklist Opera < 12

jQuery hasn't supported Opera < 12 for several releases now, and
our own support matrix and development practices also consider
Opera 11 and below being Grade C (there are known problems in
Opera 8 and 10, such as missing features and implementation bugs).

Update the blacklist to reflect Opera < 12 being Grade C.

https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix

Change-Id: Ia2764a49c5d1fad73bd4eb52748269407231700e

9 years agoMerge "MessageBlobStore: Use Config instead of globals"
jenkins-bot [Mon, 25 Aug 2014 11:44:59 +0000 (11:44 +0000)]
Merge "MessageBlobStore: Use Config instead of globals"

9 years agoMerge "Turn MessageBlobStore into a singleton instead of static functions"
jenkins-bot [Mon, 25 Aug 2014 11:39:09 +0000 (11:39 +0000)]
Merge "Turn MessageBlobStore into a singleton instead of static functions"

9 years agoMessageBlobStore: Use Config instead of globals
Kunal Mehta [Sat, 23 Aug 2014 07:58:07 +0000 (00:58 -0700)]
MessageBlobStore: Use Config instead of globals

Change-Id: I458cc74bac1bff8edab6ad537a3a999ede5706ed

9 years agoTurn MessageBlobStore into a singleton instead of static functions
Kunal Mehta [Sat, 23 Aug 2014 07:55:32 +0000 (00:55 -0700)]
Turn MessageBlobStore into a singleton instead of static functions

For easier testability and other things. There are no uses
of this class in any extensions in gerrit.

Change-Id: I606de4259239e128ed7e0477fc98b84c647430c4

9 years agoMerge "Add some @see to doc blocks"
jenkins-bot [Mon, 25 Aug 2014 09:51:15 +0000 (09:51 +0000)]
Merge "Add some @see to doc blocks"

9 years agoMerge "Do not return anything on __construct"
jenkins-bot [Mon, 25 Aug 2014 09:48:14 +0000 (09:48 +0000)]
Merge "Do not return anything on __construct"

9 years agoMerge "Add missing @return to function docs"
jenkins-bot [Mon, 25 Aug 2014 09:47:39 +0000 (09:47 +0000)]
Merge "Add missing @return to function docs"

9 years agoMerge "Remove double @return from User::isAllowedAny"
jenkins-bot [Mon, 25 Aug 2014 09:46:47 +0000 (09:46 +0000)]
Merge "Remove double @return from User::isAllowedAny"

9 years agoMerge "Remove useNew (no longer any effect) from qqq messages"
jenkins-bot [Mon, 25 Aug 2014 06:20:30 +0000 (06:20 +0000)]
Merge "Remove useNew (no longer any effect) from qqq messages"

9 years agoMerge "Deprecate $wgDeferredUpdateList"
jenkins-bot [Mon, 25 Aug 2014 05:25:07 +0000 (05:25 +0000)]
Merge "Deprecate $wgDeferredUpdateList"

9 years agoRemove useNew (no longer any effect) from qqq messages
Matthew Flaschen [Mon, 25 Aug 2014 04:00:35 +0000 (00:00 -0400)]
Remove useNew (no longer any effect) from qqq messages

Change-Id: I6b09efe28db2d61d55d1a79a801207f3e371777f

9 years agoUpdate findHooks.php and move MonoBook hook out of docs/hooks.txt
Kunal Mehta [Sun, 24 Aug 2014 22:09:01 +0000 (15:09 -0700)]
Update findHooks.php and move MonoBook hook out of docs/hooks.txt

Added includes/skins/ to the list of directories and removed
the skins that were moved out of core.

The MonoBook hook is moved to skins/MonoBook in Ieb85b4bed.

Change-Id: Ie8ad1eb694575b8e1485177e2d14f2a9dcab179d

9 years agoAllow custom event handlers for the click event of toolbar buttons
helderwiki [Sat, 23 Aug 2014 19:12:21 +0000 (16:12 -0300)]
Allow custom event handlers for the click event of toolbar buttons

Example:
mw.toolbar.addButton( {
imageFile: '//upload.wikimedia.org/wikipedia/commons/a/a9/Button_tournesol.png',
onClick: function(){ alert( 'MediaWiki!' ); }
} );

Change-Id: I615960f689a0f8d35a12879efebc0afda8eef7b1

9 years agoDo not return anything on __construct
umherirrender [Sun, 24 Aug 2014 09:29:45 +0000 (11:29 +0200)]
Do not return anything on __construct

Change-Id: I47f67ed17112af832b19f7e7538cae3e0b8354ef

9 years agoAdd some @see to doc blocks
umherirrender [Sun, 24 Aug 2014 09:19:32 +0000 (11:19 +0200)]
Add some @see to doc blocks

This avoids repeating the @params for the functions

Change-Id: Ie1f4488a0a7aa30ab128b9ea7ff6f3af12a88884

9 years agoRemove double @return from User::isAllowedAny
umherirrender [Sun, 24 Aug 2014 09:05:16 +0000 (11:05 +0200)]
Remove double @return from User::isAllowedAny

And fix the @param for the varargs

Change-Id: Idb9b3037bb6cbb41e01432a278695d6a29008edd

9 years agoDeprecate $wgDeferredUpdateList
Kunal Mehta [Sun, 24 Aug 2014 05:41:26 +0000 (22:41 -0700)]
Deprecate $wgDeferredUpdateList

Callers should instead use DeferredUpdates::addUpdate. The
function is superior because it is able to enforce type-hinting
rather than throwing a fatal error. Also it's not a global :)

The only extension still using the global is FlaggedRevs,
for which I've submitted I1a7c6540b2.

Change-Id: Ic59c90c0d0131039295bd785280dc70ebde6e40f

9 years agoincludes/htmlform/: Use Config instead of globals
Kunal Mehta [Sun, 24 Aug 2014 05:09:15 +0000 (22:09 -0700)]
includes/htmlform/: Use Config instead of globals

Change-Id: Ibc798f3ee22dec0a77bab39611d490c09b3cb764

9 years agoMerge "Apply csshelpclass to vform help"
jenkins-bot [Sun, 24 Aug 2014 04:39:47 +0000 (04:39 +0000)]
Merge "Apply csshelpclass to vform help"

9 years agoFix regression: Allow HTML as checkbox label in HTMLCheckField
Matthew Flaschen [Sun, 24 Aug 2014 01:12:26 +0000 (21:12 -0400)]
Fix regression: Allow HTML as checkbox label in HTMLCheckField

Follow-up to aa15d5287d898b624a30a70d14e495899f7d251e

Change-Id: Ie9a6b3f017912d0f3493da09a267cf32852392af

9 years agoApply csshelpclass to vform help
Bryan Davis [Sat, 23 Aug 2014 22:10:17 +0000 (16:10 -0600)]
Apply csshelpclass to vform help

Ensure that a form field which sets 'csshelpclass' and is rendered as
a vform receives expected styling.

Change-Id: Ibe082e07fe846334bd4dc257c9c0df8db23a1957

9 years agoAdd missing @return to function docs
umherirrender [Sat, 23 Aug 2014 20:34:25 +0000 (22:34 +0200)]
Add missing @return to function docs

Change-Id: I45b9d02f94ecc58372268ec5e6a0b572a0b7e2a9

9 years agoImprove GlobalVarConfigTest
Kunal Mehta [Sat, 23 Aug 2014 21:11:43 +0000 (14:11 -0700)]
Improve GlobalVarConfigTest

Should bring includes/config to 100% coverage :D

Change-Id: I929448b7a306fb1efb8b523d16305a7666f78fd0

9 years agoMerge "Use config instead of globals for OutputPage"
jenkins-bot [Sat, 23 Aug 2014 20:21:44 +0000 (20:21 +0000)]
Merge "Use config instead of globals for OutputPage"

9 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sat, 23 Aug 2014 20:08:25 +0000 (20:08 +0000)]
Merge "Localisation updates from https://translatewiki.net."

9 years agoMerge "OutputPage: addParserOutput*() family doesn't need to take a reference"
jenkins-bot [Sat, 23 Aug 2014 19:59:49 +0000 (19:59 +0000)]
Merge "OutputPage: addParserOutput*() family doesn't need to take a reference"

9 years agoOutputPage: addParserOutput*() family doesn't need to take a reference
Bartosz Dziewoński [Sat, 23 Aug 2014 16:20:51 +0000 (18:20 +0200)]
OutputPage: addParserOutput*() family doesn't need to take a reference

We never assign to the variable, only call some (mutating) methods on
the object. With PHP 5 we don't need to pass this by reference.

The functions that evolved into this family were originally added in
r12337, back then we probably still ran on PHP 4 or something.

Change-Id: Ib4ab141ca6d803f9df0351b1f65c7e9955c37d57

9 years agoMerge "Be consistent about 'TablePager' CSS class usage"
jenkins-bot [Sat, 23 Aug 2014 19:46:57 +0000 (19:46 +0000)]
Merge "Be consistent about 'TablePager' CSS class usage"

9 years agoMerge "Split includes/Pager.php"
jenkins-bot [Sat, 23 Aug 2014 19:45:51 +0000 (19:45 +0000)]
Merge "Split includes/Pager.php"

9 years agoMerge "Remove unused styles for .imagelist"
jenkins-bot [Sat, 23 Aug 2014 19:45:19 +0000 (19:45 +0000)]
Merge "Remove unused styles for .imagelist"

9 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Sat, 23 Aug 2014 19:12:41 +0000 (21:12 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: I0d1cdf104964c0923cfea01e3c7e18838ed47046

9 years agoBe consistent about 'TablePager' CSS class usage
Bartosz Dziewoński [Sat, 23 Aug 2014 13:00:07 +0000 (15:00 +0200)]
Be consistent about 'TablePager' CSS class usage

* Do not use it when not actually using the TablePager
* Always use it when actually using the TablePager
* Use parent::getTableClass() rather than hardcoding it every time
* Place it before other classes to allow overriding

Change-Id: I042b65be64e2c2fa6c68a7bb972a7a2ea7f55b4e

9 years agoSplit includes/Pager.php
Bartosz Dziewoński [Sat, 23 Aug 2014 12:25:02 +0000 (14:25 +0200)]
Split includes/Pager.php

Change-Id: I67fcffca4e3de081a895deb1a285a5545940ece9

9 years agoRemove unused styles for .imagelist
Bartosz Dziewoński [Sat, 23 Aug 2014 11:56:47 +0000 (13:56 +0200)]
Remove unused styles for .imagelist

Added in r16083 for Special:ImageList, which has been renamed to
Special:ListFiles in r45357, with class names being changed in the PHP
code without adjusting the CSS.

It seems no one has missed these styles over the years, so let's just
delete them.

Change-Id: I1f7775b3c7733cbfdd3f404527063e973fb80ec7

9 years agoMerge "Add more tests for GlobalVarConfig"
jenkins-bot [Sat, 23 Aug 2014 11:20:23 +0000 (11:20 +0000)]
Merge "Add more tests for GlobalVarConfig"

9 years agoMerge "Add a test for ApiFormatNone"
jenkins-bot [Sat, 23 Aug 2014 10:40:41 +0000 (10:40 +0000)]
Merge "Add a test for ApiFormatNone"

9 years agoUse config instead of globals for OutputPage
umherirrender [Sat, 23 Aug 2014 08:52:41 +0000 (10:52 +0200)]
Use config instead of globals for OutputPage

Change-Id: I5e0ebc173631d1d1052de7ccee4ef839c7c1767f

9 years agoMark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore
Kunal Mehta [Sat, 23 Aug 2014 06:32:37 +0000 (23:32 -0700)]
Mark ConfigFactory::destroyDefaultInstance() with @codeCoverageIgnore

Change-Id: Icd4a5724aefab58dad1af07874ef7ee415922ead

9 years agoAdd a test for ApiFormatNone
Kunal Mehta [Sat, 23 Aug 2014 06:27:51 +0000 (23:27 -0700)]
Add a test for ApiFormatNone

Because lolz.

Change-Id: I9c472131746a722737300b7d2d2291c70f80bb2e

9 years agoMerge "ResourceLoaderFileModule: Do not separately cache .less files"
jenkins-bot [Sat, 23 Aug 2014 00:43:07 +0000 (00:43 +0000)]
Merge "ResourceLoaderFileModule: Do not separately cache .less files"

9 years agoFix documentation for $wgResourceLoaderLESSVars
Bartosz Dziewoński [Wed, 20 Aug 2014 17:39:36 +0000 (19:39 +0200)]
Fix documentation for $wgResourceLoaderLESSVars

* These aren't string values, but LESS code snippets. This rarely
  matters, but it matters very much when it does.
* Changes to the values do not actually trigger cache invalidation.
  Hashed contents are only used for "second-level" cache keys and do
  not make it possible to invalidate module cache.

Change-Id: I373dfedac1e43db4d0aa709384eee7f7e7f1808c

9 years agoMerge "Use config instead of globals for ImageGallery"
jenkins-bot [Fri, 22 Aug 2014 23:53:13 +0000 (23:53 +0000)]
Merge "Use config instead of globals for ImageGallery"

9 years agoMerge "Use getConfig for ChangesList"
jenkins-bot [Fri, 22 Aug 2014 23:42:39 +0000 (23:42 +0000)]
Merge "Use getConfig for ChangesList"

9 years agoMerge "Fix name of SpecialListFilesTest > ImageListPagerTest"
jenkins-bot [Fri, 22 Aug 2014 23:32:33 +0000 (23:32 +0000)]
Merge "Fix name of SpecialListFilesTest > ImageListPagerTest"

9 years agoMerge "Remove unused private var and fix phpdoc"
jenkins-bot [Fri, 22 Aug 2014 23:32:30 +0000 (23:32 +0000)]
Merge "Remove unused private var and fix phpdoc"

9 years agoMerge "Rename variable in RequestContext, $t => $title"
jenkins-bot [Fri, 22 Aug 2014 23:30:34 +0000 (23:30 +0000)]
Merge "Rename variable in RequestContext, $t => $title"

9 years agoMerge "tests: avoid sql queries in TitleTest"
jenkins-bot [Fri, 22 Aug 2014 23:21:08 +0000 (23:21 +0000)]
Merge "tests: avoid sql queries in TitleTest"

9 years agoMerge "Change @return to start with type"
jenkins-bot [Fri, 22 Aug 2014 23:20:36 +0000 (23:20 +0000)]
Merge "Change @return to start with type"

9 years agotests: avoid sql queries in TitleTest
Antoine Musso [Thu, 21 Aug 2014 19:54:51 +0000 (21:54 +0200)]
tests: avoid sql queries in TitleTest

testIsAlwaysKnown was invoked on an interwiki link. To have the test
pass, we used addDBData() to inject the interwiki in the database.  This
end up being execute on each test when it is only needed for a single
assertion.

Instead of creating a Title, use Title::makeTitle() to populate the
interwiki, thus letting us avoid the database hits.

Random timing: 1.20s -> 150ms.

Change-Id: I63a4e7b9af5eacb7dc1de4b33b8e631e6c3f1fa6

9 years agoMerge "Rename variable in Title: $parser -> $titleParser"
jenkins-bot [Fri, 22 Aug 2014 23:10:37 +0000 (23:10 +0000)]
Merge "Rename variable in Title: $parser -> $titleParser"

9 years agoMerge "Pass config to ResourceLoader from OutputPage"
jenkins-bot [Fri, 22 Aug 2014 22:16:10 +0000 (22:16 +0000)]
Merge "Pass config to ResourceLoader from OutputPage"

9 years agoMerge "Use getConfig in HistoryAction for global"
jenkins-bot [Fri, 22 Aug 2014 22:15:11 +0000 (22:15 +0000)]
Merge "Use getConfig in HistoryAction for global"

9 years agoAvoid sleeper connections in LoadMonitor::getLagTimes()
Aaron Schulz [Thu, 21 Aug 2014 17:33:09 +0000 (10:33 -0700)]
Avoid sleeper connections in LoadMonitor::getLagTimes()

* Also improved the cache fallback logic

Change-Id: I65a2c46b49a2d79e014b910a7f7357aa64964690

9 years agoMerge "Localisation updates from https://translatewiki.net."
Translation updater bot [Fri, 22 Aug 2014 20:51:09 +0000 (20:51 +0000)]
Merge "Localisation updates from https://translatewiki.net."

9 years agoUse config instead of globals for ImageGallery
umherirrender [Fri, 22 Aug 2014 20:36:59 +0000 (22:36 +0200)]
Use config instead of globals for ImageGallery

Have to pass a context to the constructor to acutally use it for
settings.

Also adds a RequestContext::getMainAndWarn to get a default warning,
when using the main request, but it would be better to pass one.

Change-Id: I1628a1790c45d44aa4239701486b8b1b7c59a0e6

9 years agoChange css rule order
jdlrobson [Fri, 22 Aug 2014 20:33:20 +0000 (13:33 -0700)]
Change css rule order

:invalid is incorrectly overriding a :focus:invalid element
correct the order and add a note about this.

Change-Id: I4ee1a4634840b2251e294dfb704c1f5e3b730f7d

9 years agoLocalisation updates from https://translatewiki.net.
Translation updater bot [Fri, 22 Aug 2014 20:19:33 +0000 (22:19 +0200)]
Localisation updates from https://translatewiki.net.

Change-Id: Ie07b1bd0e3696af417e3c131f8c6d2506c881b0e

9 years agoPass config to ResourceLoader from OutputPage
umherirrender [Fri, 22 Aug 2014 20:13:16 +0000 (22:13 +0200)]
Pass config to ResourceLoader from OutputPage

Change-Id: Iae99ab65a254fc3fe3acac764a068470f99af1c4

9 years agoUse getConfig for ChangesList
umherirrender [Fri, 22 Aug 2014 20:01:08 +0000 (22:01 +0200)]
Use getConfig for ChangesList

Change-Id: I1f440a2fca2dd8f1973987d635c70954938b6ea6

9 years agoUse getConfig in HistoryAction for global
umherirrender [Fri, 22 Aug 2014 19:48:49 +0000 (21:48 +0200)]
Use getConfig in HistoryAction for global

Change-Id: I4a3bb4149c3c1da75215e0e6336c89e4a00fc8e4

9 years agoMade getCachedRevisionObject() use MapCacheLRU
Aaron Schulz [Wed, 20 Aug 2014 23:41:59 +0000 (16:41 -0700)]
Made getCachedRevisionObject() use MapCacheLRU

* Previously the cache size was unbounded and leaky
* Also made MapCacheLRU handle null values properly

Change-Id: Ia02258cf051e1ccf11457c758741b8c7922afe89

9 years agoMerge "Ensure that expiry times are given as integers"
jenkins-bot [Fri, 22 Aug 2014 18:10:39 +0000 (18:10 +0000)]
Merge "Ensure that expiry times are given as integers"

9 years agoMerge "Fixed bogus mysql error code 0 on mid-transaction disconnect"
jenkins-bot [Fri, 22 Aug 2014 18:06:07 +0000 (18:06 +0000)]
Merge "Fixed bogus mysql error code 0 on mid-transaction disconnect"

9 years agoProtect MathML from Tidy
physikerwelt [Thu, 14 Aug 2014 16:28:36 +0000 (12:28 -0400)]
Protect MathML from Tidy

MediaWiki installations that use the setting
$wgUseTidy = true; are unable to output
MathML since the well defined MathML elements
are filtered out by Tidy. This was reported as
  http://sourceforge.net/p/tidy/patches/84/ .

This change hides MathML blocks from
Tidy.

Bug: 66516
Change-Id: Ib48b91238c3eddd6a86b62f6ce57801d7058f0d8

9 years agoMerge "Drop "left in" debugging var_dump from WikiImporter"
jenkins-bot [Fri, 22 Aug 2014 16:06:46 +0000 (16:06 +0000)]
Merge "Drop "left in" debugging var_dump from WikiImporter"

9 years agoEnsure that expiry times are given as integers
Bryan Davis [Fri, 22 Aug 2014 15:55:59 +0000 (09:55 -0600)]
Ensure that expiry times are given as integers

Fixes "Fatal error: Argument 4 passed to Memcached::cas() must be an
instance of int, float given".

Change-Id: Ibf1ea638ec1a4dcf009cdaea8aa66008c74ff30b

9 years agoMerge "Make ApiModuleManagerTest::testAddModules un-risky"
jenkins-bot [Fri, 22 Aug 2014 15:43:27 +0000 (15:43 +0000)]
Merge "Make ApiModuleManagerTest::testAddModules un-risky"

9 years agoRename variable in Title: $parser -> $titleParser
aude [Fri, 22 Aug 2014 14:15:47 +0000 (16:15 +0200)]
Rename variable in Title: $parser -> $titleParser

so not to confuse this with Parser

Change-Id: I7e06baa0a924310e9491f125d0cb851bde2702ab

9 years agoDrop "left in" debugging var_dump from WikiImporter
Thiemo Mättig [Fri, 22 Aug 2014 14:11:30 +0000 (16:11 +0200)]
Drop "left in" debugging var_dump from WikiImporter

I found this on accident when searching for a var_dump I forgot
somewhere in my own code. We are maintaining production code here,
right? Debugging and testing should be somewhere else.

Also note the stray print before the var_dump.

Change-Id: I98725b277039f55db9ff95399e9559a477b43c26

9 years agoMerge "API: Add iwprop=url, deprecate iwurl for prop=iwlinks"
jenkins-bot [Fri, 22 Aug 2014 05:53:47 +0000 (05:53 +0000)]
Merge "API: Add iwprop=url, deprecate iwurl for prop=iwlinks"

9 years agoMake ApiModuleManagerTest::testAddModules un-risky
Kunal Mehta [Fri, 22 Aug 2014 05:47:24 +0000 (22:47 -0700)]
Make ApiModuleManagerTest::testAddModules un-risky

Change-Id: Idbea51cf45fc95676759e5ac9abb342701e5b551

9 years agoCheck for existence of iw_local in Interwiki::getAllPrefixes
Bryan Davis [Fri, 22 Aug 2014 02:24:25 +0000 (20:24 -0600)]
Check for existence of iw_local in Interwiki::getAllPrefixes

Interwiki::getAllPrefixes only sets the iw_local member in a response
row if $local is set to a non-null value. Under certain error
reporting conditions, the unqualified access to the array key leads to
warnings such as "message repeated 1471 times: [ #012Notice: Undefined
index: iw_trans in ...".

Change-Id: Ibf434dc9c362984cad76ae6bdb29de826974d81e

9 years agoMerge "mediawiki.language: Expose language fallback chain"
jenkins-bot [Fri, 22 Aug 2014 01:22:55 +0000 (01:22 +0000)]
Merge "mediawiki.language: Expose language fallback chain"

9 years agoresourceloader: Only conditional-wrap script responses with only=scripts
Timo Tijhof [Wed, 13 Aug 2014 18:06:10 +0000 (19:06 +0100)]
resourceloader: Only conditional-wrap script responses with only=scripts

Follows-up 9272bc6c4721225. The shouldIncludeScripts method returns
true for only=scripts, but also for other responses (except for
only=styles, naturally).

Regular load.php responses that load both scripts and styles don't
need the conditional wrap because those requests should only be
made from the mw.loader client which inherently means the
environment has been provided already.

It's merely unnecessary and shouldn't have caused any issues since
it simply evaluates to true always. It was already correctly being
excluded from raw modules that run before the environment is
provided (such as startup, jquery and mediawiki).

Change-Id: I375a7a8039f9b3ad4909e76005725f7d975d8a5e

9 years agomediawiki.language: Expose language fallback chain
Bartosz Dziewoński [Sat, 9 Aug 2014 00:14:09 +0000 (02:14 +0200)]
mediawiki.language: Expose language fallback chain

The data can now be accessed via mw.language#getFallbackLanguages or
mw.language#getFallbackLanguageChain.

Bug: 69285
Change-Id: Id0c3267f01d5c4da0e4000a0fb318a9dfb538ef3

9 years agoUpdate OOjs UI to v0.1.0-pre (d6008381aa)
James D. Forrester [Thu, 21 Aug 2014 23:45:56 +0000 (16:45 -0700)]
Update OOjs UI to v0.1.0-pre (d6008381aa)

New changes:
7205b2a build: Check for files' existence before building using grunt-file-exists
d600838 Make window managers destroyable

Change-Id: I32e4f5bd41a5401b817cc6e37c6325df624a9e0e

9 years agoAdd more tests for GlobalVarConfig
Kunal Mehta [Wed, 20 Aug 2014 07:35:35 +0000 (00:35 -0700)]
Add more tests for GlobalVarConfig

Change-Id: I31d50a0636792104e32e3f25694f45942c5c0217

9 years agoResourcesTest: Add variable type annotations
Kunal Mehta [Thu, 21 Aug 2014 22:31:51 +0000 (00:31 +0200)]
ResourcesTest: Add variable type annotations

Change-Id: I07ec986830dcec739b0553395b9a220b44bba77d

9 years agoMerge "Add more tests for SkinFactory"
jenkins-bot [Thu, 21 Aug 2014 21:41:39 +0000 (21:41 +0000)]
Merge "Add more tests for SkinFactory"

9 years agoDelete skins/common/images/button_template.png
Bartosz Dziewoński [Thu, 21 Aug 2014 20:45:56 +0000 (22:45 +0200)]
Delete skins/common/images/button_template.png

Unused in core, as well as extensions and skins.

I have removed the two usages on Wikimedia wikis (found by mwgrep)
which must have been the cause of the 97 requests for this file per
bug 69277 comment 11:

* https://de.wikipedia.org/wiki/MediaWiki:Gadget-Vorlagenmeister.css
* https://hu.wikipedia.org/wiki/MediaWiki:Gadget-sablonmester.css

Bug: 69277
Change-Id: I9d151e1fbc2da948b5265da731496d4178f51039

9 years agoMade showJobs.php show queues with just abandoned jobs too
Aaron Schulz [Tue, 19 Aug 2014 21:13:30 +0000 (14:13 -0700)]
Made showJobs.php show queues with just abandoned jobs too

Change-Id: I7fbf000c9b9edf433ac6723843a96fcaf937b5c7

9 years agoMerge "Sync up with Parsoid parserTests."
jenkins-bot [Thu, 21 Aug 2014 17:11:37 +0000 (17:11 +0000)]
Merge "Sync up with Parsoid parserTests."

9 years agoUpdate OOjs UI to v0.1.0-pre (55b861b167)
Roan Kattouw [Thu, 21 Aug 2014 16:59:20 +0000 (09:59 -0700)]
Update OOjs UI to v0.1.0-pre (55b861b167)

New changes:
466a876 [BREAKING CHANGE] Make content isolation optional
23f26c3 [BREAKING CHANGE] Set active and pressed on the buttoned element, not the button
55b861b build: Switch from grunt-recess to grunt-contrib-less

Change-Id: Ie4454376df9492e3b77b6cc174ce7b38548cc56d

9 years agoSync up with Parsoid parserTests.
Subramanya Sastry [Tue, 19 Aug 2014 21:19:24 +0000 (16:19 -0500)]
Sync up with Parsoid parserTests.

This now aligns with Parsoid commit 13c31fc815749a6239dd357672d39de0a51d51ce

Change-Id: I929e1c195801a9055ad2847994e050836262a896

9 years agoFixed bogus mysql error code 0 on mid-transaction disconnect
Aaron Schulz [Thu, 21 Aug 2014 16:58:03 +0000 (09:58 -0700)]
Fixed bogus mysql error code 0 on mid-transaction disconnect

* Now the proper error (e.g. "server has gone away") and code is shown.

Change-Id: If0255101151441c7d05141ffc7cb416ad79e6bd8