Platonides [Tue, 22 Nov 2011 16:21:18 +0000 (16:21 +0000)]
Fix r103865 fixmes about case where there a parse error should be raised.
Also detect as an error 1..0 or
1eeeeee5
Platonides [Tue, 22 Nov 2011 16:04:39 +0000 (16:04 +0000)]
Follow-up r103865. Accept lowercase hex and remove empty statement.
John Du Hart [Tue, 22 Nov 2011 15:58:28 +0000 (15:58 +0000)]
Reverting r103856 since it does not work. <body> is not available at startup.
Antoine Musso [Tue, 22 Nov 2011 14:37:10 +0000 (14:37 +0000)]
(bug 32412) TOC links on [[Special:EditWatchlist]] points to the fieldsets
Points the TOC entry to the fieldset element and add an id to those fieldset
using the same id prefix we used in 1.17 ('editwatchlist-')
This is a 1.18 regression.
Antoine Musso [Tue, 22 Nov 2011 14:25:28 +0000 (14:25 +0000)]
reverts r103894
not meant to be sent yet.
Antoine Musso [Tue, 22 Nov 2011 14:21:09 +0000 (14:21 +0000)]
(bug 32412) TOC links on [[Special:EditWatchlist]] now points to the fieldset
Daniel Friesen [Tue, 22 Nov 2011 13:34:55 +0000 (13:34 +0000)]
Implement a number of namespace related equals functions:
* MWNamespace::equals to test equivalence of two namespaces (forward compatible with any changes we may make like introducing namespace keys like 'USER')
* MWNamespace::subjectEquals to test equivalence of the subject of two namespaces e.g.: MWNamespace::subjectEquals( NS_USER, $ns ); instead of testing for equivalence to both NS_USER and NS_USER_TALK
* Title::inNamespace to use instead of $title->getNamespace() == NS_???
* Title::inNamespaces for use like $title->inNamespaces( NS_USER, NS_PROJECT ) when you only care if it's in one of a number of namespaces (also accepts an array)
* Title::hasSubjectNamespace for use instead of testing for equivalence to both the subject and talk such as NS_USER and NS_USER_TALK.
Include phpunit tests for all this new code, and also add some tests for some existing code.
Antoine Musso [Tue, 22 Nov 2011 13:28:39 +0000 (13:28 +0000)]
revert r103691 that makes update.php output garbage
reopens bug 32020:
- Improve messages output by the database updaters
closes bug 32508:
- Too many update messages even though nothing much happens
Brion Vibber [Mon, 21 Nov 2011 23:16:36 +0000 (23:16 +0000)]
* (bug 32548) fix minification bug when numeric literal with exponent was split over lines
This broke the OpenLayers support in the Maps extension, as used for example on TranslateWiki.net.
The original JavaScriptMinifier's tokenizer (r83885) explicitly didn't bother looking for the exponent part because it "didn't matter" to its internal state machine; however since r83891 added a max line length that definitely is not true.
I've split out handling of hex and decimal numerals, and let the decimal numeral handling check for exponents.
PHPUnit test cases were added in r103846.
John Du Hart [Mon, 21 Nov 2011 22:53:24 +0000 (22:53 +0000)]
Followup r95318, move client-(no)js classes to the body tag per discussion in bug 30497
Brion Vibber [Mon, 21 Nov 2011 22:20:06 +0000 (22:20 +0000)]
Add PHPUnit tests for the minification failure case in bug 32548.
This will trigger 2 test failures, where an exponent in a JS numeric literal gets split over line breaks at the '-' or '+', causing a parse error in the resulting output.
A number with the same string length but without using + or - in the exponent passes through fine, indicating that it's the -/+ that's getting misinterpreted.
Raimond Spekking [Mon, 21 Nov 2011 21:20:36 +0000 (21:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net
John Du Hart [Mon, 21 Nov 2011 16:13:21 +0000 (16:13 +0000)]
Bug 29524 - Rename RequestContext::getLang to getLanguage
I'll be amazed if this doens't break any tests.
John Du Hart [Mon, 21 Nov 2011 15:42:58 +0000 (15:42 +0000)]
Bug 28981 - handle diffonly param on diffs between deleted revision
John Du Hart [Mon, 21 Nov 2011 15:30:20 +0000 (15:30 +0000)]
Bug 28296 - Installer should honor &uselang= parameter
Alexandre Emsenhuber [Mon, 21 Nov 2011 14:27:22 +0000 (14:27 +0000)]
* Use local context to get messages
* Refactored SpecialChangeEmail::error() to get the message name and call OutputPage::wrapWikiMsg() instead of having lot of different ways to handle messages (including parsing the message and then escape it, which is really bad)
Alexandre Emsenhuber [Mon, 21 Nov 2011 14:09:13 +0000 (14:09 +0000)]
Use WikiPage instead of Article to call getUsedTemplates()
Mark A. Hershberger [Mon, 21 Nov 2011 01:45:23 +0000 (01:45 +0000)]
Fixes Bug 31865 - Tag <dws> for discarding whitespaces.
Patch with parser tests from Van de Bugger
Antoine Musso [Sun, 20 Nov 2011 22:39:26 +0000 (22:39 +0000)]
Special:Log title can be an invalid thus trigger a Fatal error
follow up r103711
Platonides [Sun, 20 Nov 2011 21:38:15 +0000 (21:38 +0000)]
Move the hidden input with the title inside the <div> (adding a silly one for two-button search).
Removes dumb XHTML1 conformance warning about <input> (an inline element) not being able to be there
(a place for a block element). (Bug 13381)
Raimond Spekking [Sun, 20 Nov 2011 21:18:38 +0000 (21:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sun, 20 Nov 2011 19:15:39 +0000 (19:15 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Sun, 20 Nov 2011 18:59:23 +0000 (18:59 +0000)]
Use WikiPage instead of Article to call updateRevisionOn()
Platonides [Sun, 20 Nov 2011 18:57:59 +0000 (18:57 +0000)]
Change <br clear="all/left" to <br style="clear: in inline html.
(Bug 13381) Improve the XHTML strictness
Roan Kattouw [Sun, 20 Nov 2011 18:57:47 +0000 (18:57 +0000)]
(bug 1672) Add $wgDisableUploadScriptChecks to allow disabling of the HTML/JS detection for uploads. Patch by Emufarmers
Roan Kattouw [Sun, 20 Nov 2011 18:17:49 +0000 (18:17 +0000)]
(bug 24037) Add byte length of revision to Special:Contributions. Patch by Umherirrender
Sam Reed [Sun, 20 Nov 2011 18:02:38 +0000 (18:02 +0000)]
Braces, spaces, documentation
Sam Reed [Sun, 20 Nov 2011 17:54:47 +0000 (17:54 +0000)]
* (bug 29635) update.php for Postgres creates sequences, then fails when it to rename sequences to those same names
Patch by Luigi Corsaro
Roan Kattouw [Sun, 20 Nov 2011 17:45:18 +0000 (17:45 +0000)]
(bug 310720) Make Http::request() (and, by extension, get() and post() as well) accept a 'userAgent' option. Patch by Chad Horohoe
Sam Reed [Sun, 20 Nov 2011 15:16:54 +0000 (15:16 +0000)]
* (bug 24765) User tool links edit hook
Original patch by "biolizard", updated to not use $this in static, and added relevant documentation
Sam Reed [Sun, 20 Nov 2011 15:01:09 +0000 (15:01 +0000)]
Query already does ORDER BY value, so remove manual order by from r103759
Sam Reed [Sun, 20 Nov 2011 14:49:07 +0000 (14:49 +0000)]
* (bug 13577) Optimize query in Special Unusedcategories & Special Mostlinkedcategories by using category table
Patch by Nicolas Dumazet, updated in line with changed code
If unbounded it does a filesort. With a limit, it's a fine query
Marking as not expensive
Roan Kattouw [Sun, 20 Nov 2011 14:32:59 +0000 (14:32 +0000)]
(bug 7304) Links on redirect pages no longer cause the redirect page to show up as a redirect to the linked page on Special:Whatlinkshere. Patch by Bawolff, using the redirect table instead of page_is_redirect to identify redirects
Roan Kattouw [Sun, 20 Nov 2011 13:02:34 +0000 (13:02 +0000)]
Fix typo in r103751
Sam Reed [Sun, 20 Nov 2011 11:41:42 +0000 (11:41 +0000)]
Fix spaces to tabs
Roan Kattouw [Sun, 20 Nov 2011 11:29:56 +0000 (11:29 +0000)]
In the spirit of r103745, guard against invalid user names in SpecialContributions and SpecialDeletedContributions by checking for invalidity early, then passing User objects around. Loosely based on Søren Løvborg's patch on bug 26854
Sam Reed [Sun, 20 Nov 2011 10:58:46 +0000 (10:58 +0000)]
* (bug 32506) Inconsistent behavior for Special:EditWatchlist/raw when submitting an empty watchlist
Patch by Brad Jorsch
Roan Kattouw [Sun, 20 Nov 2011 10:55:58 +0000 (10:55 +0000)]
(bug 26854) Invalid user names go unchecked. Applied most of the patch submitted by Søren Løvborg, checking for null return values from User::newFromName()
Aaron Schulz [Sun, 20 Nov 2011 10:24:04 +0000 (10:24 +0000)]
StreamFile::StreamFile() tweaks:
* Replaced unused $request param with $sendErrors to suppress sending error messages
* Added boolean return value (success/failure)
Aaron Schulz [Sun, 20 Nov 2011 08:50:13 +0000 (08:50 +0000)]
image_auth.php cleanups:
* Factored main code into wfImageAuthMain()
* Made preg_match() for $name account for "page3-" type specifiers in the thumb name
* Code style cleanups
Mark A. Hershberger [Sat, 19 Nov 2011 23:42:17 +0000 (23:42 +0000)]
Fix Bug #32105 - Copyright/trademark/terms of use not showing in
Simple skin
Don't really know why this was hidden, anyway.
Antoine Musso [Sat, 19 Nov 2011 21:22:30 +0000 (21:22 +0000)]
(bug 1697) Special:Log make Title an User object when the log type expect it
Sam Reed [Sat, 19 Nov 2011 21:17:50 +0000 (21:17 +0000)]
RELEASE-NOTES-1.19 for r103706, r103708
CREDITS for r103705
Sam Reed [Sat, 19 Nov 2011 21:14:42 +0000 (21:14 +0000)]
* (bug 32505) Incorrect spacing on messages for Special:EditWatchlist/raw results
Patch by Brad Jorsch
Sam Reed [Sat, 19 Nov 2011 21:03:43 +0000 (21:03 +0000)]
* (bug 19698) Inverse selection for Special:Contributions
Manually updated patch to fix conflicts
Sam Reed [Sat, 19 Nov 2011 20:17:29 +0000 (20:17 +0000)]
* (bug 8859) Database::update should take array of tables too
Original patch by Andrew Dunbar
Also apply in DatabaseOracle and DB2 code as they override update
Sam Reed [Sat, 19 Nov 2011 20:01:33 +0000 (20:01 +0000)]
Bug 13759 - memcached predefined hashes
Patch by Zac Bristow
Half of the patch was already applied. Updated documentation to match
Roan Kattouw [Sat, 19 Nov 2011 19:01:08 +0000 (19:01 +0000)]
Followup r103692: don't add a query per row
Antoine Musso [Sat, 19 Nov 2011 18:24:43 +0000 (18:24 +0000)]
parserTests: add --filter as an alias of --regex
PHPUnit use the --filter option and I keep incorrectly using it for
parserTest. So this is adding an alias of --regex.
Sam Reed [Sat, 19 Nov 2011 17:39:56 +0000 (17:39 +0000)]
More updater message updates and normalisation
Fix a call to $this->db->applyPatch() to $this->applyPatch()
Roan Kattouw [Sat, 19 Nov 2011 17:30:56 +0000 (17:30 +0000)]
RELEASE-NOTES for r103692
Roan Kattouw [Sat, 19 Nov 2011 17:27:34 +0000 (17:27 +0000)]
(bug 32228) Special:Search doesn't conserve profile when new search terms are entered
Sam Reed [Sat, 19 Nov 2011 17:21:55 +0000 (17:21 +0000)]
Followup r103685
Not sure why I reinvented the wheel. Oh well, doing it properly now
Roan Kattouw [Sat, 19 Nov 2011 17:21:43 +0000 (17:21 +0000)]
(bug 30368) When a page is moved, link to and display the new name rather than the old name on Special:Newpages. Did this by treating relying on rc_cur_id instead of rc_namespace & rc_title when building the list. This is safe because the Newpages query already joins against page, so we know the rc_cur_id points to an existing page.
Sam Reed [Sat, 19 Nov 2011 17:18:22 +0000 (17:18 +0000)]
* (bug 32020) Improve messages output by the database updaters
Patch by David Baumgarten
Antoine Musso [Sat, 19 Nov 2011 17:04:13 +0000 (17:04 +0000)]
Bug 32397 - #userlogin is too narrow
Patch by A. D. Bergi
Antoine Musso [Sat, 19 Nov 2011 17:00:57 +0000 (17:00 +0000)]
revert r103694 r103687
Need to find a better way to fix that cache issue :(
Antoine Musso [Sat, 19 Nov 2011 16:40:23 +0000 (16:40 +0000)]
Bug 32238 - phaseout wgEnableTooltipsAndAccesskeys
Antoine Musso [Sat, 19 Nov 2011 16:31:42 +0000 (16:31 +0000)]
closing a store is only available for CDB type
follow up r103684
Sam Reed [Sat, 19 Nov 2011 16:26:28 +0000 (16:26 +0000)]
* (bug 32470) Increase the length of ug_group
Postgres doesn't need extending...
Antoine Musso [Sat, 19 Nov 2011 16:23:52 +0000 (16:23 +0000)]
add possibility to close a LCStore_CDB
also close an LCStore_CDB after checking for expiry
Sam Reed [Sat, 19 Nov 2011 16:19:35 +0000 (16:19 +0000)]
Global tables died
Roan Kattouw [Sat, 19 Nov 2011 16:02:26 +0000 (16:02 +0000)]
Make ResourceLoader::register() non-recursive, was calling itself recursively on every page load.
Raimond Spekking [Sat, 19 Nov 2011 14:32:52 +0000 (14:32 +0000)]
Localisation update for core and extension messages from translatewiki.net
Derk-Jan Hartman [Sat, 19 Nov 2011 14:32:45 +0000 (14:32 +0000)]
Fixes broken alignment of catlinks in cologneblue and simple skins.
Follow up to r102297
Fixes bug 32460
Daniel Friesen [Sat, 19 Nov 2011 14:14:57 +0000 (14:14 +0000)]
Incorporate a router into our maintenance/dev/ code to better handle the variety of file types we support.
Derk-Jan Hartman [Sat, 19 Nov 2011 14:09:58 +0000 (14:09 +0000)]
Fix the sitesub of cologneblue. Follow up to r80785
Derk-Jan Hartman [Sat, 19 Nov 2011 13:48:02 +0000 (13:48 +0000)]
Fix an issue with the header of CologneBlue. Introduced in r97657
Fixes bug 32474
Antoine Musso [Sat, 19 Nov 2011 11:42:25 +0000 (11:42 +0000)]
bug 32086 get fixed in 1.18 not 1.18
r101478 did not get merged in 1.18
Alexandre Emsenhuber [Sat, 19 Nov 2011 09:44:03 +0000 (09:44 +0000)]
* Use local context to get messages
* Escape 'word-separator' and 'parentheses' messages
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:54:03 +0000 (08:54 +0000)]
Use ParserOptions::newFromContext() instead of 'new ParserOptions' to use the local context instead of relying on $wgUser and $wgLang
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:51:20 +0000 (08:51 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:29:49 +0000 (08:29 +0000)]
Follow-up r103332: fix "invalidoldimage" error message to say "oldimage" instead of "oldid"
Aaron Schulz [Sat, 19 Nov 2011 05:37:24 +0000 (05:37 +0000)]
Made ChangesList generate page links with rcid=x for new pages when $wgUseNPPatrol is on (not just $wgUseRCPatrol)
Robin Pepermans [Sat, 19 Nov 2011 05:18:32 +0000 (05:18 +0000)]
Make $wgDummyLanguageCodes an associative array so it maps to the correct codes; and use it in WikimediaIncubator to check whether the wiki exists (so e.g. Wx/sgs recognizes that the wiki corresponding to Wx/bat-smg exists). The extension is compatible with the old $wgDummyLanguageCodes array.
gicode [Sat, 19 Nov 2011 02:53:37 +0000 (02:53 +0000)]
Don't force a localization cache rebuild if it will be handled automatically.
Alexandre Emsenhuber [Fri, 18 Nov 2011 21:36:57 +0000 (21:36 +0000)]
* Use ParserOptions::newFromContext() to not depend on $wgUser and $wgLang
* Use a WikiPage object instead of Article to get the text or the ParserOutput and create the object directly in getParsedSectionOrText()
* Use Title::getLatestRevID() instead of Article::getRevIdFetched() since the latter will always return the current revision ID when 0 is passed as second parameter to the constructor
* Pass the User object to Revision::getText()
* Removed double setting of $wgTitle
Raimond Spekking [Fri, 18 Nov 2011 14:57:27 +0000 (14:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ariel Glenn [Fri, 18 Nov 2011 09:08:29 +0000 (09:08 +0000)]
followup to r103448, tighten up code
Alexandre Emsenhuber [Fri, 18 Nov 2011 07:10:03 +0000 (07:10 +0000)]
Fix for r103502: make PoolWorkArticleView::doWork() return true when the parse is successful; also fixed getIsDirty() to return the member parameter and not try to execute a non-existing function
Raimond Spekking [Thu, 17 Nov 2011 22:50:20 +0000 (22:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 17 Nov 2011 20:30:28 +0000 (20:30 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Thu, 17 Nov 2011 20:21:54 +0000 (20:21 +0000)]
* Added WikiPage::getParserOutput() and changed Article::getParserOutput() to use it
* WikiPage::getParserOutput() requires a ParserOptions object (and optionally the revision ID) instead of an User object, removes an hidden dependency on $wgLang. For this reason, WikiPage::isParserCacheUsed() now also uses a ParserOptions object instead of an User object (doesn't change anything in the code except the variable name and it's not called in extensions)
* Moved PoolWorkArticleView to WikiPage.php and added an entry in the AutoLoader and moved output-related stuff directly in Article::view() so that in can be shared with WikiPage::getParserOutput() (removes code duplication, etc.)
* Added the revision ID to the PoolCounter key so that it knows which revision is being parsed and doesn't wait for another parse operation with same options but different revisions
* Removed Article::doViewParse(), Article::tryDirtyCache() and Article::getOutputFromWikitext() since they are now integrated in PoolWorkArticleView and Article::view() and there are no callers in extensions. This also fixes a bug since Article::doViewParse() will get another ParserOptions instance with special options set in Article::view() not be repercuted.
* Updated DifferenceEngine to use the new system
* Updated docs/memcached.txt to correct method names
Sam Reed [Thu, 17 Nov 2011 19:06:30 +0000 (19:06 +0000)]
Fix the rest of 'inlanguage ' in r93765
Sam Reed [Thu, 17 Nov 2011 19:00:09 +0000 (19:00 +0000)]
Fix trailing space in r93765
Antoine Musso [Thu, 17 Nov 2011 16:46:45 +0000 (16:46 +0000)]
(bug 32450) MediaWiki: .js|.css pages parsed [[Category:#]] links
This patch skip the [[Category:#]] parsing logic when the Title is in
NS_MEDIAWIKI and ends with .js or .css. This way the code is kept as is
and pages are no more categorized.
How to reproduce the issue:
$ echo 'var foo = "[[Category:bug32450]]"' \
| php maintenance/parse.php --title MediaWiki:Foobar.js
<p>var foo = ""
</p>
$
Note how the text got stripped.
After this patch:
$ echo 'var foo = "[[Category:bug32450]]"' \
| php maintenance/parse.php --title MediaWiki:Foobar.js
<p>var foo = "[[Category:bug32450]]"
</p>
$
TEST PLAN:
==========
$ php parserTests.php --quiet
This is MediaWiki version 1.19alpha (r103473).
Reading tests from "tests/parser/parserTests.txt"...
Reading tests from "tests/parser/extraParserTests.txt"...
Passed 654 of 654 tests (100%)... ALL TESTS PASSED!
$
Mark A. Hershberger [Thu, 17 Nov 2011 16:00:41 +0000 (16:00 +0000)]
Apply cryptocoryne's patch from Bug 32454 - ArticlePurge hook is broken after r86041
Mark A. Hershberger [Thu, 17 Nov 2011 15:16:03 +0000 (15:16 +0000)]
Adapt and re-apply Michael Newton's patch from Bug 24464 - Execute
LoginAuthenticateAudit hook more often.
Also updated release notes.
Antoine Musso [Thu, 17 Nov 2011 14:46:17 +0000 (14:46 +0000)]
use spaces for usage indentation
Alexandre Emsenhuber [Thu, 17 Nov 2011 10:33:20 +0000 (10:33 +0000)]
* Use the fact that WikiPage::getLatest() is updated when editing the page since r103383
* Moved override of $wgTitle and creation of EditPage object to the place they will be used
Antoine Musso [Thu, 17 Nov 2011 10:10:40 +0000 (10:10 +0000)]
skip Media: links in addition to Special: links
That one triggered an exception stack trace when using Media:foo as
a target on Special:WhatLinksHere.
Example:
Special:WhatLinksHere/Media:file.png
That is a rare occurence that "should not happen". I am not sure it is
worth backporting to 1.18 although it impacts live site:
http://en.wikipedia.org/wiki/Special:WhatLinksHere/Media:BSicon_uBS2lf.svg
Alexandre Emsenhuber [Thu, 17 Nov 2011 10:06:56 +0000 (10:06 +0000)]
* Removed Preferences::validateEmail() to that e-mail address modification is in another special page, no callers
* Added $form parameter to Preferences::cleanSignature() and Preferences::validateSignature(), they are passed to the functions since r102879
* Use local context to get messages
Ariel Glenn [Thu, 17 Nov 2011 09:20:51 +0000 (09:20 +0000)]
if user id is 0 and username is actually an IP, write it as <ip>, not <username>
Siebrand Mazeland [Thu, 17 Nov 2011 04:43:41 +0000 (04:43 +0000)]
Put $fallback back that was accidentally removed in r96692. Spotted by Merlissimo.
Cannot explain how this happened.
Siebrand Mazeland [Thu, 17 Nov 2011 03:28:48 +0000 (03:28 +0000)]
Follow-up r103437: fix typo and add quotes.
Aaron Schulz [Thu, 17 Nov 2011 03:14:05 +0000 (03:14 +0000)]
Documentation
Siebrand Mazeland [Thu, 17 Nov 2011 03:13:33 +0000 (03:13 +0000)]
Tweak message updated in r103386.
Brian Wolff [Wed, 16 Nov 2011 23:55:40 +0000 (23:55 +0000)]
revert r103396 (breaks unit tests) - In lots of these places $u is undefined (for example, of a user doesn't specify a name, we havn't created a user object yet at the time of that check). Probably need to do something like create a second hook for loginAuditUserTotallyFailed or something.
Aaron Schulz [Wed, 16 Nov 2011 22:55:48 +0000 (22:55 +0000)]
Moved File classes to filerepo/file (as well as ArchivedFile)
Aaron Schulz [Wed, 16 Nov 2011 22:33:34 +0000 (22:33 +0000)]
Fixed comment typo
dépôts / lhc / web / wiklou.git / log