lhc/web/wiklou.git
13 years agoRemove comment about possibly removing the extra debugging info. Only the site admin...
Chad Horohoe [Thu, 16 Dec 2010 15:01:39 +0000 (15:01 +0000)]
Remove comment about possibly removing the extra debugging info. Only the site admin should have access to the installer/updater anyway, so we're not really disclosing anything here.

13 years agoFix a few more paths from the tests move
Chad Horohoe [Thu, 16 Dec 2010 13:49:48 +0000 (13:49 +0000)]
Fix a few more paths from the tests move

13 years agoNo need to call wfDoUpdates(), already done by Article::doEdit()
Alexandre Emsenhuber [Thu, 16 Dec 2010 13:34:32 +0000 (13:34 +0000)]
No need to call wfDoUpdates(), already done by Article::doEdit()

13 years agoRemoving trailing whitespace
Sam Reed [Thu, 16 Dec 2010 11:20:39 +0000 (11:20 +0000)]
Removing trailing whitespace

13 years agoRepair phpunit.php
Mark A. Hershberger [Thu, 16 Dec 2010 01:32:28 +0000 (01:32 +0000)]
Repair phpunit.php

13 years agoSet cursor to default for tooltips to avoid text cursor appearing and sticking when...
Trevor Parscal [Thu, 16 Dec 2010 01:19:15 +0000 (01:19 +0000)]
Set cursor to default for tooltips to avoid text cursor appearing and sticking when moving the mouse of a tooltip that's either configure with a delayed exit or fade-out.

13 years agoFixed typo
Priyanka Dhanda [Wed, 15 Dec 2010 23:09:46 +0000 (23:09 +0000)]
Fixed typo

13 years agoMake these tests run again. I think this is the right fix. At least they run now.
Priyanka Dhanda [Wed, 15 Dec 2010 23:00:11 +0000 (23:00 +0000)]
Make these tests run again. I think this is the right fix. At least they run now.

13 years agoChange old php4 style constructor
Sam Reed [Wed, 15 Dec 2010 22:41:06 +0000 (22:41 +0000)]
Change old php4 style constructor

13 years agoFollow-up r78445: don't spam a useless edit token into the URL for GET requests.
Happy-melon [Wed, 15 Dec 2010 21:37:50 +0000 (21:37 +0000)]
Follow-up r78445: don't spam a useless edit token into the URL for GET requests.

13 years agoClean up the running mess that is r64866, r65040, and then r67277. Implement and...
Happy-melon [Wed, 15 Dec 2010 21:14:36 +0000 (21:14 +0000)]
Clean up the running mess that is r64866, r65040, and then r67277.  Implement and document consistent behaviour for all types of fields: if the 'name' parameter is specified, use it exactly as is, otherwise use "wp{$fieldname}".  For hidden fields added with addHiddenField(), continue to use either $attrib['name'] or $name, both unaltered.

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Wed, 15 Dec 2010 21:12:17 +0000 (21:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-15 20:54:00 UTC)

13 years agoChanged doQuery() -> query()
Aaron Schulz [Wed, 15 Dec 2010 20:59:29 +0000 (20:59 +0000)]
Changed doQuery() -> query()

13 years agoFollow-up r78445: validation errors would never be shown on a GET form
Happy-melon [Wed, 15 Dec 2010 20:10:16 +0000 (20:10 +0000)]
Follow-up r78445: validation errors would never be shown on a GET form

13 years agoWhen using safe_mode, mail() cannot take the 5th parameter. Rather than (needlessly...
Chad Horohoe [Wed, 15 Dec 2010 19:55:08 +0000 (19:55 +0000)]
When using safe_mode, mail() cannot take the 5th parameter. Rather than (needlessly) disabling e-mail confirmation as a result, just disregard the parameter. Pointed out by Kunda on IRC.

13 years agoLocalisation updates Cantonese, Chinese and Literary Chinese
Shinjiman [Wed, 15 Dec 2010 19:41:51 +0000 (19:41 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese

13 years agoAllow HTMLForms to be submitted by GET requests.
Happy-melon [Wed, 15 Dec 2010 19:33:03 +0000 (19:33 +0000)]
Allow HTMLForms to be submitted by GET requests.

13 years agoFollowup r78383: deny tests from web
Chad Horohoe [Wed, 15 Dec 2010 16:26:26 +0000 (16:26 +0000)]
Followup r78383: deny tests from web

13 years agoBetter regexes for r78246.
Happy-melon [Wed, 15 Dec 2010 13:33:47 +0000 (13:33 +0000)]
Better regexes for r78246.

13 years agoFollow-up r78426: Tweak messages for consistency. Remove sentence about "API documena...
Raimond Spekking [Wed, 15 Dec 2010 13:07:21 +0000 (13:07 +0000)]
Follow-up r78426: Tweak messages for consistency. Remove sentence about "API documenation" because I think it is not helpful for normal users.
Add new messages to maintenance file

13 years agoRemove public from interface defintion, as decleration in an interface is not valid
Sam Reed [Wed, 15 Dec 2010 11:30:54 +0000 (11:30 +0000)]
Remove public from interface defintion, as decleration in an interface is not valid

13 years agoadded a page to list all stashed files, and clear them if necessary -- helpful while...
Neil Kandalgaonkar [Wed, 15 Dec 2010 01:21:11 +0000 (01:21 +0000)]
added a page to list all stashed files, and clear them if necessary -- helpful while debugging some concurrency issues, also gets us closer to keeping the UploadWizard state on the server

13 years agorefactored HTMLForm show() into three methods, in case you want to process a form...
Neil Kandalgaonkar [Wed, 15 Dec 2010 01:17:28 +0000 (01:17 +0000)]
refactored HTMLForm show() into three methods, in case you want to process a form in some way separate from showing it.

13 years agoFollow-up r77796: a couple of typos in the comment, and break more consistently at...
Happy-melon [Wed, 15 Dec 2010 01:03:44 +0000 (01:03 +0000)]
Follow-up r77796: a couple of typos in the comment, and break more consistently at 90 cols.

13 years agoAccess modifiers aren't valid on interfaces
Sam Reed [Tue, 14 Dec 2010 23:43:03 +0000 (23:43 +0000)]
Access modifiers aren't valid on interfaces

13 years agoIn the vein of r75313, get groups from the $wg(Add|Remove)Groups and $wgGroups(AddTo...
Happy-melon [Tue, 14 Dec 2010 22:45:25 +0000 (22:45 +0000)]
In the vein of r75313, get groups from the $wg(Add|Remove)Groups and $wgGroups(AddTo|RemoveFrom)Self variables as well.

13 years agoRemove the word global from the messages itselves, per r78230 CR.
Platonides [Tue, 14 Dec 2010 21:57:13 +0000 (21:57 +0000)]
Remove the word global from the messages itselves, per r78230 CR.

13 years ago* (bug 26339) Throw warning when truncating an overlarge API result
Sam Reed [Tue, 14 Dec 2010 21:40:14 +0000 (21:40 +0000)]
* (bug 26339) Throw warning when truncating an overlarge API result

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Tue, 14 Dec 2010 21:19:18 +0000 (21:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-14 20:54:00 UTC)

13 years agoChecking permissions for $wgUser while doing an edit with another user is not a good...
Alexandre Emsenhuber [Tue, 14 Dec 2010 19:40:27 +0000 (19:40 +0000)]
Checking permissions for $wgUser while doing an edit with another user is not a good idea

13 years agoFixup fixme on r76844
Sam Reed [Tue, 14 Dec 2010 18:17:42 +0000 (18:17 +0000)]
Fixup fixme on r76844

Only "known issue", is the bottom limit thing posts, and won't override the top one, if it's set one in the URL, which is a PITA. 2 clicks does it. Hopefully this can be fixed, and uncommented when VVV sorts out our queryparameters? :)

13 years agoDo not access to mTouched internals of Article from a different module per r70783...
Platonides [Tue, 14 Dec 2010 17:49:01 +0000 (17:49 +0000)]
Do not access to mTouched internals of Article from a different module per r70783#c12039

13 years ago* Removing wfSupportsAjax() call. We don't use legacy sajax_ anymore, jQuery takes...
Krinkle [Tue, 14 Dec 2010 17:21:40 +0000 (17:21 +0000)]
* Removing wfSupportsAjax() call. We don't use legacy sajax_ anymore, jQuery takes care of this
* Thus also removing the dependency on mediawiki.legacy.ajax in mediawiki.action.watch.ajax
* Moving the show() call further down in jsMessage. Before this commit the box shows for a split second (empty) and then it suddenly grows with content. Now moved it down so that it comes into view, filled already. Also made it possible to bring back the slideDown effect without ugly flashes.

13 years agoUse $.getJSON()'s middle parameter rather than DIY URL building in AJAX watch JS
Roan Kattouw [Tue, 14 Dec 2010 16:56:56 +0000 (16:56 +0000)]
Use $.getJSON()'s middle parameter rather than DIY URL building in AJAX watch JS

13 years agoFix a few more paths, restore a few files lost in the move
Chad Horohoe [Tue, 14 Dec 2010 16:48:44 +0000 (16:48 +0000)]
Fix a few more paths, restore a few files lost in the move

13 years agoFix path changes from move in r78383
Chad Horohoe [Tue, 14 Dec 2010 16:33:06 +0000 (16:33 +0000)]
Fix path changes from move in r78383

13 years agoMissed another comment in r78381
Chad Horohoe [Tue, 14 Dec 2010 16:31:25 +0000 (16:31 +0000)]
Missed another comment in r78381

13 years agosvn ci'd from the wrong directory, missed the deletes in r78383
Chad Horohoe [Tue, 14 Dec 2010 16:28:52 +0000 (16:28 +0000)]
svn ci'd from the wrong directory, missed the deletes in r78383

13 years agoPer wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're...
Chad Horohoe [Tue, 14 Dec 2010 16:26:35 +0000 (16:26 +0000)]
Per wikitech-l discussion: Move tests from maintenance/tests/ to tests/. They're not strictly maintenance scripts, and some people want to do a selective checkout that doesn't include the tests. There's still debate on whether we should include these in the release downloads, but we had a pretty firm consensus to move this.

13 years agoRemove big commented list of URLs (added in r61078) that this class will never be...
Chad Horohoe [Tue, 14 Dec 2010 15:49:41 +0000 (15:49 +0000)]
Remove big commented list of URLs (added in r61078) that this class will never be testing. Core tests shouldn't depend on extensions and they were confusing my grepping too.

13 years agoFix up few remaining fixme things from r69910
Sam Reed [Tue, 14 Dec 2010 15:44:16 +0000 (15:44 +0000)]
Fix up few remaining fixme things from r69910

13 years agoFollowup r77354: it's page_touched, with an underscore
Roan Kattouw [Tue, 14 Dec 2010 15:33:14 +0000 (15:33 +0000)]
Followup r77354: it's page_touched, with an underscore

13 years agoCleanup for r63578: Use Maintenance::error(), that's what its for
Chad Horohoe [Tue, 14 Dec 2010 13:37:53 +0000 (13:37 +0000)]
Cleanup for r63578: Use Maintenance::error(), that's what its for

13 years agoRevert r74978 per CR, no followup for nearly 2 months
Chad Horohoe [Tue, 14 Dec 2010 13:20:10 +0000 (13:20 +0000)]
Revert r74978 per CR, no followup for nearly 2 months

13 years agoPer r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that needs it...
Chad Horohoe [Tue, 14 Dec 2010 12:59:17 +0000 (12:59 +0000)]
Per r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that needs it is badly written and needs to use the AutoLoader properly."

13 years agoStyle fix for r76220
Chad Horohoe [Tue, 14 Dec 2010 12:51:59 +0000 (12:51 +0000)]
Style fix for r76220

13 years agorm double comment
Chad Horohoe [Tue, 14 Dec 2010 12:47:37 +0000 (12:47 +0000)]
rm double comment

13 years agoFix for r78322, check $result not $value
Chad Horohoe [Tue, 14 Dec 2010 12:47:07 +0000 (12:47 +0000)]
Fix for r78322, check $result not $value

13 years agoChanged $wgArticle to local variable, not needed
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:25:34 +0000 (12:25 +0000)]
Changed $wgArticle to local variable, not needed

13 years agoArticle::insertNewArticle() -> Article::doEdit()
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:15:55 +0000 (12:15 +0000)]
Article::insertNewArticle() -> Article::doEdit()

13 years agoImprove some of the descriptions added in r68482
Roan Kattouw [Tue, 14 Dec 2010 11:47:13 +0000 (11:47 +0000)]
Improve some of the descriptions added in r68482

13 years agoCleaned up r70342 and r70343: removed commented-out code.
Tim Starling [Tue, 14 Dec 2010 11:11:38 +0000 (11:11 +0000)]
Cleaned up r70342 and r70343: removed commented-out code.

13 years agoFollowup r78104: set the cookie unconditionally, so its expiry is renewed every time...
Roan Kattouw [Tue, 14 Dec 2010 11:09:30 +0000 (11:09 +0000)]
Followup r78104: set the cookie unconditionally, so its expiry is renewed every time sessionId() is called

13 years agoUpdate references for wfEscapeShellArg() for r69732 etc. The very useful mailing...
Tim Starling [Tue, 14 Dec 2010 10:57:41 +0000 (10:57 +0000)]
Update references for wfEscapeShellArg() for r69732 etc. The very useful mailing list post that I cited has disappeared from the web!

13 years agoFixed comments and indenting style from r68491.
Tim Starling [Tue, 14 Dec 2010 09:01:48 +0000 (09:01 +0000)]
Fixed comments and indenting style from r68491.

13 years agoLocalization update for he.
Rotem Liss [Tue, 14 Dec 2010 08:44:09 +0000 (08:44 +0000)]
Localization update for he.

13 years agoFixed typos in file names from r65967
Tim Starling [Tue, 14 Dec 2010 08:14:55 +0000 (08:14 +0000)]
Fixed typos in file names from r65967

13 years agomerging the two addModules() calls into one, (they take an array, so might as well...
Krinkle [Tue, 14 Dec 2010 00:08:54 +0000 (00:08 +0000)]
merging the two addModules() calls into one, (they take an array, so might as well me together); + using mw instead of mediaWiki in mediawiki.util.js

13 years agoAdded comment about why you should not be depending on mediaWiki.user.sessionId befor...
Trevor Parscal [Tue, 14 Dec 2010 00:08:07 +0000 (00:08 +0000)]
Added comment about why you should not be depending on mediaWiki.user.sessionId before mediaWiki.loader.go is called.

13 years agoFixes r78104 much better than r78344 did. By adding jquery.cookie to the loading...
Trevor Parscal [Tue, 14 Dec 2010 00:02:21 +0000 (00:02 +0000)]
Fixes r78104 much better than r78344 did. By adding jquery.cookie to the loading queue just after declaring mediaWiki we can ensure it's in the first batch of modules that are fetched - essentially adding it to the initial payload.

13 years agoadded compareObject function to mediaWiki core jQuery prototyping utilities
Krinkle [Mon, 13 Dec 2010 23:52:45 +0000 (23:52 +0000)]
added compareObject function to mediaWiki core jQuery prototyping utilities

13 years agoFixed issue in r78104 where jquery.cookie wouldn't load properly. Changed the mediaWi...
Trevor Parscal [Mon, 13 Dec 2010 23:51:29 +0000 (23:51 +0000)]
Fixed issue in r78104 where jquery.cookie wouldn't load properly. Changed the mediaWiki User object to load jquery.cookie on demand.

13 years agoChecking namespace restriction with $wgUser while calling Title::getUserPermissionsEr...
Alexandre Emsenhuber [Mon, 13 Dec 2010 22:33:08 +0000 (22:33 +0000)]
Checking namespace restriction with $wgUser while calling Title::getUserPermissionsErrors() with anoter User object is really not a good idea

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Mon, 13 Dec 2010 20:58:38 +0000 (20:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-13 20:33:00 UTC)

13 years agoFollowup to r77836. Update parserTests
Derk-Jan Hartman [Mon, 13 Dec 2010 20:34:35 +0000 (20:34 +0000)]
Followup to r77836. Update parserTests

13 years agoMake the Map-class publicly available
Krinkle [Mon, 13 Dec 2010 20:13:39 +0000 (20:13 +0000)]
Make the Map-class publicly available

13 years agoFollow-up r66364: wincache fixes
Bryan Tong Minh [Mon, 13 Dec 2010 20:04:06 +0000 (20:04 +0000)]
Follow-up r66364: wincache fixes
* Return the result of wincache_ucache_get() in get()
* In command line mode $info['ucache_entries'] returned from wincache_ucache_info() is null, so don't iterate over a non-array

13 years agoFollow-up r78297: allow the hook to break the execution; added &$term: could be usefu...
Bryan Tong Minh [Mon, 13 Dec 2010 20:00:43 +0000 (20:00 +0000)]
Follow-up r78297: allow the hook to break the execution; added &$term: could be useful for modifying the edit link

13 years agoRemoved trailing whitespaces
Alexandre Emsenhuber [Mon, 13 Dec 2010 19:47:34 +0000 (19:47 +0000)]
Removed trailing whitespaces

13 years agoFollowup r64047: pass static callbacks in array form, not string form
Roan Kattouw [Mon, 13 Dec 2010 16:39:48 +0000 (16:39 +0000)]
Followup r64047: pass static callbacks in array form, not string form

13 years agoDo not assume that the current working dir is phase3/config
Platonides [Mon, 13 Dec 2010 15:49:05 +0000 (15:49 +0000)]
Do not assume that the current working dir is phase3/config

13 years agoFix for r75858: Move $IP detection further up so it can be used in child constructors
Chad Horohoe [Mon, 13 Dec 2010 15:30:41 +0000 (15:30 +0000)]
Fix for r75858: Move $IP detection further up so it can be used in child constructors

13 years agoFix comment: Article::insertNewArticle() -> Article::doEdit() and Article::insertOn()
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:16:05 +0000 (15:16 +0000)]
Fix comment: Article::insertNewArticle() -> Article::doEdit() and Article::insertOn()

13 years agoChanged global variables ($wgTitle and $wgArticle) to local ones
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:13:06 +0000 (15:13 +0000)]
Changed global variables ($wgTitle and $wgArticle) to local ones

13 years agoFollowup r76220: locateExecutableInDefaultPaths() was made static, so use static...
Roan Kattouw [Mon, 13 Dec 2010 13:13:29 +0000 (13:13 +0000)]
Followup r76220: locateExecutableInDefaultPaths() was made static, so use static calls

13 years agoFix variable name in doc comment added in r78192
Roan Kattouw [Mon, 13 Dec 2010 12:44:34 +0000 (12:44 +0000)]
Fix variable name in doc comment added in r78192

13 years agoFix r78196: readd accidentally removed lines in shared.css
Roan Kattouw [Mon, 13 Dec 2010 12:40:08 +0000 (12:40 +0000)]
Fix r78196: readd accidentally removed lines in shared.css

13 years agoFollowup r78295, seems I didn't even bother to rename it last time
Sam Reed [Mon, 13 Dec 2010 12:38:44 +0000 (12:38 +0000)]
Followup r78295, seems I didn't even bother to rename it last time

13 years agoFollowup r78268, do it as Bryan suggested, not as how I'd interpretted it for some...
Sam Reed [Mon, 13 Dec 2010 11:06:57 +0000 (11:06 +0000)]
Followup r78268, do it as Bryan suggested, not as how I'd interpretted it for some daft reason

13 years agoFollow-up to r77956: instead of making $wgFileExtensions override $wgFileBlacklist...
Benjamin Lees [Sun, 12 Dec 2010 23:19:24 +0000 (23:19 +0000)]
Follow-up to r77956: instead of making $wgFileExtensions override $wgFileBlacklist, make sure the upload page does not mark blacklisted extensions as "Permitted file types".  I've updated the MediaWiki.org pages to explain how to remove items from the blacklist.

13 years ago(mw.util.test) Escape the 'does return, the same way as the 'should return' (mw.html...
Krinkle [Sun, 12 Dec 2010 22:30:02 +0000 (22:30 +0000)]
(mw.util.test) Escape the 'does return, the same way as the 'should return' (mw.html.escape() and spaces to non-breaking)

13 years agoFix fatal error from r78264
Alexandre Emsenhuber [Sun, 12 Dec 2010 20:45:32 +0000 (20:45 +0000)]
Fix fatal error from r78264

13 years agoLocalisation updates for core and extension messages from translatewiki.net (2010...
Raimond Spekking [Sun, 12 Dec 2010 20:34:19 +0000 (20:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-12 20:19:00 UTC)

13 years agoFollowup r65114 (per CR cabal), remove SpecialSearchGomatch, replace with SpecialSear...
Sam Reed [Sun, 12 Dec 2010 18:57:10 +0000 (18:57 +0000)]
Followup r65114 (per CR cabal), remove SpecialSearchGomatch, replace with SpecialSearchGo in SearchEngine::getNearMatch

13 years agoMoved the check for the "printable" parameter to performRequestForTitle() instead...
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:54:33 +0000 (18:54 +0000)]
Moved the check for the "printable" parameter to performRequestForTitle() instead of checkInitialQueries(), I don't know why we need to do this check that early

13 years agoIt's easier to use addWikiMsgArray()
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:47:04 +0000 (18:47 +0000)]
It's easier to use addWikiMsgArray()

13 years agoFollowup r75763, fixup wrong change of deprecated method
Sam Reed [Sun, 12 Dec 2010 18:35:19 +0000 (18:35 +0000)]
Followup r75763, fixup wrong change of deprecated method

No need to do separate htmlspecialchars et al, Xml::expandAttributes

13 years agoFix typo in hooks.txt
Sam Reed [Sun, 12 Dec 2010 18:17:33 +0000 (18:17 +0000)]
Fix typo in hooks.txt

13 years ago&& not and, || not or
Chad Horohoe [Sun, 12 Dec 2010 17:50:35 +0000 (17:50 +0000)]
&& not and, || not or

13 years agoRemove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.
Chad Horohoe [Sun, 12 Dec 2010 17:25:56 +0000 (17:25 +0000)]
Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.

13 years agoRedo r78254 without the syntax error
Roan Kattouw [Sun, 12 Dec 2010 16:18:08 +0000 (16:18 +0000)]
Redo r78254 without the syntax error

13 years agoThis is not an array, but a parameter. Revert r78254. Is the precommit hook not working?
Platonides [Sun, 12 Dec 2010 16:15:35 +0000 (16:15 +0000)]
This is not an array, but a parameter. Revert r78254. Is the precommit hook not working?
PHP Parse error:  syntax error, unexpected T_DOUBLE_ARROW in includes/Title.php on line 3752

13 years agoFolllowup r72866: use array syntax for rev_page = foo condition
Roan Kattouw [Sun, 12 Dec 2010 15:55:03 +0000 (15:55 +0000)]
Folllowup r72866: use array syntax for rev_page = foo condition

13 years agoFollow-up r65652: Do not double-slash the path if it came from PATH_INFO
Bryan Tong Minh [Sun, 12 Dec 2010 15:50:25 +0000 (15:50 +0000)]
Follow-up r65652: Do not double-slash the path if it came from PATH_INFO

13 years agoFollow-up r64903: rm leftover debugging code.
Happy-melon [Sun, 12 Dec 2010 15:40:41 +0000 (15:40 +0000)]
Follow-up r64903: rm leftover debugging code.

13 years agoFollow-up r78246: clean several integer preferences before saving. It's not dangerou...
Happy-melon [Sun, 12 Dec 2010 15:38:54 +0000 (15:38 +0000)]
Follow-up r78246: clean several integer preferences before saving.  It's not dangerous to not do this, here or elsewhere, because it is done implicitly whenever the value is treated as a number; but it keeps the database tidier.

13 years agoFollow-up to r64866: follow the HTML5 spec when validating floats and ints, and suppo...
Happy-melon [Sun, 12 Dec 2010 15:32:29 +0000 (15:32 +0000)]
Follow-up to r64866: follow the HTML5 spec when validating floats and ints, and support 'required' attribute universally (apart from type=hidden).

13 years agoPer CR on r71359: Fix DB_MASTER where it should be __METHOD__
Chad Horohoe [Sun, 12 Dec 2010 15:29:47 +0000 (15:29 +0000)]
Per CR on r71359: Fix DB_MASTER where it should be __METHOD__

13 years agoMake ul.gallery block, not inline-block
Aryeh Gregor [Sun, 12 Dec 2010 00:30:06 +0000 (00:30 +0000)]
Make ul.gallery block, not inline-block

As suggested by fomafix at
<https://bugzilla.wikimedia.org/show_bug.cgi?id=3276#c33>.  This makes
it play nicer with floats, at least in Firefox 4, and doesn't seem to
otherwise break stuff (but I haven't tested in many browsers).

13 years agoRemove that ugly unset( $vars['_lsExists'] );
Platonides [Sat, 11 Dec 2010 22:54:41 +0000 (22:54 +0000)]
Remove that ugly unset( $vars['_lsExists'] );
Shouldn't the second file_exists() also need a wfSuppressWarnings?
Follow up to r78118.