lhc/web/wiklou.git
12 years ago* Removed usage of error suppression operator in includes/db
Alexandre Emsenhuber [Mon, 4 Jul 2011 15:00:30 +0000 (15:00 +0000)]
* Removed usage of error suppression operator in includes/db
* Changed an usage of $_REQUEST to $wgRequest

12 years agoUse WebRequest::getValues() instead of raw $_REQUEST
Alexandre Emsenhuber [Mon, 4 Jul 2011 14:40:17 +0000 (14:40 +0000)]
Use WebRequest::getValues() instead of raw $_REQUEST

12 years agoAllow SqlBagOStuff data to be split over many tables, to avoid lock contention perfor...
Tim Starling [Mon, 4 Jul 2011 12:01:10 +0000 (12:01 +0000)]
Allow SqlBagOStuff data to be split over many tables, to avoid lock contention performance issues on servers with a high write load. See bugs.mysql.com/bug.php?id=61735 and http://bugs.mysql.com/bug.php?id=61736 .

12 years agoFix for r90337 and r90743: Use $this->title instead of $wgTitle, also groupped global...
Alexandre Emsenhuber [Mon, 4 Jul 2011 08:40:41 +0000 (08:40 +0000)]
Fix for r90337 and r90743: Use $this->title instead of $wgTitle, also groupped global declarations at the top

12 years agoChanged calls to Linker::tooltipAndAccesskeyAttribs() to be static and fixed casing...
Alexandre Emsenhuber [Mon, 4 Jul 2011 08:28:27 +0000 (08:28 +0000)]
Changed calls to Linker::tooltipAndAccesskeyAttribs() to be static and fixed casing in method's name

12 years agoFix for the broken tests introduced in r91387.
Krinkle [Sun, 3 Jul 2011 23:24:51 +0000 (23:24 +0000)]
Fix for the broken tests introduced in r91387.

Check input before assuming there are no arguments and the values object is expected.

12 years agoAdding tests for expected reponse when passing invalid values to Map.get
Krinkle [Sun, 3 Jul 2011 23:22:50 +0000 (23:22 +0000)]
Adding tests for expected reponse when passing invalid values to Map.get
* These are currently @broken
* Map.get should (as documented) handle an object for multiple or a string for a single selection and return the value(s). Right now, however, the function returns the values object if the first two if-cases are not matched. It needs an additional check to verify that there are indeed no arguments passed.
* Adding comments in the test suite

12 years agoMinor optimalizations and jsperfs in mediawiki.js
Krinkle [Sun, 3 Jul 2011 23:13:11 +0000 (23:13 +0000)]
Minor optimalizations and jsperfs in mediawiki.js
* Use strict comparison to undefined where possible (arguments and object/array members)
* Make sure $ is not implied global (using jQuery.isFunction at the bottom instead of creating another 1-line closure)

12 years agoUse Linker::linkKnown per Siebrand on r91377.
Robin Pepermans [Sun, 3 Jul 2011 20:37:57 +0000 (20:37 +0000)]
Use Linker::linkKnown per Siebrand on r91377.

12 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sun, 3 Jul 2011 20:01:47 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-03 19:50:00 UTC)

12 years agoenhance tests name (for --testdox option)
Antoine Musso [Sun, 3 Jul 2011 18:09:30 +0000 (18:09 +0000)]
enhance tests name (for --testdox option)

12 years agoChanging back to $wgUser in SpecialImport.php. Importing pages returned "call to...
Robin Pepermans [Sun, 3 Jul 2011 17:56:59 +0000 (17:56 +0000)]
Changing back to $wgUser in SpecialImport.php. Importing pages returned "call to undefined method ImportReporter::getSkin()" due to r91246.

12 years agosplit tests for ArticleTest
Antoine Musso [Sun, 3 Jul 2011 17:51:11 +0000 (17:51 +0000)]
split tests for ArticleTest

12 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Sat, 2 Jul 2011 20:52:25 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-02 20:44:00 UTC)

12 years agoMoved doCascadeProtectionUpdates() to WikiPage.php
Aaron Schulz [Sat, 2 Jul 2011 17:45:32 +0000 (17:45 +0000)]
Moved doCascadeProtectionUpdates() to WikiPage.php

12 years agoFix for r91344: removed straggling instances of $this->special in item classes
Aaron Schulz [Sat, 2 Jul 2011 17:27:48 +0000 (17:27 +0000)]
Fix for r91344: removed straggling instances of $this->special in item classes

12 years agoBug #29699: Minor adjustments to Vector search button
Mark A. Hershberger [Sat, 2 Jul 2011 16:12:07 +0000 (16:12 +0000)]
Bug #29699: Minor adjustments to Vector search button

Patch from Erwin Dokter as an alternative(?) to r73427.

Applying here so that it can be tested and compared.

12 years agoThe User object parameter of WikiPage::doRollback() and WikiPage::commitRollback...
Alexandre Emsenhuber [Sat, 2 Jul 2011 15:10:39 +0000 (15:10 +0000)]
The User object parameter of WikiPage::doRollback() and WikiPage::commitRollback() was not passed by the Article implementation because it was not present.
While I'm a it, WikiPage::doRollback() and WikiPage::commitRollback() now require that parameter, moved the check to Article.

12 years agoRemoved one hidden usage of $wgUser
Alexandre Emsenhuber [Sat, 2 Jul 2011 14:53:01 +0000 (14:53 +0000)]
Removed one hidden usage of $wgUser

12 years agoMoved action=rollback to an Action subclass
Alexandre Emsenhuber [Sat, 2 Jul 2011 13:46:56 +0000 (13:46 +0000)]
Moved action=rollback to an Action subclass

12 years agoAdded filterByIds() function to Rev_List and made ID based filtering optional. It...
Aaron Schulz [Sat, 2 Jul 2011 09:30:55 +0000 (09:30 +0000)]
Added filterByIds() function to Rev_List and made ID based filtering optional. It's still mandatory for RevDel_List however.

12 years agoRemoved some dead code (useless since r87806)
Aaron Schulz [Sat, 2 Jul 2011 09:12:08 +0000 (09:12 +0000)]
Removed some dead code (useless since r87806)

12 years agoRemoved dead $undeletedRevisions code (useless since r87804)
Aaron Schulz [Sat, 2 Jul 2011 09:08:22 +0000 (09:08 +0000)]
Removed dead $undeletedRevisions code (useless since r87804)

12 years ago* Added generic Rev_List revision listing class and refactored RevDelete_List stuff...
Aaron Schulz [Sat, 2 Jul 2011 09:04:32 +0000 (09:04 +0000)]
* Added generic Rev_List revision listing class and refactored RevDelete_List stuff to use it
* Fixed bug in revdelete where all list Items where assumed to be of the same type (no longer holds since r87804). This was causing "Undefined property: stdClass::$rev_timestamp" errors for deleted revs.
* Cleaned up RevisionDeleter::getRelationType()
* Minor cleanups to SpecialRevisionDelete

12 years agoPatch to replace for-in with for(;;)
Derk-Jan Hartman [Sat, 2 Jul 2011 08:32:19 +0000 (08:32 +0000)]
Patch to replace for-in with for(;;)

This breaks when strange things are added to Array.prototype (and you never know what users do in their user scripts), so use for (var i = 0; i < ...length; i++ ) instead.

Fixes 29676. Patch courtesy of Micheal M.

12 years ago* Put float:left/right for images in shared.css with @noflip. This was inconsistent...
Robin Pepermans [Sat, 2 Jul 2011 01:57:48 +0000 (01:57 +0000)]
* Put float:left/right for images in shared.css with @noflip. This was inconsistent between skins, causing image alignment on RTL wikis to be dependent on your skin. Left is left and right is right, even for RTL languages :)
* Also moving position: relative; from all skins to shared.css
* Replacing .mw-content-ltr/rtl (added in r90743) with div#content [dir="ltr/rtl"] so it also works on e.g. special pages

12 years agoRemoved followRedirectText, unused
Aaron Schulz [Sat, 2 Jul 2011 00:20:11 +0000 (00:20 +0000)]
Removed followRedirectText, unused

12 years agoMove prefs-beta and prefs-labs messages from WikiEditor to core
Sam Reed [Fri, 1 Jul 2011 23:49:24 +0000 (23:49 +0000)]
Move prefs-beta and prefs-labs messages from WikiEditor to core

12 years agoFixed bogus $conds in r91327
Aaron Schulz [Fri, 1 Jul 2011 23:46:20 +0000 (23:46 +0000)]
Fixed bogus $conds in r91327

12 years ago* Fixed getLatest() check in Article
Aaron Schulz [Fri, 1 Jul 2011 23:33:34 +0000 (23:33 +0000)]
* Fixed getLatest() check in Article
* Added Title::loadFromRow() function and made WikiPage::loadPageData() use it; avoids raw Title field accessing
* Added Revision::newFromPageId() function and changed WikiPage::loadLastEdit() to use it. This makes it try a slave first instead of always hitting the master. It also makes it more consistent with getLatest() for sanity.
* Made WikiPage::loadPageData() use accessor for Title::mRestrictionsExpiry

12 years ago* Add release notes for my recent commits (bug 6100 and others like bugs 28030, 12406...
Robin Pepermans [Fri, 1 Jul 2011 22:50:58 +0000 (22:50 +0000)]
* Add release notes for my recent commits (bug 6100 and others like bugs 28030, 12406, 2834)
* Add me to credits

12 years agoRemoved ampersand in HTMLFileCache constructor
Aaron Schulz [Fri, 1 Jul 2011 22:01:48 +0000 (22:01 +0000)]
Removed ampersand in HTMLFileCache constructor

12 years agoAdd lang & dir attributes to the sitenotice, in the site content language
Robin Pepermans [Fri, 1 Jul 2011 21:28:11 +0000 (21:28 +0000)]
Add lang & dir attributes to the sitenotice, in the site content language

12 years agoAdd direction mark for better RTL display
Robin Pepermans [Fri, 1 Jul 2011 20:48:16 +0000 (20:48 +0000)]
Add direction mark for better RTL display

12 years ago* Changed action=revert to use a subclass of Action
Alexandre Emsenhuber [Fri, 1 Jul 2011 20:07:21 +0000 (20:07 +0000)]
* Changed action=revert to use a subclass of Action
* Added WikiPage::getActionOverrides() to be able to execute different actions depending on the namespace (obviously needed for action=revert). This is only used when the value of $wgActions for the corresponding action is true; so extension can still override this.
* Added Action::getDescription() to ease the change of the page header and the <title> element

12 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Fri, 1 Jul 2011 19:48:58 +0000 (19:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-01 19:43:00 UTC)

12 years agothrow an exception on !is_executable( $wgExiv2Command )
Antoine Musso [Fri, 1 Jul 2011 18:34:50 +0000 (18:34 +0000)]
throw an exception on !is_executable( $wgExiv2Command )

12 years agoMerge ApiTestSetup into ApiTestCase and update all subclasses. The amount of duplicat...
Chad Horohoe [Fri, 1 Jul 2011 16:34:02 +0000 (16:34 +0000)]
Merge ApiTestSetup into ApiTestCase and update all subclasses. The amount of duplication here was nasty, and also lets us get rid of a bunch of useless require_once()s.

./phpunit.php --filter Api currently gives me: Tests: 24, Assertions: 107, Incomplete: 1, Skipped: 2.

12 years agoFix for Bug #29628 - scriptpath Option of maintenance/install.php is ignored
Mark A. Hershberger [Fri, 1 Jul 2011 14:22:59 +0000 (14:22 +0000)]
Fix for Bug #29628 - scriptpath Option of maintenance/install.php is ignored

    The Script Path Option (--scriptpath) of maintenance/install.php
    is silently ignored if there is $_SERVER['SCRIPT_NAME'] set.

Apply patch from Tobias Müller.

12 years agoReplaced calls to Skin::formatSize() by Language::formatSize() where escaping is...
Alexandre Emsenhuber [Fri, 1 Jul 2011 09:03:15 +0000 (09:03 +0000)]
Replaced calls to Skin::formatSize() by Language::formatSize() where escaping is not needed (the former is just a wrapper to the latter with a call to htmlspecialchars())

12 years agoCall Linker::link() statically instead of getting a Skin object from $wgUser
Alexandre Emsenhuber [Fri, 1 Jul 2011 08:24:32 +0000 (08:24 +0000)]
Call Linker::link() statically instead of getting a Skin object from $wgUser

12 years agoRemove unused globals
Sam Reed [Fri, 1 Jul 2011 02:58:42 +0000 (02:58 +0000)]
Remove unused globals

12 years agoAdd documentation
Sam Reed [Fri, 1 Jul 2011 02:57:31 +0000 (02:57 +0000)]
Add documentation

Trim trailing whitespace

12 years agoMinor revert to r91246
Sam Reed [Fri, 1 Jul 2011 02:28:08 +0000 (02:28 +0000)]
Minor revert to r91246

12 years agoChange usages of $wgUser->getSkin() in special pages to use $this->getSkin()
Sam Reed [Fri, 1 Jul 2011 02:25:19 +0000 (02:25 +0000)]
Change usages of $wgUser->getSkin() in special pages to use $this->getSkin()

Fix trailing whitespace

12 years agoFix numerous undefined variables
Sam Reed [Fri, 1 Jul 2011 01:42:48 +0000 (01:42 +0000)]
Fix numerous undefined variables

12 years agoRemove unused parameter, update callers
Sam Reed [Fri, 1 Jul 2011 01:37:15 +0000 (01:37 +0000)]
Remove unused parameter, update callers

Trim whitespace

12 years agoFollowup r91168, fix last usage of $currentUser which was undefined
Sam Reed [Fri, 1 Jul 2011 01:30:26 +0000 (01:30 +0000)]
Followup r91168, fix last usage of $currentUser which was undefined

12 years agoFollow-up r91123:
Aaron Schulz [Fri, 1 Jul 2011 00:12:09 +0000 (00:12 +0000)]
Follow-up r91123:
* Tweaked getRevision() return type to NULL on failure
* Changed "$revision === null" checks to just "!$revision" (this avoids the landmine of getting false or something)

12 years ago(Follow-up r87705) per CR add docs to function. No code changes.
Brian Wolff [Thu, 30 Jun 2011 22:47:41 +0000 (22:47 +0000)]
(Follow-up r87705) per CR add docs to function. No code changes.

12 years agoFollowup r91224: stupid syntax error
Chad Horohoe [Thu, 30 Jun 2011 21:32:55 +0000 (21:32 +0000)]
Followup r91224: stupid syntax error

12 years agoRemove superfluous inclusion of SiteConfiguration in doMaintenance. It's in the AutoL...
Chad Horohoe [Thu, 30 Jun 2011 21:25:52 +0000 (21:25 +0000)]
Remove superfluous inclusion of SiteConfiguration in doMaintenance. It's in the AutoLoader and has already been initialized by DefaultSettings by this point.

As a result: rm DIY inclusion protection, since this was the only reason it was still needed.

12 years agotest that wfUrlencode() encodes apostrophe
Antoine Musso [Thu, 30 Jun 2011 21:14:33 +0000 (21:14 +0000)]
test that wfUrlencode() encodes apostrophe

12 years agor91207: Make one qunit test var local. Thanks Krinkle
Leo Koppelkamm [Thu, 30 Jun 2011 21:13:12 +0000 (21:13 +0000)]
r91207: Make one qunit test var local. Thanks Krinkle

12 years agoforgot one, follow-up to r91204
Ryan Kaldari [Thu, 30 Jun 2011 21:10:31 +0000 (21:10 +0000)]
forgot one, follow-up to r91204

12 years ago* Follow-up r84397: make sure that mysql uses the job_id index even with the job_cmd...
Aaron Schulz [Thu, 30 Jun 2011 20:32:41 +0000 (20:32 +0000)]
* Follow-up r84397: make sure that mysql uses the job_id index even with the job_cmd clause
* Removed redundant 'LIMIT' option, already added by using selectRow()

12 years agoLocalisation updates for core and extension messages from translatewiki.net (2011...
Raimond Spekking [Thu, 30 Jun 2011 20:17:56 +0000 (20:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-06-30 20:09:00 UTC)

12 years agoFixed a long-standing broken test:
Chad Horohoe [Thu, 30 Jun 2011 20:11:45 +0000 (20:11 +0000)]
Fixed a long-standing broken test:

1) ApiUploadTest::testUploadStash
Failed asserting that <boolean:true> is false.

Did this by copying the correct stuff from $_SESSION to our local $session we're using for the test. Not sure if this is strictly correct, but hey it passes ;-)

Currently at: Tests: 1622, Assertions: 32090, Incomplete: 8, Skipped: 5.

12 years agoRemove --upload option to parserTests.php and backend RemoteTestRecorder -- was only...
Chad Horohoe [Thu, 30 Jun 2011 19:47:26 +0000 (19:47 +0000)]
Remove --upload option to parserTests.php and backend RemoteTestRecorder -- was only used for since-removed CR integration

12 years ago* Marked WikiCategoryPage::hasViewableContent() as "public"
Aaron Schulz [Thu, 30 Jun 2011 19:44:06 +0000 (19:44 +0000)]
* Marked WikiCategoryPage::hasViewableContent() as "public"
* Renamed WikiPage::getID -> WikiPage::getId
* Fixed undefined $changed var from r91180
* Various doc tweaks

12 years agor86088: Adding legacy support for .sortbottom & a test for it per CR
Leo Koppelkamm [Thu, 30 Jun 2011 19:40:19 +0000 (19:40 +0000)]
r86088: Adding legacy support for .sortbottom & a test for it per CR

12 years agofixing jQuery UI button styles for the old version of jQuery UI that is on live ...
Ryan Kaldari [Thu, 30 Jun 2011 19:37:17 +0000 (19:37 +0000)]
fixing jQuery UI button styles for the old version of jQuery UI that is on live - still forward compatible as well

12 years agoPer Aaron, fix for r91180: pass false to second parameter of User::newFromName()...
Alexandre Emsenhuber [Thu, 30 Jun 2011 19:34:25 +0000 (19:34 +0000)]
Per Aaron, fix for r91180: pass false to second parameter of User::newFromName() to allow anonymous users

12 years agoFollow-up r89544: add dot per CR
Bryan Tong Minh [Thu, 30 Jun 2011 18:51:24 +0000 (18:51 +0000)]
Follow-up r89544: add dot per CR

12 years agoReverted r91195, this isn't needed ;)
Aaron Schulz [Thu, 30 Jun 2011 18:45:48 +0000 (18:45 +0000)]
Reverted r91195, this isn't needed ;)

12 years agoAdded normalizeSubpageLink() to DummyLinker. __call doesn't handle static function...
Aaron Schulz [Thu, 30 Jun 2011 18:38:32 +0000 (18:38 +0000)]
Added normalizeSubpageLink() to DummyLinker. __call doesn't handle static function call attempts, __callStatic__ is PHP >= 5.3, and both clobber references anyway. Just added a wrapper function instead.

12 years agoLinker::titleAttrib() didn't obey $wgEnableTooltipsAndAccesskeys
Platonides [Thu, 30 Jun 2011 18:21:05 +0000 (18:21 +0000)]
Linker::titleAttrib() didn't obey $wgEnableTooltipsAndAccesskeys

12 years agoMove $wgFeedClasses to DefaultSettings where they belong. This has been bothering...
Chad Horohoe [Thu, 30 Jun 2011 18:16:45 +0000 (18:16 +0000)]
Move $wgFeedClasses to DefaultSettings where they belong. This has been bothering me for years.

Somewhat in the spirit of r87637, except I didn't put them in WebStart because that doesn't make sense.

12 years agoFollow-up r81536: Properly extract ($dstZone, $dstRel) from the triplet.
Bryan Tong Minh [Thu, 30 Jun 2011 17:43:20 +0000 (17:43 +0000)]
Follow-up r81536: Properly extract ($dstZone, $dstRel) from the triplet.

12 years agoFollow-up r80988: fix function documentation
Bryan Tong Minh [Thu, 30 Jun 2011 17:35:37 +0000 (17:35 +0000)]
Follow-up r80988: fix function documentation

12 years agoTab w/s fixes
Aaron Schulz [Thu, 30 Jun 2011 17:14:27 +0000 (17:14 +0000)]
Tab w/s fixes

12 years agoFollowup r91087, rename directory
Sam Reed [Thu, 30 Jun 2011 16:41:50 +0000 (16:41 +0000)]
Followup r91087, rename directory

12 years agoFixes for r88113 and some realted changes:
Alexandre Emsenhuber [Thu, 30 Jun 2011 15:26:26 +0000 (15:26 +0000)]
Fixes for r88113 and some realted changes:
* Modified <s>Article::editUpdates()</s> WikiPage::doEditUpdates() arguments to take a Revision object, an User object and options (much more readable that those boolean parameters)
* Call isCountable() on the old content and pass it to WikiPage::doEditUpdates() with the 'oldcountable' option so that it really reflects the old state of the page
* Updated all calls (no one in extensions) and removed the wrapper WikiPage::editUpdates()
* Call onArticleEdit() and onArticleCreate() (the one that is of course) from doEditUpdates()
* Removed $wgTitle hack from Import.php

12 years agoSimpler code
Robin Pepermans [Thu, 30 Jun 2011 15:20:57 +0000 (15:20 +0000)]
Simpler code

12 years agoFix fatal in r77354 (!!), discovered this when purgeList.php fataled on me on the...
Roan Kattouw [Thu, 30 Jun 2011 15:15:54 +0000 (15:15 +0000)]
Fix fatal in r77354 (!!), discovered this when purgeList.php fataled on me on the WMF cluster

12 years agoMuch, much easier to call Linker::link() statically instead of grabbing a Skin from...
Alexandre Emsenhuber [Thu, 30 Jun 2011 14:53:37 +0000 (14:53 +0000)]
Much, much easier to call Linker::link() statically instead of grabbing a Skin from $wgUser

12 years agoUse the current instance instead of messing with $wgUser
Alexandre Emsenhuber [Thu, 30 Jun 2011 14:49:12 +0000 (14:49 +0000)]
Use the current instance instead of messing with $wgUser

12 years agoFollow-up r91167: that was for history of course.. this one is for recentchanges...
Robin Pepermans [Thu, 30 Jun 2011 14:10:53 +0000 (14:10 +0000)]
Follow-up r91167: that was for history of course.. this one is for recentchanges etc.

12 years agoAnd I forgot to commit this file in r91074
Alexandre Emsenhuber [Thu, 30 Jun 2011 13:56:45 +0000 (13:56 +0000)]
And I forgot to commit this file in r91074

12 years agoAdd dirmark so RecentChanges displays properly with CleanChanges extension and wgBett...
Robin Pepermans [Thu, 30 Jun 2011 13:51:56 +0000 (13:51 +0000)]
Add dirmark so RecentChanges displays properly with CleanChanges extension and wgBetterDirectionality = true

12 years ago* Fixes for r91123:
Aaron Schulz [Thu, 30 Jun 2011 07:52:59 +0000 (07:52 +0000)]
* Fixes for r91123:
** Avoid calling protected pageDataFromId() from Article class.
** Made pageDataFromTitle()/pageDataFromId() public for anything else doing something like that (loadPageData was already public anyway).
** Moved getParserOutput() back to Article since it needs getOutputFromWikitext().
* Other: cascading protection side-effect moved to outputWikiText().

12 years agoExpand on r91123 Article refactoring:
Aaron Schulz [Thu, 30 Jun 2011 07:05:20 +0000 (07:05 +0000)]
Expand on r91123 Article refactoring:
* Added $user param to relevant WikiPage functions (with b/c)
* Cleaned up editUpdates() signature and tweaked three other WikiPage functions signatures (with b/c)
* Added fixme to prepareTextForEdit()

12 years agoMore return documentation and trimming trailing whitespace
Sam Reed [Thu, 30 Jun 2011 02:59:43 +0000 (02:59 +0000)]
More return documentation and trimming trailing whitespace

12 years agoMinor tweaks for r83833 per CR
Sam Reed [Thu, 30 Jun 2011 02:14:45 +0000 (02:14 +0000)]
Minor tweaks for r83833 per CR

12 years ago* (bug 29531) r89628 breaks img_auth.php
Sam Reed [Thu, 30 Jun 2011 01:44:11 +0000 (01:44 +0000)]
* (bug 29531) r89628 breaks img_auth.php

Apply Tims strpos -> strrpos fix, confirmed to work by bug reporter

12 years agoMerge r90664 from 1.17wmf1
Sam Reed [Thu, 30 Jun 2011 01:27:03 +0000 (01:27 +0000)]
Merge r90664 from 1.17wmf1

12 years agoMerge r86683 from 1.17wmf1
Sam Reed [Thu, 30 Jun 2011 01:24:54 +0000 (01:24 +0000)]
Merge r86683 from 1.17wmf1

12 years agoAdding alternative method for U+024B62. Making sure both ways work.
Krinkle [Thu, 30 Jun 2011 01:20:37 +0000 (01:20 +0000)]
Adding alternative method for U+024B62. Making sure both ways work.

12 years agobyteLimit/byteLength improvements:
Krinkle [Thu, 30 Jun 2011 01:06:47 +0000 (01:06 +0000)]
byteLimit/byteLength improvements:
* Split the byte length logic into a seperate method to allow it to be called directly on a string (easier to test and easier re-use)
* Added basic unit tests for it.

12 years agoReplace more multiple calls to $this->getResult() in methods with temporary variable
Sam Reed [Thu, 30 Jun 2011 01:06:17 +0000 (01:06 +0000)]
Replace more multiple calls to $this->getResult() in methods with temporary variable

12 years agoFix trailing whitespace
Sam Reed [Wed, 29 Jun 2011 23:46:39 +0000 (23:46 +0000)]
Fix trailing whitespace

Swap methods that call $this->getResult() to use temporary variable

12 years agoTweak doc comments on WebRequest::getRequestURL() & WebRequest::getFullRequestURL...
Brion Vibber [Wed, 29 Jun 2011 23:35:05 +0000 (23:35 +0000)]
Tweak doc comments on WebRequest::getRequestURL() & WebRequest::getFullRequestURL() per in-person discussion with preilly; the docs were unclear as to whether the query string is included (it is).

12 years agoFollowup r91082, capitalise API, mark as optional
Sam Reed [Wed, 29 Jun 2011 23:18:45 +0000 (23:18 +0000)]
Followup r91082, capitalise API, mark as optional

12 years ago(Follow-up r91059) Make backlinks query do both null or "" to potentially account...
Brian Wolff [Wed, 29 Jun 2011 23:09:00 +0000 (23:09 +0000)]
(Follow-up r91059) Make backlinks query do both null or "" to potentially account for old rows that havn't been updated
yet to new conventions.

Hopefully I got the syntax right for the OR thing using mw's db functions (I tested the query, its fine, I'm just not 100% sure thats the most correct way using mw's db funcs, I've never really had to build an OR query using the db funcs).

12 years agoFollow up r91072. This is indeed not needed.
Platonides [Wed, 29 Jun 2011 22:37:11 +0000 (22:37 +0000)]
Follow up r91072. This is indeed not needed.

12 years ago(follow-up r91106) Explicitly compare against the self::BROKEN_FILE constants.
Brian Wolff [Wed, 29 Jun 2011 22:24:27 +0000 (22:24 +0000)]
(follow-up r91106) Explicitly compare against the self::BROKEN_FILE constants.

Before was doing if !$metadata, which used to work when self::BROKEN_FILE was 0, now it's -1
and that works less.

12 years ago* Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiC...
Aaron Schulz [Wed, 29 Jun 2011 22:09:51 +0000 (22:09 +0000)]
* Split off WikiPage class from Article, WikiFilePage class from ImagePage, and WikiCategoryPage from CategoryPage.
* WikiPage functions/fields are "magically" part of Article when accessed for b/c. Magic is kind of ugly but there are too many callers to make breaking changes atm. Some functions are just wrappers for WikiPage ones (were magic won't work).
* Added newFromID() to each WikiPage subclass (works around pre-existing inheritance problem).
* Added Page class for convenient type hinting and changed hints from Article -> Page. This lets things use WikiPage objects without getting type errors.
* Updated FlaggedPage to extend WikiPage. Worked around getOldIdFromRequest().
* Added setTimestamp() to WikiPage and moved some timestamp setting code from ParserCache to Article.
* Removed ampersands from $dbw arguments.
* @TODO: dependency inject user objects for WikiPage

The idea is to migrate things to use WikiPage, as the run-of-the-mill "new Article()" call doesn't care about $oldid and $wgRequest. After that, Article, ImagePage, and CategoryPage can be rewritten as an Action class or something sane (a Viewer class of sorts).

12 years agoWe don't need $skin as a local variable.
Platonides [Wed, 29 Jun 2011 21:51:27 +0000 (21:51 +0000)]
We don't need $skin as a local variable.

12 years agoPer CR, revert non debugging stuff from r82436. (KML uploads)
Bryan Tong Minh [Wed, 29 Jun 2011 20:31:43 +0000 (20:31 +0000)]
Per CR, revert non debugging stuff from r82436. (KML uploads)

12 years agobasic tests for wfUrlencode
Antoine Musso [Wed, 29 Jun 2011 20:28:43 +0000 (20:28 +0000)]
basic tests for wfUrlencode

Please note this function use a static variable based on the value
of $GLOBALS[’SERVER_SOFTWARE'].  With PHP 5.2 and PHPUnit 3.5.x, there
is currently now way to reset the static variable :-/   Tests relying on
a change of SERVER_SOFTWARE are thus skipped, still the framework is there
for later use.