From: Aaron Schulz <aschulz@wikimedia.org>
Date: Fri, 17 Jul 2015 22:22:54 +0000 (-0700)
Subject: Added FIXME to default Database replace() implementation
X-Git-Tag: 1.31.0-rc.0~10724^2
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=d807a9dc4ac1a4216664428f75cb56abc77a9b5c;p=lhc%2Fweb%2Fwiklou.git

Added FIXME to default Database replace() implementation

Change-Id: I3ec0ec066248ee733b41f9c70d40382d96898613
---

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 2f1155dd78..04b3edd3b1 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2873,6 +2873,7 @@ abstract class DatabaseBase implements IDatabase {
 			$rows = array( $rows );
 		}
 
+		// @FXIME: this is not atomic, but a trx would break affectedRows()
 		foreach ( $rows as $row ) {
 			# Delete rows which collide
 			if ( $uniqueIndexes ) {