From: Derick Alangi <alangiderick@gmail.com>
Date: Thu, 14 Feb 2019 12:30:49 +0000 (+0100)
Subject: import: Remove deprecated WikiRevision::$importer property
X-Git-Tag: 1.34.0-rc.0~2801^2
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=d6f4e0422ada79e073fef08b3d362c462208690e;p=lhc%2Fweb%2Fwiklou.git

import: Remove deprecated WikiRevision::$importer property

This property was introduced since 1.17 and was unused, then following
the deprecation policy, it was deprecated in 1.29. Removing this now
as it's been long enough and has been for several MW versions. Also,
updated release notes to mention this removal.

Change-Id: Ib6353dd37079bcfe7cd15600e8af1f67b245f4a3
---

diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33
index 0cee392223..d438f2d439 100644
--- a/RELEASE-NOTES-1.33
+++ b/RELEASE-NOTES-1.33
@@ -246,6 +246,7 @@ because of Phabricator reports.
   Use require( 'mediawiki.libs.jpegmeta' ) instead.
 * The mw.user.stickyRandomId() method, deprecated in 1.32, was removed.
   Use mw.user.getPageviewToken() instead.
+* Removed deprecated class property WikiRevision::$importer.
 
 === Deprecations in 1.33 ===
 * The configuration option $wgUseESI has been deprecated, and is expected
diff --git a/includes/import/WikiRevision.php b/includes/import/WikiRevision.php
index 55a7b2d386..96b43d6ada 100644
--- a/includes/import/WikiRevision.php
+++ b/includes/import/WikiRevision.php
@@ -36,13 +36,6 @@ use MediaWiki\MediaWikiServices;
  */
 class WikiRevision implements ImportableUploadRevision, ImportableOldRevision {
 
-	/**
-	 * @since 1.17
-	 * @deprecated in 1.29. Unused.
-	 * @note Introduced in 9b3128eb2b654761f21fd4ca1d5a1a4b796dc912, unused there, unused now.
-	 */
-	public $importer = null;
-
 	/**
 	 * @since 1.2
 	 * @var Title