From: Mark A. Hershberger <mah@everybody.org>
Date: Thu, 12 Nov 2015 22:15:07 +0000 (-0500)
Subject: Add error checking for file argument
X-Git-Tag: 1.31.0-rc.0~8694^2
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=89282735ffaaf9b45f42fa3697979f191b1a84df;hp=-c;p=lhc%2Fweb%2Fwiklou.git

Add error checking for file argument

If the user ignorantly passes in ".", this will fail.

Change-Id: I1128945b7277ce7b3da27eb30b2dfbbf644c9d38
---

89282735ffaaf9b45f42fa3697979f191b1a84df
diff --git a/maintenance/convertExtensionToRegistration.php b/maintenance/convertExtensionToRegistration.php
index 3e86d8a6d8..828507b625 100644
--- a/maintenance/convertExtensionToRegistration.php
+++ b/maintenance/convertExtensionToRegistration.php
@@ -79,7 +79,12 @@ class ConvertExtensionToRegistration extends Maintenance {
 			$$var = array();
 		}
 		unset( $var );
-		require $this->getArg( 0 );
+		$arg = $this->getArg( 0 );
+		if ( !is_file( $arg ) ) {
+			$this->error( "$arg is not a file.", true );
+		}
+		require $arg;
+		unset( $arg );
 		// Try not to create any local variables before this line
 		$vars = get_defined_vars();
 		unset( $vars['this'] );