From: David Barratt <dbarratt@wikimedia.org>
Date: Mon, 4 Sep 2017 23:19:42 +0000 (-0400)
Subject: Enable save button when removing item from UsersMultiselectWidget list
X-Git-Tag: 1.31.0-rc.0~2215^2
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=83ce742a91b2527ae34aeff75031b364f643a04b;p=lhc%2Fweb%2Fwiklou.git

Enable save button when removing item from UsersMultiselectWidget list

UsersMultiselectWidget uses a hidden input to store values. Hidden inputs do not trigger onChange events. The onChange event must be trigger manually.

Bug: T173973
Change-Id: Ib9ec31791f1fe7bdde8d91ae16a2111f4320c615
---

diff --git a/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js b/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js
index 832cb2b6da..d250ad8533 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js
@@ -152,6 +152,9 @@
 	mw.widgets.UsersMultiselectWidget.prototype.updateHiddenInput = function () {
 		if ( 'hiddenInput' in this ) {
 			this.hiddenInput.val( this.getSelectedUsernames().join( '\n' ) );
+			// Hidden inputs do not trigger onChange.
+			// @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/hidden
+			this.hiddenInput.trigger( 'change' );
 		}
 	};