From: Platonides <platonides@users.mediawiki.org>
Date: Fri, 8 Oct 2010 22:51:03 +0000 (+0000)
Subject: Change the FIXME to the other way.
X-Git-Tag: 1.31.0-rc.0~34575
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=7b6afb1996ffe8d3b0f80b6140768fc01c2331d2;p=lhc%2Fweb%2Fwiklou.git

Change the FIXME to the other way.
The issue is, php strtolower() calls tolower(3), which is locale sensitive.
Eg. LC_ALL='pt_BR.ISO-8859-1' php -r'echo strtolower("ÉÁÇÚÍ");'

Adding a call to setlocale(LC_ALL,'C'); in Setup.php may be a good idea.
---

diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 5e8a5c2d7b..c9bc05c07d 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -3895,9 +3895,10 @@ class Parser {
 					'noninitial' );
 			}
 
-			# HTML names must be case-insensitively unique (bug 10721).  FIXME:
-			# Does this apply to Unicode characters?  Because we aren't
-			# handling those here.
+			# HTML names must be case-insensitively unique (bug 10721). 
+			# This does not apply to Unicode characters per 
+			# http://dev.w3.org/html5/spec/infrastructure.html#case-sensitivity-and-string-comparison
+			# FIXME: We may be changing them depending on the current locale.
 			$arrayKey = strtolower( $safeHeadline );
 			if ( $legacyHeadline === false ) {
 				$legacyArrayKey = false;