From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 9 Mar 2019 20:27:29 +0000 (-0800)
Subject: Add sanity check to notifyUpdatesForRevision() for $oldRev
X-Git-Tag: 1.34.0-rc.0~2554^2
X-Git-Url: https://git.heureux-cyclage.org/?a=commitdiff_plain;h=3e40bc1d5647988e3541aae848013f3a7778a705;p=lhc%2Fweb%2Fwiklou.git

Add sanity check to notifyUpdatesForRevision() for $oldRev

Change-Id: Ibd8975efb33d061ab16dc1a59899b6f78976ec5d
---

diff --git a/includes/jobqueue/jobs/CategoryMembershipChangeJob.php b/includes/jobqueue/jobs/CategoryMembershipChangeJob.php
index b64c87aea7..3aedc38f5f 100644
--- a/includes/jobqueue/jobs/CategoryMembershipChangeJob.php
+++ b/includes/jobqueue/jobs/CategoryMembershipChangeJob.php
@@ -195,7 +195,7 @@ class CategoryMembershipChangeJob extends Job {
 		// Get the prior revision (the same for null edits)
 		if ( $newRev->getParentId() ) {
 			$oldRev = Revision::newFromId( $newRev->getParentId(), Revision::READ_LATEST );
-			if ( !$oldRev->getContent() ) {
+			if ( !$oldRev || !$oldRev->getContent() ) {
 				return; // deleted?
 			}
 		} else {